submit-social-housing-lettings-and-sales-data

2266 Commits

230 Branches

261 Tags

83 MiB

Tree: 91a61bb1b9

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	79c4f9b74b	CLDC-2334 Add journey to fix soft validation errors only (#1615 ) * Sends a correct email if there are only soft validations * Add soft errors valid page * Add soft errors confirm page * Confirm the soft validations * Reuse the how to fix template for check soft validations email * Update email link * Move soft validation confirmation to processor * Correctly set the log status, remove redundant confirm_soft_validations * Redirect successful upload to logs index and display a success banner * Implement the soft validations only journey for sales logs * Display the soft validation errors on the soft-errors-valid page * Fix page alignment * Fix tests by mapping housingneeds in csv hepler * Add the sales soft validations to unpend_and_confirm_soft_validations * Change naming * Update method names * refactor * undo typo * Only set the existing soft validations for correct types * Fix path name * Add missing error mappings for location fields * Add missing tests and cancel button * Change some wording * Typos	2 years ago
natdeanlewissoftwire	6973ade8c4	CLDC-2262 Bulk upload clear invalid data to create forms (#1618 ) * feat: wip blank fields and dependent fields on upload tos ee if valid and can upload with missing info - this is not the exact ac on the ticket yet * feat: update seed * feat: wip commit * feat: add postcodenk error so can clear on validation * feat: add postcode validation back * feat: move la vals to shared and move and add tests * feat: add correct pluralisation to warning message * feat: add blank compound invalid fields methods * feat: update validations * feat: update pluralisation * refactor: lint * feat: clear errors associated with blanked values so log status is set correctly on creation * feat: validate instead * feat: avoid duplicated errors * feat: dont auto-refuse income, different to imports * feat: validate after every blank method * feat: delete la validator spec * tests: update * refactor: erblinting * refactor: cleanup * refactor: move pluralizer to helper * feat: copy update * feat: rename * feat: refactor to avoid redundant re-validations and test * refactor: rubocop * test: update * test: update * test: update * update sidekiq * feat: clear errors * feat: run clearing twice in case first clear creates different errors * feat: remove moved file * feat: undo validation file tweaks as shared/specific overlap could do with a more general refactor * feat: update tests	2 years ago
Phil Lee	454df8389e	CLDC-2135 Bulk upload resume with how fix (#1503 ) * add first page for bulk upload resume journey * bulk upload resume handles upload again * add confirm page to bulk upload resume journey * replace placeholder count with correct value * apply recommendation for bulk upload resume choice * add how to fix bulk upload mailer * integrate new bulk upload approve journey * add missing bulk upload error mappings * remove test * prevent approve being called multiple times * bulk upload creates invisible logs ahead of time * work invisible logs into bulk upload flow * sort errors so deterministic * remove unused ensure * remove expected_log_count and processed - these fields are no longer used or needed * introduce pending status * swap visible for pending logs * only show visible lettings logs * hard code status filters * remove unused model methods * only show visible sales logs * form controller ignores hidden logs * locations and schemes only affect visible logs	2 years ago

Author

SHA1

Message

Date

kosiakkatrina

79c4f9b74b

CLDC-2334 Add journey to fix soft validation errors only (#1615 )

* Sends a correct email if there are only soft validations

* Add soft errors valid page

* Add soft errors confirm page

* Confirm the soft validations

* Reuse the how to fix template for check soft validations email

* Update email link

* Move soft validation confirmation to processor

* Correctly set the log status, remove redundant confirm_soft_validations

* Redirect successful upload to logs index and display a success banner

* Implement the soft validations only journey for sales logs

* Display the soft validation errors on the soft-errors-valid page

* Fix page alignment

* Fix tests by mapping housingneeds in csv hepler

* Add the sales soft validations to unpend_and_confirm_soft_validations

* Change naming

* Update method names

* refactor

* undo typo

* Only set the existing soft validations for correct types

* Fix path name

* Add missing error mappings for location fields

* Add missing tests and cancel button

* Change some wording

* Typos

2 years ago

natdeanlewissoftwire

6973ade8c4

CLDC-2262 Bulk upload clear invalid data to create forms (#1618 )

* feat: wip blank fields and dependent fields on upload tos ee if valid and can upload with missing info - this is not the exact ac on the ticket yet

* feat: update seed

* feat: wip commit

* feat: add postcodenk error so can clear on validation

* feat: add postcode validation back

* feat: move la vals to shared and move and add tests

* feat: add correct pluralisation to warning message

* feat: add blank compound invalid fields methods

* feat: update validations

* feat: update pluralisation

* refactor: lint

* feat: clear errors associated with blanked values so log status is set correctly on creation

* feat: validate instead

* feat: avoid duplicated errors

* feat: dont auto-refuse income, different to imports

* feat: validate after every blank method

* feat: delete la validator spec

* tests: update

* refactor: erblinting

* refactor: cleanup

* refactor: move pluralizer to helper

* feat: copy update

* feat: rename

* feat: refactor to avoid redundant re-validations and test

* refactor: rubocop

* test: update

* test: update

* test: update

* update sidekiq

* feat: clear errors

* feat: run clearing twice in case first clear creates different errors

* feat: remove moved file

* feat: undo validation file tweaks as shared/specific overlap could do with a more general refactor

* feat: update tests

2 years ago

Phil Lee

454df8389e

CLDC-2135 Bulk upload resume with how fix (#1503 )

* add first page for bulk upload resume journey

* bulk upload resume handles upload again

* add confirm page to bulk upload resume journey

* replace placeholder count with correct value

* apply recommendation for bulk upload resume choice

* add how to fix bulk upload mailer

* integrate new bulk upload approve journey

* add missing bulk upload error mappings

* remove test

* prevent approve being called multiple times

* bulk upload creates invisible logs ahead of time

* work invisible logs into bulk upload flow

* sort errors so deterministic

* remove unused ensure

* remove expected_log_count and processed

- these fields are no longer used or needed

* introduce pending status

* swap visible for pending logs

* only show visible lettings logs

* hard code status filters

* remove unused model methods

* only show visible sales logs

* form controller ignores hidden logs

* locations and schemes only affect visible logs

2 years ago

1 Commits (91a61bb1b99a2b9a1312e3508d52e68e379ffa37)