submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	40cf0c10c2	CLDC-1633 build feature csv download of sales logs (#1568 ) * create a method on the FormHandler that returns the sales form questions for all years in the order that they appear in the form * update csv email job to accomodate sales log export as well as lettings add to tests to reflec the changes made * write tests to cover the desired functionality of the SalesLogCsvService * create the SalesLogCsvService create a necessary method on the log to enable submission method to be included on the csv derive values for the two halves of previous postcode for export * add relevant links in the UI and pipe everything together in controllers amend organisations controller to have flexibility to download logs of either type add necessary methods to sales log controller, raising shared method to logs controller update routing for amendments and additions extract helper method to build urls for downloading logs within an organisation * correct various linter complaints and tech review suggestions * minor amendment to add old_id and reorder early columns * undo my 'clever' refactor that broke things * refactoring of csv service after some tech review and some UI testing in review app * update tests to include a test of a full export and all values in teh csv * correct minor routing error to ensure correct url is shown and tab selected after requesting csv email * update organisations controller requests spec file to cover new functionality and make a minor amendment to authentication scope in the controller after error found in testing * write request tests for the new functionality in the sales log controller, define authorisation in the controller * minor correction after rubocop's kind suggestion' * various corrections from first pass at PO, tech review, linter, etc * refactor :ordered_sales_questions_for_all_years * first pass at implementing flexible code-based form fixtures for testing * second pass * refactor all tests of :ordered_sales_questions_for_all_years to use new factories * some refactoring in the testing of the csv service * use that fact that params is always available in controllers and don't pass it around, inline some methods calls * correct minor bug to ensure that "Return to logs" link returns to the correct index page * remove reminder comments * write further tests on the manipulation of questions into the csv headers, update factories of form constituents to allow the creation of forms with richer questions * fix linter complaints * minor alterations after rebase to account for changes made on other branches * refactor after code review * tweak fixtures after rebase containing alterations to the factory defaults	2 years ago
Arthur Campbell	4e489b5300	CLDC-2288 ensure derived answers cleared when renewal changed from yes to no (#1596 ) * add a validation to prevent an inconsistent combination of values and tests for this validation * show related method in diff * remove comment * extract reusable logic from SalesLogVariables to independent module * update lettings log tests around derivations related to renewal * refactor derivation logic to share functionality with sales logs where possible * remove some tests which are now duplicated above, refactor tests using Jack's wonderful :change suggestion, add in tests about logic deriving vacdays that was not previously covered * minor changes after tech review	2 years ago
Arthur Campbell	899c9995d9	CLDC-2163 add validations on whether buyers are living in the property (#1512 ) * add several methods to the sales log to allow subsequent work to be human readable * add a validation to prevent an inconsistent combination of values and tests for this validation * handle derivation of values around buyers living in the property - derive values where appropriate - clear these values when the derived state no longer holds - update the routing for pages holding questions about whether particular buyers will live in the property to reflect when they are derived - test the deriving and associated clearing of values - update tests on page routing and sales log factory * update a page routing condition for human readability using an existing method and update test to reflect this change * show related method in diff * minor amendments after tech review * simplify reset_derived_questions after tech review * refactor on deriving and clearing invalid derived values on sales log * correct linter complaints * remove comment * add validation to one more field with a new error message as it is in fact possible to tirgger the validation in the setup section	2 years ago
kosiakkatrina	94dcc2ace8	Update mscharge question wording (#1532 ) * rename mscharge known * Update field name across the codebase * Rename files * Set has_mscharge to no if mscharge is 0 * update question wording	2 years ago
Arthur Campbell	a08c9d6134	CLDC-2017-monthly-charges-validation (#1448 ) * add a validation against the case where monthly leashold charges are zero, test this, remove unnecessary validation on cash discount as this is covered by validate_numeric_min_max * remove focus: true from describe block * minor changes for testing and linting * correct minor bug found in PO * make minor amendments to failing tests	2 years ago
Jack	cff4cc45bc	CLDC-2068 request, validate UPRN and retrieve address (#1370 ) * Add OS_DATA_KEY env var * Add new UPRN and address columns to logs * Bugfix: use dynamic optional fields * Update optional fields * Add UPRN validation * Add UPRN Client * Add UPRN Presenter * UPRN questions and flows * Skip to non addresss questions if UPRN unknown * Address PO review comments and add missing specs * Display LA correctly	2 years ago
kosiakkatrina	79f7b9473b	CLDC-1846 Derive hhmemb from hholdcount (#1369 ) * Derive household members from household count * Calculate hholdcount if not given and calculate hhmemb * Check if economic status is answered	2 years ago
Arthur Campbell	8fd31f3bfb	CLDC-886 add validations for discounts (#1214 ) * fix rebase conflicts * fix rebase conflicts * feat: update validation * fix rebase conflicts * fix rebase conflicts * test: update * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * implement before validation check to ensure that if the user declares no mortgage will be used, mortgage value is set to 0 * fix rebase conflicts * fix rebase conflicts * remove comment * fix rebase conflicts * Update config/locales/en.yml Co-authored-by: James Rose <james@jbpr.net> * alter order of before validation methods on sales log so that derived fields are calculated after invalidated dependent fields are cleared, fix tests broken by this change * add mortgage to derived variables so that mortgage value is set to 0 if a mortgage is not being used in the sale * remove hard validation of range for discount question and allow shared validation of numeric questions to handle this case * amend tests after rebasing * fix tests after rebasing * fix test and ensure schema correct after rebase --------- Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com> Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	64f245d066	Consider everyone below 18 a child (#1195 )	2 years ago
kosiakkatrina	52abc23c70	Cldc 808 derived sales variables (#1184 ) * Add derived household fields * Derive household variables for sales logs * Refactor and fix wrong test names * Count everyone under 20 as children if relationship is "C"	2 years ago
kosiakkatrina	352dae8efe	CLDC-1468 Add property postcode questions to sales (#1187 ) * Add postcode fields * Add postcode page and questions * Add postcode page to the property information subsection * Only display local authority question if the la is not inferred * Fix migration * Move postcode validation * Infer LA fields from postcode * infer partial postcodes	2 years ago
Jack	2f9e3d7d71	[CLDC-1746] Add HandoverDate question (#1161 )	2 years ago
natdeanlewissoftwire	b9f775fba1	Cldc 1547 leasehold charges (#1134 ) * Mark subsection as completed if it is not displayed in the tasklist and hide it from the UI * Add sale_information section * add sales information subsections * Cldc 1531 staircasing (#1109) * Add staircase field to sales_logs table * Add staircase question and page * add staircase page to the shared ownership scheme subsection fix file name * Cldc 1539 previous bedrooms (#1108) * add frombeds field * Add previous_bedrooms page and question * add Previous Bedrooms page to the shared ownership subsection * Cldc 1532 about staircasing (#1110) * Add stairboughts and stairowned fields to the database * Add about staircasing page and questions * Add about staircasing page to the shared wnership scheme subsection * Add a space before percent * Cldc 1546 monthly rent (#1111) * Add monthly rent column to sales logs table * Add monthly rent question and page * Add monthly rent page to the shared ownership scheme subsection * Cldc 1535 exchange contracts (#1112) * Add exdate to sales logs table * Add exchange date page and question * Add exchange contracts page to the shared ownership subsection * derive exday, exmonth and exyear, tests and lint * rebase tests * Cldc 1538 la nominations (#1115) * Add la nominations column to sales logs table * Add La nominations page and questions * Add la nominations to the shared ownership subsection * Add accidentally removed files * Cldc 1545 about the deposit (#1113) * feat: add question(s) without depends_on behaviour * feat: separate ids for diff sections * test: update tests * test: add tests * tests: test tweaks * refactor: linting * Cldc 1538 la nominations (#1115) * Add la nominations column to sales logs table * Add La nominations page and questions * Add la nominations to the shared ownership subsection * Add accidentally removed files * feat: add question(s) without depends_on behaviour Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> * Cldc 1533 is resale (#1118) * feat: add resale question and page * tests: add new tests * test: update previous tests * refactor: linting * refactor: linting * Cldc 1576 buyer prp (#1117) * Add soctenant field to sales logs * Add buyer previous page and question * Add buyer previous page to shared ownership scheme subsection * rebase migrate * rebase too * Cldc 1540 about price (#1121) * add price fields to the sales logs table * Add about proce questions * add about proce pages * Add about price pages to sale information sections * rebase changes * happy new year * Switch the order of sales log sections * Cldc 1540 fixes (#1130) * Update order of pages and remove wrong id's * Add spacing to the hint text * feat: add page, question, and update db * Cldc 1521 living before purchase (#1129) * feat: add new page and question and update db * test: add and update tests * feat: reset db * feat: infer mscharge if mscharge_known == No * test: add and update tests * feat: add page, question, and update db * feat: infer mscharge if mscharge_known == No * test: add and update tests * feat: update to main * test: update tests * tests: update tests * faet: move mscharge derivation Co-authored-by: Kat <katrina@kosiak.co.uk> Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>	2 years ago
kosiakkatrina	f0ff0fec2f	Cldc 1543 mortgage used (#1139 ) * Add sale_information section * Switch the order of sales log sections * Add mortgageused column * Add mortgageused page and question * Add mortgageused page to subsections * derive deposit * tests	2 years ago
kosiakkatrina	6102b50ebe	Cldc 1776 sales information sections (#1106 ) * Mark subsection as completed if it is not displayed in the tasklist and hide it from the UI * Add sale_information section * add sales information subsections * Cldc 1531 staircasing (#1109) * Add staircase field to sales_logs table * Add staircase question and page * add staircase page to the shared ownership scheme subsection fix file name * Cldc 1539 previous bedrooms (#1108) * add frombeds field * Add previous_bedrooms page and question * add Previous Bedrooms page to the shared ownership subsection * Cldc 1532 about staircasing (#1110) * Add stairboughts and stairowned fields to the database * Add about staircasing page and questions * Add about staircasing page to the shared wnership scheme subsection * Add a space before percent * Cldc 1546 monthly rent (#1111) * Add monthly rent column to sales logs table * Add monthly rent question and page * Add monthly rent page to the shared ownership scheme subsection * Cldc 1535 exchange contracts (#1112) * Add exdate to sales logs table * Add exchange date page and question * Add exchange contracts page to the shared ownership subsection * derive exday, exmonth and exyear, tests and lint * rebase tests * Cldc 1538 la nominations (#1115) * Add la nominations column to sales logs table * Add La nominations page and questions * Add la nominations to the shared ownership subsection * Add accidentally removed files * Cldc 1545 about the deposit (#1113) * feat: add question(s) without depends_on behaviour * feat: separate ids for diff sections * test: update tests * test: add tests * tests: test tweaks * refactor: linting * Cldc 1538 la nominations (#1115) * Add la nominations column to sales logs table * Add La nominations page and questions * Add la nominations to the shared ownership subsection * Add accidentally removed files * feat: add question(s) without depends_on behaviour Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> * Cldc 1533 is resale (#1118) * feat: add resale question and page * tests: add new tests * test: update previous tests * refactor: linting * refactor: linting * Cldc 1576 buyer prp (#1117) * Add soctenant field to sales logs * Add buyer previous page and question * Add buyer previous page to shared ownership scheme subsection * rebase migrate * rebase too * Cldc 1540 about price (#1121) * add price fields to the sales logs table * Add about proce questions * add about proce pages * Add about price pages to sale information sections * rebase changes * happy new year * Switch the order of sales log sections * Cldc 1540 fixes (#1130) * Update order of pages and remove wrong id's * Add spacing to the hint text * Cldc 1521 living before purchase (#1129) * feat: add new page and question and update db * test: add and update tests * feat: reset db * Only display from beds for social housing (#1131) * Cldc 1544 mortgage amount (#1136) * feat: add sales log seeds * feat: add question and page and update db * tests: add and update tests * Cldc 1540 fixes part two (#1135) * Change about_price_social_housing to about_price_shared_ownership and display it in all shared ownership cases * Change about_price to purchase_price and display it for outright sale * lint * Move exchange contracts date page (#1143) * feat: PO fix and tests (#1144) * feat: PO fix and tests * feat: simmplification * refactor: linting * feat: copy tweak Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com> Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>	2 years ago
Jack S	43b9c44c00	[CLDC-1486] Add ethnic group and background questions (#922 ) * Add derived variables to sales log * Add ethnic background question * Add inferred question response * Test inferred check questions of lettings logs	2 years ago

16 Commits (93c88ad37af03a7c6aa04769bc3ff6c3453f5d6d)