* Different versions of details_html
* One version of details_html
* Replace you didnt answer with link
* Fix lint
* Update some tests
* Update some tests
* Add question marks to yes no questions - test
* Improve formatting helper
* Improve formatting helper
* Improve prompt message
* Revert "Add question marks to yes no questions - test"
This reverts commit 40bee289
* Rename question method
* Add check answer prompt method to question model and translation key
* Add translation key to soft validations
* Lettings custom prompts
* Update to handle new helpdesk ticket logic
* Update copy
* Update copy
* Update method names
* Add check answer prompt to soft validations
* Change copy
* Do not put error objects into cookies
* Hide change link for inferred or derived values not yet answered
* Revert "Hide change link for inferred or derived values not yet answered"
This reverts commit ec1fd1c9aa.
* Update lettings related check answer prompts
* Update some sales related check answer prompts
* Update some sales related check answer prompts
* Bug fix
* More sales prompts
* Replace text for bulk upload
* Update uprn known test with specific error message already used
* Translation file to CSV
* Revert "Translation file to CSV"
This reverts commit 0565fea717.
* Add a red link to show questions that still must be answered (after bulk upload)
* Lint
* Update feature tests
* Update component tests
* Update helper tests
* Update requests tests
* Update request test
* Refactor improvements
* Refactor improvements 0.2
* Lint
* Stay consistent with date question message
* Rename variable
* Add tests
* Improvements
* Refactor details table helper
* Remove action link not just hide
* Revert "Remove action link not just hide"
This reverts commit 59ecac5cf3.
* Users - remove action link
* Organisations - remove action link
* Merge requests - remove action link
* Revert "Refactor details table helper"
This reverts commit b74fd830f1.
* Schemes - remove action link
* Location - remove action link
* Logs - remove action link
* Lint
* Refactor V2 details table helper
* Allow respond_to? to see private methods
* Remove .presence duplication of logic
* Change "Answer if" to "Tell us if"
* Add missing CAP
* Update age questions sales and lettings
* Update postcode and la questions
* Update wording
* Updates and improvements
* Another update
* Fix bug
* typo
* typo
* update relat to buyer/lead prompts
* Update test
* Additional copy
* Additional copy
* Update copy "housing-related" to "housing related"
---------
Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com>
* CLDC-3110: Update hard max income for ecstat 8 to 2000
* CLDC-3110: Update hard max income for ecstat 10 to match new highest max
* CLDC-3110: Base income validations on all tenants for lettings logs
* CLDC-3110: Tweak validation messages
* CLDC-3110: Use prefer not to say values when tenant ecstat is not specified
* some minor refactoring
remove methods from child class that replicate methods on the parent class
tidy up check for nil
remove gubbins and inline method body given only used once
* update import services for lettings and sales to import creation method
write tests to cover this
* create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported
* update lettings log field import service and related spec to allow importing creation method of logs
* use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process.
various tests tweaked to suppor this change.
rake task from another ticket folded into this ticket to prevent merge conflicts
* rename method for ruby conventions
* update PR for altered spec
upload id now decided to be a better indicator of bulk upload status, import service amended accordingly
tests updated in line with this
* update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created
* slight refactor to reduce nesting and dodge linter complaints
* minor amendment to log creator spec in bulk upload to use enum dynamic methods
This renames the case_log to lettings_log as everything we've written so
far has been geared towards lettings of social housing so it makes sense to
have the name describe this. This is also a precursor to adding in stuff for
sales logs (whatever shape that takes)
Co-authored-by: James Rose <james@jbpr.net>
* Set up failing test for new soft validation design
* remove unneeded js controller
* remove unneeded controller and spec
* rename net income validation override column
* spec form changes (to allow tests to run)
* validation spec changes
* replace all instances of override_net_income_validatiom
* passing first test
* Add to form and import styling
* remove unneeded code from interruption screen view
* Update test & code - failing last new expectation
* Display 2 previous question answers in the informative text
* extract displaying of the informative text into a helper
* Add tests for helper
* Remove some of the previous soft validations set up
* fix some failing specs
* Fix more tests
* lint
* Reset earnings question prefix and suffix to initial values instead of nil
* make it route backwards on a no
* test and linter fixes
* refactor next_page
* stryling
* more changes
* fix specs
* update real form
* design tweaks
* delete commented out tests
* content changes
* content changes
* changes to informative/hint text
* More robust styles for interuption panel, use smart quotes
* Rubocop
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
Co-authored-by: baarkerlounger <db@slothlife.xyz>
* Iterate over all forms
* Re-lookup page to ensure we have the definition for the right form
* Match form naming convention for spec and real
* Add test for case log form
* Refactor routing
* Tenant code is now in About This Log
* Invert form definition routing syntax
* Make GDPR acceptance explicit dependency
* Add ReadMe description
* Add ADR for form routing logic
* Update JSON schema
* Add frontend gem repo to readme
* Rubocop
* Remove condition_effects_prefer_not_to_say field
* Change reason type
* Remove prefer not to say from illness
* add majorrepairs,propcode and infer postcode
* Update previous location and la
* Update majorrepairs, national and reasonpref
* Update housing benefits fields
* rename file
* Add previous postcode
* Move inferred postcode to model
* refactor infered poscode method
* Remove unneeded import
* update miration and some mappings
* Remove duplicate migration command
* migration wip
* change field names to lowercase and fix the tests
* Change national and ethnic field types and map to correct enums
* change ecstat column types
* Change prevten field type
* Change homeless field type
* Change benefit cap field type
* Put db enums in one folder and add a few new field changes"
* change field type for housing needs
* Change illness field type
* display checkbox answers
* cbl, chr, cap
* Change tenancy and tenancylength field types
* Change landlord and rsnvac field types
* Change unittype_gn field type
* Reasonble preference displaying on check answers
* update more field types
* Fix typo in comumn name
* Change more types
* Test fixes
* Add adr
* fix some tests
* run migration
* Fix tests
Co-authored-by: Matthew Phelan <matthew.phelan@madetech.com>
* Change condition format in json
* Add test for multiple conditions
* Check multiple conditions
* nearly better
* check the condition for route without checcking the question type
* remove a comment and an unused variable
Co-authored-by: magicmilo <milobascombe@gmail.com>
* Add next page path method with conditional routing
* Rename method
* Fix the tests and add files to .gitignore
* Make get_next_page_path a private method
* WIP test for total question count
* Change back button to use rails navigation
* Make total number of questions work with conditional routing and run rubocop
* Add tests for conditional question displaying
* Add conditional routing to the check answers page
* push 1 failure
* make total_questions step over the form like a user would and gather relevand questions
* Fix the tests
* fixed checks answers labels
* small refactors and rubocop
* remove unused code from get next page path
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: magicmilo <milobascombe@gmail.com>
* use test_form.json in tests
* Pass in form to view from controller for check_answers
* reduce test json length for household section
* Further shorten the test json
* Remove extra radio questions from test json household section
* Trim test form and fix tests
* do some method extraction
* Extract creation of form into a formHandler
* rubocop
* redefine form model to use filepaths instead
* Check test env var in form handler
* remove singleton and make get_all_forms a private method
* refactor get_all_forms
Co-authored-by: Kat <katrina@madetech.com>
* Make outstanding amount question conditional
* Make major repairs date conditional on major repairs having been done
* Add Other reason for leaving as a conditional question
* Make reason for reasonable preference conditional on reasonable preference being given
* Refactor conditional html attributes
* Pretty print config json
* Add numeric conditional
* Add the rest of the conditionals
* Rubocop
* Refactor how we add stimulus controller html attributes so that we can combine them
* Spec attrib merging
* Fix question counts for sections with conditional questions
* Some linting
* Spec question counting behaviour
* Linting
* Add some more readme explanation
* Rename controller helper
* Rename variables for clarity
Manny Dinssa
kosiakkatrina
Rachael Booth
Arthur Campbell
Phil Lee
natdeanlewissoftwire
Dushan
baarkerlounger
Stéphane Meny
Paul Robert Lloyd
magicmilo
MadeTech Dushan
Kat