submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	ac1d2ce8d9	CLDC-3806 Update question numbers for sales (#2936 ) * Update question numbers * Update tests * Update constant name * Fix proplen number for 2024	8 months ago
Rachael Booth	542565ed85	Use subsection copy key (#2792 ) * CLDC-3766: Ensure copy for Q78 is found correctly * Fix tests * Use subsection copy key in defaults and remove explit keys that are now defaults * Replace other uses of subsection.id interpolation in copy keys * Test copy key when specified on subsection * Update tests * Update privacy notice page tests * More test fixes	11 months ago
kosiakkatrina	51bc0cffeb	CLDC-3665 Extract sale information copy (#2711 ) * Extract shared ownership copy * Extract discounted ownership copy * rename files * CLDC-3665 Extract sale information soft validations (#2712) * Extract shared ownership copy * Extract shared ownership soft validations * Extract discounted ownership validations * Fix mappings * Update some translations * Remove full stops	1 year ago
kosiakkatrina	459420d7ee	CLDC-3541 Update sales financial validations (#2546 ) * CLDC-3569 Update social homebuy errors (#2541) * Split questions * Update the error message * Add guidance * Add back the headers * Refactor depends_on * Refactor further * CLDC-3569 Update missed errors (#2548) * Update some skipped error messages * Remove repeating deposit question * CLDC-3571 Discounted ownership validation (#2547) * Rename discount to deposit discount * Split about price rtb questions * Update error message * Update guidance partial * Fix top_guidance_partial method * Split about_price_not_rtb * Update guidance partial and validation * Fix bulk upload test * Update deposit routed_to and guidance * Refactor guidance links into a helper (#2551) * Refactor guidance links into a helper * Refactor discounted ownership guidance * CLDC-3570 Validations all other shared ownership types (#2550) * Update "all other shared ownership" errors * CLDC-3571 Update outright sale financial validations (#2549) * Update outright sale validation message * Add outright sale guidance * Update duplicate page id * User guidance helper * Fix up financial equations content (#2552) * Tweak shared ownership validation wording * Add top_guidance_partial to missed shared ownership questions * Update discounted ownership validation message when there's no grant * Update discounted sale guidance and errors * Lint and update test * Update BU test * Update test * CLDC-3569 Update guidance for shared ownership without mortgage (#2562) * Update how we display errors for BU * Update guidance for shared ownership * Add header to mortgage used question * Update shared ownership guidance * Update spacing (#2569) * Fix spacing again (#2570) * Update discounted ownership guidance (#2582) * Update discounted ownership guidance * Add top guidance partial to outright sale * Update outright sale guidance content * Update model test --------- Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>	1 year ago
kosiakkatrina	6717eb6275	CLDC-3181 Update question numbers for 2024 (#2252 ) * Update question numbers for 2024 * Stub form in tests * Stub form start_date for pages * Add a default question number * Fix a typo * Update rebase test * Refactor default question number * Refactor person question numbers * Display managing org for sales correctly in CYA * Rebase fix * More tweaks	2 years ago
Arthur Campbell	720f7ca0e2	CLDC-1945 numeric questions decimal letter entry (#1558 ) * rename variables in test file * write tests for new validations * validate that answers to numeric questions are given to the correct level of accuracy and in normal format with only digits * add error messages for new validations * add or alter step on numeric questions in sales, amend one test given step changes * copy change * remove validation that is specific to number format and fold that functionality into accuracy validation, rejig tests accordingly * fix various tests * remove reference to currency in validation message that concerns step only and doesn't check whether firled is currency related * alter copy to avoid redundant repetition in validaiton message * save changes made in rebase * changes after PO review two step values had been missed in previous work in various places there were custom validations applied that duplicated the functionality of the generic min max validation that is applied to all numeric questions, in these situations sometimes the min and max on the question class was inconsistent with the limit that triggered validations these have been corrected and made consistent various tests were affected by this and have been amended accordingly * remove tests introduced by mistake in rebase * amend step value on earnings	3 years ago
Arthur Campbell	f57b93045d	Revert "CLDC-1945 numeric questions decimal letter entry (#1442 )" (#1555 ) This reverts commit `c78f2ef5f9`.	3 years ago
Arthur Campbell	c78f2ef5f9	CLDC-1945 numeric questions decimal letter entry (#1442 ) * rename variables in test file * write tests for new validations * validate that answers to numeric questions are given to the correct level of accuracy and in normal format with only digits * add error messages for new validations * add or alter step on numeric questions in sales, amend one test given step changes * copy change * remove validation that is specific to number format and fold that functionality into accuracy validation, rejig tests accordingly * fix various tests * remove reference to currency in validation message that concerns step only and doesn't check whether firled is currency related * alter copy to avoid redundant repetition in validaiton message * save changes made in rebase * changes after PO review two step values had been missed in previous work in various places there were custom validations applied that duplicated the functionality of the generic min max validation that is applied to all numeric questions, in these situations sometimes the min and max on the question class was inconsistent with the limit that triggered validations these have been corrected and made consistent various tests were affected by this and have been amended accordingly * remove tests introduced by mistake in rebase	3 years ago
natdeanlewissoftwire	c862423adf	CLDC-1864 single log numbering (#1381 ) * feat: add initial question number behaviour * feat: add initial CYA behaviour * feat: number sales setup section * refactor: lint * feat: property information numbering * feat: household characteristics section and typo fix * feat: household characteristics numbering * feat: household situation numbering * feat: other household info numbering * feat: income, benefits and outgoings numbering * feat: shared ownership scheme numbering * feat: shared, discount and outright numbering * feat: fix income duplication bug, add numbers to other questions * feat: typo fix * feat: add lettings setup numbering * feat: add property info numbering * feat: add household char numbering * feat: add household needs numbering * feat: add household situ numbering * feat: add income numbering * feat: update tests * refactor: cleanup and disable on 2022 and before logs * feat: add test for q numbers in 23/24 year only * refactor: highlight multiplication in brackets * feat: show rent and charge questions individually on cya * feat: number new previous tenure q * feat: delete old prevten file * feat: update card numbers after merge * feat: add q60 ands 61 sales * refactor: delete empty files --------- Co-authored-by: Kat <katrina@kosiak.co.uk>	3 years ago
Arthur Campbell	0f17eab3fe	CLDC 882 add validation against grant (#1220 ) * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * implement soft validation of grant value * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix final test from added page * update test after rebase	3 years ago
kosiakkatrina	c339ffda1f	Cleanup the form (#1166 ) * Remove empty descriptions from pages * remove empty headers from pages * Remove redundant subsection assignment from pages * Remove redundant page assignement from questions * Remove redundant section assignment from subsections * Remove redundant form assignments from sections * Remove empty hint texts from questions * lint	3 years ago
kosiakkatrina	6102b50ebe	Cldc 1776 sales information sections (#1106 ) * Mark subsection as completed if it is not displayed in the tasklist and hide it from the UI * Add sale_information section * add sales information subsections * Cldc 1531 staircasing (#1109) * Add staircase field to sales_logs table * Add staircase question and page * add staircase page to the shared ownership scheme subsection fix file name * Cldc 1539 previous bedrooms (#1108) * add frombeds field * Add previous_bedrooms page and question * add Previous Bedrooms page to the shared ownership subsection * Cldc 1532 about staircasing (#1110) * Add stairboughts and stairowned fields to the database * Add about staircasing page and questions * Add about staircasing page to the shared wnership scheme subsection * Add a space before percent * Cldc 1546 monthly rent (#1111) * Add monthly rent column to sales logs table * Add monthly rent question and page * Add monthly rent page to the shared ownership scheme subsection * Cldc 1535 exchange contracts (#1112) * Add exdate to sales logs table * Add exchange date page and question * Add exchange contracts page to the shared ownership subsection * derive exday, exmonth and exyear, tests and lint * rebase tests * Cldc 1538 la nominations (#1115) * Add la nominations column to sales logs table * Add La nominations page and questions * Add la nominations to the shared ownership subsection * Add accidentally removed files * Cldc 1545 about the deposit (#1113) * feat: add question(s) without depends_on behaviour * feat: separate ids for diff sections * test: update tests * test: add tests * tests: test tweaks * refactor: linting * Cldc 1538 la nominations (#1115) * Add la nominations column to sales logs table * Add La nominations page and questions * Add la nominations to the shared ownership subsection * Add accidentally removed files * feat: add question(s) without depends_on behaviour Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> * Cldc 1533 is resale (#1118) * feat: add resale question and page * tests: add new tests * test: update previous tests * refactor: linting * refactor: linting * Cldc 1576 buyer prp (#1117) * Add soctenant field to sales logs * Add buyer previous page and question * Add buyer previous page to shared ownership scheme subsection * rebase migrate * rebase too * Cldc 1540 about price (#1121) * add price fields to the sales logs table * Add about proce questions * add about proce pages * Add about price pages to sale information sections * rebase changes * happy new year * Switch the order of sales log sections * Cldc 1540 fixes (#1130) * Update order of pages and remove wrong id's * Add spacing to the hint text * Cldc 1521 living before purchase (#1129) * feat: add new page and question and update db * test: add and update tests * feat: reset db * Only display from beds for social housing (#1131) * Cldc 1544 mortgage amount (#1136) * feat: add sales log seeds * feat: add question and page and update db * tests: add and update tests * Cldc 1540 fixes part two (#1135) * Change about_price_social_housing to about_price_shared_ownership and display it in all shared ownership cases * Change about_price to purchase_price and display it for outright sale * lint * Move exchange contracts date page (#1143) * feat: PO fix and tests (#1144) * feat: PO fix and tests * feat: simmplification * refactor: linting * feat: copy tweak Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com> Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>	3 years ago

12 Commits (9ea12911c4a5dd18b72111eb4650f2e5d5fc30c1)