9f9d7f7c6d
Undo a change
10 months ago
f73bd0b1aa
Undo changes to validation method
10 months ago
d551979800
Revert "Fix bug clearing uprn from see all answers"
...
This reverts commit a66c47a1ab
10 months ago
a66c47a1ab
Fix bug clearing uprn from see all answers
10 months ago
5c86ad442c
Handle nil
10 months ago
543a65e153
Correct attribute name
10 months ago
a89446b666
Prevent changing logs to 2025 with invalid addresses
10 months ago
6ae855bd40
Revert "Validate entered addresses as within England"
...
This reverts commit 2dbfbcc8a5
10 months ago
2dbfbcc8a5
Validate entered addresses as within England
10 months ago
ddebebee30
Remove irrelevant 2023 checks ( #2895 )
...
* Remove irrelevant 2023 checks
* Update/remove tests
11 months ago
cabd650dd6
CLDC-3833: Update validation on total discount for percentage discounts to include an extra 1000 leeway for rounding errors ( #2889 )
11 months ago
1c03a70fa2
CLDC-3769 Fix some check errors flows ( #2826 )
...
* Fix some check errors flows
* Only show check errors journey for question on different pages
* Update restore_error_field_values
1 year ago
f5e6529baa
CLDC-3314: Skip BU error for ownershipsch in validate_discounted_ownership_value ( #2837 )
1 year ago
128ac5d57a
CLDC-3758: Sales - Add shared ownership staircasing transaction section ( #2788 )
...
* db migration, new sales log fields
* Add new staircasing transaction section
* Update tests
* Lint
* Add tests
* Use log methods
* Lint
* Update test
* Remove compact
* Change section display condition
* CLDC-3760: Sales - firststair and numstair staircasing questions validations (#2793 )
* Add validation to new questions firststair and numstair
* Remove page headers on single question page
* Remove page
* More useful page header
* Show don't know option from 2025 onwards
* Add page header to monthly rent only for the version with two questions on the page
* Remove page header staircase initial date only page
* Update displayed answer options
* Fix lint
* Updates after merge
* Update test
* Update tests
1 year ago
b3dca51216
CLDC-3753: Update soft income validations ( #2779 )
...
* CLDC-3753: Update soft income validations
* Update tests
* Fix linting
* Include reference to informative text translations copy
* Combine min and max checks for income based on ecstat
* Fixes
* Update tests
1 year ago
671232daa9
CLDC-3734 Add LA in England validation for 2025 ( #2763 )
...
* Add LA in England validation for 2025
* Validate supported housing logs
* Add error message to the date
* Update error messages
* lint
* Fix error messages for date
* Update no address found soft validation
* Update validation messages
1 year ago
bc1fe83750
CLDC-3757: Sales - Change values in validation check for Q84 (25/26) ( #2781 )
...
* Update 2025 version of validation check
* Update validation for 2025
* Put two if statements into one
* Different approach to comparing dates
* Alternative method to compare dates
* Update tests
1 year ago
a3ce7e9f95
Update validation message ( #2783 )
1 year ago
de1d28c27e
Increase soft max for old persons shared ownership savings ( #2778 )
1 year ago
16393cf4ab
Trigger income error on uprn_selection ( #2771 )
1 year ago
2b629891fb
CLDC-3666: Pull sales financial validations into translations file ( #2716 )
1 year ago
61eb0057f6
CLDC-3693: Extract shared validations ( #2744 )
...
* Extract lettings household validation from shared validations
* Extract lettings setup validation from shared validations
* Extract only shared validations
1 year ago
6fb29ade6b
CLDC-3712: Sales Form Updates ( #2756 )
1 year ago
9763013ac1
Extract sale information validations into a separate translations file ( #2699 )
1 year ago
469211ce65
CLDC-3661 Update year format ( #2713 )
...
* Update year combo format
* lint
* Update tests and validations
* update model tests
* Update bu list year format
* Update test
1 year ago
9bd3389c84
CLDC-3655 Extract property information validations ( #2700 )
...
* Extract property information validations
* Refactor possesive variable from errors
1 year ago
443a19f42d
Update household validations ( #2708 )
1 year ago
29a5889aa6
CLDC-3653 Copy changes - sales setup validations ( #2677 )
...
* Extract sales setup validations to translation file
1 year ago
9b5110c175
Don't add error message to type twice ( #2626 )
1 year ago
4690fb446e
CLDC-3595 Remove duplicate errors for check errors page ( #2560 )
...
* Remove duplicate errors for check errors page
* Remove unused line
* Format some missed errors correctly
1 year ago
eb355d6829
Update equity validation for resale ( #2559 )
1 year ago
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
1 year ago
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
2 years ago
34faa74a6c
CLDC-3447: Allow decimal discount percentage and increased validation tolerance ( #2427 )
...
* CLDC-3447: Allow decimal discount percentage and increased validation tolerance
* Update tests to use decimal discount
* Disable extra borrowing soft validation for 2024 onwards
* CLDC-3447: Make tolerance inclusive
* Fix linting error
* Fix method call
* Only change strictness when discount is present
* Remove blank line
2 years ago
4baf0bcdfc
CLDC-3350: Add validation for mortgage+deposit for outright sales ( #2349 )
2 years ago
6d7a319b4f
CLDC-3338: Add tolerance to discounted sale calculations ( #2333 )
...
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
* C:DC-3338: Add tolerance to grant calculations
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
2 years ago
999a33e0f7
CLDC-3313 Update financial sale validations ( #2313 )
...
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
2 years ago
5907502f21
CLDC-3146 Update household validations ( #2256 )
...
* Separate the validations, remove irrelevant tests
* Remove relevant lettings 2023 validations from 24
* Update validations for 2024 lettings
* Separate sales validations
* Infer child uner 16 for sales
* Update sales validations
* Update tests
* Add validations to all relevant fields
* Add a 2023 context
* Undo some 2024 validations
* Remove another validation, update test names
* Remove child option hint
* Update person age hint
* Add ecstat buyer validation
* Add custom ecstat BU errors
* Skip working situation for child in sales
* Add child under 16 validation to 2024, do not reset ecstat
* Add soft validation columns
* Add partner under 16 soft validation
* Add multiple partners soft validations
* Remove child option for buyer 2
* Update CSVs
* Check hhmemb exists
* refactor
* Display child option for lettings
* Remove wrong tests
* More tests
2 years ago
aca9eb6301
CLDC-3300 Update BU mortgageused error ( #2310 )
...
* Don't allow don't know as 2023 mortgageused
* Don't allow don't know as 2023 mortgageused for discounted ownership
* Allow mortgageused don't know if stairowned 100
* Update row parser test
* Move mortgageused validations onto the log model
* Allor outright sale mortgageused 3, don't allow non staircaseing shared ownership mortgageused 3
* Rebase fix
2 years ago
8693037132
CLDC-1944: Replace soft date validation with hard date validation for 2024 and allow dates before 2000 ( #2280 )
...
* CLDC-1944: Replace soft date validation with hard date validation for 2024 and allow dates before 2000 in cases of soft validation failure
2 years ago
ff55bed2b2
CLDC-2220 Update buyer pluralisation ( #2272 )
...
* Pluralise buyer in household characteristics/setup
* Pluralise buyer in sales information sections
* Pluralise buyer in savings
* Pluralise other buyers, update privacy notice test
* Pluralise buyer in validations and translations
* Route to pages when joint purchase is not answered
* Fix apostrophes
* Update translations
* More updates
2 years ago
642b9cdaf2
CLDC-3264: Setup to allow using future form on staging for testing ( #2279 )
...
* CLDC-3264: Setup to allow using future form on staging for testing
* Update bulk upload year_spec tests
* Fix indentation
* Disable future form use on review apps for testing
* Move lettings startdate 14 day validation to enforce order
* Update tests
* Restore future form use on review apps
2 years ago
36553f4777
CLDC-1970: Use more relevant error message for shared ownership income below 0 ( #2270 )
2 years ago
3856a175af
Add tolerance to soft validation ( #2240 )
2 years ago
2cf55470d0
CLDC-3177 Validate staircasing mortgage ( #2239 )
...
* Validate staircasing mortgage
* Fix BU tests
2 years ago
f266099e19
Update non staircasing mortgage validation ( #2238 )
2 years ago
ac16c74303
CLDC-3179 Update routing for previous postcode ( #2207 )
...
* Update routing for previous postcode
* Infer ppostcode_full for discounted sales
* Escape characters
* Update previous la routing
* Set prevloc
* Move postcode inferance
* Remove validation for 2024
* Update postgres in dockerfile
2 years ago
ea1a7b7f54
CLDC-3176 Make deposit dynamically optional ( #2210 )
...
* Update optional hint text for deposit in 24/25
* Make deposit dynamically optional, update BU
* Refactor conditional page
* Add validation
2 years ago
46aae6e774
Validate non staircasing mortgage value ( #2223 )
2 years ago
140e55d313
CLDC-3184 Add value/discount validation ( #2222 )
...
* Add value/discount validation
* fix postcode field
2 years ago
Manny Dinssa
kosiakkatrina
Rachael Booth
Arthur Campbell
Robert Sullivan