submit-social-housing-lettings-and-sales-data

2897 Commits

223 Branches

251 Tags

76 MiB

Tree: a0842064fb

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	745e1e7e4b	CLDC-2248 Improve soft validations (#1584 ) * Update interruption screen page * Update routing and add flash * Only display routed to affected questions * Add affected_question_ids to pregnancy check * lint * Add skip link and lint * Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids * typo * Fix button wording * Update action href links * Change how we route back to interruption screen * Update affected_question_ids for lettings * Update sales soft validations * Update title texts * Update styling * Update is_referrer_interruption_screen? check and naming * Add interuption screen helper specs * Add request test for fixing soft validation * Add tests for geting soft validation page * Extract interruption screen banner * Update action_href to be reusable * Extract questions out of check answers summary list * Reuse check_answers_summary_list for interruption screen * refactor string parse * Rename attribute * fix test * Add tests for sales paths * typo * Update validation message: void date, major repairs date * Update validation message: rent_value_check, 2022 * Update validation message: buyer live in * Update validation message: staircase * Update validation message: purchase price * Update validation message: income * Update validation message: savings * Update validation message: extra borrowing * Update validation message: extra borrowing * Update validation message: wheelchair * Update validation message: monthly charge * Update validation message: mortgage * Update validation message: old persons shared ownership * Update validation message: discount * Update validation: min retirement * Wording in tests and time test * Update missing question * Refactor is referrer methods * Update validation message: net income * Update validation message: deposit and savings * Update validation message: mortgage, discount and deposit * Fix test validation messages * Fix the retirement check showing on the card 8, fix tests * test * return the user back to the check_your_answers after fixing a validation from check_your_anwers * pr comments	2 years ago
kosiakkatrina	7f76fffcce	CLDC-1911 Add form definition for 23/24 lettings (#1254 ) * Spike for generating form * Add remaining field mappings * Add question attributes conditionally * Display page attributes conditionally * update subsection formatting * Update section formatting * fix generator * Fix generator * Update the form handler and form to create post 2021 forms programatically * Initially generated and linted form * Cover lettings sections and subsections wiht tests * Cover age pages and questions with tests * Add reusable age questions and adjust the tests * Add a generic person age page using generic questions and adjust specs * Multiline arrays in subsections * Use generic person age page in household characteristics and remove unused pages/questions * Combine and reduce tests * Backfill duplicate rsnvac question * Backfill repeating question * Backfill repeating voiddate * Backfill repeating tenancy question * Backfill ethnic questions * Backfill reason question * Backfill prevten question * Backfill referral questions * Backfill chcharges questions * Backfill brent questions * Backfill scharge * Backfill pscharge * Backfill supcharg * Backfill tcharge * Backfill retirement value check question * Make person known questions generic * Make person gender identity questions generic * Make relationship questions generic * Make working situation questions generic * make retirement check generic * make pregnant household check generic * Make pregnancy value checks generic, again * Undo for and form handler changes * Remove generate form task and service * Remove empty headers, descriptions and initializers from pages * Fix tests * lint	2 years ago

Author

SHA1

Message

Date

kosiakkatrina

745e1e7e4b

CLDC-2248 Improve soft validations (#1584 )

* Update interruption screen page

* Update routing and add flash

* Only display routed to affected questions

* Add affected_question_ids to pregnancy check

* lint

* Add skip link and lint

* Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids

* typo

* Fix button wording

* Update action href links

* Change how we route back to interruption screen

* Update affected_question_ids for lettings

* Update sales soft validations

* Update title texts

* Update styling

* Update is_referrer_interruption_screen? check and naming

* Add interuption screen helper specs

* Add request test for fixing soft validation

* Add tests for geting soft validation page

* Extract interruption screen banner

* Update action_href to be reusable

* Extract questions out of check answers summary list

* Reuse check_answers_summary_list for interruption screen

* refactor string parse

* Rename attribute

* fix test

* Add tests for sales paths

* typo

* Update validation message: void date, major repairs date

* Update validation message: rent_value_check, 2022

* Update validation message: buyer live in

* Update validation message: staircase

* Update validation message: purchase price

* Update validation message: income

* Update validation message: savings

* Update validation message: extra borrowing

* Update validation message: extra borrowing

* Update validation message: wheelchair

* Update validation message: monthly charge

* Update validation message: mortgage

* Update validation message: old persons shared ownership

* Update validation message: discount

* Update validation: min retirement

* Wording in tests and time test

* Update missing question

* Refactor is referrer methods

* Update validation message: net income

* Update validation message: deposit and savings

* Update validation message: mortgage, discount and deposit

* Fix test validation messages

* Fix the retirement check showing on the card 8, fix tests

* test

* return the user back to the check_your_answers after fixing a validation from check_your_anwers

* pr comments

2 years ago

kosiakkatrina

7f76fffcce

CLDC-1911 Add form definition for 23/24 lettings (#1254 )

* Spike for generating form

* Add remaining field mappings

* Add question attributes conditionally

* Display page attributes conditionally

* update subsection formatting

* Update section formatting

* fix generator

* Fix generator

* Update the form handler and form to create post 2021 forms programatically

* Initially generated and linted form

* Cover lettings sections and subsections wiht tests

* Cover age pages and questions with tests

* Add reusable age questions and adjust the tests

* Add a generic person age page using generic questions and adjust specs

* Multiline arrays in subsections

* Use generic person age page in household characteristics and remove unused pages/questions

* Combine and reduce tests

* Backfill duplicate rsnvac question

* Backfill repeating question

* Backfill repeating voiddate

* Backfill repeating tenancy question

* Backfill ethnic questions

* Backfill reason question

* Backfill prevten question

* Backfill referral questions

* Backfill chcharges questions

* Backfill brent questions

* Backfill scharge

* Backfill pscharge

* Backfill supcharg

* Backfill tcharge

* Backfill retirement value check question

* Make person known questions generic

* Make person gender identity questions generic

* Make relationship questions generic

* Make working situation questions generic

* make retirement check generic

* make pregnant household check generic

* Make pregnancy value checks generic, again

* Undo for and form handler changes

* Remove generate form task and service

* Remove empty headers, descriptions and initializers from pages

* Fix tests

* lint

2 years ago

2 Commits (a0842064fbfa618f8ea026da21d871d32b916042)