submit-social-housing-lettings-and-sales-data

2319 Commits

218 Branches

260 Tags

83 MiB

Tree: a0b708b21e

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	825076a522	CLDC-2456 Sales collection year test fixes (#1689 ) * feat: setup to replicate failures to fix * feat: wip test fixes * feat: remainder of current state test fixes * feat: set form date to past to trigger errors to fix * feat: revert, don't want this in final diff * feat: fix row_parser tests * feat: sales log importer and validator fixes * feat: remainder of test fixes * refactor: lint	2 years ago
Arthur Campbell	170b727d76	CLDC-2371-ensure-invalid-values-for-sales-logs-are-reset (#1628 ) * call form to reset invalid values when saving a sales log * fix tests failing after updating sales log functionality to reset invalid answers * add a test to cover the new functionality added * a further test	2 years ago
Arthur Campbell	40cf0c10c2	CLDC-1633 build feature csv download of sales logs (#1568 ) * create a method on the FormHandler that returns the sales form questions for all years in the order that they appear in the form * update csv email job to accomodate sales log export as well as lettings add to tests to reflec the changes made * write tests to cover the desired functionality of the SalesLogCsvService * create the SalesLogCsvService create a necessary method on the log to enable submission method to be included on the csv derive values for the two halves of previous postcode for export * add relevant links in the UI and pipe everything together in controllers amend organisations controller to have flexibility to download logs of either type add necessary methods to sales log controller, raising shared method to logs controller update routing for amendments and additions extract helper method to build urls for downloading logs within an organisation * correct various linter complaints and tech review suggestions * minor amendment to add old_id and reorder early columns * undo my 'clever' refactor that broke things * refactoring of csv service after some tech review and some UI testing in review app * update tests to include a test of a full export and all values in teh csv * correct minor routing error to ensure correct url is shown and tab selected after requesting csv email * update organisations controller requests spec file to cover new functionality and make a minor amendment to authentication scope in the controller after error found in testing * write request tests for the new functionality in the sales log controller, define authorisation in the controller * minor correction after rubocop's kind suggestion' * various corrections from first pass at PO, tech review, linter, etc * refactor :ordered_sales_questions_for_all_years * first pass at implementing flexible code-based form fixtures for testing * second pass * refactor all tests of :ordered_sales_questions_for_all_years to use new factories * some refactoring in the testing of the csv service * use that fact that params is always available in controllers and don't pass it around, inline some methods calls * correct minor bug to ensure that "Return to logs" link returns to the correct index page * remove reminder comments * write further tests on the manipulation of questions into the csv headers, update factories of form constituents to allow the creation of forms with richer questions * fix linter complaints * minor alterations after rebase to account for changes made on other branches * refactor after code review * tweak fixtures after rebase containing alterations to the factory defaults	2 years ago

Author

SHA1

Message

Date

natdeanlewissoftwire

825076a522

CLDC-2456 Sales collection year test fixes (#1689 )

* feat: setup to replicate failures to fix

* feat: wip test fixes

* feat: remainder of current state test fixes

* feat: set form date to past to trigger errors to fix

* feat: revert, don't want this in final diff

* feat: fix row_parser tests

* feat: sales log importer and validator fixes

* feat: remainder of test fixes

* refactor: lint

2 years ago

Arthur Campbell

170b727d76

CLDC-2371-ensure-invalid-values-for-sales-logs-are-reset (#1628 )

* call form to reset invalid values when saving a sales log

* fix tests failing after updating sales log functionality to reset invalid answers

* add a test to cover the new functionality added

* a further test

2 years ago

Arthur Campbell

40cf0c10c2

CLDC-1633 build feature csv download of sales logs (#1568 )

* create a method on the FormHandler that returns the sales form questions for all years in the order that they appear in the form

* update csv email job to accomodate sales log export as well as lettings
add to tests to reflec the changes made

* write tests to cover the desired functionality of the SalesLogCsvService

* create the SalesLogCsvService
create a necessary method on the log to enable submission method to be included on the csv
derive values for the two halves of previous postcode for export

* add relevant links in the UI and pipe everything together in controllers
amend organisations controller to have flexibility to download logs of either type
add necessary methods to sales log controller, raising shared method to logs controller
update routing for amendments and additions
extract helper method to build urls for downloading logs within an organisation

* correct various linter complaints and tech review suggestions

* minor amendment to add old_id and reorder early columns

* undo my 'clever' refactor that broke things

* refactoring of csv service after some tech review and some UI testing in review app

* update tests to include a test of a full export and all values in teh csv

* correct minor routing error to ensure correct url is shown and tab selected after requesting csv email

* update organisations controller requests spec file to cover new functionality and make a minor amendment to authentication scope in the controller after error found in testing

* write request tests for the new functionality in the sales log controller, define authorisation in the controller

* minor correction after rubocop's kind suggestion'

* various corrections from first pass at PO, tech review, linter, etc

* refactor :ordered_sales_questions_for_all_years

* first pass at implementing flexible code-based form fixtures for testing

* second pass

* refactor all tests of :ordered_sales_questions_for_all_years to use new factories

* some refactoring in the testing of the csv service

* use that fact that params is always available in controllers and don't pass it around, inline some methods calls

* correct minor bug to ensure that "Return to logs" link returns to the correct index page

* remove reminder comments

* write further tests on the manipulation of questions into the csv headers, update factories of form constituents to allow the creation of forms with richer questions

* fix linter complaints

* minor alterations after rebase to account for changes made on other branches

* refactor after code review

* tweak fixtures after rebase containing alterations to the factory defaults

2 years ago

3 Commits (a0b708b21eb75b1e58aadac4c93ab16c6a04475b)