f5bba4ac5b
CLDC-2367 Add tenancy length validation to rent_type field ( #1653 )
...
* feat: add tenancy length validations to rent_type as well
* feat: update tests and conditionally add rent_type errors
2 years ago
89c1fc542b
ensure that validation errors about tenancy length are added to needstype ( #1599 )
...
needstype is a field that contributes to the vcalidation and can therefore trigger the validation
relevant test file has also been updated in line with this change
2 years ago
02aa97e793
if dont know joint tenancy dont validate hhmemb ( #1477 )
2 years ago
5606d06491
CLDC-1917 test flakiness fix ( #1437 )
...
* feat: add validation with feature flag, typo fix and update tests
* feat: flip feature toggle
* feat: update feature toggle name
* feat: fix form handler inequality
* refactor: linting
* refactor: use between in form handler
* feat: remove feature toggle
* feat: add dynamic date to lettings log factory
* feat: fix log_summary_component_spec.rb tests
* feat: update lettings_log.rb and start fixing lettings_log_spec.rb
* feat: fix more tests
* feat: fix more tests
* feat: fix lettings log import service
* refactor: linting
* feat: fix checkboxes_spec.rb
* feat: fix interruption_screen_helper_spec.rb
* feat: fix check_answers_helper_spec.rb
* feat: fix page_routing_spec.rb
* feat: fix lettings_logs_field_import_service_spec.rb
* feat: fix lettings_log_spec.rb
* feat: fix question_spec.rb
* feat: fix lettings_logs_controller_spec.rb
* feat: fix check_answers_page_lettings_logs_spec.rb
* feat: fix tenancy_validations_spec.rb
* feat: fix validations_spec.rb
* feat: fix accessible_autocomplete_spec.rb
* feat: fix form_navigation_spec.rb
* feat: fix soft_validations_spec.rb
* feat: fix lettings_log_export_service_spec.rb
* feat: fix saving_data_spec.rb
* feat: fix page_spec.rb
* feat: fix form_controller_spec.rb
* refactor: linting
* feat: fix subsection_spec.rb
* feat: fix lettings_log_spec.rb
* feat: fix financial_validations_spec.rb
* feat: fix tasklist_page_spec.rb
* feat: fix conditional_questions_spec.rb
* feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb
* feat: fix lettings_log_csv_service_spec.rb
* feat: fix tasklist_helper_spec.rb
* refactor: linting
* refactor: linting
* feat: fix lettings_log_spec.rb
* refactor: linting
* refactor: replace financial year with collection yaer
* feat: respond to PR comments pt. 1
* feat: respond to PR comments pt. 2
* feat: unfreeze all timecop freezes
2 years ago
f758d598c4
CLDC-1917 Add Startdate Validation ( #1378 )
...
* feat: add validation with feature flag, typo fix and update tests
* feat: flip feature toggle
* feat: update feature toggle name
* feat: fix form handler inequality
* refactor: linting
* refactor: use between in form handler
* feat: remove feature toggle
* feat: add dynamic date to lettings log factory
* feat: fix log_summary_component_spec.rb tests
* feat: update lettings_log.rb and start fixing lettings_log_spec.rb
* feat: fix more tests
* feat: fix more tests
* feat: fix lettings log import service
* refactor: linting
* feat: fix checkboxes_spec.rb
* feat: fix interruption_screen_helper_spec.rb
* feat: fix check_answers_helper_spec.rb
* feat: fix page_routing_spec.rb
* feat: fix lettings_logs_field_import_service_spec.rb
* feat: fix lettings_log_spec.rb
* feat: fix question_spec.rb
* feat: fix lettings_logs_controller_spec.rb
* feat: fix check_answers_page_lettings_logs_spec.rb
* feat: fix tenancy_validations_spec.rb
* feat: fix validations_spec.rb
* feat: fix accessible_autocomplete_spec.rb
* feat: fix form_navigation_spec.rb
* feat: fix soft_validations_spec.rb
* feat: fix lettings_log_export_service_spec.rb
* feat: fix saving_data_spec.rb
* feat: fix page_spec.rb
* feat: fix form_controller_spec.rb
* refactor: linting
* feat: fix subsection_spec.rb
* feat: fix lettings_log_spec.rb
* feat: fix financial_validations_spec.rb
* feat: fix tasklist_page_spec.rb
* feat: fix conditional_questions_spec.rb
* feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb
* feat: fix lettings_log_csv_service_spec.rb
* feat: fix tasklist_helper_spec.rb
* refactor: linting
* refactor: linting
* feat: fix lettings_log_spec.rb
* refactor: linting
* refactor: replace financial year with collection yaer
* feat: respond to PR comments pt. 1
* feat: respond to PR comments pt. 2
2 years ago
ff788afcb5
CLDC-1698 Update tenancy length validations ( #975 )
2 years ago
be7677ddb9
Rename case log to lettings log ( #840 )
...
This renames the case_log to lettings_log as everything we've written so
far has been geared towards lettings of social housing so it makes sense to
have the name describe this. This is also a precursor to adding in stuff for
sales logs (whatever shape that takes)
Co-authored-by: James Rose <james@jbpr.net>
2 years ago
baarkerlounger
490ebee4f6
Enable better other field validation labels
3 years ago
9f738b53e5
CLDC-1224: Tenancy type and tenancy length ( #578 )
...
* Fix value mapping for tenancy type 22/23
* Update secure helper
* Null safe
* Spec update
* Update mandatory
* Use helper
3 years ago
26c0107779
add check to prevent error on hhmemb if joint is nil ( #560 )
...
* add failing spec
* add check to prevent error on hhmemb if joint is nil
3 years ago
69bdfb2e5b
CLDC-744-joint-tenancy-validation ( #549 )
...
* add joint tenancy validation
* fix validation and spec
* improvements
* updates
* lint fixes
* fix typo
* change message displayed on hhmemb page
3 years ago
b8d60a86ea
Import changes ( #470 )
3 years ago
3488d96713
remove tenancy/referral validations ( #375 )
3 years ago
e7f57315a5
Update referral validation numbers and clearing of the answers ( #339 )
...
* Update referral validation numbers and clearing of the answers
* refactor is_internal_transfer
3 years ago
0f1f03aa8f
Refactor enums ( #321 )
...
* Remove enums
* Add some convenience methods to make validations more readable
* Gender chars instead of ints
* Remove incorrect API doc info for now
* More convenience methods
* Rename label from value method
* Wrapper hbrentshortfall
* Please the cop
3 years ago
ab1a16fb58
Cldc 465 tenancy type validation ( #312 )
...
* Validate internal referrals and secure tenancy
* Fix referral validations and move referral validation from local_authority to household
* Move validation
* Add more error messages
* lint
* fix typo in test
* Check that the methods get called
* Fix lint
3 years ago
9d77a93859
Refactor validation specs ( #304 )
...
* Refactor other household member validation specs
* Remove dupes
* Tenancy type validation
* LA validations
* Benefits proportion validations
* Outstanding rent and shortfall validations
* Typo
* Net income hard validations
* First let vacancy reason validations
3 years ago
3dff81393e
Fix tenancy validations ( #296 )
...
* Add compound tenancy validations to both fields
* Don't validate tenancy length if not answered yet
* Name subject
3 years ago
natdeanlewissoftwire
Arthur Campbell
Phil Lee
David May-Miller
Dushan
baarkerlounger
baarkerlounger
Stéphane Meny
kosiakkatrina