submit-social-housing-lettings-and-sales-data

2419 Commits

218 Branches

260 Tags

83 MiB

Tree: ab55b67e3e

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	5d80aad202	CLDC-2310 add creation method to both log import services, lettings log field import and create sales log field import (#1744 ) * some minor refactoring remove methods from child class that replicate methods on the parent class tidy up check for nil remove gubbins and inline method body given only used once * update import services for lettings and sales to import creation method write tests to cover this * create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported * update lettings log field import service and related spec to allow importing creation method of logs * use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process. various tests tweaked to suppor this change. rake task from another ticket folded into this ticket to prevent merge conflicts * rename method for ruby conventions * update PR for altered spec upload id now decided to be a better indicator of bulk upload status, import service amended accordingly tests updated in line with this * update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created * slight refactor to reduce nesting and dodge linter complaints * minor amendment to log creator spec in bulk upload to use enum dynamic methods	1 year ago
kosiakkatrina	e0e09a22d2	CLDS-1938 Add sales logs importer (#1331 ) * Create test fixtures * Add old id column * Add sales logs importer * Save and update completed discounted ownership log without postcode * Update fixtures to be incomplete * Import a completed shared ownership example * Test with a non homebuy shared ownership example * Add privacynotice * Update hholdcount and confirmed fields * Add buyer stilll serving mapping * Add totadult/totchild and outright sale examples * Update log fixtures * Extract shared methods into logs import service and lint * Add sales logs import rake task * Update noint, xml examples and some mappings * Add tests for checking that all required questions are answered * Update tests, clean up import * Map mortgage lender and mortgage lender other * Infer Mscharge known as no for outright sale * refactor setting default values * when the armedforcesspouse is not answered set is as don't know * Refactor tests: change log id names * set savings to not known if not given * Refactor tests: change nesting * Backfill default household characteristics for completed log * Add more default mapping * Typo * Improve logging and refactor tests * Adjust test data to fit with the mappings that are known so far * Rename fixture files	2 years ago

Author

SHA1

Message

Date

Arthur Campbell

5d80aad202

CLDC-2310 add creation method to both log import services, lettings log field import and create sales log field import (#1744 )

* some minor refactoring
remove methods from child class that replicate methods on the parent class
tidy up check for nil
remove gubbins and inline method body given only used once

* update import services for lettings and sales to import creation method
write tests to cover this

* create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported

* update lettings log field import service and related spec to allow importing creation method of logs

* use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process.
various tests tweaked to suppor this change.
rake task from another ticket folded into this ticket to prevent merge conflicts

* rename method for ruby conventions

* update PR for altered spec
upload id now decided to be a better indicator of bulk upload status, import service amended accordingly
tests updated in line with this

* update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created

* slight refactor to reduce nesting and dodge linter complaints

* minor amendment to log creator spec in bulk upload to use enum dynamic methods

1 year ago

kosiakkatrina

e0e09a22d2

CLDS-1938 Add sales logs importer (#1331 )

* Create test fixtures

* Add old id column

* Add sales logs importer

* Save and update completed discounted ownership log without postcode

* Update fixtures to be incomplete

* Import a completed shared ownership example

* Test with a non homebuy shared ownership example

* Add privacynotice

* Update hholdcount and confirmed fields

* Add buyer stilll serving mapping

* Add totadult/totchild and outright sale examples

* Update log fixtures

* Extract shared methods into logs import service and lint

* Add sales logs import rake task

* Update noint, xml examples and some mappings

* Add tests for checking that all required questions are answered

* Update tests, clean up import

* Map mortgage lender and mortgage lender other

* Infer Mscharge known as no for outright sale

* refactor setting default values

* when the armedforcesspouse is not answered set is as don't know

* Refactor tests: change log id names

* set savings to not known if not given

* Refactor tests: change nesting

* Backfill default household characteristics for completed log

* Add more default mapping

* Typo

* Improve logging and refactor tests

* Adjust test data to fit with the mappings that are known so far

* Rename fixture files

2 years ago

2 Commits (ab55b67e3e2af49863af0d44d00cd668bfb70406)