submit-social-housing-lettings-and-sales-data

3328 Commits

229 Branches

274 Tags

77 MiB

Tree: ac176f7ed8

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Manny Dinssa	29a469b668	CLDC-3787 Autocomplete address search (#2924 ) * Prototype * Remove git from dockerfile * UPRN search too * Revert address client and use uprn client * Add address search to lettings too * Updates with lettings logs * Update copy * Move guidance to partial * Fix uprn return * Delete new db file, restore old * Lint * Remove old db file * Lint * Add new db file, remove old * JS lint * Update schema * Add manual entry option * Update derived variables * Comment out old version of find address in 2024 * Remove db column * Add new db columns * Update guidance partial * Add unless to migration * Add migration files to remove and readd * authenticate user * Remove file * Delete migration files * Add search url * Add search url * Fix onConfirm * Add manual entry button instead of change skip link * Revert "Add manual entry button instead of change skip link" This reverts commit `22577c801a`. * Revert "Revert "Add manual entry button instead of change skip link"" This reverts commit `9f0a2111a5`. * Replace uprn question * Update question copy * Allow changing the address search value * Rename address autocomplete to address search * Add buttons to switch between address questions * Fix controller logic * Enable adding question numbers to page headers * Update skip links * Add js disabled message to select * Alternative way to handle js disabled users * Revert "Alternative way to handle js disabled users" This reverts commit `10da3d61e2`. * Fix typo * Fix address options for address search question * Reuse AddressDataPresenter where appropriate * Lint * Remove uprn selection question tests * Reuse UprnDataPresenter where appropriate * CSV export, exclude address_search * Add address search to sales and lettings factory bots * Exclude old address questions from routing, keep as exported values * lint * Update uprn value * Add address search input boolean and switch between questions * Reword copy, remove "Find" and "Search by" * Align address questions, add question number and question text * Remove old wip depends on * Update some tests * Update migration, move default value from db to model * Update test * Remove binding pry * Lint * Update test * Lint * Update test * Update routes with underscores * Remove debugging * Limit visible logs to user * Add manual address entry selected variable * Change address search min length to 3chars * Remove binding.pry * Update factory bots, manual_address_entry_selected to true for preexisting tests * Update model tests * Update sales model tests excl E-code tests * Update address search request test * Reuse uprn id instead of address_search * Set manual address entry selected as false when creating test logs * Update model test * Update request tests and remove old questions * Add back test * Update services * Update more tests Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com> * Update request tests * update model tests * Also update sales log * Update service csv uprn_selection values to 1 * Add tests for pages and questions * Update test * Update uprn_known * Lint * Add feature test * Update test * Update tests * Remove test * pre-consolidate migration files * Indentation * Controller method improvements * Update question numbers for 2025/26 * Update question numbers tests * consolidate and delete old migration files * undo changes to schema.rb * Update 2025 property information translation files * Update answer options to show singular previously selected result if present * Move buttons to bottom guidance partials * Small improvements, make address search and existing search more similar * Validate entered addresses as within England * Update test * Revert "Validate entered addresses as within England" This reverts commit `2dbfbcc8a5`. * Add missing button to sales address page * Change error code * Clear invalid options * Edit no results message method * Keep no result logic just change text * Display uprn value with address value * Still show no results message when characters entered is less than 3 rather than nothing * Fix uprn result when query is ambiguous * Reduce min match for address search * Hide no result found message just before results are populated * Prevent changing logs to 2025 with invalid addresses * Correct attribute name * Handle nil * Remove custom error message * Remove unused variables from factory * Update tests, remove address and postcode from old find address * Fix bug clearing uprn from see all answers * Revert "Fix bug clearing uprn from see all answers" This reverts commit `a66c47a1ab`. * Undo changes to validation method * Fix unchanged uprn_selection when clearing or changing uprn * Undo a change * Update bulk upload 2025 * Fix typo * Remove redundant line --------- Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com> Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>	3 weeks ago
Rachael Booth	731dcc9325	CLDC-3650: Move copy for sales setup section to translation files (#2672 )	5 months ago
natdeanlewissoftwire	fedbc6acad	CLDC-2069 Find UPRNs by address (#2278 ) * feat: mvp commit with address selector from address line 1 and postcode using OS places find endpoint * feat: build out alternative routes through the address lookup flow * refactor: lint * refactor: remove commented lines * feat: make nil safe * feat: test address client * feat: store address input separately * feat: add migration * feat: display inputs in answer label * feat: update data presenter and test * feat: revert precicions schema update * feat: revert precision schema update * feat: migrate new fields to sales logs * feat: update shared log examples tests * feat: use -1 for not listed address for extensibility * feat: add service error to address_selection * feat: handle case when no addresses are found * feat: allow re-entering different uprns * feat: improve error handling and don't accept "no match" precisions * feat: add page tests * feat: confirm uprn on address update * feat: add question tests * feat: don't set minimum match for initial search * feat: mvp commit with address selector from address line 1 and postcode using OS places find endpoint * feat: build out alternative routes through the address lookup flow * refactor: lint * refactor: remove commented lines * feat: make nil safe * feat: test address client * feat: store address input separately * feat: add migration * feat: display inputs in answer label * feat: update data presenter and test * feat: revert precision schema update * feat: migrate new fields to sales logs * feat: update shared log examples tests * feat: use -1 for not listed address for extensibility * feat: add service error to address_selection * feat: handle case when no addresses are found * feat: allow re-entering different uprns * feat: improve error handling and don't accept "no match" precisions * feat: add page tests * feat: confirm uprn on address update * feat: add question tests * feat: don't set minimum match for initial search * feat: add no address found page * feat: allow uprn known to be skipped, and set 0.4 min precision * feat: accept best "good" match in bulk upload * feat: update validations and test * refactor: avoid stubbing using any_instance_of * refactor: use change_table in migrations * feat: add lettings behaviour to sales logs * feat: update sales tests * feat: xit test that is xited in lettings * feat: stub os api in sales row parser * feat: stub os api in sales row parser * feat: add address line 1 to required attributes * feat: update matching details and fix row parser validation * refactor: improve readability * feat: set uprns as option IDs to avoid multiple lookups * feat: add sales uprn_selection * feat: update schema * feat: update tests * feat: remove redundant methods * feat: update error message and fix tests * feat: update tests * feat: update tests and error behaviour * feat: update tests	1 year ago

Manny Dinssa

29a469b668

CLDC-3787 Autocomplete address search (#2924 )

* Prototype

* Remove git from dockerfile

* UPRN search too

* Revert address client and use uprn client

* Add address search to lettings too

* Updates with lettings logs

* Update copy

* Move guidance to partial

* Fix uprn return

* Delete new db file, restore old

* Lint

* Remove old db file

* Lint

* Add new db file, remove old

* JS lint

* Update schema

* Add manual entry option

* Update derived variables

* Comment out old version of find address in 2024

* Remove db column

* Add new db columns

* Update guidance partial

* Add unless to migration

* Add migration files to remove and readd

* authenticate user

* Remove file

* Delete migration files

* Add search url

* Add search url

* Fix onConfirm

* Add manual entry button instead of change skip link

* Revert "Add manual entry button instead of change skip link"

This reverts commit 22577c801a.

* Revert "Revert "Add manual entry button instead of change skip link""

This reverts commit 9f0a2111a5.

* Replace uprn question

* Update question copy

* Allow changing the address search value

* Rename address autocomplete to address search

* Add buttons to switch between address questions

* Fix controller logic

* Enable adding question numbers to page headers

* Update skip links

* Add js disabled message to select

* Alternative way to handle js disabled users

* Revert "Alternative way to handle js disabled users"

This reverts commit 10da3d61e2.

* Fix typo

* Fix address options for address search question

* Reuse AddressDataPresenter where appropriate

* Lint

* Remove uprn selection question tests

* Reuse UprnDataPresenter where appropriate

* CSV export, exclude address_search

* Add address search to sales and lettings factory bots

* Exclude old address questions from routing, keep as exported values

* lint

* Update uprn value

* Add address search input boolean and switch between questions

* Reword copy, remove "Find" and "Search by"

* Align address questions, add question number and question text

* Remove old wip depends on

* Update some tests

* Update migration, move default value from db to model

* Update test

* Remove binding pry

* Lint

* Update test

* Lint

* Update test

* Update routes with underscores

* Remove debugging

* Limit visible logs to user

* Add manual address entry selected variable

* Change address search min length to 3chars

* Remove binding.pry

* Update factory bots, manual_address_entry_selected to true for preexisting tests

* Update model tests

* Update sales model tests excl E-code tests

* Update address search request test

* Reuse uprn id instead of address_search

* Set manual address entry selected as false when creating test logs

* Update model test

* Update request tests and remove old questions

* Add back test

* Update services

* Update more tests

Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>

* Update request tests

* update model tests

* Also update sales log

* Update service csv uprn_selection values to 1

* Add tests for pages and questions

* Update test

* Update uprn_known

* Lint

* Add feature test

* Update test

* Update tests

* Remove test

* pre-consolidate migration files

* Indentation

* Controller method improvements

* Update question numbers for 2025/26

* Update question numbers tests

* consolidate and delete old migration files

* undo changes to schema.rb

* Update 2025 property information translation files

* Update answer options to show singular previously selected result if present

* Move buttons to bottom guidance partials

* Small improvements, make address search and existing search more similar

* Validate entered addresses as within England

* Update test

* Revert "Validate entered addresses as within England"

This reverts commit 2dbfbcc8a5.

* Add missing button to sales address page

* Change error code

* Clear invalid options

* Edit no results message method

* Keep no result logic just change text

* Display uprn value with address value

* Still show no results message when characters entered is less than 3 rather than nothing

* Fix uprn result when query is ambiguous

* Reduce min match for address search

* Hide no result found message just before results are populated

* Prevent changing logs to 2025 with invalid addresses

* Correct attribute name

* Handle nil

* Remove custom error message

* Remove unused variables from factory

* Update tests, remove address and postcode from old find address

* Fix bug clearing uprn from see all answers

* Revert "Fix bug clearing uprn from see all answers"

This reverts commit a66c47a1ab.

* Undo changes to validation method

* Fix unchanged uprn_selection when clearing or changing uprn

* Undo a change

* Update bulk upload 2025

* Fix typo

* Remove redundant line

---------

Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>

3 weeks ago

Rachael Booth

731dcc9325

CLDC-3650: Move copy for sales setup section to translation files (#2672 )

5 months ago

natdeanlewissoftwire

fedbc6acad

CLDC-2069 Find UPRNs by address (#2278 )

* feat: mvp commit with address selector from address line 1 and postcode using OS places find endpoint

* feat: build out alternative routes through the address lookup flow

* refactor: lint

* refactor: remove commented lines

* feat: make nil safe

* feat: test address client

* feat: store address input separately

* feat: add migration

* feat: display inputs in answer label

* feat: update data presenter and test

* feat: revert precicions schema update

* feat: revert precision schema update

* feat: migrate new fields to sales logs

* feat: update shared log examples tests

* feat: use -1 for not listed address for extensibility

* feat: add service error to address_selection

* feat: handle case when no addresses are found

* feat: allow re-entering different uprns

* feat: improve error handling and don't accept "no match" precisions

* feat: add page tests

* feat: confirm uprn on address update

* feat: add question tests

* feat: don't set minimum match for initial search

* feat: mvp commit with address selector from address line 1 and postcode using OS places find endpoint

* feat: build out alternative routes through the address lookup flow

* refactor: lint

* refactor: remove commented lines

* feat: make nil safe

* feat: test address client

* feat: store address input separately

* feat: add migration

* feat: display inputs in answer label

* feat: update data presenter and test

* feat: revert precision schema update

* feat: migrate new fields to sales logs

* feat: update shared log examples tests

* feat: use -1 for not listed address for extensibility

* feat: add service error to address_selection

* feat: handle case when no addresses are found

* feat: allow re-entering different uprns

* feat: improve error handling and don't accept "no match" precisions

* feat: add page tests

* feat: confirm uprn on address update

* feat: add question tests

* feat: don't set minimum match for initial search

* feat: add no address found page

* feat: allow uprn known to be skipped, and set 0.4 min precision

* feat: accept best "good" match in bulk upload

* feat: update validations and test

* refactor: avoid stubbing using any_instance_of

* refactor: use change_table in migrations

* feat: add lettings behaviour to sales logs

* feat: update sales tests

* feat: xit test that is xited in lettings

* feat: stub os api in sales row parser

* feat: stub os api in sales row parser

* feat: add address line 1 to required attributes

* feat: update matching details and fix row parser validation

* refactor: improve readability

* feat: set uprns as option IDs to avoid multiple lookups

* feat: add sales uprn_selection

* feat: update schema

* feat: update tests

* feat: remove redundant methods

* feat: update error message and fix tests

* feat: update tests

* feat: update tests and error behaviour

* feat: update tests

1 year ago

3 Commits (ac176f7ed846b64a65f4971cab425526c04e31cd)