This commit fixes the tests that failed as a result of the introduction
of the created_by column in the case log table. The tests were failing as
it is now necessary to have a created_by for a case log
* Remove Save and go to submit
* Update hidden_in_check_answers
* Add la_known to dynamically not required questions if postcode_known is yes or not filled in
* infer the correct field value and remove irrelevant dynamically not required line
* Route back to the check answers if answer is changed from check answers page
* Remove redundant column
* Change field value in the test
* update test description
* change get_question form method to prioritise the routed to questions
* Add soft validation and interruption screen for basic rent
* get previous page that was routed to and display the same error for both soft validations
* Separate max and min error screens
* add a test for getting the previous page
* Update content and add more tests for previous page
* Fix link to next incomplete section
* Update status of log on log page
* Remove TasklistController as no longer required
* Add missing quotes around HTML attribute
* Add additional spec for tasklist page
* Capybara does not enjoy setting focus
Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
* Set up failing test for new soft validation design
* remove unneeded js controller
* remove unneeded controller and spec
* rename net income validation override column
* spec form changes (to allow tests to run)
* validation spec changes
* replace all instances of override_net_income_validatiom
* passing first test
* Add to form and import styling
* remove unneeded code from interruption screen view
* Update test & code - failing last new expectation
* Display 2 previous question answers in the informative text
* extract displaying of the informative text into a helper
* Add tests for helper
* Remove some of the previous soft validations set up
* fix some failing specs
* Fix more tests
* lint
* Reset earnings question prefix and suffix to initial values instead of nil
* make it route backwards on a no
* test and linter fixes
* refactor next_page
* stryling
* more changes
* fix specs
* update real form
* design tweaks
* delete commented out tests
* content changes
* content changes
* changes to informative/hint text
* More robust styles for interuption panel, use smart quotes
* Rubocop
Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
Co-authored-by: baarkerlounger <db@slothlife.xyz>
* Remove enums
* Add some convenience methods to make validations more readable
* Gender chars instead of ints
* Remove incorrect API doc info for now
* More convenience methods
* Rename label from value method
* Wrapper hbrentshortfall
* Please the cop
* household needs section change
* update enums
* fix specs
* spec fixes
* content updates to form
* fix failing spec
* remove hint text
* Update config/forms/2021_2022.json
Co-authored-by: Paul Robert Lloyd <paulrobertlloyd@users.noreply.github.com>
Co-authored-by: Paul Robert Lloyd <paulrobertlloyd@users.noreply.github.com>
* Add routing for renewals
* Fix inferring postcode (it works 🤷♀️)
* Infer remaining renewal variables
* update check answer labels
* Route to the next page if the first one is not routed to from tasklist
* Fix allocation unknown type and depends on for referrals
* add a test for and rename first_page_or_check_answers'
* Count inferred check answers answer as an answered answer :)
and remove la unknown reason field
* rename the method and add a test for gdpr completed section
* remove commented code
* add button for moving to next incomplete section
* Add extra logic for cycling sections
* fix all failures
* add test for in progress case log to declaration redirection
* fix bug with infinite recursion
* update button text to save and return to log
* use govuk_link helpers
* lint fixes
* some basic extract method refactors
* refactor tests
* lint fixes
* redirect to check answers if next subsection in progress
* fix failing spec
* Hackety hack hack
* Leave JS hooks until text conditionals are updated as well
* Fix JS errors and remove UJS
* Reload the GOV UK frontend JS
* Fix armed forces case
* Remove obsolete tests and config
* Temo fix for household members question
* Unit test
* Add helper unit test
* Correctly failing spec
* We still need stimulus to clear answers
* Fix styling issues
* Refactor style logic into helper
* Form fix
* Conditional check box questions are shown on a new page
* Update readme
* Fix date bug
* Clear conditional date fields if invalidated by top level answer
Co-authored-by: Stéphane Meny <smeny@users.noreply.github.com>
* Add hidden text to change links
This was missing, the hidden text users the check answer label so that the
two will be consistent with each other.
* update chsnge link test
* Update app/models/form/question.rb
Co-authored-by: Paul Robert Lloyd <paulrobertlloyd@users.noreply.github.com>
* Update app/models/form/question.rb
Co-authored-by: Paul Robert Lloyd <paulrobertlloyd@users.noreply.github.com>
* update change link test
* update answer links too
* add hidden text for answer links
* fix failing tests
* update answer link with hidden text creation is now less repetetive
Co-authored-by: Paul Robert Lloyd <paulrobertlloyd@users.noreply.github.com>
* Update hb question options
* add has benefits field
* derive has_benefits
* update benefit question options
* Add nocharge field
* Add rent period question and check multiple condition sets for depends_on
* update rent period answer options
* Add carehome questions and move the remaining rent questions to income and benefits section
* Reset incfreq and incref and update rent routing based on periods
* Hide total field by default
* Total charge is inferred
* We don't need to reload if we're fetching from DB anyway
* Rubocop
* Add prefixes and suffixes
* Don't count read-only questions for section status
* Add feature test for progressive enhancement
* Progressively enhance the progressive enhancement spec
* Only enhance select element once
* Add test for disabled select option
* Select by key
* Test for selected option
* Rubocop
* Instance vars
* Don't turbo cache page to make js function act each time
* Include accessible autoselect package
* Test type ahead functionality
* Add CSS
* Disabled null value
* Fix answer options so they match validations
* Disabled
* Only english LAs for current LA
* Rubocop
* Infer la from postcode
* Fix other tests and lint
* Add routing based on inferred la
* reset la to inferred false
* Use postcodes io gem
* reset values if la cannot be inferred
* Fix tests
Dushan Despotovic
baarkerlounger
kosiakkatrina
Dushan
Stéphane Meny
baarkerlounger
Paul Robert Lloyd
kiddhustle
Matthew Phelan