submit-social-housing-lettings-and-sales-data

2196 Commits

233 Branches

250 Tags

74 MiB

Tree: b3620073b9

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	6daa84b42e	CLDC-2072 changing startdate to another collection year clear invalid answers (#1469 ) * write tests that invalid answers are cleared when the start date of a log is changed * clear invalid answers when the start date of a log is changed * correct error * undo previous work to take new direction * write tests to cover updated functionality of method in form to reset values when they are not routed to or when answers to radio questions are no longer valid * update method in form to improve readability and to ensure that when the answers to radio questions are no longer valid, taht they are cleared * add back an "end" deleted by mistake and fix a linting issue * make some minor copy and variable name corrections * fix a broken test after updates * remove bulk upload tests for adding validations to unpermitted values to radio questions, these are now being cleared before validation * fix some tests broken after rebasing * add step to age questions in sales * remove list of question ids from the form that should not be cleared, this information should be held on the questions themselves * rename variables * rename instance variable to be nice and long * minor changes after rebase	2 years ago
kosiakkatrina	ae9a4d0638	Fix collection year shift issues (#1506 ) * Fix possible bulk upload years * Initialise 2021/22 form routes for tests * Return test routes from form handler * Fix some tests * fix bulk upload tests - change from mocks to actual code calls * update years for bulk upload form * Fix some uprn tests * Set the scheme as available from previous year if the collection is in crossover * Update location available_from * Update location and scheme tests * Refactor and comment out a scheme test * Some uprn and export tests * Fix lettings logs controller tests and comment out previous collection message test * fix tests for new collection year * fix bulk upload tests for some reason tenancylength must not be given for validation to pass * update bulk upload tests for new year * More fixes * Undo location changes * Fix remaining uprn * further new collection year test fixes --------- Co-authored-by: Phil Lee <asmega@users.noreply.github.com>	2 years ago
Jack	cff4cc45bc	CLDC-2068 request, validate UPRN and retrieve address (#1370 ) * Add OS_DATA_KEY env var * Add new UPRN and address columns to logs * Bugfix: use dynamic optional fields * Update optional fields * Add UPRN validation * Add UPRN Client * Add UPRN Presenter * UPRN questions and flows * Skip to non addresss questions if UPRN unknown * Address PO review comments and add missing specs * Display LA correctly	2 years ago

Author

SHA1

Message

Date

Arthur Campbell

6daa84b42e

CLDC-2072 changing startdate to another collection year clear invalid answers (#1469 )

* write tests that invalid answers are cleared when the start date of a log is changed

* clear invalid answers when the start date of a log is changed

* correct error

* undo previous work to take new direction

* write tests to cover updated functionality of method in form to reset values when they are not routed to or when answers to radio questions are no longer valid

* update method in form to improve readability and to ensure that when the answers to radio questions are no longer valid, taht they are cleared

* add back an "end" deleted by mistake and fix a linting issue

* make some minor copy and variable name corrections

* fix a broken test after updates

* remove bulk upload tests for adding validations to unpermitted values to radio questions, these are now being cleared before validation

* fix some tests broken after rebasing

* add step to age questions in sales

* remove list of question ids from the form that should not be cleared, this information should be held on the questions themselves

* rename variables

* rename instance variable to be nice and long

* minor changes after rebase

2 years ago

kosiakkatrina

ae9a4d0638

Fix collection year shift issues (#1506 )

* Fix possible bulk upload years

* Initialise 2021/22 form routes for tests

* Return test routes from form handler

* Fix some tests

* fix bulk upload tests

- change from mocks to actual code calls

* update years for bulk upload form

* Fix some uprn tests

* Set the scheme as available from previous year if the collection is in crossover

* Update location available_from

* Update location and scheme tests

* Refactor and comment out a scheme test

* Some uprn and export tests

* Fix lettings logs controller tests and comment out previous collection message test

* fix tests for new collection year

* fix bulk upload tests

for some reason tenancylength must not be given for validation to pass

* update bulk upload tests for new year

* More fixes

* Undo location changes

* Fix remaining uprn

* further new collection year test fixes

---------

Co-authored-by: Phil Lee <asmega@users.noreply.github.com>

2 years ago

Jack

cff4cc45bc

CLDC-2068 request, validate UPRN and retrieve address (#1370 )

* Add OS_DATA_KEY env var

* Add new UPRN and address columns to logs

* Bugfix: use dynamic optional fields

* Update optional fields

* Add UPRN validation

* Add UPRN Client

* Add UPRN Presenter

* UPRN questions and flows

* Skip to non addresss questions if UPRN unknown

* Address PO review comments and add missing specs

* Display LA correctly

2 years ago

3 Commits (b3620073b98d71e695b2910b6af773247e06057a)