submit-social-housing-lettings-and-sales-data

2664 Commits

235 Branches

278 Tags

78 MiB

Tree: b813b73cf3

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	745e1e7e4b	CLDC-2248 Improve soft validations (#1584 ) * Update interruption screen page * Update routing and add flash * Only display routed to affected questions * Add affected_question_ids to pregnancy check * lint * Add skip link and lint * Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids * typo * Fix button wording * Update action href links * Change how we route back to interruption screen * Update affected_question_ids for lettings * Update sales soft validations * Update title texts * Update styling * Update is_referrer_interruption_screen? check and naming * Add interuption screen helper specs * Add request test for fixing soft validation * Add tests for geting soft validation page * Extract interruption screen banner * Update action_href to be reusable * Extract questions out of check answers summary list * Reuse check_answers_summary_list for interruption screen * refactor string parse * Rename attribute * fix test * Add tests for sales paths * typo * Update validation message: void date, major repairs date * Update validation message: rent_value_check, 2022 * Update validation message: buyer live in * Update validation message: staircase * Update validation message: purchase price * Update validation message: income * Update validation message: savings * Update validation message: extra borrowing * Update validation message: extra borrowing * Update validation message: wheelchair * Update validation message: monthly charge * Update validation message: mortgage * Update validation message: old persons shared ownership * Update validation message: discount * Update validation: min retirement * Wording in tests and time test * Update missing question * Refactor is referrer methods * Update validation message: net income * Update validation message: deposit and savings * Update validation message: mortgage, discount and deposit * Fix test validation messages * Fix the retirement check showing on the card 8, fix tests * test * return the user back to the check_your_answers after fixing a validation from check_your_anwers * pr comments	2 years ago
natdeanlewissoftwire	f356ef38ab	Cldc 1464 completion date validations PO review (#1259 ) * feat: add 22/23 year validation * feat: wip commit * feat: update i18n * feat: add one year gap exchange/completion validations * tests: add tests for new validations * test: add setup validations tests * test: update factory to pass saledate validation * feat: update seeds * feat: update tests to reflect sales logs shouldn't exist in new service before 2022 * feat: merge with main, improve date behaviour * refactor: cleanup * feat: update tests * feat: enforce saledate not after 22/23 collection year end * feat: check date is valid * feat: add hodate/saledate hard validation to saledate as well * feat: add HandoverDate check to saledate question * test: update * db: update * test: update * feat: wip po updates * feat: add soft_validation to setup * feat: fix bug by making sale date soft validation optional * feat: add tests * test: update * refactor: linting	2 years ago
Jack	d4e8e64c28	CLDC-863 Add practical completion/handover date validations (#1198 ) * [CLDC-863] Add hard validation for hodate * Add soft validation	2 years ago

Author

SHA1

Message

Date

kosiakkatrina

745e1e7e4b

CLDC-2248 Improve soft validations (#1584 )

* Update interruption screen page

* Update routing and add flash

* Only display routed to affected questions

* Add affected_question_ids to pregnancy check

* lint

* Add skip link and lint

* Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids

* typo

* Fix button wording

* Update action href links

* Change how we route back to interruption screen

* Update affected_question_ids for lettings

* Update sales soft validations

* Update title texts

* Update styling

* Update is_referrer_interruption_screen? check and naming

* Add interuption screen helper specs

* Add request test for fixing soft validation

* Add tests for geting soft validation page

* Extract interruption screen banner

* Update action_href to be reusable

* Extract questions out of check answers summary list

* Reuse check_answers_summary_list for interruption screen

* refactor string parse

* Rename attribute

* fix test

* Add tests for sales paths

* typo

* Update validation message: void date, major repairs date

* Update validation message: rent_value_check, 2022

* Update validation message: buyer live in

* Update validation message: staircase

* Update validation message: purchase price

* Update validation message: income

* Update validation message: savings

* Update validation message: extra borrowing

* Update validation message: extra borrowing

* Update validation message: wheelchair

* Update validation message: monthly charge

* Update validation message: mortgage

* Update validation message: old persons shared ownership

* Update validation message: discount

* Update validation: min retirement

* Wording in tests and time test

* Update missing question

* Refactor is referrer methods

* Update validation message: net income

* Update validation message: deposit and savings

* Update validation message: mortgage, discount and deposit

* Fix test validation messages

* Fix the retirement check showing on the card 8, fix tests

* test

* return the user back to the check_your_answers after fixing a validation from check_your_anwers

* pr comments

2 years ago

natdeanlewissoftwire

f356ef38ab

Cldc 1464 completion date validations PO review (#1259 )

* feat: add 22/23 year validation

* feat: wip commit

* feat: update i18n

* feat: add one year gap exchange/completion validations

* tests: add tests for new validations

* test: add setup validations tests

* test: update factory to pass saledate validation

* feat: update seeds

* feat: update tests to reflect sales logs shouldn't exist in new service before 2022

* feat: merge with main, improve date behaviour

* refactor: cleanup

* feat: update tests

* feat: enforce saledate not after 22/23 collection year end

* feat: check date is valid

* feat: add hodate/saledate hard validation to saledate as well

* feat: add HandoverDate check to saledate question

* test: update

* db: update

* test: update

* feat: wip po updates

* feat: add soft_validation to setup

* feat: fix bug by making sale date soft validation optional

* feat: add tests

* test: update

* refactor: linting

2 years ago

Jack

d4e8e64c28

CLDC-863 Add practical completion/handover date validations (#1198 )

* [CLDC-863] Add hard validation for hodate

* Add soft validation

2 years ago

3 Commits (b813b73cf390776750812afb4d4c23574fd70bcd)