submit-social-housing-lettings-and-sales-data

3348 Commits

228 Branches

285 Tags

79 MiB

Tree: b91887b230

Commit Graph

Author	SHA1	Message	Date
J G	7815965af1	CLDC-1290 Permitted user can create a new scheme (#671 ) * added test to find link to create a new scheme * added button to create a new scheme * testing arriving to the new scheme form * non exsiting link to controller new action * SPIKEEEE * first page complete * posting to create * refactored scheme to enums * refactored new scheme page to use enums as well * views * SPIKE WIP * SPIKE WIP * SPIKE WIP * drawing list of scheme details * expanded on feature seeing more fields to fill in * expanded on feature seeing more fields to fill in 2nd page * refactored * working back buttons * working flash * more change in wip * default value for org * working spike * some spacing * filling answers * spike finished * correct name for details * testing fill in details * removed gem and further tests * Add has other client group field to schemes. Display it in the check answers. Fix tests and routing * remove details view and path Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com> * WIP change update paths * Implement changing answers (except the details one) * Add details page back for editing scheme details * added missing test for support questions and nested check answers under correct context * checking the back functionality * rubo and lint * checking the back functionality for primary gourp * checking the back functionality for confirm secondary * checking the back functionality for secondary group * checking the back functionality for support answers * checking the back functionality for returning to check answers from details page * checking the back functionality for returning to check answers from primary group page * checking the back functionality for secondary group confirm yes * checking the back functionality for secondary group confirm yes - fixed * checking the back functionality for secondary group * checking the back functionality for secondary group -fixed * checking the back functionality for returning from support page * Do not display secondary client group if the scheme doesn't have one * Add details path to schemes controller update method * Add more tests for back button * Add tests for new controller method * Add tests for creating schemes as data coordinator * fixed schema * added test for missing params when creating scheme * create for support user with or withotu required param * code to get controller render errors when required param is missing * code to implement correct validation * code to implement correct validation - part 2 * highlight missing field * doing silly dance to get correct field highlighted on the error * testing patch for schemes * testing patch for schemes - correct path * small refactoring * testing primary client group update via regular path * testing primary client group update via check answers page * testing confirm secondary group update with YES NO and returning from check answers page * testing updating secondary client group update and returning from check answers page * testing support answers and returning from check answers page * testing details and returning from check answers page * weird path when no names supplied * rubocop * lost in rebasing * started id to code refactoring * model specs remastered * fixed scheme controller specs * further refactorings * fixing feature schemes * final touches * removed code from db * remaining code purged * rubocop * included check for owning org field * checking for stock owning org selection * added stock owning org * added stock owning org on new page * added stock owning org to details * removed total units * managing related schems properly via Org * managing related schems properly via Org - rubocop * small refactoring * small refactoring - 2 * small refactoring - 3 * tests for owned_schemes and managed_schemes * rubocop * added tests for support user creating scheme * rubocop -a * tests for a primary-client-group * tests for a secondary-client-group * tests for a confirm-secondary-client-group * tests for a check-answers * tests for a details * rubocop * redundant action in controller * Trigger WF * switched to int for confirm * flashing test * flashing test for support user * flashing test rubocop Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: baarkerlounger <baarkerlounger@users.noreply.github.com>	3 years ago
Dushan	d338d277bf	CLDC-456-start-date-validations (#683 ) * start date validations * remove condition * move code * lint fixes * updates * content update * remove unneeded validations * validations * review changes * Update app/models/validations/date_validations.rb Co-authored-by: baarkerlounger <5101747+baarkerlounger@users.noreply.github.com> * update error messages * lint fixes * fix specs Co-authored-by: baarkerlounger <5101747+baarkerlounger@users.noreply.github.com>	3 years ago

Author

SHA1

Message

Date

J G

7815965af1

CLDC-1290 Permitted user can create a new scheme (#671 )

* added test to find link to create a new scheme

* added button to create a new scheme

* testing arriving to the new scheme form

* non exsiting link to controller new action

* SPIKEEEE

* first page complete

* posting to create

* refactored scheme to enums

* refactored new scheme page to use enums as well

* views

* SPIKE WIP

* SPIKE WIP

* SPIKE WIP

* drawing list of scheme details

* expanded on feature seeing more fields to fill in

* expanded on feature seeing more fields to fill in 2nd page

* refactored

* working back buttons

* working flash

* more change in wip

* default value for org

* working spike

* some spacing

* filling answers

* spike finished

* correct name for details

* testing fill in details

* removed gem and further tests

* Add has other client group field to schemes. Display it in the check answers. Fix tests and routing

* remove details view and path

Co-authored-by: baarkerlounger  <baarkerlounger@users.noreply.github.com>

* WIP change update paths

* Implement changing answers (except the details one)

* Add details page back for editing scheme details

* added missing test for support questions and nested check answers under correct context

* checking the back functionality

* rubo and lint

* checking the back functionality for primary gourp

* checking the back functionality for confirm secondary

* checking the back functionality for secondary group

* checking the back functionality for support answers

* checking the back functionality for returning to check answers from details page

* checking the back functionality for returning to check answers from primary group page

* checking the back functionality for secondary group confirm yes

* checking the back functionality for secondary group confirm yes - fixed

* checking the back functionality for secondary group

* checking the back functionality for secondary group -fixed

* checking the back functionality for returning from support page

* Do not display secondary client group if the scheme doesn't have one

* Add details path to schemes controller update method

* Add more tests for back button

* Add tests for new controller method

* Add tests for creating schemes as data coordinator

* fixed schema

* added test for missing params when creating scheme

* create for support user with or withotu required param

* code to get controller render errors when required param is missing

* code to implement correct validation

* code to implement correct validation - part 2

* highlight missing field

* doing silly dance to get correct field highlighted on the error

* testing patch for schemes

* testing patch for schemes - correct path

* small refactoring

* testing primary client group update via regular path

* testing primary client group update via check answers page

* testing confirm secondary group update with YES NO and returning from check answers page

* testing updating secondary client group update and returning from check answers page

* testing support answers and returning from check answers page

* testing details and returning from check answers page

* weird path when no names supplied

* rubocop

* lost in rebasing

* started id to code refactoring

* model specs remastered

* fixed scheme controller specs

* further refactorings

* fixing feature schemes

* final touches

* removed code from db

* remaining code purged

* rubocop

* included check for owning org field

* checking for stock owning org selection

* added stock owning org

* added stock owning org on new page

* added stock owning org to details

* removed total units

* managing related schems properly via Org

* managing related schems properly via Org - rubocop

* small refactoring

* small refactoring - 2

* small refactoring - 3

* tests for owned_schemes and managed_schemes

* rubocop

* added tests for support user creating scheme

* rubocop -a

* tests for a primary-client-group

* tests for a secondary-client-group

* tests for a confirm-secondary-client-group

* tests for a check-answers

* tests for a details

* rubocop

* redundant action in controller

* Trigger WF

* switched to int for confirm

* flashing test

* flashing test for support user

* flashing test rubocop

Co-authored-by: Kat <katrina@madetech.com>
Co-authored-by: baarkerlounger  <baarkerlounger@users.noreply.github.com>

3 years ago

Dushan

d338d277bf

CLDC-456-start-date-validations (#683 )

* start date validations

* remove condition

* move code

* lint fixes

* updates

* content update

* remove unneeded validations

* validations

* review changes

* Update app/models/validations/date_validations.rb

Co-authored-by: baarkerlounger  <5101747+baarkerlounger@users.noreply.github.com>

* update error messages

* lint fixes

* fix specs

Co-authored-by: baarkerlounger  <5101747+baarkerlounger@users.noreply.github.com>

3 years ago

2 Commits (b91887b230a5dc05d25447e606e3eaff868b0f16)