submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
James Rose	2440e8a2ef	Update service charge validations (#1428 ) * Update service charge validations * Create location deactivation periods instead of setting a scheme end date * Add test for deactivation period * Update ranges in tests * Remove scheme validation test * Check that the location gets confirmed --------- Co-authored-by: Kat <katrina@kosiak.co.uk>	2 years ago
natdeanlewissoftwire	f758d598c4	CLDC-1917 Add Startdate Validation (#1378 ) * feat: add validation with feature flag, typo fix and update tests * feat: flip feature toggle * feat: update feature toggle name * feat: fix form handler inequality * refactor: linting * refactor: use between in form handler * feat: remove feature toggle * feat: add dynamic date to lettings log factory * feat: fix log_summary_component_spec.rb tests * feat: update lettings_log.rb and start fixing lettings_log_spec.rb * feat: fix more tests * feat: fix more tests * feat: fix lettings log import service * refactor: linting * feat: fix checkboxes_spec.rb * feat: fix interruption_screen_helper_spec.rb * feat: fix check_answers_helper_spec.rb * feat: fix page_routing_spec.rb * feat: fix lettings_logs_field_import_service_spec.rb * feat: fix lettings_log_spec.rb * feat: fix question_spec.rb * feat: fix lettings_logs_controller_spec.rb * feat: fix check_answers_page_lettings_logs_spec.rb * feat: fix tenancy_validations_spec.rb * feat: fix validations_spec.rb * feat: fix accessible_autocomplete_spec.rb * feat: fix form_navigation_spec.rb * feat: fix soft_validations_spec.rb * feat: fix lettings_log_export_service_spec.rb * feat: fix saving_data_spec.rb * feat: fix page_spec.rb * feat: fix form_controller_spec.rb * refactor: linting * feat: fix subsection_spec.rb * feat: fix lettings_log_spec.rb * feat: fix financial_validations_spec.rb * feat: fix tasklist_page_spec.rb * feat: fix conditional_questions_spec.rb * feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb * feat: fix lettings_log_csv_service_spec.rb * feat: fix tasklist_helper_spec.rb * refactor: linting * refactor: linting * feat: fix lettings_log_spec.rb * refactor: linting * refactor: replace financial year with collection yaer * feat: respond to PR comments pt. 1 * feat: respond to PR comments pt. 2	2 years ago
natdeanlewissoftwire	02c41333f6	Cldc 1669 add location redesign (#1034 ) * feat: wip postcode page * feat: wip add new flow * feat: add check answers page, continue updating flow * feat: add back behaviour * feat: more flow work * feat: further flow work and flash notice, name tidying * feat: add check_answers referrer linking * feat: add controller and details linking and lint * refactor: erblinting * feat: add local_authority page (currenlty separate from edit_local_authority to avoid conflict with add location to newly created scheme path, to be fixed later). also copy and routing updates * feat: add validations to controller (could later be added to model) * fix: correct date order * feat: validate on model (except startdate) * feat: copy update * refactor: railsification * feat: add date model validation * feat: add updated availability text in check_answers * feat: more updated dynamic text and linking * refactor: erblinting * refactor: cleanup of redundant code * refactor: remove redundant create * feat: use rails route * test: wip tests * test: wip tests * feat: add new back behaviour for new scheme path and tests wip * feat: add more back behaviour for new scheme path and fix local auth validation * feat: further linking behaviour with routes and referrers, don't add new location automatically to new schemes * feat: if location with no details added, route to normal path rather than check answers * test: update model and helper location tests * test: more test updates * test: more test updates and remove redundant files * test: remove redundant tests, add postcode test * test: add new #new tests * test: add test for all new controller methods * test: add more startdate tests * refactor: erblinting * test: fix failing tests * test: update scheme test * feat: respond to PR comments * feat: make postcode clear only if changed * feat: add _update methods * refactor: simplify validation and location_edit_path method * refactor: add helper method for action text * refactor: remove redundant logic * refactor: simplify routing * refactor: reintroduce location_params * refactor: use presence validation for postcode * refactor: use presence validation for la * feat: validate confirmed * tests: make tests pass with new startdate validation * WIP * refactor: simplify display attributes helpers and update tests * refactor: linting * feat: design change to save behaviour * test: fix failing tests * feat: location code copy tweak * refactor: remove redundant function * refactor: remove add_another_location and new location page * feat: simplify startdate validations to move to model, use scheme available_from date for in range validation * test: fix failing tests * refactor: linting * feat: remove name validation as a result of PO review * test: update tests * refactor: remove redundant context Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	85368c017e	Update error message wording (#1070 )	2 years ago
kosiakkatrina	409a24b333	Cldc 1609 schemes and location validations (#1022 ) * Add base errors for start date * Add validation to location * add validation to scheme id * update error messages * wip * return dates for errors * choose newest reactivation date * Add validation to scheme_id * Fix validations in tests * add diferent error message * fix some edge dates and add activating_soon schemes error * fix error message * move status_during_startdate into validations files * rebase * refactor * rename method * remove reverse and update ordering * Extract scheme validation method * Refactor validations * Refactor status validations	2 years ago
natdeanlewissoftwire	d7f650a283	feat: add validation for voiddate and mrcdate when startdate changed … (#942 ) * feat: add validation for voiddate and mrcdate when startdate changed after these have been added later * test: add tests for new validations * refactor: remove unnecessary parens	2 years ago
Dushan	be7677ddb9	Rename case log to lettings log (#840 ) This renames the case_log to lettings_log as everything we've written so far has been geared towards lettings of social housing so it makes sense to have the name describe this. This is also a precursor to adding in stuff for sales logs (whatever shape that takes) Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	0ff0aa31fe	Cldc 1338 dates validation (#820 ) * Change property major repairs date validation from 2 years to 10 * add voiddate_date_in_soft_range? and major_repairs_date_in_soft_range? methods * update error messages for hard validations * Add property_major_repairs_value_check to the form * add void_date_value_check and fix some namings * Update value_check hidden in check answers to depend on whether the questions is answered * Remove a schema key * extract constants for number of days * change error messages wording * update schema and csv files	2 years ago
Dushan	d338d277bf	CLDC-456-start-date-validations (#683 ) * start date validations * remove condition * move code * lint fixes * updates * content update * remove unneeded validations * validations * review changes * Update app/models/validations/date_validations.rb Co-authored-by: baarkerlounger <5101747+baarkerlounger@users.noreply.github.com> * update error messages * lint fixes * fix specs Co-authored-by: baarkerlounger <5101747+baarkerlounger@users.noreply.github.com>	2 years ago
Stéphane Meny	b8d60a86ea	Import changes (#470 )	3 years ago
Dushan	b72eb9f3fc	CLDC-667 newprop derived variable (#426 ) * Update keys of rsnvac for first lets Making it match with what is in the data dictionary. It was a wuick enough fix to be included in this branch since it pairs well with the newprop derived variable implementation * add newprop derived variable and tests * fixes * use ternary statement for newprop derivation	3 years ago
baarkerlounger	0f1f03aa8f	Refactor enums (#321 ) * Remove enums * Add some convenience methods to make validations more readable * Gender chars instead of ints * Remove incorrect API doc info for now * More convenience methods * Rename label from value method * Wrapper hbrentshortfall * Please the cop	3 years ago
baarkerlounger	22e566e7ae	Refactor Reason for leaving last settled home validations (#303 ) * Refactor other field validation * Refactor reason for leaving last settled home validations * Additional tests * Remove dupe code * Remove dupe validation * Armed forces injured validations * Armed forces * Major repairs date validations * Void date validations	3 years ago
baarkerlounger	ac52864a03	Start date validation (#299 ) * Start date validation * Derive collection windows from form definitions	3 years ago

14 Commits (bc722ab1ff2a9d34bd4f2571803695892c554be8)