submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	15bbe798df	Cldc 591/further data changes (#83 ) * Remove condition_effects_prefer_not_to_say field * Change reason type * Remove prefer not to say from illness * add majorrepairs,propcode and infer postcode * Update previous location and la * Update majorrepairs, national and reasonpref * Update housing benefits fields * rename file * Add previous postcode * Move inferred postcode to model * refactor infered poscode method * Remove unneeded import * update miration and some mappings * Remove duplicate migration command	4 years ago
Daniel Baark	dbef8dfba4	CLDC-642: Soft validation UI bug fix (#82 ) * Soft validation UI needs to be on both questions being validated * Fix whether the box is checked or not * All checkboxes are integers now * Fix * Use enums as well for consistency * Use capybara matcher for less flakiness * Click link already waits * Add a retry to our fetch so tests are more resilient to intermittent network issues	4 years ago
Daniel Baark	3a753364eb	Soft validations with controllers (#77 ) * Working except for selenium checkbox issues * Remove old debug message * Make sure we only run the stimulus init once per page load * Revert that * Rubocop * Use data targets rather than id lookup, so that coupling is explicit * Use fetch * Schema update * No schema changes introduced here * Add a request spec for the new controller * Schema order did change * map over forEach * Update factory fields * Int for booleans :( * Fix spec fields * Lazy create	4 years ago
kosiakkatrina	5ae2f120a8	Db migration (#79 ) * migration wip * change field names to lowercase and fix the tests * Change national and ethnic field types and map to correct enums * change ecstat column types * Change prevten field type * Change homeless field type * Change benefit cap field type * Put db enums in one folder and add a few new field changes" * change field type for housing needs * Change illness field type * display checkbox answers * cbl, chr, cap * Change tenancy and tenancylength field types * Change landlord and rsnvac field types * Change unittype_gn field type * Reasonble preference displaying on check answers * update more field types * Fix typo in comumn name * Change more types * Test fixes * Add adr * fix some tests * run migration * Fix tests Co-authored-by: Matthew Phelan <matthew.phelan@madetech.com>	4 years ago
Daniel Baark	81ff68bb11	CLDC-510: Income range soft validations (#72 ) * Init * Add some tests * Add failing spec * Move soft validations into a module * Update test * Rubocop * Scope are auto created by enums * Rename folder to validations * No instance variable * Commit both lines * Add error indication * Make partial slightly more generic * Fix back link * Write failing test * All specs currently passing. Can this be real? * Check page should have an override question * Fix back button for check answers pages * Don't really need a wrapper method for the validations * We're really validating a page here not a question * Dup variable * Bit of a nasty hack but maybe better than deriving back link? * Set a no cache header instead of reloading * Move a teeny bit of logic out of the controller * Rubocop * Extract method	4 years ago
baarkerlounger	d92dd2d8b1	Rubocop	4 years ago
Matthew Phelan	ba9cdd31a2	Code review updates	4 years ago
magicmilo	a83a0c53fd	fix merge and move validation	4 years ago
baarkerlounger	d240e299bd	Add some test for our validations	4 years ago
baarkerlounger	656c7bda26	Specs passing	4 years ago
Matthew Phelan	c3e1f07797	validate_other_household_members refactor Co-authored-by: Daniel Baark <baarkerlounger@users.noreply.github.com>	4 years ago
Daniel Baark	fff5da304e	Refactor validations into modules (#73 ) * Refactor validations into modules * PropertyValidations * Add financial and tenancy validations * Shorten comment * Simplify	4 years ago

13 Commits (bfc3af72a903c54659e2382e2d254dfb8d09978a)