submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
David May-Miller	4a31906d45	CLDC-853 Added validations for sales income2 (#1101 ) * CLDC-853 Added hard validations for sales income2 * CLDC-853 Added soft validation for sales income2 * CLDC-853 Fix tests broken by new code * CLDC-853 Add new tests for new page and refactor slightly * CLDC-853 Fix linting errors * CLDC-853 Rename migration and update schema version * CLDC-853 Fix broken sales income2 test * CLDC-853 Rename migration * CLDC-853 Move income 2 to cya card 2 and commonise combined income validation * CLDC-853 Actually use the validate_combined_income method * combine duplicate methods after rebase, ensure hard validations are triggered on all relevant fields * move validation on child income to financial validations to stop it being triggered on lettings logs, minor amendments to tests broken by changes * revamp financial validations tests against income to reflect updates * amend child income validation to reflect specifications and write tests to cover this validation * correct linting errors and play a little code golf * change copy for some validations, add sales log method and amend interruption screen helper to support this * extract duplicate code to private method * update buyer 1 and 2 income value check to be consistent * remove ecstat from income checks, the only ecstat we care about is child which is dealt with elsewhere * rename constant struct with same anme as existing variable * amend tests to reflect the chagnes in validations and copy * enable currency formatting of numbers for inserting into informative_text or title_text * update evil test in form handler spec * rebase and fix conflicts and tests * change a variable name and correct minor rebase errors * update interruption screen helper tests * correct linting errors, minor test failure and typo * add tests for new sales log method for formatting currency * fix merge conflicts --------- Co-authored-by: Arthur Campbell <arfa.camble@gmail.com>	2 years ago
natdeanlewissoftwire	d254ef8c62	CLDC-868 Add purchase price validations (#1225 ) * feat: wip behaviour * feat: hide in cya * feat: show in cya * feat: purchase price range service and rake task * feat: fix hodate validation and use purchase price ranges * db:update * feat: more saledate -> exdate fixing * feat: add min and max conditional text * refactor: linting * refactor: remove duplicated behaviour * refactor: linting * feat: update tests * test: add validation tests * test: add purchase price rangeimport service tests * refactor: linting * feat: allow translation text and title text to display currency formatting even when not a log field * feat: use i18n * feat: update i18n * refactor: pratical -> practical * refactor: linting * refactor: revert unnecessary change * feat: respond to PR comments * tests: update after merge * feat: improve currency interruption screen display * feat: update docs * feat: fix typo * feat: missing end after merge * feat: respond to PR comments * feat: add soft validation to beds and la pages * db:update * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: revert saledate/exdate work * feat: PO comment responses * tests: update * refactor: linting * refactor: simplification * refactor: railsification * test: fix * refactor: use number_to_currency units * refactor: remove duplicated copy * db:update	2 years ago
natdeanlewissoftwire	f356ef38ab	Cldc 1464 completion date validations PO review (#1259 ) * feat: add 22/23 year validation * feat: wip commit * feat: update i18n * feat: add one year gap exchange/completion validations * tests: add tests for new validations * test: add setup validations tests * test: update factory to pass saledate validation * feat: update seeds * feat: update tests to reflect sales logs shouldn't exist in new service before 2022 * feat: merge with main, improve date behaviour * refactor: cleanup * feat: update tests * feat: enforce saledate not after 22/23 collection year end * feat: check date is valid * feat: add hodate/saledate hard validation to saledate as well * feat: add HandoverDate check to saledate question * test: update * db: update * test: update * feat: wip po updates * feat: add soft_validation to setup * feat: fix bug by making sale date soft validation optional * feat: add tests * test: update * refactor: linting	2 years ago
kosiakkatrina	fca8a852d4	CLDC-870 Update mortgage amount validations (#1240 ) * Add mortgage value check after mortgage used and mortgage amount pages * Run the mortgage amount validation on non joint purchases as well * Add validation to disounted and outright sales * only show buyer 2 checks if it's a jjoint purchase	2 years ago
kosiakkatrina	b2d5f9f546	CLDC-1924 Add monthly charges validation (#1247 ) * Add monthly_charges_value_check field to sales * Add monthly_charges_over_soft_max soft validation * Add monthly_charges_value_check page and question * Add monthly_charges_value_check pages to the relevant subsections * Fix optional field name, add validation message * test	2 years ago
Arthur Campbell	648e344af6	CLDC-1786 add validations for staircasing transaction (#1235 ) * change percent to % so that suffix is consistent with other similar questions * fix rebase conflicts * add hard validation that percentage owned after a staircasing transaction cannot be less than the percentage bought in that transaction, with associated tests * add compound validation to ensure that logs of type older person shared ownership may not have a stairbought value of greater than 75% \n associated tests included * remove duplicate method and use existing version * fix rebase conflicts * ensure schema correct and test of page number correct * fix form handler test after rebase * fix tests and ensure schema correct after rebase	2 years ago
Arthur Campbell	8fd31f3bfb	CLDC-886 add validations for discounts (#1214 ) * fix rebase conflicts * fix rebase conflicts * feat: update validation * fix rebase conflicts * fix rebase conflicts * test: update * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * implement before validation check to ensure that if the user declares no mortgage will be used, mortgage value is set to 0 * fix rebase conflicts * fix rebase conflicts * remove comment * fix rebase conflicts * Update config/locales/en.yml Co-authored-by: James Rose <james@jbpr.net> * alter order of before validation methods on sales log so that derived fields are calculated after invalidated dependent fields are cleared, fix tests broken by this change * add mortgage to derived variables so that mortgage value is set to 0 if a mortgage is not being used in the sale * remove hard validation of range for discount question and allow shared validation of numeric questions to handle this case * amend tests after rebasing * fix tests after rebasing * fix test and ensure schema correct after rebase --------- Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com> Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	7bd76c4d32	CLDC-1575 Add shared ownership validations (#1217 ) * Add income error to ownership type and ecstat fields * Add shared_ownership_deposit_value_check field * Add shared_ownership_deposit_invalid? soft validation * Add shared ownership deposit check pages and questions * Add pages to the subsection and update validation message * tests * Update validation to only trigger if la is given * Run the soft validation when mortgage isn't used or cash discount isn't given * test	2 years ago
Arthur Campbell	0f17eab3fe	CLDC 882 add validation against grant (#1220 ) * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * implement soft validation of grant value * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix rebase conflicts * fix final test from added page * update test after rebase	2 years ago
natdeanlewissoftwire	a4fbb99a3f	CLDC-1583 Add extra borrowing validation (#1201 ) * feat: add condition-less soft validation and update db * feat: add validation condition and update tests * feat: update validation * feat: update validation * feat: add tests * db: update * test: update * refactor: linting * test: update * feat: update text, remove separate redundant function, add value check page everywhere * feat: leave value check at end * test: update * feat: add value check everywhere * tests: update * db:update * feat: only appear at end * test: update * feat: add soft validation everywhere smoothly * test: update	2 years ago
Jack	cf92c9559c	Add disability and wheelchair questions validation (#1215 ) * Add Page#interruption_screen? method * Use form helper method * Validate household disability questions * Update CYA	2 years ago
Jack	d4e8e64c28	CLDC-863 Add practical completion/handover date validations (#1198 ) * [CLDC-863] Add hard validation for hodate * Add soft validation	2 years ago
kosiakkatrina	09e4a55bbb	Cldc 855 savings validation (#1102 ) * Add savings soft validation page and question * Add savings saof validation page to the income subsection * add savings_over_soft_max? soft validation * Add deposit value check soft validation page and question * Add deposit soft validation page to the income and benefits subsection * Add deposit, savings and deposit value check fields to the db * Add deposit over soft max validation * Add the value check to the new sections	2 years ago
kosiakkatrina	7d02752d82	Cldc 1440 household situation section (#1132 ) * feat: add question page and subsection (#1120) * feat: add question page and subsection * refactor: linting * feat: remove schema rows from other branch * feat: slight refactor, fix tag behaviour and add section tests * test: update and add tests * feat: update status behaviour * feat: update subsection status tag * refactor: linting * [CLDC-857] Add household wheelchair check (#1122) * [CLDC-857] Add household wheelchair check * Hide only if answered * Cldc 1497 ever served armed forces (#1124) * feat: add question and page * test: update tests * refactor: linting and slight test updates * test: fix tests * Cldc 1498 still serving armed forces (#1123) * feat: new question and tests * test: update subsection spec * test: update tests * feat: (future) conflict resolving * feat: more conflict resolution * feat: update db field * test: update id * test: updates * Cldc 1488 last accomodation (#1125) * Add postcode fields * Add previous postcode page and questions * Add last accommodation page to household situation subsection * add previous la known to the db * infer correct location fields * styling * Reorder disability questions (#1127) * [CLDC-1487] Add buyer1 previous tenure question (#1133) * use collection_start_year instead of the startdate (#1128) * [CLDC-1487] Add buyer 1 previous tenure Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> * feat: fix routing (#1141) * Add last accommodation la question (#1142) * move hint text (#1146) Co-authored-by: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com> Co-authored-by: Jack S <113976590+bibblobcode@users.noreply.github.com>	2 years ago
kosiakkatrina	514552934d	Sales financial validations (#1079 ) * Include shared validations in sales log model and run validate_numeric_min_max method * Add non london hard max income validation * Add london income validation * Remove child vlidation because buyer cannot be a child * Add income1_value_check column * Add buyer_1_income_value_check question and page * Update income1_under_soft_min? * Add mortgage and value check column * Add mortgage value check page * Update mortgage_over_soft_max? in soft validateions * Remove unused error message	2 years ago

15 Commits (c418312b6cf999e5aef2e6ac8e0ab20199d236f8)