fd24a9c964
CLDC-2227 Reorder UPRN and address question on sales logs ( #1571 )
2 years ago
37fab3fe25
[CLDC-2260] Move UPRN Known and UPRN questions to same page ( #1537 )
...
* Set uprn_known to 1 when setting UPRN
* Move fake to dev+test gemfile block
So that we can use factories in local
* Move UPRN known and UPRN questions to single UPRN page
2 years ago
3d2f362106
CLDC-2013 Add percentage discount validation ( #1516 )
...
* Add percentage_discount_value_check column
* Add percentage discount form elements
* Add soft validation method
* Add validation message
* Update import
2 years ago
cff4cc45bc
CLDC-2068 request, validate UPRN and retrieve address ( #1370 )
...
* Add OS_DATA_KEY env var
* Add new UPRN and address columns to logs
* Bugfix: use dynamic optional fields
* Update optional fields
* Add UPRN validation
* Add UPRN Client
* Add UPRN Presenter
* UPRN questions and flows
* Skip to non addresss questions if UPRN unknown
* Address PO review comments and add missing specs
* Display LA correctly
2 years ago
6be860db28
CLDC-868 purchase price validations PO review ( #1285 )
...
* feat: wip behaviour
* feat: hide in cya
* feat: show in cya
* feat: purchase price range service and rake task
* feat: fix hodate validation and use purchase price ranges
* db:update
* feat: more saledate -> exdate fixing
* feat: add min and max conditional text
* refactor: linting
* refactor: remove duplicated behaviour
* refactor: linting
* feat: update tests
* test: add validation tests
* test: add purchase price rangeimport service tests
* refactor: linting
* feat: allow translation text and title text to display currency formatting even when not a log field
* feat: use i18n
* feat: update i18n
* refactor: pratical -> practical
* refactor: linting
* refactor: revert unnecessary change
* feat: respond to PR comments
* tests: update after merge
* feat: improve currency interruption screen display
* feat: update docs
* feat: fix typo
* feat: missing end after merge
* feat: respond to PR comments
* feat: add soft validation to beds and la pages
* db:update
* feat: revert saledate/exdate work
* feat: revert saledate/exdate work
* feat: revert saledate/exdate work
* feat: revert saledate/exdate work
* feat: revert saledate/exdate work
* feat: PO comment responses
* tests: update
* refactor: linting
* refactor: simplification
* refactor: railsification
* test: fix
* refactor: use number_to_currency units
* refactor: remove duplicated copy
* db:update
* feat: add value check for discounted and outright sale
* feat: rename files
* test: update
* test: update
* test: update
* db: update
2 years ago
d254ef8c62
CLDC-868 Add purchase price validations ( #1225 )
...
* feat: wip behaviour
* feat: hide in cya
* feat: show in cya
* feat: purchase price range service and rake task
* feat: fix hodate validation and use purchase price ranges
* db:update
* feat: more saledate -> exdate fixing
* feat: add min and max conditional text
* refactor: linting
* refactor: remove duplicated behaviour
* refactor: linting
* feat: update tests
* test: add validation tests
* test: add purchase price rangeimport service tests
* refactor: linting
* feat: allow translation text and title text to display currency formatting even when not a log field
* feat: use i18n
* feat: update i18n
* refactor: pratical -> practical
* refactor: linting
* refactor: revert unnecessary change
* feat: respond to PR comments
* tests: update after merge
* feat: improve currency interruption screen display
* feat: update docs
* feat: fix typo
* feat: missing end after merge
* feat: respond to PR comments
* feat: add soft validation to beds and la pages
* db:update
* feat: revert saledate/exdate work
* feat: revert saledate/exdate work
* feat: revert saledate/exdate work
* feat: revert saledate/exdate work
* feat: revert saledate/exdate work
* feat: PO comment responses
* tests: update
* refactor: linting
* refactor: simplification
* refactor: railsification
* test: fix
* refactor: use number_to_currency units
* refactor: remove duplicated copy
* db:update
2 years ago
b2d5f9f546
CLDC-1924 Add monthly charges validation ( #1247 )
...
* Add monthly_charges_value_check field to sales
* Add monthly_charges_over_soft_max soft validation
* Add monthly_charges_value_check page and question
* Add monthly_charges_value_check pages to the relevant subsections
* Fix optional field name, add validation message
* test
2 years ago
352dae8efe
CLDC-1468 Add property postcode questions to sales ( #1187 )
...
* Add postcode fields
* Add postcode page and questions
* Add postcode page to the property information subsection
* Only display local authority question if the la is not inferred
* Fix migration
* Move postcode validation
* Infer LA fields from postcode
* infer partial postcodes
2 years ago
e77b73b316
CLDC-1467 show property_unit_type before property_building_type ( #1181 )
2 years ago
c339ffda1f
Cleanup the form ( #1166 )
...
* Remove empty descriptions from pages
* remove empty headers from pages
* Remove redundant subsection assignment from pages
* Remove redundant page assignement from questions
* Remove redundant section assignment from subsections
* Remove redundant form assignments from sections
* Remove empty hint texts from questions
* lint
2 years ago
b97ba94964
[CLDC-1470] Add wheelchair accessible question ( #1145 )
...
* Add missing PropertyLocalAuthority specs
* Add Property Wheelchair Accessible question
2 years ago
ecf1fa1a28
Update enabled method ( #990 )
...
* Change enabled? subsection method to check depends on using log questions and methods instead of a subsection status
* Update sales subsections
* Update rent validation tests to check all the affected fields
* Update setup_completed? to check all the setup sections
2 years ago
47551f8276
CLDC-1577 Added page asking for local authority in sales log ( #953 )
2 years ago
c52a30ae0c
[CLDC-1467] add type of building question to sales ( #911 )
...
* add type of building question to sales
* update check answer label
* fix tests
* [CLDC-1467] Use correct page ID
Co-authored-by: Jack S <jacopo.scotti@softwire.com>
2 years ago
78d805f704
model changes ( #915 )
2 years ago
fb9e1c50e6
Folder structure ( #901 )
...
* Update the folder structure
* Add specs
* testy 💁♀️
* Update names in tests 🫠
2 years ago
4a648a144b
CLDC 1465 Add beds question to saleslog ( #890 )
...
* Add beds question to saleslog
* move beds question to property section
* fix property filepath references
* fix failing tests
* add tests to form spec
* fix migration
2 years ago
Jack
kosiakkatrina
natdeanlewissoftwire
David May-Miller
Ted-U
Dushan