submit-social-housing-lettings-and-sales-data

2289 Commits

228 Branches

285 Tags

79 MiB

Tree: c5842122d7

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	745e1e7e4b	CLDC-2248 Improve soft validations (#1584 ) * Update interruption screen page * Update routing and add flash * Only display routed to affected questions * Add affected_question_ids to pregnancy check * lint * Add skip link and lint * Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids * typo * Fix button wording * Update action href links * Change how we route back to interruption screen * Update affected_question_ids for lettings * Update sales soft validations * Update title texts * Update styling * Update is_referrer_interruption_screen? check and naming * Add interuption screen helper specs * Add request test for fixing soft validation * Add tests for geting soft validation page * Extract interruption screen banner * Update action_href to be reusable * Extract questions out of check answers summary list * Reuse check_answers_summary_list for interruption screen * refactor string parse * Rename attribute * fix test * Add tests for sales paths * typo * Update validation message: void date, major repairs date * Update validation message: rent_value_check, 2022 * Update validation message: buyer live in * Update validation message: staircase * Update validation message: purchase price * Update validation message: income * Update validation message: savings * Update validation message: extra borrowing * Update validation message: extra borrowing * Update validation message: wheelchair * Update validation message: monthly charge * Update validation message: mortgage * Update validation message: old persons shared ownership * Update validation message: discount * Update validation: min retirement * Wording in tests and time test * Update missing question * Refactor is referrer methods * Update validation message: net income * Update validation message: deposit and savings * Update validation message: mortgage, discount and deposit * Fix test validation messages * Fix the retirement check showing on the card 8, fix tests * test * return the user back to the check_your_answers after fixing a validation from check_your_anwers * pr comments	2 years ago
kosiakkatrina	af6b6bc03d	CLD-1857 Update household characteristics section (#1249 ) * Update datails known numbering in the db * Update check answers card headers * Display same person pges for joint and non-joint purchase * Only display person questions once * Remove unused person class and methods * Always display person known pages and update headers * Fix depends on, show retirement validation for buyer 2 * test * Add person 5 to test * fix context description * Display person known question for appropriate number of other household members * tests * update test * Remove page id stubbing * Remove redundant tests * only put validation on the pages that are routed to * Refactor tests	2 years ago
kosiakkatrina	7e176bba34	CLDC-845 Add sales household details validations (#1191 ) * Add min and max for age 1 validation * Add retirement value check column to the sales table * Add retirement value check question and page * Add retirement value check pages to household characteristics * Reuse soft validations for retirement in sales * Update person_indexes * Add old_persons_shared_ownership validation * Display the retirement value check in correct places depending on the joinpur value * Update page IDs * It's always joint purchase if age 2 is displayed * lint * lint	2 years ago

Author

SHA1

Message

Date

kosiakkatrina

745e1e7e4b

CLDC-2248 Improve soft validations (#1584 )

* Update interruption screen page

* Update routing and add flash

* Only display routed to affected questions

* Add affected_question_ids to pregnancy check

* lint

* Add skip link and lint

* Move affected_question_ids to page, because we reuse questions so they might have different affected_question_ids

* typo

* Fix button wording

* Update action href links

* Change how we route back to interruption screen

* Update affected_question_ids for lettings

* Update sales soft validations

* Update title texts

* Update styling

* Update is_referrer_interruption_screen? check and naming

* Add interuption screen helper specs

* Add request test for fixing soft validation

* Add tests for geting soft validation page

* Extract interruption screen banner

* Update action_href to be reusable

* Extract questions out of check answers summary list

* Reuse check_answers_summary_list for interruption screen

* refactor string parse

* Rename attribute

* fix test

* Add tests for sales paths

* typo

* Update validation message: void date, major repairs date

* Update validation message: rent_value_check, 2022

* Update validation message: buyer live in

* Update validation message: staircase

* Update validation message: purchase price

* Update validation message: income

* Update validation message: savings

* Update validation message: extra borrowing

* Update validation message: extra borrowing

* Update validation message: wheelchair

* Update validation message: monthly charge

* Update validation message: mortgage

* Update validation message: old persons shared ownership

* Update validation message: discount

* Update validation: min retirement

* Wording in tests and time test

* Update missing question

* Refactor is referrer methods

* Update validation message: net income

* Update validation message: deposit and savings

* Update validation message: mortgage, discount and deposit

* Fix test validation messages

* Fix the retirement check showing on the card 8, fix tests

* test

* return the user back to the check_your_answers after fixing a validation from check_your_anwers

* pr comments

2 years ago

kosiakkatrina

af6b6bc03d

CLD-1857 Update household characteristics section (#1249 )

* Update datails known numbering in the db

* Update check answers card headers

* Display same person pges for joint and non-joint purchase

* Only display person questions once

* Remove unused person class and methods

* Always display person known pages and update headers

* Fix depends on, show retirement validation for buyer 2

* test

* Add person 5 to test

* fix context description

* Display person known question for appropriate number of other household members

* tests

* update test

* Remove page id stubbing

* Remove redundant tests

* only put validation on the pages that are routed to

* Refactor tests

2 years ago

kosiakkatrina

7e176bba34

CLDC-845 Add sales household details validations (#1191 )

* Add min and max for age 1 validation

* Add retirement value check column to the sales table

* Add retirement value check question and page

* Add retirement value check pages to household characteristics

* Reuse soft validations for retirement in sales

* Update person_indexes

* Add old_persons_shared_ownership validation

* Display the retirement value check in correct places depending on the joinpur value

* Update page IDs

* It's always joint purchase if age 2 is displayed

* lint

* lint

2 years ago

3 Commits (c5842122d733bebdea357e71a0dad8ac14402251)