kosiakkatrina
73cef27a0c
Restore form date validations ( #2365 )
9 months ago
kosiakkatrina
f06bcaa5e6
Bump express from 4.18.2 to 4.19.2 ( #2364 )
...
Bumps [express](https://github.com/expressjs/express ) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases )
- [Changelog](https://github.com/expressjs/express/blob/master/History.md )
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.19.2 )
---
updated-dependencies:
- dependency-name: express
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9 months ago
kosiakkatrina
a65cc59713
CLDC-2479 Allow deleting users ( #2288 )
...
* Add delete confirmation page
* Add status to the user
* Allow deleting user
* Refactor sign_in user in tests
* Add delete user button and update policy
* Update user policy
* Do not display deleted users as an answer option
* Update user table and details
* Do not show deleted users
* Disable delete user on production
* Update test
9 months ago
kosiakkatrina
d15a11bda8
Update time dependant tests ( #2361 )
...
* Update feature tests
* Remove old rake tasks
* Update some unit tests
* Update more tests
* More tests
* Fix failing sales household validation test
---------
Co-authored-by: Robert Sullivan <robert.sullivan@softwire.com>
9 months ago
kosiakkatrina
7d5aae6395
Update lettings BU specification and paper form ( #2359 )
9 months ago
Robert Sullivan
2e7cb56c70
CLDC-3351: Clear deposit in situations where it is no longer derived ( #2354 )
...
* CLDC-3351: Clear deposit in situations where it is no longer derived
9 months ago
Robert Sullivan
1d5d736f03
CLDC-3355: Reorder rent types on 2024/5 forms ( #2343 )
9 months ago
natdeanlewissoftwire
da0d27c8f9
feat: update copy ( #2357 )
9 months ago
natdeanlewissoftwire
43c0f457c9
CLDC-3363 Uneditable sales log redirect bug fix ( #2353 )
...
* feat: make check_collection_period log type specific
* feat: test check_collection_period routing
9 months ago
Rachael Booth
a51abc864b
CLDC-3333: Tweak what is a location text ( #2337 )
9 months ago
Rachael Booth
4baf0bcdfc
CLDC-3350: Add validation for mortgage+deposit for outright sales ( #2349 )
9 months ago
natdeanlewissoftwire
d53c31602d
feat: update flaky tests ( #2352 )
9 months ago
kosiakkatrina
826b803e4e
CLDC-3305 Update previous postcode routing for renewals ( #2325 )
...
* Derive previous postcode for renewals
* Do not route renewals to previous postcode
* Update test
9 months ago
kosiakkatrina
81d0363a60
Fix some timezones in tests ( #2351 )
9 months ago
kosiakkatrina
0e23fa160c
Log unsuccessful updates ( #2350 )
9 months ago
kosiakkatrina
6ccb5854d4
Add question number to success message ( #2344 )
9 months ago
kosiakkatrina
5bbf0148b5
CLDC-2478 Allow deleting locations ( #2285 )
...
* Add delete confirmation page
* Allow deleting location
* Add delete location button and update policy
* Add delete button to CYA
* Update location policy
* Do not display deleted locationa as an option
* Move delete button into the button group
* Add informative text for locations that have logs
* Refactor query
* CLDC-2478 Allow deleting scheme (#2286 )
* Add delete confirmation page
* Allow deleting scheme
* Add delete scheme button and update policy
* Add delete button to CYA
* Update scheme policy
* Do not display deleted schemes as an option
* Add informative text for schemesrbe that have logs
* Refactor query
* Update tests
* Add feature toggle
9 months ago
kosiakkatrina
41a68eee0a
CLDC-3341 Update nationality all csv labels ( #2328 )
...
* Update nationality all csv labels
* Update csv tests
* Return prefers not to say labels
9 months ago
kosiakkatrina
d7ac6efbeb
CLDC-3305 Correct previous renewal postcodes ( #2326 )
...
* Correct previous renewal postcodes
* Add test, update logs with different LAs
* Fix test
9 months ago
Robert Sullivan
b0d7dec4f7
CLDC-3291: Add empty assigned_to field to support csv export ( #2347 )
9 months ago
natdeanlewissoftwire
99ad80aebd
feat: update skip links ( #2342 )
9 months ago
natdeanlewissoftwire
695f542fdc
CLDC-3327 Deduplicate null errors in bulk upload ( #2338 )
...
* feat: validate nulls last in bu
* feat: add tests
* feat: update org errors and tests
* feat: update test copy
* feat: update tests
* CLDC-3328 Make bulk upload errors consistent between lettings and sales (#2341 )
* feat: add validate_address_fields to lettings for 2024
* CLDC-3338: Add tolerance to discounted sale calculations (#2333 )
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
* C:DC-3338: Add tolerance to grant calculations
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
* feat: add validate_address_fields to lettings for 2024
* feat: update tests
* Revert "CLDC-3338: Add tolerance to discounted sale calculations (#2333 )"
This reverts commit cdecdfebfe
.
---------
Co-authored-by: Robert Sullivan <Robert.Sullivan@Softwire.com>
Co-authored-by: Kat <katrina@kosiak.co.uk>
---------
Co-authored-by: Robert Sullivan <Robert.Sullivan@Softwire.com>
Co-authored-by: Kat <katrina@kosiak.co.uk>
9 months ago
kosiakkatrina
6dc697fa5b
Specify start date for 2023 specific logs in tests ( #2346 )
9 months ago
kosiakkatrina
a38d6a265f
CLDC-3334 Improve address search flow ( #2339 )
...
* Refactor page buttons
* Immediately show address search results
9 months ago
Robert Sullivan
845065d2d3
CLDC-3297: Add assigned to field to xml exports ( #2345 )
...
* feat: add fields to xml for 24/25 on
* CLDC-3297: Add empty assigned to column to XML exports
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
9 months ago
Robert Sullivan
cdfca1c023
CLDC-3336: Add hint text to Q77 for renewals ( #2340 )
9 months ago
natdeanlewissoftwire
9881bc7c0d
feat: add fields to xml for 24/25 on ( #2329 )
9 months ago
natdeanlewissoftwire
9881fb990a
CLDC-3339 Improve select correct address bulk upload error ( #2331 )
...
* feat: add unable to find address errors when some options are returned if they are low confidence
* feat: update copy
* feat: add tests
9 months ago
Robert Sullivan
6d7a319b4f
CLDC-3338: Add tolerance to discounted sale calculations ( #2333 )
...
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
* C:DC-3338: Add tolerance to grant calculations
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
9 months ago
kosiakkatrina
b9d93fe732
Revert all charges given validation ( #2308 )
9 months ago
natdeanlewissoftwire
a1059ef31c
CLDC-3337 Uprn confirmed routing bug fix ( #2327 )
...
* feat: update derived variables to clear uprn_confirmed when uprn_known is 0
* feat: reset other address fields when uprn is not confirmed
* feat: use pcodenk in sales logs
9 months ago
Robert Sullivan
976d0f6e73
CLDC-3329: Update hint text for schemes question ( #2336 )
9 months ago
kosiakkatrina
284dc0c263
Set managing org to created by org on date change ( #2292 )
9 months ago
Rachael Booth
f6dbc0a984
CLDC-3326: Update question number on irproduct_other to match rent_type ( #2330 )
9 months ago
Rachael Booth
e19f1e5b0d
CLDC-3234: Prevent errors from nil hhmemb ( #2301 )
...
* CLDC-3234: Handle nil hhmemb gracefully in soft validations
* CLDC-3234: Don't blank hhmemb when blanking invalid non setup fields
9 months ago
kosiakkatrina
e52a8238cc
CLDC-3343 Check relat fields for people we collect data for ( #2335 )
...
* Check relat fields for people we collect data for
* rename
9 months ago
Rachael Booth
9dc37f7fff
CLDC-3304: Add bulk upload id to xml exports from 2024 ( #2323 )
9 months ago
natdeanlewissoftwire
24dfdbe5eb
CLDC-3271 Add address fields as entered in bulk upload to support csv downloads ( #2322 )
...
* feat: add bulk upload address info to lettings csv download
* feat: add bulk upload address info to sales csv download
* refactor: lint
* feat: fix typo
* feat: update tests
* feat: add to non question fields
* feat: update tests
* feat: add sales tests
* feat: add as entered fields to xml export for 2024 only (#2324 )
* feat: update schema
9 months ago
kosiakkatrina
999a33e0f7
CLDC-3313 Update financial sale validations ( #2313 )
...
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
9 months ago
kosiakkatrina
5907502f21
CLDC-3146 Update household validations ( #2256 )
...
* Separate the validations, remove irrelevant tests
* Remove relevant lettings 2023 validations from 24
* Update validations for 2024 lettings
* Separate sales validations
* Infer child uner 16 for sales
* Update sales validations
* Update tests
* Add validations to all relevant fields
* Add a 2023 context
* Undo some 2024 validations
* Remove another validation, update test names
* Remove child option hint
* Update person age hint
* Add ecstat buyer validation
* Add custom ecstat BU errors
* Skip working situation for child in sales
* Add child under 16 validation to 2024, do not reset ecstat
* Add soft validation columns
* Add partner under 16 soft validation
* Add multiple partners soft validations
* Remove child option for buyer 2
* Update CSVs
* Check hhmemb exists
* refactor
* Display child option for lettings
* Remove wrong tests
* More tests
9 months ago
Robert Sullivan
e2ed41c03a
CLDC-3318: Add maximum percentage discount validation for bulk uploads ( #2316 )
...
* CLDC-3318: Add maximum percentage discount validation for bulk uploads
* CLDC-2213: Review markups
9 months ago
kosiakkatrina
79a009cf4b
Bump follow-redirects from 1.15.4 to 1.15.6 ( #2321 )
...
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects ) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases )
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.15.4...v1.15.6 )
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
9 months ago
natdeanlewissoftwire
f2014439ce
feat: update sales resources ( #2320 )
9 months ago
natdeanlewissoftwire
7055d5b538
CLDC-3192 Add new rent range data ( #2306 )
...
* feat: add new rent range data
* feat: update data
9 months ago
kosiakkatrina
aca9eb6301
CLDC-3300 Update BU mortgageused error ( #2310 )
...
* Don't allow don't know as 2023 mortgageused
* Don't allow don't know as 2023 mortgageused for discounted ownership
* Allow mortgageused don't know if stairowned 100
* Update row parser test
* Move mortgageused validations onto the log model
* Allor outright sale mortgageused 3, don't allow non staircaseing shared ownership mortgageused 3
* Rebase fix
9 months ago
natdeanlewissoftwire
d063e653f9
CLDC-3311 UPRN bulk upload efficiency improvements ( #2317 )
...
* Empty-Commit
* feat: stress testing efficiency improvements
* feat: revert initialisations
* refactor: lint
9 months ago
natdeanlewissoftwire
29980b1f7b
CLDC-3302 Make mortgageused bulk upload errors only display on relevant field ( #2311 )
...
* feat: only add mortgageuesd error to relevant mortgageused field
* feat: add test
* feat: test
* feat: test 2023
9 months ago
natdeanlewissoftwire
7d83639fc4
feat: update resources ( #2319 )
9 months ago
natdeanlewissoftwire
73aec51425
CLDC-2742 Update user status display behaviour ( #2307 )
...
* feat: use status tags to show user active status
* feat: add unconfirmed status
* feat: update tests
* refactor: erblinting
* feat: update tests
* refactor: lint
9 months ago
natdeanlewissoftwire
5b5e29a84a
CLDC-3310 UPRN routing bug fix ( #2312 )
...
* feat: update routing
* feat: test routing
9 months ago