submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	0e4950c2cc	CLDC-3438 Update log csv download flow (#2403 ) * Filter out empty options from selected filters * Redirect to year filter if it is not selected * Add remaining filter questions * Display lettings filters CYA * Add cancel, conditionally display send email * Refactor * Add removed tests * Update method name * Add sales logs filters * Update tests * Set label size on filter questions * Refactor * Deduplicate filter views * Rename methods * Authenticate pages * Update filtering per organisation * Update routing from CYA * lint * Refactor check_your_answers_filters_list * Redirect if year is not given for sales csv * Update formatted organisations methods * Update missing and wrong copy * Update cancel and back buttons * CLDC-3442 Download logs csv per year (#2404) * Specify year in lettings csv download service * Specify year in sales csv download service * Define non_question_fields per year * Tidy up missing fields and tests * Fix request tests * Refactor * Add missing param * CLDC-3348 Update sales CSV for support (#2407) * Update sales csv for support * CLDC-3352 Update sales CSV address order (#2410) * Update sales support csv address ordering * Refactor * CLDC-3367 Rename sales support CSV fields (#2413) * Rename sales support CSV fields * Update sales CSV user fields order (#2416) * CLDC-2586 Rename scheme sensitive (#2405) * Rename scheme sensitive in lettings csv * Rename scheme sensitive in schemes csv * CLDC-3347 Show soft validations in support CSVs only (#2406) * Show soft validations in support csvs only * CLDC-3352 Update lettings CSV address order (#2409) * Update lettings support csv address ordering * Refactor * CLDC-3415/3421/3422 Add lettings CSV updates (#2415) * Add first_time_property_let_as_social_housing to coordinators csv * Update lettings CSV user fields order * Remove new_old from lettings CSV * Remove duplicate rent value check from CSV (#2423) * Refactor CSV service (#2425) * Extract and move lettings methods * Extract and more sales methods	7 months ago
natdeanlewissoftwire	24dfdbe5eb	CLDC-3271 Add address fields as entered in bulk upload to support csv downloads (#2322 ) * feat: add bulk upload address info to lettings csv download * feat: add bulk upload address info to sales csv download * refactor: lint * feat: fix typo * feat: update tests * feat: add to non question fields * feat: update tests * feat: add sales tests * feat: add as entered fields to xml export for 2024 only (#2324) * feat: update schema	10 months ago
natdeanlewissoftwire	05b9e59939	CLDC-2242 Add assigned to filter (#1775 ) * feat: wip commit * feat: rest of assigned to filter behaviour * feat: start to update tests * feat: update tests * feat: update tests * refactor: linting * feat: add new test * feat: add new test * feat: update filters_count * feat: let support users see all users * feat: let users select users from stock owners/managing agents too * refactor: typo * feat: update tests	1 year ago
Arthur Campbell	8c34719987	CLDC-2291 refactor and minor updates to lettings log csv service (#1719 ) * form handler to return all questions from lettings forms for all years with ordering interleaved functionality and tests * refactor lettings log csv service and all associated tests remove methods on log models when we can call them directly on associated models update job to call the service directly with the collection of logs rather minor modifications to the sales log csv service update many test files to test the appropriate logic in the appropriate place * tidying final amendments to tests remove commented code rename variable * change the position of the rent value check field in the headers * CLDC-2492 add creation method field to logs (#1738) * create migrations to add creation method fields to both log types * add enum definition to logs for creation method * upadte csv export services to retrieve creation method values direct from the log, remove methods previously used from the log model * run migrations to update schema * ensure that logs created via bulk upload have this set correctly when created	2 years ago
Arthur Campbell	40cf0c10c2	CLDC-1633 build feature csv download of sales logs (#1568 ) * create a method on the FormHandler that returns the sales form questions for all years in the order that they appear in the form * update csv email job to accomodate sales log export as well as lettings add to tests to reflec the changes made * write tests to cover the desired functionality of the SalesLogCsvService * create the SalesLogCsvService create a necessary method on the log to enable submission method to be included on the csv derive values for the two halves of previous postcode for export * add relevant links in the UI and pipe everything together in controllers amend organisations controller to have flexibility to download logs of either type add necessary methods to sales log controller, raising shared method to logs controller update routing for amendments and additions extract helper method to build urls for downloading logs within an organisation * correct various linter complaints and tech review suggestions * minor amendment to add old_id and reorder early columns * undo my 'clever' refactor that broke things * refactoring of csv service after some tech review and some UI testing in review app * update tests to include a test of a full export and all values in teh csv * correct minor routing error to ensure correct url is shown and tab selected after requesting csv email * update organisations controller requests spec file to cover new functionality and make a minor amendment to authentication scope in the controller after error found in testing * write request tests for the new functionality in the sales log controller, define authorisation in the controller * minor correction after rubocop's kind suggestion' * various corrections from first pass at PO, tech review, linter, etc * refactor :ordered_sales_questions_for_all_years * first pass at implementing flexible code-based form fixtures for testing * second pass * refactor all tests of :ordered_sales_questions_for_all_years to use new factories * some refactoring in the testing of the csv service * use that fact that params is always available in controllers and don't pass it around, inline some methods calls * correct minor bug to ensure that "Return to logs" link returns to the correct index page * remove reminder comments * write further tests on the manipulation of questions into the csv headers, update factories of form constituents to allow the creation of forms with richer questions * fix linter complaints * minor alterations after rebase to account for changes made on other branches * refactor after code review * tweak fixtures after rebase containing alterations to the factory defaults	2 years ago
Phil Lee	454df8389e	CLDC-2135 Bulk upload resume with how fix (#1503 ) * add first page for bulk upload resume journey * bulk upload resume handles upload again * add confirm page to bulk upload resume journey * replace placeholder count with correct value * apply recommendation for bulk upload resume choice * add how to fix bulk upload mailer * integrate new bulk upload approve journey * add missing bulk upload error mappings * remove test * prevent approve being called multiple times * bulk upload creates invisible logs ahead of time * work invisible logs into bulk upload flow * sort errors so deterministic * remove unused ensure * remove expected_log_count and processed - these fields are no longer used or needed * introduce pending status * swap visible for pending logs * only show visible lettings logs * hard code status filters * remove unused model methods * only show visible sales logs * form controller ignores hidden logs * locations and schemes only affect visible logs	2 years ago
natdeanlewissoftwire	f758d598c4	CLDC-1917 Add Startdate Validation (#1378 ) * feat: add validation with feature flag, typo fix and update tests * feat: flip feature toggle * feat: update feature toggle name * feat: fix form handler inequality * refactor: linting * refactor: use between in form handler * feat: remove feature toggle * feat: add dynamic date to lettings log factory * feat: fix log_summary_component_spec.rb tests * feat: update lettings_log.rb and start fixing lettings_log_spec.rb * feat: fix more tests * feat: fix more tests * feat: fix lettings log import service * refactor: linting * feat: fix checkboxes_spec.rb * feat: fix interruption_screen_helper_spec.rb * feat: fix check_answers_helper_spec.rb * feat: fix page_routing_spec.rb * feat: fix lettings_logs_field_import_service_spec.rb * feat: fix lettings_log_spec.rb * feat: fix question_spec.rb * feat: fix lettings_logs_controller_spec.rb * feat: fix check_answers_page_lettings_logs_spec.rb * feat: fix tenancy_validations_spec.rb * feat: fix validations_spec.rb * feat: fix accessible_autocomplete_spec.rb * feat: fix form_navigation_spec.rb * feat: fix soft_validations_spec.rb * feat: fix lettings_log_export_service_spec.rb * feat: fix saving_data_spec.rb * feat: fix page_spec.rb * feat: fix form_controller_spec.rb * refactor: linting * feat: fix subsection_spec.rb * feat: fix lettings_log_spec.rb * feat: fix financial_validations_spec.rb * feat: fix tasklist_page_spec.rb * feat: fix conditional_questions_spec.rb * feat: fix form_page_error_helper_spec.rb and log_summary_component_spec.rb * feat: fix lettings_log_csv_service_spec.rb * feat: fix tasklist_helper_spec.rb * refactor: linting * refactor: linting * feat: fix lettings_log_spec.rb * refactor: linting * refactor: replace financial year with collection yaer * feat: respond to PR comments pt. 1 * feat: respond to PR comments pt. 2	2 years ago
kosiakkatrina	297ba50e78	Validate the user belongs to either the managing or owning organisation (#1055 ) * Validate that the user belongs to either the managing or owning organisation * do not reset created_by and remove user_organisation_chosen? * Do not default managing organisation to owning organisation * validate user belongs to organisation * update tests to specify created_by * clear create_by for support users * refactor * typo * rebase lint * Add `updated_by` to logs to track who was the last person to update a log - Reset `created_by` automatically when a form is updated and the owner does not belong to the managing or owning organisation * move reset_invalidated_dependent_fields!, update schema file and fix tests Co-authored-by: James Rose <james@jbpr.net>	2 years ago
kosiakkatrina	409a24b333	Cldc 1609 schemes and location validations (#1022 ) * Add base errors for start date * Add validation to location * add validation to scheme id * update error messages * wip * return dates for errors * choose newest reactivation date * Add validation to scheme_id * Fix validations in tests * add diferent error message * fix some edge dates and add activating_soon schemes error * fix error message * move status_during_startdate into validations files * rebase * refactor * rename method * remove reverse and update ordering * Extract scheme validation method * Refactor validations * Refactor status validations	2 years ago
kosiakkatrina	f8f0624938	Cldc 1430 csv export (#888 ) * Remove an unused ethnic_other column * remove sale_completion_date from lettings logs * Add collection start year * Remove sale_or_letting column * Rename rent_type to rent_type_detail in the export * Format dates * refactor * Fix test	2 years ago
James Rose	d3075e4e43	Revert to `f4e6d6d6bb` (#887 )	2 years ago
natdeanlewissoftwire	f162f880ae	Revert "Merge remote-tracking branch 'origin/main' into CLDC-1429-output-la-code" This reverts commit `626e2bd1a6`, reversing changes made to `f86e13cea7`.	2 years ago
kosiakkatrina	ac4ee2a1fb	Cldc 1600 refactor form handler (#875 ) * Add previous, current and next forms to form handler * Add current, previous and next sales forms to form handler * Implement current_lettings_form, current_sales_form and store year and form type in form * refactor lettings_forms * Use current, previous and next forms in lettings log model * Use current, previous and next forms in sales log model * use current, previous and next forms in csv service * Remove "startyear_endyear" forms from form handler * Remove name from form initializer and add an optional start year * refactor get_form * update csv test, fix form initialize * rebase fix * Refactor form_name_from_start_year method out * remove unused variable * fix typo, add date tests * rebase, fix tests * add comment to before test block * Change the FormHandler back to only contain the form objects * extract name	2 years ago
James Rose	947b2287f6	Use correct mail method to deliver CSV email	2 years ago
Sam	a92fb1030c	CLDC-1362 Improve CSV download performance (#851 ) * Replaced log CSV direct download with email * Tidy up authorization of organisations controller - We already have a method to authenticate the scope of the user, so we can reuse that. * Use Rails routes instead of absolute paths for CSV download links * Introduce base NotifyMailer to to abstract away shared Notify mail functionality * Fix mailer spec name * Add worker instance to PaaS manifest * Add CSV download bucket instance name into environment * Update tests for improved search term handling * Fix download mailer tests * Clarifying comments Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com> Co-authored-by: James Rose <james@jbpr.net>	2 years ago

15 Commits (d2964d73db4f276f1db841a282ed3b0dfe34b225)