submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	20337fde59	Migration use kebab org fields (#1913 ) * feat: use kebab case org fields * feat: update tests	1 year ago
Arthur Campbell	5d80aad202	CLDC-2310 add creation method to both log import services, lettings log field import and create sales log field import (#1744 ) * some minor refactoring remove methods from child class that replicate methods on the parent class tidy up check for nil remove gubbins and inline method body given only used once * update import services for lettings and sales to import creation method write tests to cover this * create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported * update lettings log field import service and related spec to allow importing creation method of logs * use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process. various tests tweaked to suppor this change. rake task from another ticket folded into this ticket to prevent merge conflicts * rename method for ruby conventions * update PR for altered spec upload id now decided to be a better indicator of bulk upload status, import service amended accordingly tests updated in line with this * update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created * slight refactor to reduce nesting and dodge linter complaints * minor amendment to log creator spec in bulk upload to use enum dynamic methods	1 year ago
kosiakkatrina	c5dc8ebd12	Import support type as missing (#1561 ) * Import support type as missing * Set support_type to nil if it's not given * Fix casing	2 years ago
kosiakkatrina	b3cf6724f3	Add 23/24 fields to import mappings (#1560 ) * Import location fields for 2023/24 logs * Map 23/24 location fields for sales logs * Add remaining 23/24 import mappings * Remove redundant mappings * Add default mappings * Remove year check	2 years ago
Arthur Campbell	a08c9d6134	CLDC-2017-monthly-charges-validation (#1448 ) * add a validation against the case where monthly leashold charges are zero, test this, remove unnecessary validation on cash discount as this is covered by validate_numeric_min_max * remove focus: true from describe block * minor changes for testing and linting * correct minor bug found in PO * make minor amendments to failing tests	2 years ago
kosiakkatrina	931922b018	CLDC-1938 Set soft validations to confirmed (#1384 ) * Set soft validations to confirmed * Add remaining default soft validation values * Clears invalidated fields for in progress logs	2 years ago
kosiakkatrina	aab205624a	CLDC-1938 Fix location import (#1375 ) * Fix location import * Get postcode from full postcode field	2 years ago
kosiakkatrina	79f7b9473b	CLDC-1846 Derive hhmemb from hholdcount (#1369 ) * Derive household members from household count * Calculate hholdcount if not given and calculate hhmemb * Check if economic status is answered	2 years ago
kosiakkatrina	fb6d25b33c	CLDC-1938 Import relevant logs in sales and lettings log import (#1353 ) * Only process sales logs in sales import job * Only process lettings logs in lettings import job * Add sales log import task to the full import * change review app import bucket name * Update mortgageused and joinmore * Update jointmore and ownership scheme * Fix ownershipsch so that it doesn't override to nil * Set default relat2, update default household count * het ownership from type if not given * Improve logging * Remove mortgageused method * Look at Q16aProplensec2 column if Q16aProplen2 is empty * Set default income used and pregblank * Remove fields calculated internally * Comment out sales import from full import task * typo and change bucket name	2 years ago
kosiakkatrina	21341bdac1	Make privacy notice mandatory (#1351 )	2 years ago
kosiakkatrina	e0e09a22d2	CLDS-1938 Add sales logs importer (#1331 ) * Create test fixtures * Add old id column * Add sales logs importer * Save and update completed discounted ownership log without postcode * Update fixtures to be incomplete * Import a completed shared ownership example * Test with a non homebuy shared ownership example * Add privacynotice * Update hholdcount and confirmed fields * Add buyer stilll serving mapping * Add totadult/totchild and outright sale examples * Update log fixtures * Extract shared methods into logs import service and lint * Add sales logs import rake task * Update noint, xml examples and some mappings * Add tests for checking that all required questions are answered * Update tests, clean up import * Map mortgage lender and mortgage lender other * Infer Mscharge known as no for outright sale * refactor setting default values * when the armedforcesspouse is not answered set is as don't know * Refactor tests: change log id names * set savings to not known if not given * Refactor tests: change nesting * Backfill default household characteristics for completed log * Add more default mapping * Typo * Improve logging and refactor tests * Adjust test data to fit with the mappings that are known so far * Rename fixture files	2 years ago

11 Commits (d44f00c4efdfd4de43a2b4610a73a2cd53a0dde5)