submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	6c5391ad1c	Cldc 1065 soft validations (#434 ) * change get_question form method to prioritise the routed to questions * Add soft validation and interruption screen for basic rent * get previous page that was routed to and display the same error for both soft validations * Separate max and min error screens * add a test for getting the previous page * Update content and add more tests for previous page	3 years ago
baarkerlounger	910f13d507	Household member validations (#420 ) * Add missing ecstat validation * Add compound validation errors to all involved fields * Update ecstat values * Update values in validations and tests * Update rent rant values * Add some helper methods for readability	3 years ago
Dushan	484bb499e6	CLDC-788 interruption screen net income soft validation (#372 ) * Set up failing test for new soft validation design * remove unneeded js controller * remove unneeded controller and spec * rename net income validation override column * spec form changes (to allow tests to run) * validation spec changes * replace all instances of override_net_income_validatiom * passing first test * Add to form and import styling * remove unneeded code from interruption screen view * Update test & code - failing last new expectation * Display 2 previous question answers in the informative text * extract displaying of the informative text into a helper * Add tests for helper * Remove some of the previous soft validations set up * fix some failing specs * Fix more tests * lint * Reset earnings question prefix and suffix to initial values instead of nil * make it route backwards on a no * test and linter fixes * refactor next_page * stryling * more changes * fix specs * update real form * design tweaks * delete commented out tests * content changes * content changes * changes to informative/hint text * More robust styles for interuption panel, use smart quotes * Rubocop Co-authored-by: Kat <katrina@madetech.com> Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com> Co-authored-by: baarkerlounger <db@slothlife.xyz>	3 years ago
baarkerlounger	0f1f03aa8f	Refactor enums (#321 ) * Remove enums * Add some convenience methods to make validations more readable * Gender chars instead of ints * Remove incorrect API doc info for now * More convenience methods * Rename label from value method * Wrapper hbrentshortfall * Please the cop	3 years ago
baarkerlounger	49f27e6ccc	Ruby 3.1 syntax rubocop	3 years ago
Stéphane Meny	7a9ad40a43	CLDC-913: Export validation messages into i18n language file (#218 )	3 years ago
baarkerlounger	96d9e948a3	Move model modules to models (#137 )	3 years ago
baarkerlounger	8cac41c494	Net income range soft validation fix	3 years ago
Daniel Baark	dbef8dfba4	CLDC-642: Soft validation UI bug fix (#82 ) * Soft validation UI needs to be on both questions being validated * Fix whether the box is checked or not * All checkboxes are integers now * Fix * Use enums as well for consistency * Use capybara matcher for less flakiness * Click link already waits * Add a retry to our fetch so tests are more resilient to intermittent network issues	3 years ago
Daniel Baark	3a753364eb	Soft validations with controllers (#77 ) * Working except for selenium checkbox issues * Remove old debug message * Make sure we only run the stimulus init once per page load * Revert that * Rubocop * Use data targets rather than id lookup, so that coupling is explicit * Use fetch * Schema update * No schema changes introduced here * Add a request spec for the new controller * Schema order did change * map over forEach * Update factory fields * Int for booleans :( * Fix spec fields * Lazy create	3 years ago
kosiakkatrina	5ae2f120a8	Db migration (#79 ) * migration wip * change field names to lowercase and fix the tests * Change national and ethnic field types and map to correct enums * change ecstat column types * Change prevten field type * Change homeless field type * Change benefit cap field type * Put db enums in one folder and add a few new field changes" * change field type for housing needs * Change illness field type * display checkbox answers * cbl, chr, cap * Change tenancy and tenancylength field types * Change landlord and rsnvac field types * Change unittype_gn field type * Reasonble preference displaying on check answers * update more field types * Fix typo in comumn name * Change more types * Test fixes * Add adr * fix some tests * run migration * Fix tests Co-authored-by: Matthew Phelan <matthew.phelan@madetech.com>	3 years ago
Daniel Baark	81ff68bb11	CLDC-510: Income range soft validations (#72 ) * Init * Add some tests * Add failing spec * Move soft validations into a module * Update test * Rubocop * Scope are auto created by enums * Rename folder to validations * No instance variable * Commit both lines * Add error indication * Make partial slightly more generic * Fix back link * Write failing test * All specs currently passing. Can this be real? * Check page should have an override question * Fix back button for check answers pages * Don't really need a wrapper method for the validations * We're really validating a page here not a question * Dup variable * Bit of a nasty hack but maybe better than deriving back link? * Set a no cache header instead of reloading * Move a teeny bit of logic out of the controller * Rubocop * Extract method	3 years ago

7 Commits (d70e11d2df5038717a482a0e48bf025aec296efc)