submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	3b83614ab5	CLDC-2313 add bulk upload validation buyer 1 cannot be child (#1634 ) * add a bespoke validation to the row parser when buyer 1 is uploaded with working situation child, this should be validated with a custom message. a test for this case was also created * replicate the work from the last commit for the 2023 row parser and associated test file * lint correction remove blank lines	2 years ago
natdeanlewissoftwire	336d9ffe6f	CLDC-2357 Correct sales bulk upload UPRN errors (#1626 ) * feat: process postcode changes to clear la etc when uprn errors clear values * refactor: how_fix -> how_to_fix * feat: explicitly blank uprn * feat: add uprn to error mapping * refactor: typos * refactor: cleanup * feat: make postcode secretly optional, same as lettings * test: update * test: add main tests * feat: remove unneccessary assignement * feat: add fix choice error message to sales * feat: typo fix * refactor: lint	2 years ago
kosiakkatrina	0fea8585ec	CLDC-2354 Add soft validation messages to 23/24 sales (#1627 ) * Add soft validation messages to 23/24 sales * Refactor return and tests * More flaky tests	2 years ago
natdeanlewissoftwire	da00fa73f6	CLDC-2348 Purchaser code bug fix (#1638 ) * feat: assign purchaser_code for each year * refactor: lint * feat: add test that checks purchaser code assignment without explicitly calling a field	2 years ago
kosiakkatrina	ea59d036d2	CLDC-2347 Set monthly charges for bulk upload (#1629 ) * Infer has mscharge as no if it's 0 for 22/23 * Infer has mscharge as no if it's 0 for 23/24	2 years ago
Phil Lee	a50fff656c	CLDC-2277 Add missing bulk upload sales error mappings (#1623 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2277 - Issues with sales 2023 and UPRN + new fields # Changes - Add missing error mappings for sales 2023	2 years ago
kosiakkatrina	2ffa2d632b	Set proplen_asked based on proplen answer for 23/24 (#1630 )	2 years ago
kosiakkatrina	f32dfd6d2f	Set uprn confirmed (#1624 )	2 years ago
natdeanlewissoftwire	f662536c14	CLDC-2352 Infer uprn_known in 23/24 sales bulk upload (#1625 ) * feat: infer uprn_known * feat: add test * refactor: lint * feat: process postcode changes to clear la etc when uprn errors clear values * feat: revert previous (moved to CLDC-2357 instead) * feat: revert previous (moved to CLDC-2357 instead)	2 years ago
kosiakkatrina	353facc893	CLDC-2304 Deduplicate sales logs in bulk upload (#1612 ) * Deduplicate 2022 sales logs * Don't run deduplication on staging * Do not create duplicate logs * Add deduplication to the 23/24 sales	3 years ago
Phil Lee	d939e88435	CLDC-2316 Bulk upload sales 2023 (#1603 ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2316 - Implement bulk upload sales for new collection year 2023 - This is a first pass implementation and will probably have some bugs in it and we can address over time # Changes - Add CSV parser for sales 2023 to handle CSV structure - Tweak collection window validation so error now contextual to year selected for upload - Handle arbitrary ordering of CSV columns - Fix ordering of errors in report and now ordered by cell - Added `Upload your file again` link styled as button on error report to match lettings experience - Update tooling to convert logs to 2023 csv rows with support for random column ordering # Known issues - There seem to be some issues with how UPRN is handled if the UPRN cannot be validated. - For the above I think there is dependency on https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/pull/1570 which should clear any errored fields so users can continue to create logs and fix within the service	3 years ago

11 Commits (d7b15b20255043896ddadac804f4ad7a60d2006c)