Manny Dinssa
e2b18c77ce
Update setting errors
10 months ago
Manny Dinssa
a4fd73db20
Update method
10 months ago
Manny Dinssa
212a0bda0c
Add validation on reasonpref dontknow
10 months ago
Manny Dinssa
455afced6e
Fix copy multiple matches for for this address ( #2914 )
...
* Copy update
* Update copy
* Check address options returned is more than 1
* Update test
* Update and add test
* Update error messaging for single and multiple returns
* lint
* Fix lint
10 months ago
Manny Dinssa
02d1c664ef
Fix view bulk uploads and add another status label ( #2883 )
...
* Add another bulk upload status for invalid uploads
* Add test and update text
* update text missed
11 months ago
kosiakkatrina
3a4a8144d5
CLDC-3646 Do not update status for pending logs ( #2851 )
...
* Do not update status for pending logs
* Update some tests
* skip_update_status when unpending logs
1 year ago
kosiakkatrina
e7490f1381
CLDC-3779 Add duplicate logs email ( #2843 )
...
* Find block log creation reason
* Update mailer
* Remove create_logs? method
1 year ago
kosiakkatrina
9343d22768
CLDC-3335 Adjust BU errors for addresses ( #2829 )
...
* Adjust BU errors for addresses
* typo
* Update error messages
1 year ago
kosiakkatrina
5d36a13e7c
Ignore irrelevant empty headers ( #2800 )
1 year ago
kosiakkatrina
f77a986e13
Do not save bu log when setting creation method ( #2770 )
1 year ago
kosiakkatrina
dd9bc7b191
CLDC-3669 Extract bulk upload validations ( #2719 )
1 year ago
kosiakkatrina
1e968e50a6
CLDC-3694 Extract lettings BU validations
1 year ago
kosiakkatrina
64caf018e0
CLDC-2413 Allow 4 digit year format for bulk uploads ( #2715 )
...
* Allow 4 digit years for start date/sale date
* Update other dates
1 year ago
kosiakkatrina
443a19f42d
Update household validations ( #2708 )
1 year ago
Rachael Booth
2974bcddd7
CLDC-3330: Use partial postcodes in bulk upload ( #2692 )
...
* CLDC-3330: Use partial postcodes in bulk upload
* Adjust key address fields provided validations
* Use join to only insert space when both parts of postcode are provided
1 year ago
Manny Dinssa
b1ad8a1520
CLDC-3633++ Full stops in error messages & capitalisation within messages ( #2674 )
1 year ago
Rachael Booth
35100ab7fe
CLDC-3413: Make BU validate_nulls account for errors on before_log when choosing whether to add errors ( #2686 )
1 year ago
Manny Dinssa
ec55d405e1
CLDC-3618: Support user - View bulk uploads page ( #2666 )
1 year ago
kosiakkatrina
6cdf3bbf63
Correctly caption message to sentry ( #2679 )
1 year ago
Manny Dinssa
53c3b3e61a
CLDC-3633 Full stops in error messages ( #2628 )
...
* Make full stops consistent in error messages
* Fix test
* Update few hardcoded errors
* Update join in remaining row parsers
* Update some more tests
* Update more hard coded BU errors
* Fix typo I introduced - bedrooms to bedroom
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
1 year ago
kosiakkatrina
f99bd9756c
Capture failed bulk uploads ( #2667 )
...
* Capture failed bulk uploads
* Update capture exception to capture message
1 year ago
Manny Dinssa
d0ce0b87f2
CLDC 3623 Support user bulk uploading ( #2629 )
1 year ago
kosiakkatrina
c3bfadfe7f
Empty bulk upload row parsing ( #2638 )
...
* empty
* Add stripped_row back
* Skip empty rows
1 year ago
kosiakkatrina
c45cb160d2
Do not check duplicates on empty rows ( #2636 )
1 year ago
Manny Dinssa
331ee8f0e8
CLDC-3575: Remove reference to dluhc on GitHub ( #2581 )
...
* Update github README.md picture
* Change name
* Remove old image & change private to public beta text
1 year ago
Rachael Booth
85bbbe6108
CLDC-3556: Ignore address data in bulk upload for supported housing logs ( #2540 )
...
* Only set address data in BU for general needs logs
* Don't route to uprn selection page for supported housing logs
* Fix tests
1 year ago
Manny Dinssa
1da04df30f
CLDC-3411 correct 24 25 bulk upload error messages on lettings and sales ( #2556 )
...
* Update error messages and sales parser
1 year ago
Manny Dinssa
c3b85f2b50
CLDC-3411: Correct 24/25 bulk upload error messages on lettings and sales ( #2553 )
1 year ago
Rachael Booth
6a42978fab
CLDC-3546: Add error to managing org when it does not have relevant rent period ( #2538 )
...
* CLDC-3546: Add error to managing org when it does not have relevant rent period
* Add test for :skip_bu_error
* Fix managing org question id
1 year ago
kosiakkatrina
523f931770
Set the bulk upload value for correct log type ( #2533 )
1 year ago
kosiakkatrina
b9f900c98e
CLDC-3550 Fix rent_type 2024 BU mapping ( #2501 )
...
* Fix rent_type 2024 BU mapping
* Correct rent_type values
* Reuse rent_type mapping
* Track updated bulk uploads
* Fix test
1 year ago
kosiakkatrina
8dcd80e4f8
Strip scheme ID ( #2487 )
1 year ago
Rachael Booth
22522fb907
CLDC-3265: Duplicate whitespace row fix to sales BU ( #2481 )
...
* CLDC-3265: Duplicate whitespace row fix to sales BU
* CLDC-3265: Fix bu test that accidentally had whitespace only row
1 year ago
Rachael Booth
0718c10847
CLDC-3522: Correct logic around BU address search and address not found errors ( #2476 )
...
* CLDC-3522: Correct logic around BU address search and address not found errors
* Fix lint errors
1 year ago
Rachael Booth
4a5a912816
CLDC-3483: Prevent/fix missing letting allocation values ( #2453 )
...
* CLDC-3483: Enforce that all lettings allocation method fields are present for bulk uploads
* CLDC-3483: Add task to fix existing nil letting allocation values
* Better capitalisation
* Keep previous punctuation
* Use find_each for task
2 years ago
kosiakkatrina
9ed93efc58
CLDC-3474 Correctly construct dates for template validation ( #2447 )
...
* Correctly construct dates
* Update tests
2 years ago
Rachael Booth
4cfdd967dc
CLDC-3460: Don't validate P2 not child in BU when not a joint purchase ( #2431 )
...
* CLDC-3460: Don't validate P2 not child in BU when not a joint purchase
* Fix joint purchase field numbers for 2023
2 years ago
kosiakkatrina
ad488bb5ce
CLDC-3345 Add assigned_to to the exports ( #2391 )
...
* Empty
* CLDC-3345 Rename created_by to assigned_to (#2372 )
* Rename created_by to assigned_to
* Replace created_by with assigned_to
* Update created_by to assigned_to in exports, remove blank assigned to
* CLDC-3345 Add and set created_by fields (#2373 )
* Add created_by
* Update existing created_by values
* Set created_by on single log
* Set created_by on BU
* Add created_by to exports
* feat: update since last merge
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
* Fix papertrail create version
---------
Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
2 years ago
natdeanlewissoftwire
452066a37c
CLDC-2652 Use new env vars ( #2379 )
...
* feat: use new env var names
* feat: update names
* feat: update test
* feat: update test
2 years ago
kosiakkatrina
a0842064fb
Update privacy notice BU validation ( #2377 )
2 years ago
natdeanlewissoftwire
695f542fdc
CLDC-3327 Deduplicate null errors in bulk upload ( #2338 )
...
* feat: validate nulls last in bu
* feat: add tests
* feat: update org errors and tests
* feat: update test copy
* feat: update tests
* CLDC-3328 Make bulk upload errors consistent between lettings and sales (#2341 )
* feat: add validate_address_fields to lettings for 2024
* CLDC-3338: Add tolerance to discounted sale calculations (#2333 )
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
* C:DC-3338: Add tolerance to grant calculations
---------
Co-authored-by: Kat <katrina@kosiak.co.uk>
* feat: add validate_address_fields to lettings for 2024
* feat: update tests
* Revert "CLDC-3338: Add tolerance to discounted sale calculations (#2333 )"
This reverts commit cdecdfebfe .
---------
Co-authored-by: Robert Sullivan <Robert.Sullivan@Softwire.com>
Co-authored-by: Kat <katrina@kosiak.co.uk>
---------
Co-authored-by: Robert Sullivan <Robert.Sullivan@Softwire.com>
Co-authored-by: Kat <katrina@kosiak.co.uk>
2 years ago
natdeanlewissoftwire
9881fb990a
CLDC-3339 Improve select correct address bulk upload error ( #2331 )
...
* feat: add unable to find address errors when some options are returned if they are low confidence
* feat: update copy
* feat: add tests
2 years ago
kosiakkatrina
b9d93fe732
Revert all charges given validation ( #2308 )
2 years ago
natdeanlewissoftwire
24dfdbe5eb
CLDC-3271 Add address fields as entered in bulk upload to support csv downloads ( #2322 )
...
* feat: add bulk upload address info to lettings csv download
* feat: add bulk upload address info to sales csv download
* refactor: lint
* feat: fix typo
* feat: update tests
* feat: add to non question fields
* feat: update tests
* feat: add sales tests
* feat: add as entered fields to xml export for 2024 only (#2324 )
* feat: update schema
2 years ago
kosiakkatrina
999a33e0f7
CLDC-3313 Update financial sale validations ( #2313 )
...
* Rename method
* Update staircase/non staircase validations
* Add errors to type
* Remove validate_shared_ownership_deposit
* Don't add setup BU errors, deduplicate different sale type errors
* Add tolerance
* Reuse method
* Rename methods
* Skip type error completely in BU
* Update validation messages
* Update over tolerance method
2 years ago
kosiakkatrina
5907502f21
CLDC-3146 Update household validations ( #2256 )
...
* Separate the validations, remove irrelevant tests
* Remove relevant lettings 2023 validations from 24
* Update validations for 2024 lettings
* Separate sales validations
* Infer child uner 16 for sales
* Update sales validations
* Update tests
* Add validations to all relevant fields
* Add a 2023 context
* Undo some 2024 validations
* Remove another validation, update test names
* Remove child option hint
* Update person age hint
* Add ecstat buyer validation
* Add custom ecstat BU errors
* Skip working situation for child in sales
* Add child under 16 validation to 2024, do not reset ecstat
* Add soft validation columns
* Add partner under 16 soft validation
* Add multiple partners soft validations
* Remove child option for buyer 2
* Update CSVs
* Check hhmemb exists
* refactor
* Display child option for lettings
* Remove wrong tests
* More tests
2 years ago
Robert Sullivan
e2ed41c03a
CLDC-3318: Add maximum percentage discount validation for bulk uploads ( #2316 )
...
* CLDC-3318: Add maximum percentage discount validation for bulk uploads
* CLDC-2213: Review markups
2 years ago
kosiakkatrina
aca9eb6301
CLDC-3300 Update BU mortgageused error ( #2310 )
...
* Don't allow don't know as 2023 mortgageused
* Don't allow don't know as 2023 mortgageused for discounted ownership
* Allow mortgageused don't know if stairowned 100
* Update row parser test
* Move mortgageused validations onto the log model
* Allor outright sale mortgageused 3, don't allow non staircaseing shared ownership mortgageused 3
* Rebase fix
2 years ago
natdeanlewissoftwire
29980b1f7b
CLDC-3302 Make mortgageused bulk upload errors only display on relevant field ( #2311 )
...
* feat: only add mortgageuesd error to relevant mortgageused field
* feat: add test
* feat: test
* feat: test 2023
2 years ago
Rachael Booth
daa817c574
CLDC-3279: Ignore reasonother field in bulk upload if reason is not other ( #2291 )
2 years ago