submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Rachael Booth	ea73a730f4	CLDC-3224: Fix bulk upload noint bug (#2251 ) * Empty commit * CLDC-3224: Parse noint correctly in bulk upload row parsers * CLDC-3224: Add task to fix previous noint data * CLDC-3224: Remove nonsensical value for noint field in bu test * CLDC-3224: Move where bulk upload noint fix status is set to ensure it matches processing version * Put BU noint_fix_status setting before creating any logs	10 months ago
kosiakkatrina	7ccc0fabd3	CLDC-3191 Create sales BU for 24/25 (#2154 ) * Copy 23 BU files to 24 * Renumber bulk upload fields for 2024 * Add prepare your file * Update max columns * Update fields in first_record_start_date * Update managing org * Rebase changes	11 months ago
kosiakkatrina	52a0b27611	CLDC-2442 Remove 2022/23 BU code (#2153 ) * Remove 2022/23 BU code * Add empty lines to csvs * Update feature tests * More tests * Remove forms and update a test * rebase tests	11 months ago
Arthur Campbell	5d80aad202	CLDC-2310 add creation method to both log import services, lettings log field import and create sales log field import (#1744 ) * some minor refactoring remove methods from child class that replicate methods on the parent class tidy up check for nil remove gubbins and inline method body given only used once * update import services for lettings and sales to import creation method write tests to cover this * create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported * update lettings log field import service and related spec to allow importing creation method of logs * use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process. various tests tweaked to suppor this change. rake task from another ticket folded into this ticket to prevent merge conflicts * rename method for ruby conventions * update PR for altered spec upload id now decided to be a better indicator of bulk upload status, import service amended accordingly tests updated in line with this * update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created * slight refactor to reduce nesting and dodge linter complaints * minor amendment to log creator spec in bulk upload to use enum dynamic methods	1 year ago
Arthur Campbell	8c34719987	CLDC-2291 refactor and minor updates to lettings log csv service (#1719 ) * form handler to return all questions from lettings forms for all years with ordering interleaved functionality and tests * refactor lettings log csv service and all associated tests remove methods on log models when we can call them directly on associated models update job to call the service directly with the collection of logs rather minor modifications to the sales log csv service update many test files to test the appropriate logic in the appropriate place * tidying final amendments to tests remove commented code rename variable * change the position of the rent value check field in the headers * CLDC-2492 add creation method field to logs (#1738) * create migrations to add creation method fields to both log types * add enum definition to logs for creation method * upadte csv export services to retrieve creation method values direct from the log, remove methods previously used from the log model * run migrations to update schema * ensure that logs created via bulk upload have this set correctly when created	2 years ago
Phil Lee	c5842122d7	CLDC-2369 Spreadsheet dupe (#1663 ) * remove dead code * handle spreadsheet dupes in lettings * handle spreadsheet dupes in sales * update error message * use feature flag	2 years ago
kosiakkatrina	d1f21a5890	CLDC-2031 Sales bulk upload (#1574 ) * Add sales csv parser * Create log creator and update row parser for sales * Add validations * Add status_cache to sales logs * Parse completed log * Add basic validations to the row parser * Fix details known and proplen mapping * Add setup section errors * Update sales log validator * tests * Add sales resume and summary pages * send the correct emails	2 years ago
Phil Lee	454df8389e	CLDC-2135 Bulk upload resume with how fix (#1503 ) * add first page for bulk upload resume journey * bulk upload resume handles upload again * add confirm page to bulk upload resume journey * replace placeholder count with correct value * apply recommendation for bulk upload resume choice * add how to fix bulk upload mailer * integrate new bulk upload approve journey * add missing bulk upload error mappings * remove test * prevent approve being called multiple times * bulk upload creates invisible logs ahead of time * work invisible logs into bulk upload flow * sort errors so deterministic * remove unused ensure * remove expected_log_count and processed - these fields are no longer used or needed * introduce pending status * swap visible for pending logs * only show visible lettings logs * hard code status filters * remove unused model methods * only show visible sales logs * form controller ignores hidden logs * locations and schemes only affect visible logs	2 years ago
Phil Lee	35de06e324	CLDC-2067 Bulk upload for lettings 23/24 (#1417 ) * refactor questions from validator to row parser * able to switch between bulk upload parsers - depending on what year we are processing * spec tooling to support bulk upload multi year * row parser now has year in namespacing * add static data for 2023 row parser * add placeholder to log to csv for specs * bulk upload aribtrary 23/34 column ordering works * bulk upload supports 23/24 without headers * bulk upload 23/24 supports BOM + invalid chars * dupe tests * port 23/24 attributes_for_log * port 23/24 bulk upload validations * force crossover period * tweak max permitted columns * able to return column for given field * work out column for field for errors * add field_4 as 23/24 setup field * remove duplicate method * map schemes and locations correctly * handle arbitrary number of header rows * add missing fields to bulk upload support	2 years ago
Phil Lee	ca8b797012	bulk upload ignores blank rows in csv (#1295 )	2 years ago
Phil Lee	0009d535fe	CLDC-1896 Bulk upload line endings (#1208 ) * add class to create logs from bulk upload * create logs when processing bulk uploads * remove bulk_upload_id from csv output * create bulk upload logs only if all valid - this will be changed later to allow for partial logs - and only to create logs when a threshold has been met * add method to blank invalid non setup fields * bulk upload log creation blanks invalid fields * fix incorrect logic for bulk upload renewal * fix linting * bulk upload log creation fail logs to sentry * fix bulk upload line ending parsing * extract bulk uploading csv parsing to class * use csv parser in log creator * change handle line endings mechanism - we now strip all windows line endings for unix based line endings - this normalises things making it simpler	2 years ago

7 Commits (e52a8238cc41528219921fe94b2412745dcee047)