submit-social-housing-lettings-and-sales-data

3462 Commits

238 Branches

292 Tags

81 MiB

Tree: e5f0eb6d24

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
David May-Miller	44c9c563b2	CLDC-4074 Update tests now that 2023 is closed (#3093 ) * CLDC-4074 Updated sales log tests to use filters from the current year instead of a fixed one * CLDC-4074: Update other sales log tests to use the current year instead of a fixed one * CLDC-4074: Update more failing tests * CLDC-4074: Remove some 2024 sales log tests * CLDC-4074: Ignore a failing request test * CLDC-4074: Fix lettings log services tests * CLDC-4074: Fix merge request helper spec * CLDC-4074: Fix rake tests for 2024 logs * CLDC-4074: Fix guidance helper tests * CLDC-4074: Fix skipped tests * CLDC-4074: Update tests for 2023 edit closing (#3095) * CLDC-4074: Fix model tests * CLDC-4074: Fix requests tests * CLDC-4074: Fix services tests * CLDC-4074: Fix rake tasks tests the broken ones only make sense for 2024 logs so feels like timecop is the only option * CLDC-4074: Specify why some tests are not validated based on year --------- Co-authored-by: Samuel Young <samuel.young@softwire.com>	3 months ago
carolynbarker	b02bfcb7cd	CLDC-3939 update tests for new FY (#3010 ) * test tests in April * update tests where 2014 is assumed * update test where time moving is assumed * update rake task tests that only affect 2024 logs * update another 2024 assumption * handle null period in validation * give pages different ids in SharedOwnershipInitialPurchase and SharedOwnershipStaircasingTransaction sections * refactor to remove unnecessary method * delete some old rake tasks and tests * CLDC-3899 remove flaky date comparison from tests * CLDC-3899 fix flaky test occasionally picking bad input * fix test year setup * add relat mapping for log_to_csv * temp disable fail-fast for ease of testing * specify 2024 in 2024-specific test * Revert "temp disable fail-fast for ease of testing" This reverts commit `6993d29866`. * Revert "test tests in April" This reverts commit `f5635dba11`. * pass test in 2024 and 2025 * fix test to 2024 * temp disable fail-fast again * Revert "temp disable fail-fast again" This reverts commit `55d3e1c7d8`. --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com>	8 months ago
kosiakkatrina	459420d7ee	CLDC-3541 Update sales financial validations (#2546 ) * CLDC-3569 Update social homebuy errors (#2541) * Split questions * Update the error message * Add guidance * Add back the headers * Refactor depends_on * Refactor further * CLDC-3569 Update missed errors (#2548) * Update some skipped error messages * Remove repeating deposit question * CLDC-3571 Discounted ownership validation (#2547) * Rename discount to deposit discount * Split about price rtb questions * Update error message * Update guidance partial * Fix top_guidance_partial method * Split about_price_not_rtb * Update guidance partial and validation * Fix bulk upload test * Update deposit routed_to and guidance * Refactor guidance links into a helper (#2551) * Refactor guidance links into a helper * Refactor discounted ownership guidance * CLDC-3570 Validations all other shared ownership types (#2550) * Update "all other shared ownership" errors * CLDC-3571 Update outright sale financial validations (#2549) * Update outright sale validation message * Add outright sale guidance * Update duplicate page id * User guidance helper * Fix up financial equations content (#2552) * Tweak shared ownership validation wording * Add top_guidance_partial to missed shared ownership questions * Update discounted ownership validation message when there's no grant * Update discounted sale guidance and errors * Lint and update test * Update BU test * Update test * CLDC-3569 Update guidance for shared ownership without mortgage (#2562) * Update how we display errors for BU * Update guidance for shared ownership * Add header to mortgage used question * Update shared ownership guidance * Update spacing (#2569) * Fix spacing again (#2570) * Update discounted ownership guidance (#2582) * Update discounted ownership guidance * Add top guidance partial to outright sale * Update outright sale guidance content * Update model test --------- Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>	1 year ago

David May-Miller

44c9c563b2

CLDC-4074 Update tests now that 2023 is closed (#3093 )

* CLDC-4074 Updated sales log tests to use filters from the current year instead of a fixed one

* CLDC-4074: Update other sales log tests to use the current year instead of a fixed one

* CLDC-4074: Update more failing tests

* CLDC-4074: Remove some 2024 sales log tests

* CLDC-4074: Ignore a failing request test

* CLDC-4074: Fix lettings log services tests

* CLDC-4074: Fix merge request helper spec

* CLDC-4074: Fix rake tests for 2024 logs

* CLDC-4074: Fix guidance helper tests

* CLDC-4074: Fix skipped tests

* CLDC-4074: Update tests for 2023 edit closing (#3095)

* CLDC-4074: Fix model tests

* CLDC-4074: Fix requests tests

* CLDC-4074: Fix services tests

* CLDC-4074: Fix rake tasks tests

the broken ones only make sense for 2024 logs so feels like timecop is the only option

* CLDC-4074: Specify why some tests are not validated based on year

---------

Co-authored-by: Samuel Young <samuel.young@softwire.com>

3 months ago

carolynbarker

b02bfcb7cd

CLDC-3939 update tests for new FY (#3010 )

* test tests in April

* update tests where 2014 is assumed

* update test where time moving is assumed

* update rake task tests that only affect 2024 logs

* update another 2024 assumption

* handle null period in validation

* give pages different ids in SharedOwnershipInitialPurchase and  SharedOwnershipStaircasingTransaction sections

* refactor to remove unnecessary method

* delete some old rake tasks and tests

* CLDC-3899 remove flaky date comparison from tests

* CLDC-3899 fix flaky test occasionally picking bad input

* fix test year setup

* add relat mapping for log_to_csv

* temp disable fail-fast for ease of testing

* specify 2024 in 2024-specific test

* Revert "temp disable fail-fast for ease of testing"

This reverts commit 6993d29866.

* Revert "test tests in April"

This reverts commit f5635dba11.

* pass test in 2024 and 2025

* fix test to 2024

* temp disable fail-fast again

* Revert "temp disable fail-fast again"

This reverts commit 55d3e1c7d8.

---------

Co-authored-by: Carolyn <carolyn.barker@softwire.com>

8 months ago

kosiakkatrina

459420d7ee

CLDC-3541 Update sales financial validations (#2546 )

* CLDC-3569 Update social homebuy errors (#2541)

* Split questions

* Update the error message

* Add guidance

* Add back the headers

* Refactor depends_on

* Refactor further

* CLDC-3569 Update missed errors (#2548)

* Update some skipped error messages

* Remove repeating deposit question

* CLDC-3571 Discounted ownership validation (#2547)

* Rename discount to deposit discount

* Split about price rtb questions

* Update error message

* Update guidance partial

* Fix top_guidance_partial method

* Split about_price_not_rtb

* Update guidance partial and validation

* Fix bulk upload test

* Update deposit routed_to and guidance

* Refactor guidance links into a helper (#2551)

* Refactor guidance links into a helper

* Refactor discounted ownership guidance

* CLDC-3570 Validations all other shared ownership types (#2550)

* Update "all other shared ownership" errors

* CLDC-3571 Update outright sale financial validations (#2549)

* Update outright sale validation message

* Add outright sale guidance

* Update duplicate page id

* User guidance helper

* Fix up financial equations content (#2552)

* Tweak shared ownership validation wording

* Add top_guidance_partial to missed shared ownership questions

* Update discounted ownership validation message when there's no grant

* Update discounted sale guidance and errors

* Lint and update test

* Update BU test

* Update test

* CLDC-3569 Update guidance for shared ownership without mortgage (#2562)

* Update how we display errors for BU

* Update guidance for shared ownership

* Add header to mortgage used question

* Update shared ownership guidance

* Update spacing (#2569)

* Fix spacing again (#2570)

* Update discounted ownership guidance (#2582)

* Update discounted ownership guidance

* Add top guidance partial to outright sale

* Update outright sale guidance content

* Update model test

---------

Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>

1 year ago

3 Commits (e5f0eb6d24f121579ff26a522c1dd360bdfb7453)