submit-social-housing-lettings-and-sales-data

3627 Commits

268 Branches

306 Tags

85 MiB

Tree: e843e2587f

Commit Graph

Author	SHA1	Message	Date
Samuel Young	5dcb84966c	CLDC-4202: Update question numbers (#3169 ) * CLDC-4202: No longer assume question numbers for years the default logic is already a little confusing with the .max call, and we renumber most questions anyway between years to simply this logic and make it less surprising, specify each year all files should now specify 2023, 2024, 2025, 2026 * CLDC-4202: Account for removal of building type see CLDC-4136, Q20 has been removed. renumber every question above 20 to be one lower * CLDC-4202: Update household characteristics question nums done separate as these question numbers are calculated * CLDC-4202: Account for household characteristics renumbering increase all after Q72 (previously Q64) armedforces.rb by 8 * CLDC-4202: Account for new referral question * CLDC-4202: Update tests * fixup! CLDC-4202: No longer assume question numbers for years fix mistaken rent_type number * CLDC-4202: Extract person question count to the form definition * fixup! CLDC-4202: Extract person question count to the form definition syntax error * CLDC-4202: Extract hash logic to a common function * CLDC-4202: Add a rake to populate new question numbers we can run this rake to automatically add all the question numbers at the start of a new year, which should simplify the process a lot * fixup! CLDC-4202: Add a rake to populate new question numbers lint * fixup! CLDC-4202: Extract person question count to the form definition update tests * fixup! CLDC-4202: Extract person question count to the form definition lint * fixup! CLDC-4202: Extract person question count to the form definition also update age_known * CLDC-4141: copy person questions refactor from CLDC-4142 * CLDC-4141: remove gender same as sex and replace gender identity q * CLDC-4202: Use form person question count on sexrab * CLDC-4202: Remove new question numbers from questions we don't ask anymore * CLDC-4141: replace sex with sexrab where relevant for 2026 * fixup! CLDC-4202: Use form person question count on sexrab update test * fixup! CLDC-4202: Use form person question count on sexrab page test too * CLDC-4141: update download order * CLDC-4140: remove sex from rowparser entirely * CLDC-4140: keep sex in factory for now * CLDC-4140: update household characteristics test * CLDC-4140: update log variable spec * CLDC-4202: Use relevant person_question_count in tests * CLDC-4140: update csv export tests * CLDC-4140: update validator tests * CLDC-4140: update row-parser spec * CLDC-4140: update csv-parser spec * CLDC-4140: update export spec * CLDC-4140: update log var defs spec * CLDC-4140: update export spec * CLDC-4140: update row parser spec * CLDC-4140: update validator spec * CLDC-4140: update csv parser spec * CLDC-4143: Update gender retirement validations rename functions as the new wording is more related to those that identify as male and any other option * CLDC-4143: Add 2026 tests * CLDC-4143: Update legacy json files causes issues with some old tests * CLDC-4143: Add error mappings for gender fields * CLDC-4143: Add new gender age retirement soft validation replaces the many check pages from previous years with a single one shows if either of the previous ones would show has agreed wording on ticket * fixup! CLDC-4143: Update gender retirement validations improve gender comment wording * CLDC-4143: Update non males validation name reference to 'soft validation' we found confusing * fixup! CLDC-4143: Add new gender age retirement soft validation update subsection specs * CLDC-4140: update parsers post merge * CLDC-4140: update tests after field renumbering * CLDC-4140: update tests after field renumbering * CLDC-4140: update spacing in to_2026_row * CLDC-4140: update row parser spec field numbers * CLDC-4140: update row parser field types --------- Co-authored-by: Nat Dean-Lewis <nat.dean-lewis@softwire.com>	2 months ago

Author

SHA1

Message

Date

Samuel Young

5dcb84966c

CLDC-4202: Update question numbers (#3169 )

* CLDC-4202: No longer assume question numbers for years

the default logic is already a little confusing with the .max call, and we renumber most questions anyway between years

to simply this logic and make it less surprising, specify each year

all files should now specify 2023, 2024, 2025, 2026

* CLDC-4202: Account for removal of building type

see CLDC-4136, Q20 has been removed. renumber every question above 20 to be one lower

* CLDC-4202: Update household characteristics question nums

done separate as these question numbers are calculated

* CLDC-4202: Account for household characteristics renumbering

increase all after Q72 (previously Q64) armedforces.rb by 8

* CLDC-4202: Account for new referral question

* CLDC-4202: Update tests

* fixup! CLDC-4202: No longer assume question numbers for years

fix mistaken rent_type number

* CLDC-4202: Extract person question count to the form definition

* fixup! CLDC-4202: Extract person question count to the form definition

syntax error

* CLDC-4202: Extract hash logic to a common function

* CLDC-4202: Add a rake to populate new question numbers

we can run this rake to automatically add all the question numbers at the start of a new year, which should simplify the process a lot

* fixup! CLDC-4202: Add a rake to populate new question numbers

lint

* fixup! CLDC-4202: Extract person question count to the form definition

update tests

* fixup! CLDC-4202: Extract person question count to the form definition

lint

* fixup! CLDC-4202: Extract person question count to the form definition

also update age_known

* CLDC-4141: copy person questions refactor from CLDC-4142

* CLDC-4141: remove gender same as sex and replace gender identity q

* CLDC-4202: Use form person question count on sexrab

* CLDC-4202: Remove new question numbers from questions we don't ask anymore

* CLDC-4141: replace sex with sexrab where relevant for 2026

* fixup! CLDC-4202: Use form person question count on sexrab

update test

* fixup! CLDC-4202: Use form person question count on sexrab

page test too

* CLDC-4141: update download order

* CLDC-4140: remove sex from rowparser entirely

* CLDC-4140: keep sex in factory for now

* CLDC-4140: update household characteristics test

* CLDC-4140: update log variable spec

* CLDC-4202: Use relevant person_question_count in tests

* CLDC-4140: update csv export tests

* CLDC-4140: update validator tests

* CLDC-4140: update row-parser spec

* CLDC-4140: update csv-parser spec

* CLDC-4140: update export spec

* CLDC-4140: update log var defs spec

* CLDC-4140: update export spec

* CLDC-4140: update row parser spec

* CLDC-4140: update validator spec

* CLDC-4140: update csv parser spec

* CLDC-4143: Update gender retirement validations

rename functions as the new wording is more related to those that identify as male and any other option

* CLDC-4143: Add 2026 tests

* CLDC-4143: Update legacy json files

causes issues with some old tests

* CLDC-4143: Add error mappings for gender fields

* CLDC-4143: Add new gender age retirement soft validation

replaces the many check pages from previous years with a single one

shows if either of the previous ones would show

has agreed wording on ticket

* fixup! CLDC-4143: Update gender retirement validations

improve gender comment wording

* CLDC-4143: Update non males validation name

reference to 'soft validation' we found confusing

* fixup! CLDC-4143: Add new gender age retirement soft validation

update subsection specs

* CLDC-4140: update parsers post merge

* CLDC-4140: update tests after field renumbering

* CLDC-4140: update tests after field renumbering

* CLDC-4140: update spacing in to_2026_row

* CLDC-4140: update row parser spec field numbers

* CLDC-4140: update row parser field types

---------

Co-authored-by: Nat Dean-Lewis <nat.dean-lewis@softwire.com>

2 months ago

1 Commits (e843e2587f8c551484397c4e8e96f5da41efa5f3)