ec02c411a0
Skip bu error on setup question type for equity calculations
8 months ago
2f88fa5777
Lint
8 months ago
9e8e34e93a
Skip bu error on the setup question type
8 months ago
72a94810eb
CLDC-3843: Lettings household situation change Q84 question format ( #2958 )
...
* Rename old renewal prp page and question
* Update subsection
* Add referral_type to lettings logs
* Add two-step source of referral for letting questions
* Update test
* Update validations
* Update tests with referral_type
* Fix test
* Update test
* Update referral type
* Update factory bot
* Remove hint text
* Change check answer label
* Update incorrect value
* Rename old referral pages and questions
* Update referral type options
* Remove clearing
* Update id name
* Update row parser for referral type
* Update test
8 months ago
5ae962696f
CLDC-3855 Check date input format ( #2918 )
...
* Check date input format
* Update feature test
* Check if the date is valid before running location validations
9 months ago
e3a3c2ebb0
CLDC-3820: Ensure la/prevloc/layear validation is triggered on fields which cause la to be inferred ( #2884 )
10 months ago
19c5deb1d3
CLDC-3817 Only run net income validations when applicable_income_range exists ( #2882 )
...
* Only run net income validations when applicable_income_range exists
* Check that income ranges exist
10 months ago
ddebebee30
Remove irrelevant 2023 checks ( #2895 )
...
* Remove irrelevant 2023 checks
* Update/remove tests
10 months ago
7455440e01
CLDC-3822 Update date validations for 2025 ( #2886 )
...
* Update date validations for 2025
* Refactor date validations, account for leap years
10 months ago
80f126c49b
CLDC-3837: Fix bug with step validation for numeric fields with step 0.1 ( #2893 )
...
* CLDC-3837: Fix bug with step validation for numeric fields with step 0.1
* Refactor tests
* Fix test
10 months ago
cabd650dd6
CLDC-3833: Update validation on total discount for percentage discounts to include an extra 1000 leeway for rounding errors ( #2889 )
10 months ago
54912a066c
CLDC-3744 Validate correct benefits value in the validation ( #2769 )
...
* Check correct benefits value in the validation
* Update some tests
* Update validation
* clear invalid benefits
* Update more tests
* Fix world
* Clear the benefits
* Move benefits assign
11 months ago
456d1e6586
Do not run pregnancy validations if hhmemb is over 8 ( #2869 )
11 months ago
1c03a70fa2
CLDC-3769 Fix some check errors flows ( #2826 )
...
* Fix some check errors flows
* Only show check errors journey for question on different pages
* Update restore_error_field_values
11 months ago
f5e6529baa
CLDC-3314: Skip BU error for ownershipsch in validate_discounted_ownership_value ( #2837 )
11 months ago
128ac5d57a
CLDC-3758: Sales - Add shared ownership staircasing transaction section ( #2788 )
...
* db migration, new sales log fields
* Add new staircasing transaction section
* Update tests
* Lint
* Add tests
* Use log methods
* Lint
* Update test
* Remove compact
* Change section display condition
* CLDC-3760: Sales - firststair and numstair staircasing questions validations (#2793 )
* Add validation to new questions firststair and numstair
* Remove page headers on single question page
* Remove page
* More useful page header
* Show don't know option from 2025 onwards
* Add page header to monthly rent only for the version with two questions on the page
* Remove page header staircase initial date only page
* Update displayed answer options
* Fix lint
* Updates after merge
* Update test
* Update tests
11 months ago
b3dca51216
CLDC-3753: Update soft income validations ( #2779 )
...
* CLDC-3753: Update soft income validations
* Update tests
* Fix linting
* Include reference to informative text translations copy
* Combine min and max checks for income based on ecstat
* Fixes
* Update tests
11 months ago
671232daa9
CLDC-3734 Add LA in England validation for 2025 ( #2763 )
...
* Add LA in England validation for 2025
* Validate supported housing logs
* Add error message to the date
* Update error messages
* lint
* Fix error messages for date
* Update no address found soft validation
* Update validation messages
12 months ago
bc1fe83750
CLDC-3757: Sales - Change values in validation check for Q84 (25/26) ( #2781 )
...
* Update 2025 version of validation check
* Update validation for 2025
* Put two if statements into one
* Different approach to comparing dates
* Alternative method to compare dates
* Update tests
12 months ago
a3ce7e9f95
Update validation message ( #2783 )
12 months ago
de1d28c27e
Increase soft max for old persons shared ownership savings ( #2778 )
12 months ago
16393cf4ab
Trigger income error on uprn_selection ( #2771 )
12 months ago
0083485b42
CLDC-3690 Extract lettings property validations copy ( #2742 )
...
* Extract lettings property validations copy
* Update uprn question
* Remove redundant validations (can't trigger them because on inferrance)
12 months ago
0b4ff65429
CLDC-3689: Extract lettings household validations ( #2741 )
...
* Extract household validations
* Use question ids a primary key
* Fix lint
* Refactor, remove one level of keys
* Fix merge
12 months ago
2b629891fb
CLDC-3666: Pull sales financial validations into translations file ( #2716 )
12 months ago
afc7cf86b4
Exctract financial validations ( #2740 )
12 months ago
61eb0057f6
CLDC-3693: Extract shared validations ( #2744 )
...
* Extract lettings household validation from shared validations
* Extract lettings setup validation from shared validations
* Extract only shared validations
12 months ago
6fb29ade6b
CLDC-3712: Sales Form Updates ( #2756 )
1 year ago
83e3ddccdd
CLDC-3692: Extract lettings tenancy validations ( #2743 )
...
* Extract lettings tenancy validations
1 year ago
576d0900fa
CLDC-3691: Extract copy - lettings setup validations ( #2739 )
1 year ago
7f016f898f
CLDC-3687: Extract copy - lettings date validations ( #2738 )
1 year ago
3424cbc550
CLDC-3366: Use single page for rent soft validation ( #2724 )
...
* CLDC-3366: Use single page for rent soft validation
* Fix tests
1 year ago
9763013ac1
Extract sale information validations into a separate translations file ( #2699 )
1 year ago
469211ce65
CLDC-3661 Update year format ( #2713 )
...
* Update year combo format
* lint
* Update tests and validations
* update model tests
* Update bu list year format
* Update test
1 year ago
9bd3389c84
CLDC-3655 Extract property information validations ( #2700 )
...
* Extract property information validations
* Refactor possesive variable from errors
1 year ago
443a19f42d
Update household validations ( #2708 )
1 year ago
29a5889aa6
CLDC-3653 Copy changes - sales setup validations ( #2677 )
...
* Extract sales setup validations to translation file
1 year ago
54d15d95ef
CLDC-3420 Check tshortfall for care homes ( #2659 )
...
* Check tshortfall for care homes
* Fix BU tests
1 year ago
d5f2424247
CLDC-3576 Update soft pregnancy validation ( #2640 )
...
* Update soft pregnancy validation
* Fix tests
1 year ago
27188ad3a2
CLDC-3001 Handle locations and logs on deactivate schemes ( #2605 )
1 year ago
9b5110c175
Don't add error message to type twice ( #2626 )
1 year ago
4690fb446e
CLDC-3595 Remove duplicate errors for check errors page ( #2560 )
...
* Remove duplicate errors for check errors page
* Remove unused line
* Format some missed errors correctly
1 year ago
eb355d6829
Update equity validation for resale ( #2559 )
1 year ago
459420d7ee
CLDC-3541 Update sales financial validations ( #2546 )
...
* CLDC-3569 Update social homebuy errors (#2541 )
* Split questions
* Update the error message
* Add guidance
* Add back the headers
* Refactor depends_on
* Refactor further
* CLDC-3569 Update missed errors (#2548 )
* Update some skipped error messages
* Remove repeating deposit question
* CLDC-3571 Discounted ownership validation (#2547 )
* Rename discount to deposit discount
* Split about price rtb questions
* Update error message
* Update guidance partial
* Fix top_guidance_partial method
* Split about_price_not_rtb
* Update guidance partial and validation
* Fix bulk upload test
* Update deposit routed_to and guidance
* Refactor guidance links into a helper (#2551 )
* Refactor guidance links into a helper
* Refactor discounted ownership guidance
* CLDC-3570 Validations all other shared ownership types (#2550 )
* Update "all other shared ownership" errors
* CLDC-3571 Update outright sale financial validations (#2549 )
* Update outright sale validation message
* Add outright sale guidance
* Update duplicate page id
* User guidance helper
* Fix up financial equations content (#2552 )
* Tweak shared ownership validation wording
* Add top_guidance_partial to missed shared ownership questions
* Update discounted ownership validation message when there's no grant
* Update discounted sale guidance and errors
* Lint and update test
* Update BU test
* Update test
* CLDC-3569 Update guidance for shared ownership without mortgage (#2562 )
* Update how we display errors for BU
* Update guidance for shared ownership
* Add header to mortgage used question
* Update shared ownership guidance
* Update spacing (#2569 )
* Fix spacing again (#2570 )
* Update discounted ownership guidance (#2582 )
* Update discounted ownership guidance
* Add top guidance partial to outright sale
* Update outright sale guidance content
* Update model test
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
1 year ago
6a42978fab
CLDC-3546: Add error to managing org when it does not have relevant rent period ( #2538 )
...
* CLDC-3546: Add error to managing org when it does not have relevant rent period
* Add test for :skip_bu_error
* Fix managing org question id
1 year ago
9b0cbac406
CLDC 2954 handle schemes with only deactivated locations ( #2510 )
1 year ago
975f072d2f
CLDC-3547: Validate against incomplete schemes being used in logs ( #2498 )
...
* CLDC-3547: Validate against incomplete schemes being used in logs
* Fix ordering issue in tests
1 year ago
201ce23906
CLDC-1718 Update numeric questions to text fields ( #2527 )
...
* Update numeric questions to text fields
* Add test case
1 year ago
e566ff09a0
refactor property validations specs to avoid breaking on collection year change ( #2478 )
1 year ago
5696e4b81e
Cldc 3452 remove dont know option from mortgage used when invalid ( #2470 )
...
* initial spec file refactor
remove create for build, extract form to own variable, remove non-valuable tests
run time from 0.29s to0.11s
* refactor to ensure that the questions ownershipsch instance variable and the value of ownershipsch on the log is the same in tests
* delete page test file which is not testing anything meaningful
* add error messages to the I18n yml
* update tests for the validations
* update validation logic
* update tests for the mortgage used question
* update the mortgage used question displayed answer options
* update bulk upload specs to reflect error message updates
* make use of brackets consistent within validation method
1 year ago
Manny Dinssa
kosiakkatrina
Rachael Booth
Arthur Campbell