submit-social-housing-lettings-and-sales-data

3528 Commits

272 Branches

306 Tags

85 MiB

Tree: eda0b93060

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	87793f24bd	Cldc 1671 deactivate scheme (#980 ) * feat: wip update scheme summary page * feat: wip deactivate scheme schemes page * feat: wip toggle active page * feat: wip set deactivation_date to a datetime (to be more specific times later_ * Change conditional question controller to accommodate all models * feat: add specific datetimes for deactivation * feat: correct date and add notice * feat: wip error behaviour * feat: wip errors * feat: wip errors refactoring * feat: wip errors more refactoring * refactor: linting * feat: add second error in correct position and wip date range error * feat: remove unneccessary db field * feat: change type values to strings * refactor: tidy up controller logic * refactor: use same structure as locations deactivation * feat: add general partially missing date input error * feat: add tests ("updates existing scheme with valid deactivation date and renders scheme page" still wip) and add new partially nil date behaviour to locations controller * feat: fix tests, add status tag behaviour and remove unnecessary nils * refactor: linting * refactor: erblinting * refactor: remove redundant line * refactor: respond to PR comments 1 * refactor: respond to PR comments 2 * refactor: respond to PR comments 3 * refactor: respond to PR comments 3 (locations side) * fix: remove @locations in location model * fix: remove @locations in location model * fix: update status names * feat: wip validation update * feat: add validation to model layer * feat: further separate scheme deactivation behaviour * test: update tests to new flow * feat: respond to pr comments and add dynamic success text * feat: duplicate behaviour schemes -> locations (+ tests) * refactor: linting * refactor: typo and remove unnecessary line for this PR * refactor: feature toggle simplification * Refactor locations and schemes controller actions - Rename confirmation partials to `deactivate_confirm.html.erb` so that they match the actions in which they belong to - Make all deactivation date comparision UTC time * feat: update deactivation_date validation and add tests * refactor: linting Co-authored-by: Kat <katrina@kosiak.co.uk> Co-authored-by: James Rose <james@jbpr.net>	4 years ago

Author

SHA1

Message

Date

natdeanlewissoftwire

87793f24bd

Cldc 1671 deactivate scheme (#980 )

* feat: wip update scheme summary page

* feat: wip deactivate scheme schemes page

* feat: wip toggle active page

* feat: wip set deactivation_date to a datetime (to be more specific times later_

* Change conditional question controller to accommodate all models

* feat: add specific datetimes for deactivation

* feat: correct date and add notice

* feat: wip error behaviour

* feat: wip errors

* feat: wip errors refactoring

* feat: wip errors more refactoring

* refactor: linting

* feat: add second error in correct position and wip date range error

* feat: remove unneccessary db field

* feat: change type values to strings

* refactor: tidy up controller logic

* refactor: use same structure as locations deactivation

* feat: add general partially missing date input error

* feat: add tests ("updates existing scheme with valid deactivation date and renders scheme page" still wip) and add new partially nil date behaviour to locations controller

* feat: fix tests, add status tag behaviour and remove unnecessary nils

* refactor: linting

* refactor: erblinting

* refactor: remove redundant line

* refactor: respond to PR comments 1

* refactor: respond to PR comments 2

* refactor: respond to PR comments 3

* refactor: respond to PR comments 3 (locations side)

* fix: remove @locations in location model

* fix: remove @locations in location model

* fix: update status names

* feat: wip validation update

* feat: add validation to model layer

* feat: further separate scheme deactivation behaviour

* test: update tests to new flow

* feat: respond to pr comments and add dynamic success text

* feat: duplicate behaviour schemes -> locations (+ tests)

* refactor: linting

* refactor: typo and remove unnecessary line for this PR

* refactor: feature toggle simplification

* Refactor locations and schemes controller actions

- Rename confirmation partials to `deactivate_confirm.html.erb` so that they match the actions in which they belong to
- Make all deactivation date comparision UTC time

* feat: update deactivation_date validation and add tests

* refactor: linting

Co-authored-by: Kat <katrina@kosiak.co.uk>
Co-authored-by: James Rose <james@jbpr.net>

4 years ago

1 Commits (eda0b9306020305a6b538177d84bd6b4ce9b3150)