submit-social-housing-lettings-and-sales-data

3649 Commits

271 Branches

306 Tags

85 MiB

Tree: ee1237cdc3

Commit Graph

Author	SHA1	Message	Date
Carolyn Barker	de4e0945a1	CLDC-4146 infer no other partners (#3152 ) * CLDC-4146 infer no to multiple partners * CLDC-4146 try removing factory change * Simplify inference logic * Fix not equals logic * Improve person_partner tests * Add tests for new not equals logic * Improve person_lead_partner tests * Fix inference logic * Revert to simpler inference logic * Correct hidden_in_check_answers logic * Fixed derived? * Improve lettings log variables tests * Pull out resetting partner fields into method * Convert 'else next' to guard clause * Refactor infer_only_partner! * Match updated requirements * Fix tests * Small tweaks * Remove redundant logic from infer_at_most_one_relationship! * Remove redundant `disable_clearing_if_not_routed_or_dynamic_answer_options` * Add tests for question number * Remove puts * Refactor derived fields tests * Fix lint * After build, set nil values for `details_known` to 0 * Add details_known to tests * Add question mark to method name * Rewrite `is_another_person_partner?` to be `is_any_person_partner?` * Move skip in form flow method from page to question * Fix tests * Fix tests after merge --------- Co-authored-by: Carolyn <carolyn.barker@softwire.com> Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com>	2 months ago
Samuel Young	fe65438a2a	CLDC-4145: Don't ask partner for children (#3141 ) * CLDC-4145: Derive is partner for under 16s in contrast, clear is partner if the age goes >=16 so the user must answer the question again * CLDC-4145: Remove under 16 soft validation for 2026 it will no longer be shown as we infer the answer * fixup! CLDC-4145: Derive is partner for under 16s * fixup! CLDC-4145: Remove under 16 soft validation for 2026 the check is added twice before two diff questions * CLDC-4145: Update tests * fixup! CLDC-4145: Derive is partner for under 16s lint * fixup! CLDC-4145: Update tests lint * fixup! CLDC-4145: Derive is partner for under 16s check if the was was null rather than current. avoids potential bugs on first assign * fixup! CLDC-4145: Update tests some more tests added / updated * fixup! CLDC-4145: Update tests turns out editing the future form use is not possible for tests, too many depend on it failing use timecop instead * fixup! CLDC-4145: Update tests fix lettings log export * fixup! CLDC-4145: Update tests add 2024 derived variable tests * fixup! CLDC-4145: Update tests lint * CLDC-4145: Add a depends_on to ensure partner is hidden * fixup! CLDC-4145: Add a depends_on to ensure partner is hidden remove unnecessary depends_on make test ranges clearer	4 months ago
kosiakkatrina	b1a384e454	Update person relationship questions (#2892 )	1 year ago

Author

SHA1

Message

Date

Carolyn Barker

de4e0945a1

CLDC-4146 infer no other partners (#3152 )

* CLDC-4146 infer no to multiple partners

* CLDC-4146 try removing factory change

* Simplify inference logic

* Fix not equals logic

* Improve person_partner tests

* Add tests for new not equals logic

* Improve person_lead_partner tests

* Fix inference logic

* Revert to simpler inference logic

* Correct hidden_in_check_answers logic

* Fixed derived?

* Improve lettings log variables tests

* Pull out resetting partner fields into method

* Convert 'else next' to guard clause

* Refactor infer_only_partner!

* Match updated requirements

* Fix tests

* Small tweaks

* Remove redundant logic from infer_at_most_one_relationship!

* Remove redundant `disable_clearing_if_not_routed_or_dynamic_answer_options`

* Add tests for question number

* Remove puts

* Refactor derived fields tests

* Fix lint

* After build, set nil values for `details_known` to 0

* Add details_known to tests

* Add question mark to method name

* Rewrite `is_another_person_partner?` to be `is_any_person_partner?`

* Move skip in form flow method from page to question

* Fix tests

* Fix tests after merge

---------

Co-authored-by: Carolyn <carolyn.barker@softwire.com>
Co-authored-by: oscar-richardson-softwire <oscar.richardson@softwire.com>

2 months ago

Samuel Young

fe65438a2a

CLDC-4145: Don't ask partner for children (#3141 )

* CLDC-4145: Derive is partner for under 16s

in contrast, clear is partner if the age goes >=16 so the user must answer the question again

* CLDC-4145: Remove under 16 soft validation for 2026

it will no longer be shown as we infer the answer

* fixup! CLDC-4145: Derive is partner for under 16s

* fixup! CLDC-4145: Remove under 16 soft validation for 2026

the check is added twice before two diff questions

* CLDC-4145: Update tests

* fixup! CLDC-4145: Derive is partner for under 16s

lint

* fixup! CLDC-4145: Update tests

lint

* fixup! CLDC-4145: Derive is partner for under 16s

check if the was was null rather than current. avoids potential bugs on first assign

* fixup! CLDC-4145: Update tests

some more tests added / updated

* fixup! CLDC-4145: Update tests

turns out editing the future form use is not possible for tests, too many depend on it failing

use timecop instead

* fixup! CLDC-4145: Update tests

fix lettings log export

* fixup! CLDC-4145: Update tests

add 2024 derived variable tests

* fixup! CLDC-4145: Update tests

lint

* CLDC-4145: Add a depends_on to ensure partner is hidden

* fixup! CLDC-4145: Add a depends_on to ensure partner is hidden

remove unnecessary depends_on

make test ranges clearer

4 months ago

kosiakkatrina

b1a384e454

Update person relationship questions (#2892 )

1 year ago

3 Commits (ee1237cdc3bc16b775a2c13e2c8205c5b2f9a54b)