submit-social-housing-lettings-and-sales-data

3369 Commits

231 Branches

276 Tags

77 MiB

Commit Graph

Author	SHA1	Message	Date
natdeanlewissoftwire	b0271ea0ec	CLDC-2257 Refactor filters (#1675 An error occurred ) * feat: split lettings and sales filters * feat: remove logs filter * refactor: type -> filter_type * refactor: slight cleanup * feat: update csv download * feat: set org filters to mirror primary sales and lettings * refactor: linting * feat: fix filter types in org controller - can be changed to org specific labels in future if needed rather than copying filters from primary sales/lettings tabs * refactor: initalize filter_type * refactor: lint * refactor: combine filter_manager into filter_service * refactor: rename to filter manager * refactor: DRY session name filter logic * feat: share session filter name logic * feat: further refactor * refactor: simplify * feat: revert change to filter manager	2 years ago
Phil Lee	d939e88435	CLDC-2316 Bulk upload sales 2023 (#1603 An error occurred ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2316 - Implement bulk upload sales for new collection year 2023 - This is a first pass implementation and will probably have some bugs in it and we can address over time # Changes - Add CSV parser for sales 2023 to handle CSV structure - Tweak collection window validation so error now contextual to year selected for upload - Handle arbitrary ordering of CSV columns - Fix ordering of errors in report and now ordered by cell - Added `Upload your file again` link styled as button on error report to match lettings experience - Update tooling to convert logs to 2023 csv rows with support for random column ordering # Known issues - There seem to be some issues with how UPRN is handled if the UPRN cannot be validated. - For the above I think there is dependency on https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/pull/1570 which should clear any errored fields so users can continue to create logs and fix within the service	2 years ago

Author

SHA1

Message

Date

natdeanlewissoftwire

b0271ea0ec

CLDC-2257 Refactor filters (#1675)

* feat: split lettings and sales filters

* feat: remove logs filter

* refactor: type -> filter_type

* refactor: slight cleanup

* feat: update csv download

* feat: set org filters to mirror primary sales and lettings

* refactor: linting

* feat: fix filter types in org controller - can be changed to org specific labels in future if needed rather than copying filters from primary sales/lettings tabs

* refactor: initalize filter_type

* refactor: lint

* refactor: combine filter_manager into filter_service

* refactor: rename to filter manager

* refactor: DRY session name filter logic

* feat: share session filter name logic

* feat: further refactor

* refactor: simplify

* feat: revert change to filter manager

Phil Lee

d939e88435

CLDC-2316 Bulk upload sales 2023 (#1603)

# Context

- https://digital.dclg.gov.uk/jira/browse/CLDC-2316
- Implement bulk upload sales for new collection year 2023
- This is a first pass implementation and will probably have some bugs in it and we can address over time

# Changes

- Add CSV parser for sales 2023 to handle CSV structure
- Tweak collection window validation so error now contextual to year selected for upload
- Handle arbitrary ordering of CSV columns
- Fix ordering of errors in report and now ordered by cell
- Added `Upload your file again` link styled as button on error report to match lettings experience
- Update tooling to convert logs to 2023 csv rows with support for random column ordering

# Known issues

- There seem to be some issues with how UPRN is handled if the UPRN cannot be validated.
- For the above I think there is dependency on https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/pull/1570 which should clear any errored fields so users can continue to create logs and fix within the service

2 Commits (ef523adb5fe6e9829d069b70dbbf10f6310f3b26)