submit-social-housing-lettings-and-sales-data

3701 Commits

267 Branches

319 Tags

90 MiB

Tree: f2259aee8f

Commit Graph

Author	SHA1	Message	Date
Samuel Young	f5f0e663e0	CLDC-4184: Update question numbers for sales (#3221 ) * CLDC-4184: Consolidate logic for questions that appear in multiple subsections * CLDC-4184: Ensure all 2025 questions have a number * CLDC-4184: Add 2026 question numbers * CLDC-4184: Update question numbers to match paper form * CLDC-4184: Use the standard question hash function * CLDC-4184: Lint * CLDC-4184: Update tests * fixup! CLDC-4184: Update question numbers to match paper form * CLDC-4184: Commonise person question logic in sales * fixup! CLDC-4184: Update question numbers to match paper form add missing 2026 question * fixup! CLDC-4184: Use the standard question hash function missed nationality * fixup! CLDC-4184: Update question numbers to match paper form fix q111 * fixup! CLDC-4184: Update question numbers to match paper form some missed questions * CLDC-4184: Lint * CLDC-4184: Fix test	7 months ago
Nat Dean-Lewis	34664bde2d	CLDC-4178: Add gender same as sex question for sales (#3188 ) * CLDC-4173: add new buildheightclass db changes * CLDC-4173: add new buildheightclass page and question * CLDC-4173: add new buildheightclass bu and export updates * CLDC-4173: update tests * CLDC-4173: update var defs * CLDC-4173: add sales csv export tests for 26 including buildheightclass * CLDC-4173: add sales csv export tests for 25 and 26 including buildheightclass * CLDC-4173: update sales export spec * CLDC-4173: update sales export spec and make sales log csv service future-proof * CLDC-4178: add gender same as sex question for sales db changes * CLDC-4178: add gender same as sex question for sales questions and pages * CLDC-4178: add gender same as sex question for sales questions and pages * CLDC-4178: add gender same as sex question for sales copy * CLDC-4178: add gender same as sex question for sales person known page * CLDC-4178: add gender same as sex question for sales service updates * CLDC-4178: add gender same as sex question for sales test updates * CLDC-4140: update sales log to csv * CLDC-4140: revert typo * CLDC-4140: update factory * CLDC-4140: update factory * CLDC-4140: filename linting * CLDC-4178: update parser tests * CLDC-4178: update fixtures * CLDC-4173: add missing sales log export fixtures and tests * CLDC-4178: add missing sales log export fixtures and tests * CLDC-4178: update log var defs count * CLDC-4178: fix tests * CLDC-4237: Use each over for_each in sidekiq init (#3196) linter incorrectly assumes it is an activerecord relation * CLDC-4173: date refactoring in tests * CLDC-4173: date refactoring in tests * CLDC-4173: schema updates * CLDC-4173: cleanup and test improvements * CLDC-4173: remove deduplicated code * CLDC-4173: update dates in tests * CLDC-4178: more test date updates * CLDC-4173: test date updates * CLDC-4178: test date updates * CLDC-4178: unused copy cleanup * CLDC-4178: use shared person subsection block from CLDC-4176 * CLDC-4178: comment refactoring * CLDC-4178: person_n_present? updates * CLDC-4178: copy main csv fixtures * CLDC-4178: update csv fixtures * CLDC-4178: factory updates * CLDC-4178: export updates * CLDC-4178: refactoring for consistency with lettings * CLDC-4178: add copy key to gender same as sex * CLDC-4178: fix typo in export test * CLDC-4178: fix typo in locale copy --------- Co-authored-by: Samuel Young <samuel.young@softwire.com>	7 months ago
Samuel Young	98c58cc19a	CLDC-4142: New question on gender same as sex - lettings (#3161 ) * CLDC-4142: Add new cols to database * CLDC-4142: Add questions to flow optimise household_characteristics as there's a lot of repeated code. should make the sections a bit easier to manage * CLDC-4142: Add conditional description question seems to largely just work without needing major tweaks * CLDC-4142: Ensure description if nil if not shown looks like there's no automated process for this. without this the description will be "" if not given * CLDC-4142: Add new question to log factory * CLDC-4142: Add new fields to BU parser update BU template file to match * CLDC-4142: Add new fields to BU file generator * CLDC-4142: Add new fields to xml export also improve xml export matcher to report differences * CLDC-4142: Add final question numbers * CLDC-4142: Add question specs * CLDC-4142: Add a PERSON_DETAILS override for gender_same_as_sex this ensures if details aren't known the field will be redacted * CLDC-4142: Update model tests * CLDC-4142: Update CSV export service tests * CLDC-4142: Update other tests * fixup! CLDC-4142: Update CSV export service tests update sales variable definitons too * fixup! CLDC-4142: Ensure description if nil if not shown update inferral method name and comment * CLDC-4142: Update CYA copy as requested cya for gender_same_as_sex 'no' instead of 'no, enter gender description' cya for gender_description has the label 'gender identity description' * CLDC-4142: Use label_from_value for custom CYA text this replaces @inferred_check_answers_value so it'll work in CSV export too	8 months ago

Author

SHA1

Message

Date

Samuel Young

f5f0e663e0

CLDC-4184: Update question numbers for sales (#3221 )

* CLDC-4184: Consolidate logic for questions that appear in multiple subsections

* CLDC-4184: Ensure all 2025 questions have a number

* CLDC-4184: Add 2026 question numbers

* CLDC-4184: Update question numbers to match paper form

* CLDC-4184: Use the standard question hash function

* CLDC-4184: Lint

* CLDC-4184: Update tests

* fixup! CLDC-4184: Update question numbers to match paper form

* CLDC-4184: Commonise person question logic in sales

* fixup! CLDC-4184: Update question numbers to match paper form

add missing 2026 question

* fixup! CLDC-4184: Use the standard question hash function

missed nationality

* fixup! CLDC-4184: Update question numbers to match paper form

fix q111

* fixup! CLDC-4184: Update question numbers to match paper form

some missed questions

* CLDC-4184: Lint

* CLDC-4184: Fix test

7 months ago

Nat Dean-Lewis

34664bde2d

CLDC-4178: Add gender same as sex question for sales (#3188 )

* CLDC-4173: add new buildheightclass db changes

* CLDC-4173: add new buildheightclass page and question

* CLDC-4173: add new buildheightclass bu and export updates

* CLDC-4173: update tests

* CLDC-4173: update var defs

* CLDC-4173: add sales csv export tests for 26 including buildheightclass

* CLDC-4173: add sales csv export tests for 25 and 26 including buildheightclass

* CLDC-4173: update sales export spec

* CLDC-4173: update sales export spec and make sales log csv service future-proof

* CLDC-4178: add gender same as sex question for sales db changes

* CLDC-4178: add gender same as sex question for sales questions and pages

* CLDC-4178: add gender same as sex question for sales questions and pages

* CLDC-4178: add gender same as sex question for sales copy

* CLDC-4178: add gender same as sex question for sales person known page

* CLDC-4178: add gender same as sex question for sales service updates

* CLDC-4178: add gender same as sex question for sales test updates

* CLDC-4140: update sales log to csv

* CLDC-4140: revert typo

* CLDC-4140: update factory

* CLDC-4140: update factory

* CLDC-4140: filename linting

* CLDC-4178: update parser tests

* CLDC-4178: update fixtures

* CLDC-4173: add missing sales log export fixtures and tests

* CLDC-4178: add missing sales log export fixtures and tests

* CLDC-4178: update log var defs count

* CLDC-4178: fix tests

* CLDC-4237: Use each over for_each in sidekiq init (#3196)

linter incorrectly assumes it is an activerecord relation

* CLDC-4173: date refactoring in tests

* CLDC-4173: date refactoring in tests

* CLDC-4173: schema updates

* CLDC-4173: cleanup and test improvements

* CLDC-4173: remove deduplicated code

* CLDC-4173: update dates in tests

* CLDC-4178: more test date updates

* CLDC-4173: test date updates

* CLDC-4178: test date updates

* CLDC-4178: unused copy cleanup

* CLDC-4178: use shared person subsection block from CLDC-4176

* CLDC-4178: comment refactoring

* CLDC-4178: person_n_present? updates

* CLDC-4178: copy main csv fixtures

* CLDC-4178: update csv fixtures

* CLDC-4178: factory updates

* CLDC-4178: export updates

* CLDC-4178: refactoring for consistency with lettings

* CLDC-4178: add copy key to gender same as sex

* CLDC-4178: fix typo in export test

* CLDC-4178: fix typo in locale copy

---------

Co-authored-by: Samuel Young <samuel.young@softwire.com>

7 months ago

Samuel Young

98c58cc19a

CLDC-4142: New question on gender same as sex - lettings (#3161 )

* CLDC-4142: Add new cols to database

* CLDC-4142: Add questions to flow

optimise household_characteristics as there's a lot of repeated code. should make the sections a bit easier to manage

* CLDC-4142: Add conditional description question

seems to largely just work without needing major tweaks

* CLDC-4142: Ensure description if nil if not shown

looks like there's no automated process for this. without this the description will be "" if not given

* CLDC-4142: Add new question to log factory

* CLDC-4142: Add new fields to BU parser

update BU template file to match

* CLDC-4142: Add new fields to BU file generator

* CLDC-4142: Add new fields to xml export

also improve xml export matcher to report differences

* CLDC-4142: Add final question numbers

* CLDC-4142: Add question specs

* CLDC-4142: Add a PERSON_DETAILS override for gender_same_as_sex

this ensures if details aren't known the field will be redacted

* CLDC-4142: Update model tests

* CLDC-4142: Update CSV export service tests

* CLDC-4142: Update other tests

* fixup! CLDC-4142: Update CSV export service tests

update sales variable definitons too

* fixup! CLDC-4142: Ensure description if nil if not shown

update inferral method name and comment

* CLDC-4142: Update CYA copy as requested

cya for gender_same_as_sex 'no' instead of 'no, enter gender description'

cya for gender_description has the label 'gender identity description'

* CLDC-4142: Use label_from_value for custom CYA text

this replaces @inferred_check_answers_value so it'll work in CSV export too

8 months ago

2 Commits (f2259aee8f9cf6215b0f83c3d75652c9b91f0f04)