submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
kosiakkatrina	996a6d0757	CLDC-2105 Display merged orgs for owning organisation question (#1997 ) * Display merged orgs for owning org * Display available from date for absorbing orgs	1 year ago
natdeanlewissoftwire	ab55b67e3e	CLDC-2504 Add org select to sales if merged (#1830 ) * feat: wip update sales org select * feat: update routing and hidden in check answers methods * feat: set sales org id as derived * feat: update tests * refactor: linting * feat: update tests and radio options * feat: update test * feat: add value helper test for non-constant value question * refactor: lint * feat: freeze time in unrelated test * refactor: linting * feat: wip commit * feat: tidy up active readouts * feat: revert previous commits * feat: put merge orgs behaviour behind feature flag * feat: put merge orgs behaviour behind feature flag * refactor: lint * refactor: simplify * feat: add one more feature toggle	1 year ago
natdeanlewissoftwire	fb389414a0	CLDC-2504 Add owning org select to sales if there are stock owning absorbed orgs (#1815 ) * feat: wip update sales org select * feat: update routing and hidden in check answers methods * feat: set sales org id as derived * feat: update tests * refactor: linting * feat: update tests and radio options * feat: update test * feat: add value helper test for non-constant value question * refactor: lint * feat: freeze time in unrelated test * refactor: linting	1 year ago
natdeanlewissoftwire	ed33eec44a	CLDC-2571 Add absorbed org relationship (#1789 ) * feat: add absorbing_organisation relationship to orgs * feat: wip absorbed orgs visibility work * feat: add absorbed orgs to filter options, make unique * refactor: simplify * feat: add test * feat: update schema * feat: add absorbed org to user relations * feat: be more explicit about org scopes * feat: update log org question selections * feat: add org question to sales for all users (to be specified again in later ticket) * feat: revert previous and handle in separate ticket * feat: update validation and tests * feat: reload org to populate associations * feat: check for holding own stock in stock owner question, add schema * feat: add/update org filter tests * feat: update test * feat: update created by id pages	1 year ago
Aaron Spencer	9349b6718d	CLDC 1863: Prevent non-stock organisations appearing in search for who owns property questions. (#1748 ) * CLDC-1863: orgs must own stock to show as option WIP * CLDC-1863: Test updated * CLDC-1863: removed test of no longer relevant behaviour	2 years ago
natdeanlewissoftwire	c862423adf	CLDC-1864 single log numbering (#1381 ) * feat: add initial question number behaviour * feat: add initial CYA behaviour * feat: number sales setup section * refactor: lint * feat: property information numbering * feat: household characteristics section and typo fix * feat: household characteristics numbering * feat: household situation numbering * feat: other household info numbering * feat: income, benefits and outgoings numbering * feat: shared ownership scheme numbering * feat: shared, discount and outright numbering * feat: fix income duplication bug, add numbers to other questions * feat: typo fix * feat: add lettings setup numbering * feat: add property info numbering * feat: add household char numbering * feat: add household needs numbering * feat: add household situ numbering * feat: add income numbering * feat: update tests * refactor: cleanup and disable on 2022 and before logs * feat: add test for q numbers in 23/24 year only * refactor: highlight multiplication in brackets * feat: show rent and charge questions individually on cya * feat: number new previous tenure q * feat: delete old prevten file * feat: update card numbers after merge * feat: add q60 ands 61 sales * refactor: delete empty files --------- Co-authored-by: Kat <katrina@kosiak.co.uk>	2 years ago
Jack	d6a5f6718e	CLDC 1865 Refactor questions to avoid race conditions (#1255 ) * Extract time helper methods * Add missing specs for BulkUploadController#start * refactor ManagingOrganisation question * refactor StockOwner question	2 years ago
SamSeed-Softwire	92a00e4305	CLDC-1723 Overhaul letting log owning & managing org questions & tests (#1140 ) * test: check managing org not gone from answer opts when relationship deleted * feat: add current managing org to answer opts * feat: check if managing org exists before trying to show it * wip * test: improve managing orgs opts test when not support * test: improve managing orgs opts tests when support * test: make relationship deletion test consistent with other tests * test: add "(with hint)" to managing org opts test descriptions * test: refactor managing orgs opts tests for support user case * fix: don't call user in get_answer_label in CYA component * style: reorder instance vars and remove old comments in managing_organisation.rb * refactor: ensure label_from_value always accepts log & nil as args * lint * test: pass in log and user in housing provider opts test for support user * test: update housing provider opts tests for non-support user * feat: update housing provider answer opts to include current HP in db * style: add space after user definition * test: make context definition more human-readable * test: refactor housing providers opts tests (not support user) * test: check housing prov. still selectable after deleting relationship * fix: define log and current_user instance vars in label_from_value (housing prov.) * lint * test: update lettings log feature tests to differentiate between different numbers of stock owners when acting as a data coordinator * test: check owning & managing orgs set correctly when a log is created * test: add line breaks and start context descriptions with and (not if) * test: artificially reference org_rel2 to avoid lint offense * feat: don't set log owning org as user's org if that org doesn't hold stock * test: improve test context descriptions in lettings_log_spec * test: finish overhauling owning and managing org tests in lettings_log_spec * test: change let! to let where possible in spec/features/lettings_log_spec.rb * test: change let! to let where possible in spec/models/form/lettings/questions/managing_organisation_spec.rb * test: change let! to let where possible in spec/models/form/lettings/questions/stock_owner_spec.rb * test: remove if statement from "coordinator user's org doesn't hold stock" managing org test * test: remove if statement from "coordinator user's org does hold stock" no managing orgs managing org test * test: remove if statement from "coordinator user's org does hold stock" >=1 managing orgs managing org test plus refactor previous test * test: explicitly reference org rels in "coordinator user's org doesn't hold stock" managing org test * test: don't create vars inside other vars (for tests edited/created in this branch) * chore: save schema changes after migration Co-authored-by: Phil Lee <asmega@users.noreply.github.com>	2 years ago
kosiakkatrina	c339ffda1f	Cleanup the form (#1166 ) * Remove empty descriptions from pages * remove empty headers from pages * Remove redundant subsection assignment from pages * Remove redundant page assignement from questions * Remove redundant section assignment from subsections * Remove redundant form assignments from sections * Remove empty hint texts from questions * lint	2 years ago
natdeanlewissoftwire	b855a2987e	change housing provider -> stock owner (#1104 ) * change housing provider -> stock owner * feat: add case and _ replacements * refactor: rename files * refactor: - changes * housing provider * refactor: registered ... renaming	2 years ago
Jack S	c0541b054b	[CLDC-20] Address more ACs (#1020 ) * Bugfix provider_type on nil * Do not infer managing org * Always show 'your org' to non support users * Never show created_by_id in CYA * Show HousingProvider in CYA when not inferred * Always show ManagingOrganisation * Spec fix * Show ManagingOrganisation if managing agents >=1 * typo	2 years ago
Jack S	200a382138	Remove memoization (#998 ) These variables seemed to be memoized across users	2 years ago
Jack S	fbb06bcb9f	[CLDC-20] Submit for other orgs (#968 ) * Add scopes to OrganisationRelationship * Update seeds to have more than one org relationships * Pass current_user to questions * Add new questions * Use feature flag * Update specs * Address comments	2 years ago

10 Commits (f29507189a82a0dc76b726618ae3d2f272fd5dc4)