submit-social-housing-lettings-and-sales-data

3030 Commits

265 Branches

309 Tags

88 MiB

Tree: f5ad0a6121

Commit Graph

Author	SHA1	Message	Date
Arthur Campbell	5c78f50a64	CLDC-2310 create sales log field import service and import bulk upload id field (#1783 ) * some minor refactoring remove methods from child class that replicate methods on the parent class tidy up check for nil remove gubbins and inline method body given only used once * update import services for lettings and sales to import creation method write tests to cover this * create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported * update lettings log field import service and related spec to allow importing creation method of logs * use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process. various tests tweaked to suppor this change. rake task from another ticket folded into this ticket to prevent merge conflicts * rename method for ruby conventions * update PR for altered spec upload id now decided to be a better indicator of bulk upload status, import service amended accordingly tests updated in line with this * update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created * slight refactor to reduce nesting and dodge linter complaints * minor amendment to log creator spec in bulk upload to use enum dynamic methods * revert updating creation method in rake task with update all	3 years ago
Arthur Campbell	5d80aad202	CLDC-2310 add creation method to both log import services, lettings log field import and create sales log field import (#1744 ) * some minor refactoring remove methods from child class that replicate methods on the parent class tidy up check for nil remove gubbins and inline method body given only used once * update import services for lettings and sales to import creation method write tests to cover this * create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported * update lettings log field import service and related spec to allow importing creation method of logs * use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process. various tests tweaked to suppor this change. rake task from another ticket folded into this ticket to prevent merge conflicts * rename method for ruby conventions * update PR for altered spec upload id now decided to be a better indicator of bulk upload status, import service amended accordingly tests updated in line with this * update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created * slight refactor to reduce nesting and dodge linter complaints * minor amendment to log creator spec in bulk upload to use enum dynamic methods	3 years ago

Author

SHA1

Message

Date

Arthur Campbell

5c78f50a64

CLDC-2310 create sales log field import service and import bulk upload id field (#1783 )

* some minor refactoring
remove methods from child class that replicate methods on the parent class
tidy up check for nil
remove gubbins and inline method body given only used once

* update import services for lettings and sales to import creation method
write tests to cover this

* create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported

* update lettings log field import service and related spec to allow importing creation method of logs

* use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process.
various tests tweaked to suppor this change.
rake task from another ticket folded into this ticket to prevent merge conflicts

* rename method for ruby conventions

* update PR for altered spec
upload id now decided to be a better indicator of bulk upload status, import service amended accordingly
tests updated in line with this

* update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created

* slight refactor to reduce nesting and dodge linter complaints

* minor amendment to log creator spec in bulk upload to use enum dynamic methods

* revert updating creation method in rake task with update all

3 years ago

Arthur Campbell

5d80aad202

CLDC-2310 add creation method to both log import services, lettings log field import and create sales log field import (#1744 )

* some minor refactoring
remove methods from child class that replicate methods on the parent class
tidy up check for nil
remove gubbins and inline method body given only used once

* update import services for lettings and sales to import creation method
write tests to cover this

* create sales log field import service and associated spec file, with methods and tests for importing the creation method of logs that have already been imported

* update lettings log field import service and related spec to allow importing creation method of logs

* use the methods dynamically created by active record in all relevant places, removing obsolete methods in teh process.
various tests tweaked to suppor this change.
rake task from another ticket folded into this ticket to prevent merge conflicts

* rename method for ruby conventions

* update PR for altered spec
upload id now decided to be a better indicator of bulk upload status, import service amended accordingly
tests updated in line with this

* update field import services in line with import services to use upload id rather than upload method as the source of truth for how a log was created

* slight refactor to reduce nesting and dodge linter complaints

* minor amendment to log creator spec in bulk upload to use enum dynamic methods

3 years ago

2 Commits (f5ad0a6121935aeed9743ed492e736c1f80a1bd3)