Matthew Phelan
ba9cdd31a2
Code review updates
4 years ago
baarkerlounger
1864fdd3b3
Rubocop
4 years ago
baarkerlounger
09ac94b698
Move a teeny bit of logic out of the controller
4 years ago
baarkerlounger
cece3fd077
Set a no cache header instead of reloading
4 years ago
baarkerlounger
1cd97da0eb
Bit of a nasty hack but maybe better than deriving back link?
4 years ago
baarkerlounger
4920e9521c
Dup variable
4 years ago
baarkerlounger
afdce4535d
We're really validating a page here not a question
4 years ago
baarkerlounger
23ee3e6601
Don't really need a wrapper method for the validations
4 years ago
magicmilo
6ca1fa1bc2
fix merge
4 years ago
magicmilo
a83a0c53fd
fix merge and move validation
4 years ago
baarkerlounger
0264baf6dc
Fix back button for check answers pages
4 years ago
baarkerlounger
b727b47671
Check page should have an override question
4 years ago
baarkerlounger
2bc54919aa
All specs currently passing. Can this be real?
4 years ago
magicmilo
31b594d51c
switched to between for range
4 years ago
magicmilo
ee2323a805
Switch to household number of other members
4 years ago
baarkerlounger
7c7e3eafbc
Fix back link
4 years ago
baarkerlounger
d240e299bd
Add some test for our validations
4 years ago
baarkerlounger
656c7bda26
Specs passing
4 years ago
Matthew Phelan
c3e1f07797
validate_other_household_members refactor
...
Co-authored-by: Daniel Baark <baarkerlounger@users.noreply.github.com>
4 years ago
baarkerlounger
3aee0b976d
Make partial slightly more generic
4 years ago
baarkerlounger
84cee86db6
Add error indication
4 years ago
Daniel Baark
fff5da304e
Refactor validations into modules ( #73 )
...
* Refactor validations into modules
* PropertyValidations
* Add financial and tenancy validations
* Shorten comment
* Simplify
4 years ago
baarkerlounger
a9f1209c64
Commit both lines
4 years ago
baarkerlounger
05bdcee66c
No instance variable
4 years ago
baarkerlounger
474e036170
Rename folder to validations
4 years ago
baarkerlounger
82942ab475
Scope are auto created by enums
4 years ago
baarkerlounger
0aca7ad716
Rubocop
4 years ago
baarkerlounger
cd41b0a133
Update test
4 years ago
baarkerlounger
0f02476318
Move soft validations into a module
4 years ago
Matthew Phelan
971c3909ee
validate_other_household_members
4 years ago
kosiakkatrina
c7cd48c2e8
CLDC-513: Refused income validation ( #71 )
...
* Add net income known field
* only require the income if it is known
* fix a typo
4 years ago
baarkerlounger
d9434ac06a
Init
4 years ago
Daniel Baark
f372a4727e
Hard validation ( #69 )
4 years ago
magicmilo
2367ad16d5
tests and tweaks
4 years ago
kosiakkatrina
055cbf8fc5
CLDC-464: Other tenancy type validation ( #68 )
...
* Add other_tenancy_type conditional field
* Extract private validdate_other_field_method
* Implement other tenancy type validation
* Add missing migration file and update API doc
4 years ago
baarkerlounger
fba2474747
rubocop
4 years ago
magicmilo
073ccfe633
rubocop
4 years ago
magicmilo
1cf1197096
tests
4 years ago
kosiakkatrina
c39271d486
CLDC-466: Add fixed term tenancy validation ( #66 )
...
* Add fixed term tenancy validation
* refactor validate_fixed_term_tenancy
* add fixed_term_tenancy pattern to api docs and make it dynamically not required
4 years ago
magicmilo
d4497883ae
rubocop
4 years ago
magicmilo
bea7c54e5a
inital
4 years ago
kosiakkatrina
2c1f246350
CLDC-473: Add net income uc proportion validation ( #62 )
...
* Add validate_net_income_uc_proportion validation/
* refactor validation method;
* Update net income options in doc
* rubocop
* refactor validate_net_income_uc_proportion and increase the persons checked to 8
* rename tenant economic status field
4 years ago
magicmilo
3d2699e557
added simple validation for outstanding rent
4 years ago
magicmilo
c6fb2580df
rubocop
4 years ago
magicmilo
ede51029e9
rubocop
4 years ago
magicmilo
4520b3a1cc
added armed forces active response validation
4 years ago
magicmilo
88043a9386
made validator private method
4 years ago
magicmilo
248c67bcb3
Renamed tenant to person_1 everywhere
4 years ago
magicmilo
357aea91c7
clean up validation
4 years ago
Milo
8d3e31ee10
Update app/models/case_log.rb
...
Use map rather than indexing
Co-authored-by: Daniel Baark <5101747+baarkerlounger@users.noreply.github.com>
4 years ago