submit-social-housing-lettings-and-sales-data

Commit Graph

Author	SHA1	Message	Date
Nat Dean-Lewis	ff4753e8c4	docs: clarify comments	4 days ago
Nat Dean-Lewis	6c82c1ac37	feat: migrate to rails 8.1.3	4 days ago
kosiakkatrina	8ffc5c6daf	Update rails to 7.2.2 (#2856 ) * Update rails and puma * Update factory bot, fixture_paths, lint and populate LAs for tests * Remove enum deprecation warnings * Fix prefic syntax * Update paper_trail, add missing translations, lint * Update some tests * Update some more gems * Update npm package * Update Rails to 7.2.2.1	2 years ago
Rachael Booth	048e4c339b	Review apps on AWS (#2062 ) * CLDC-2812: update app config to run from relative root * Deploy to staging on pushes to branch * Add action mailer relative root config for review envs * Temporary pipeline to deploy this branch for testing * Update aws deploy pipeline to allow different prefixes for roles and tasks * Prepare database when deploying review apps * Update app nav and sentry to take account of relative root * Update more fixed paths * Update header root link path * Rack attack path * Revert "Deploy to staging on pushes to branch" This reverts commit `b05f13d474`. * Start updating workflows * Update teardown pipeline to drop database * Ensure destroy infra step runs after drop database * Remove user_password_path because it can't be found * Don't override path helpers in navigation items helper tests * Checkout infra code to run workflow * Try separating workflow call to job * Sync with infra repo updates * Use workflow on dev * Don't trigger on push to branch * Avoid rack attack path helper issue * Update review apps teardown pipeline * Update infra repo reference to main * Fix linting * Fix /logs redirect * Fix lettings_logs_current and sales_logs_current checks in navigation items helper * Fix existing bug in schemes nav item highlighting * Use starts with rather than == in logs nav items current checks * Split off non-support schemes current nav item checks --------- Co-authored-by: Sam Seed <sam.seed@softwire.com>	3 years ago
Arthur Campbell	cec1208b35	CLDC-2290 implement delete multiple logs story (#1657 ) * add a button to the logs list to delete multiple logs style and position of button helpers for displaying the button conditionally depending on user role and what filters and search are active * correct indentation from 4 spaces to 2 in view file * test appearance of delete logs button on index page for lettings logs * write a happy path feature test for the entire journey * create basic tests for the view component for listing logs to delete * create request tests for the GET delete-logs path * create request tests for the GET delete-logs-confirmation path * create request tests for the DELETE delete-logs path * comprehensive reworking after code review ensure that we are not passing lists of ids through params in the query string, risking overflowing the maximum URL length, adjust tests accordingly, do not attempt to reuse the same table for sales and lettings * alter config to allow creating controllers from the command line with associated spec files that matches how we test * extract controller methods and associated tests to do with the delete logs feature into their own controller, amend routes accordingly * implement same work for sales as for lettings * implement the story for lettings and sales logs under the organisation tab routing and controller methods testing for deleting sales logs, lettings or sales logs for an organisation move storage of relevant routes inside the form object as a comprehensive view model * merge the delete pages for lettings logs and sales logs, add to the tests for the lettings page to test sales specific content * minor refactor to delete logs controller: ensure session filters are only fetched from teh session when needed and extract discard logs method to private method * extract tables for lettings and sales to own partials * refactor delete logs controller after tech review improve the private method that builds the form object so that it has the flexibility to do so for all controller methods ensure that the search term is passed to the delete logs controller when navigating through the organisations tab ensure that noly logs for that organisation are displayed when navigating to delete logs through the organisations tab * remove unnecessary untested arguments * test new helper methods * implement dirty fiddle to get the checkboxes smaller and also not misaligned * ensure delete logs button is always visible on log lists when in the organisations tab * minor linting corrections * revert change, causing errors and outside the scope of this ticket * simplify tests for whether delete logs button appears on index page * replicate request specs from lettings for sales and organisations controllers * minor refactor of lettings log feature spec setup, replicate happy path for sales * minor refactors after rebasing onto Nat's work * temp * write tests for the delete logs form object * lint: add new line at end of file * respond to PO feedback the log id in the delte logs table should be a link to the log the delete logs button should be visible when the user is in a bulk upload journey updated associated tests	3 years ago
Phil Lee	24303b54ca	make cookies secure for production like envs (#1016 )	4 years ago
James Rose	d3075e4e43	Revert to `f4e6d6d6bb` (#887 )	4 years ago
natdeanlewissoftwire	f162f880ae	Revert "Merge remote-tracking branch 'origin/main' into CLDC-1429-output-la-code" This reverts commit `626e2bd1a6`, reversing changes made to `f86e13cea7`.	4 years ago
Sam	a92fb1030c	CLDC-1362 Improve CSV download performance (#851 ) * Replaced log CSV direct download with email * Tidy up authorization of organisations controller - We already have a method to authenticate the scope of the user, so we can reuse that. * Use Rails routes instead of absolute paths for CSV download links * Introduce base NotifyMailer to to abstract away shared Notify mail functionality * Fix mailer spec name * Add worker instance to PaaS manifest * Add CSV download bucket instance name into environment * Update tests for improved search term handling * Fix download mailer tests * Clarifying comments Co-authored-by: natdeanlewissoftwire <nat.dean-lewis@softwire.com> Co-authored-by: James Rose <james@jbpr.net>	4 years ago
Paul Robert Lloyd	506e9cd221	Add errors controller	5 years ago
baarkerlounger	195c41eccc	Rails 7 (#174 ) * Rails 7 config * Gem bumps * Turn off unused rails engines * Rails 7 released * Rubocop * Not currently using ActionCable	5 years ago
Daniel Baark	0a9851b43e	CLDC-639: Active admin (#75 ) * Install ActiveAdmin * Tidy up dashboard * Set time zone as per Gov UK recommendations * Add chartkick for some basic admin dashboard charts	5 years ago
baarkerlounger	4897e2cd76	Add application skeleton to repo	5 years ago

13 Commits (ff4753e8c4710b48838efd7b8daa2ae6540c4edf)