kosiakkatrina
671232daa9
CLDC-3734 Add LA in England validation for 2025 ( #2763 )
...
* Add LA in England validation for 2025
* Validate supported housing logs
* Add error message to the date
* Update error messages
* lint
* Fix error messages for date
* Update no address found soft validation
* Update validation messages
1 month ago
Manny Dinssa
502d038e9e
CLDC-3752: Sales - Hide questions if a staircasing transaction (25/26) ( #2780 )
...
* Do not ask questions from these sections when it's a staircase transaction
* Hide section/subsections from task list
* Add tests
* Fix lint
* Move logic to section model
1 month ago
Manny Dinssa
bc1fe83750
CLDC-3757: Sales - Change values in validation check for Q84 (25/26) ( #2781 )
...
* Update 2025 version of validation check
* Update validation for 2025
* Put two if statements into one
* Different approach to comparing dates
* Alternative method to compare dates
* Update tests
1 month ago
kosiakkatrina
a3ce7e9f95
Update validation message ( #2783 )
1 month ago
Manny Dinssa
4dc323059f
CLDC-3738: Sales - Update household characteristics Q29 and Q38 (25/26) ( #2774 )
...
* Create 2025 versions of these questions
* Remove blank line
* Update copy and use 2025 version of question
* Add tests
* Update depends on
* Update question number
* Update test
* Remove depends_on companybuy which has been removed
* Fix lint
1 month ago
kosiakkatrina
6fb1384364
Remove mortgage lender questions for 2025 discounted sales ( #2784 )
1 month ago
Rachael Booth
aeae0c1806
CLDC-3766: Ensure copy for sales Q78 is found correctly for 2024 logs ( #2790 )
...
* CLDC-3766: Ensure copy for Q78 is found correctly
* Fix tests
1 month ago
kosiakkatrina
de1d28c27e
Increase soft max for old persons shared ownership savings ( #2778 )
1 month ago
Manny Dinssa
c8a36fd3a6
Move sales staircasing question ( #2777 )
...
* Change order
* Update test
1 month ago
kosiakkatrina
16393cf4ab
Trigger income error on uprn_selection ( #2771 )
1 month ago
kosiakkatrina
b87c107f25
Route only to buyer questions for staircase transactions ( #2765 )
1 month ago
kosiakkatrina
10de485408
CLDC-3698 Rename household needs to other household information for sales ( #2772 )
...
* Rename household needs occurences
* Rename files
1 month ago
Rachael Booth
8dab730c54
CLDC-3704: Allow equity/stairowned/stairbought to have 1 decimal place ( #2746 )
...
* CLDC-3666: Pull sales financial validations into translations file
* CLDC-3704: Allow equity/stairowned/stairbought to have 1 decimal place
* Fix lint for migration
* Fix tests
* Fix sale information validations tests
* Fix lint
* Fix form spec
* Don't expect unexpected cashdis error
1 month ago
kosiakkatrina
0083485b42
CLDC-3690 Extract lettings property validations copy ( #2742 )
...
* Extract lettings property validations copy
* Update uprn question
* Remove redundant validations (can't trigger them because on inferrance)
1 month ago
Manny Dinssa
0b4ff65429
CLDC-3689: Extract lettings household validations ( #2741 )
...
* Extract household validations
* Use question ids a primary key
* Fix lint
* Refactor, remove one level of keys
* Fix merge
1 month ago
Rachael Booth
2b629891fb
CLDC-3666: Pull sales financial validations into translations file ( #2716 )
1 month ago
Rachael Booth
fbeaee9368
CLDC-3733: Adjust ordering for working situation question ( #2762 )
...
* CLDC-3733: Adjust ordering for working situation question
* Fix tests
1 month ago
Manny Dinssa
4886cdbe36
CLDC-3722: Sales - Remove from Q5 'outright or other sale' answer option (25/26) ( #2752 )
1 month ago
Manny Dinssa
1a07e37049
CLDC-3717: Sales - Remove Q9 (Is the buyer a company?) (25/26) ( #2755 )
1 month ago
Manny Dinssa
154f4d9538
CLDC-3721: Sales - Move Q78 (Is this a staircasing transaction?) to setup section (25/26) ( #2751 )
1 month ago
Manny Dinssa
3125171edf
CLDC-3718: Sales - Remove Q10 (Will any buyers live in the property?) (25/26) ( #2757 )
1 month ago
Rachael Booth
e2123f8b9d
CLDC-3736: Don't route to property building type or wheelchair accessibility for staircasing sales from 2025 ( #2761 )
...
* CLDC-3736: Don't route to property building type or wheelchair accessibility for staircasing sales from 2025
* Add tests for routed_to?
* Fix test
1 month ago
Rachael Booth
7d407ab4c6
CLDC-3739: Remove buyer orgs question from 2025 ( #2766 )
1 month ago
Manny Dinssa
30442fcee2
CLDC-3735: Sales - Move Q19 (What type of unit is the property?) (25/26) ( #2760 )
1 month ago
Manny Dinssa
b681b101f3
CLDC-3715: Sales - Remove Q8 (What is the type of outright sale?) (25/26) ( #2753 )
1 month ago
kosiakkatrina
afc7cf86b4
Exctract financial validations ( #2740 )
1 month ago
Rachael Booth
224e49825e
CLDC-3719: Move sale completion date question to start of setup section ( #2750 )
...
* CLDC-3716: Allow 25/26 form use on dev, review, and staging environments
* Remove empty line
* CLDC-3719: Move sale completion date question to start of setup section
* Fix test
* Update test fixture csv order
1 month ago
Manny Dinssa
61eb0057f6
CLDC-3693: Extract shared validations ( #2744 )
...
* Extract lettings household validation from shared validations
* Extract lettings setup validation from shared validations
* Extract only shared validations
1 month ago
kosiakkatrina
020b8a4f4c
CLDC-3686 Extract lettings soft validations copy ( #2735 )
...
* Extract household characteristics soft validations
* Extract household needs soft validations
* Extract household situation soft validations
* Extract income and benefits soft validations
* Extract property information soft validations
* Update tests and 2024 soft validations
* Update some test forms
* Re-add sales validation
* Update BU tests
* Fixes
* Change higher to longer
* Update model test
* Update model test
* Add 2025 translations copied from 2024
* Update pregnancy and retirement copy
---------
Co-authored-by: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Co-authored-by: Rachael Booth <rachael.booth@softwire.com>
2 months ago
Manny Dinssa
6fb29ade6b
CLDC-3712: Sales Form Updates ( #2756 )
2 months ago
Manny Dinssa
83e3ddccdd
CLDC-3692: Extract lettings tenancy validations ( #2743 )
...
* Extract lettings tenancy validations
2 months ago
kosiakkatrina
51bc0cffeb
CLDC-3665 Extract sale information copy ( #2711 )
...
* Extract shared ownership copy
* Extract discounted ownership copy
* rename files
* CLDC-3665 Extract sale information soft validations (#2712 )
* Extract shared ownership copy
* Extract shared ownership soft validations
* Extract discounted ownership validations
* Fix mappings
* Update some translations
* Remove full stops
2 months ago
kosiakkatrina
3cda5adf5c
CLDC-3683 Extract lettings household situation copy ( #2730 )
...
* Extract lettings household situation copy
* Update wrong copy, remove duplicate keys
2 months ago
kosiakkatrina
625b0c757c
CLDC-3668 Extract guidance copy ( #2737 )
...
* Extract guidance copy
* Update tests and lint
2 months ago
Manny Dinssa
576d0900fa
CLDC-3691: Extract copy - lettings setup validations ( #2739 )
2 months ago
Manny Dinssa
7f016f898f
CLDC-3687: Extract copy - lettings date validations ( #2738 )
2 months ago
Manny Dinssa
f9922c1ba4
CLDC-3654: Copy changes - Sales property information questions ( #2694 )
2 months ago
kosiakkatrina
f2f44329f3
CLDC-3684 Extract lettings tenancy information copy ( #2731 )
...
* Extract lettings tenancy information copy
* Fix flaky merged schemes test
2 months ago
Rachael Booth
3424cbc550
CLDC-3366: Use single page for rent soft validation ( #2724 )
...
* CLDC-3366: Use single page for rent soft validation
* Fix tests
2 months ago
kosiakkatrina
ff3f789acc
CLDC-3681 Extract lettings household characteristics copy ( #2728 )
...
* Extract lettings household characteristics copy
* Update cya labels for age known
* Update missing keys and copy
2 months ago
kosiakkatrina
9763013ac1
Extract sale information validations into a separate translations file ( #2699 )
2 months ago
kosiakkatrina
1ffc440342
CLDC-3656 Extract household characteristics question and page copy to translation files ( #2702 )
...
* Extract question and page copy to translation files
* Refactor 2 question pages
* Readd removed answer options
* Fix missing/wrong age mappings
* Update some pages/questions
* Update tests
* CLDC-3656 Extract household characteristics soft validations (#2707 )
* Extract retirement confirmation questions
* Extract old persons shared ownership confirmation questions
* Extract income confirmation questions
* Extract buyer live-in value check page and question copy to translation files
* Extract student not a child confirmation questions and page copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Extract partner under 16 value check page and question copy to translation files
* Update some missing/wrong keys
* Update some keys on 2023
* Update BU tests
2 months ago
kosiakkatrina
469211ce65
CLDC-3661 Update year format ( #2713 )
...
* Update year combo format
* lint
* Update tests and validations
* update model tests
* Update bu list year format
* Update test
2 months ago
kosiakkatrina
0799ff7a36
CLDC-3658 Extract household needs copy ( #2718 )
...
* Extract household needs subsection copy
* Extract housing needs soft validations copy
* Add new lines at the end of some files
2 months ago
kosiakkatrina
443a19f42d
Update household validations ( #2708 )
2 months ago
kosiakkatrina
ace6a599b0
CLDC-3664 Extract income and benefits copy ( #2709 )
...
* Refactor sales household pages and questions
* Refactor sales income and benefits soft validations
* Update subsection test
* Fix income copy keys
* Update subsection test
* Add missing question to translations
* Fix typo
* Add prevshared for 2024
2 months ago
Rachael Booth
2e6e56720d
CLDC-3257: Default to current collection year for BU guidance pages ( #2695 )
...
* CLDC-3257: Default to current collection year for BU guidance pages
* Ignore rubocop RSpec/AnyInstance when necessary
2 months ago
Rachael Booth
731dcc9325
CLDC-3650: Move copy for sales setup section to translation files ( #2672 )
2 months ago
Manny Dinssa
ed58d8e9c6
CLDC-2740: Sort rent periods in organisation details page ( #2680 )
...
* Sort rent periods in organisation details page
* Make rent periods uniq
* Update tests to check rent periods are in order
2 months ago
Manny Dinssa
b1ad8a1520
CLDC-3633++ Full stops in error messages & capitalisation within messages ( #2674 )
3 months ago