Commit Graph

  • 4e3919f80e
    CLDC-1781 Bulk upload thresholds (#1252) Phil Lee 2023-01-31 13:16:57 +0000
  • 1bfb0b5d92 only show buyer 2 checks if it's a jjoint purchase Kat 2023-01-31 10:46:48 +0000
  • f468aaa2ce Add validation to disounted and outright sales Kat 2023-01-30 11:06:03 +0000
  • e9f59ed7fe Run the mortgage amount validation on non joint purchases as well Kat 2023-01-26 15:21:56 +0000
  • de3f3f53e9 Add mortgage value check after mortgage used and mortgage amount pages Kat 2023-01-26 15:21:27 +0000
  • 342a0f3c21
    Merge branch 'main' into CLDC-1923-amend-validation-message-for-single-ended-ranges Arthur Campbell 2023-01-31 12:17:06 +0000
  • b37ea4d253 amend minor typo, add back a soft validation that had mysteriously gone missing Arthur Campbell 2023-01-31 12:04:02 +0000
  • 9518cadcb5
    CLDC-1450 Update declaration question (#1098) kosiakkatrina 2023-01-31 12:00:47 +0000
  • caf950c17f feat: check date is valid natdeanlewissoftwire 2023-01-31 11:55:46 +0000
  • b2d5f9f546
    CLDC-1924 Add monthly charges validation (#1247) kosiakkatrina 2023-01-31 11:34:21 +0000
  • e66ade7780 Merge branch 'main' into CLDC-1464-completion-date-validations natdeanlewissoftwire 2023-01-31 11:29:51 +0000
  • 7dd02d1f21 db: update natdeanlewissoftwire 2023-01-31 11:28:04 +0000
  • da2ae15e23 Merge branch 'main' into CLDC-1643-fix-inferred-check-answers-value natdeanlewissoftwire 2023-01-31 11:27:41 +0000
  • 6458a45332 refactor: copy natdeanlewissoftwire 2023-01-31 11:27:26 +0000
  • 82220ffd90 test Kat 2023-01-31 11:07:13 +0000
  • ff471ed85e Fix optional field name, add validation message Kat 2023-01-27 12:08:17 +0000
  • 98ba778166 Add monthly_charges_value_check pages to the relevant subsections Kat 2023-01-27 11:53:23 +0000
  • dbd4932393 Add monthly_charges_value_check page and question Kat 2023-01-27 11:52:59 +0000
  • 9a38622f44 Add monthly_charges_over_soft_max soft validation Kat 2023-01-27 11:52:04 +0000
  • d633602aaf Add monthly_charges_value_check field to sales Kat 2023-01-27 11:51:18 +0000
  • d882098cfc test: update natdeanlewissoftwire 2023-01-31 10:47:43 +0000
  • 4c229d3750 Merge branch 'CLDC-1923-amend-validation-message-for-single-ended-ranges' of github.com:communitiesuk/submit-social-housing-lettings-and-sales-data into CLDC-1923-amend-validation-message-for-single-ended-ranges Arthur Campbell 2023-01-31 10:35:29 +0000
  • dc3cf3a418 add min and max to household count question and remove bespoke validation. Remove code allowing max and no min given this situation does not seem to exist int eh form Arthur Campbell 2023-01-31 10:35:09 +0000
  • 6d33fa95d3 refactor: linting natdeanlewissoftwire 2023-01-31 10:30:44 +0000
  • 295251bbed refactor: combine method calls natdeanlewissoftwire 2023-01-31 10:30:24 +0000
  • a54418e830 Display the household questions if the buyers were not interviewed Kat 2023-01-31 10:28:33 +0000
  • 1e2281a5c6
    Merge branch 'main' into CLDC-1923-amend-validation-message-for-single-ended-ranges Arthur Campbell 2023-01-31 09:26:42 +0000
  • 3737a0f011
    CLDC-1875 Create bulk upload Notify email templates and corresponding methods (#1244) SamSeed-Softwire 2023-01-30 17:25:19 +0000
  • a0376627ee refactor: make has_inferred_check_answers_value? do what it says it does natdeanlewissoftwire 2023-01-30 17:15:56 +0000
  • cfdc669662 chore: lint to add commas to last line of each batch Sam Seed 2023-01-26 17:43:06 +0000
  • 282ac8e94f feat: update dummy text to use bulk_upload argument Sam Seed 2023-01-26 17:42:42 +0000
  • 6ec391a61a feat: add methods for remaining bulk upload emails Sam Seed 2023-01-26 16:27:23 +0000
  • 89cb6c1959 feat: split personalisation params onto separate lines + write "dummy" Sam Seed 2023-01-26 16:26:30 +0000
  • ec76203d58 feat: rename 'bulk upload failed' to 'bulk upload failed csv errors Sam Seed 2023-01-26 16:25:09 +0000
  • 5865e2a8d2 feat: correct template id for 'bulk upload with errors' Sam Seed 2023-01-26 16:21:40 +0000
  • eff304058b feat: create BulkUploadMailer class Sam Seed 2023-01-26 12:48:50 +0000
  • 74cd0ec1ac Add missing specs for BulkUploadController#start Jack S 2023-01-30 17:02:49 +0000
  • 6caa8d1802 Extract time helper methods Jack S 2023-01-30 16:55:14 +0000
  • 81bdd1475c
    CLDC-1780 Bulk upload summary (#1242) Phil Lee 2023-01-30 16:35:23 +0000
  • e916ffda0b refactor with extract method Phil Lee 2023-01-30 16:15:42 +0000
  • 93d79c684d add test for question with min but no max Arthur Campbell 2023-01-30 15:59:08 +0000
  • c59285a110 add bulk upload absolute threshold error rate Phil Lee 2023-01-30 15:47:07 +0000
  • c28f43912e extract magic number to constant Phil Lee 2023-01-30 15:27:11 +0000
  • 1d69d2eb03 bulk upload with 60% errors will not create logs Phil Lee 2023-01-30 15:22:43 +0000
  • 648e344af6
    CLDC-1786 add validations for staircasing transaction (#1235) v0.2.36 Arthur Campbell 2023-01-30 14:58:38 +0000
  • bc07936bd4 fix tests and ensure schema correct after rebase Arthur Campbell 2023-01-30 14:36:32 +0000
  • e67789e397 fix form handler test after rebase Arthur Campbell 2023-01-27 10:46:20 +0000
  • 6e91f1982d ensure schema correct and test of page number correct Arthur Campbell 2023-01-26 17:20:16 +0000
  • 938020e481 fix rebase conflicts Arthur Campbell 2023-01-26 17:10:45 +0000
  • 8b5533bc00 remove duplicate method and use existing version Arthur Campbell 2023-01-26 09:38:12 +0000
  • ef90eef644 add compound validation to ensure that logs of type older person shared ownership may not have a stairbought value of greater than 75% \n associated tests included Arthur Campbell 2023-01-25 17:21:31 +0000
  • a08c1f27a1 add hard validation that percentage owned after a staircasing transaction cannot be less than the percentage bought in that transaction, with associated tests Arthur Campbell 2023-01-25 16:40:47 +0000
  • d7ae2fa3cf fix rebase conflicts Arthur Campbell 2023-01-26 17:09:04 +0000
  • 2acc3bd54a change percent to % so that suffix is consistent with other similar questions Arthur Campbell 2023-01-25 14:10:28 +0000
  • 65b1533aba
    CLDC-1464 Add completion date validations (#1232) natdeanlewissoftwire 2023-01-30 13:33:43 +0000
  • 8fd31f3bfb
    CLDC-886 add validations for discounts (#1214) Arthur Campbell 2023-01-30 13:18:36 +0000
  • fb48453063 fix test and ensure schema correct after rebase Arthur Campbell 2023-01-30 13:10:15 +0000
  • 82c924eed9 fix tests after rebasing Arthur Campbell 2023-01-27 11:12:19 +0000
  • f2f63451b9 amend tests after rebasing Arthur Campbell 2023-01-26 16:47:45 +0000
  • 9f1ac16bc2 remove hard validation of range for discount question and allow shared validation of numeric questions to handle this case Arthur Campbell 2023-01-26 11:38:21 +0000
  • 2db9d9f9f3 add mortgage to derived variables so that mortgage value is set to 0 if a mortgage is not being used in the sale Arthur Campbell 2023-01-24 18:09:48 +0000
  • fb60ea4f7e alter order of before validation methods on sales log so that derived fields are calculated after invalidated dependent fields are cleared, fix tests broken by this change Arthur Campbell 2023-01-24 17:52:27 +0000
  • 02c918398c Update config/locales/en.yml Arthur Campbell 2023-01-24 11:51:45 +0000
  • 83e434dc8f fix rebase conflicts Arthur Campbell 2023-01-26 16:06:19 +0000
  • 694df30a61 remove comment Arthur Campbell 2023-01-23 14:42:21 +0000
  • 35f9ca3ff3 fix rebase conflicts Arthur Campbell 2023-01-26 16:06:07 +0000
  • d4ce51e155 fix rebase conflicts Arthur Campbell 2023-01-26 16:05:42 +0000
  • 10a050e261 implement before validation check to ensure that if the user declares no mortgage will be used, mortgage value is set to 0 Arthur Campbell 2023-01-23 12:11:02 +0000
  • 98512a311a fix rebase conflicts Arthur Campbell 2023-01-26 16:05:04 +0000
  • 2a47e776ab fix rebase conflicts Arthur Campbell 2023-01-24 12:44:28 +0000
  • 54e18260e3 fix rebase conflicts Arthur Campbell 2023-01-26 16:04:42 +0000
  • a3f32f7577 fix rebase conflicts Arthur Campbell 2023-01-26 16:03:51 +0000
  • ce4d7cb919 fix rebase conflicts Arthur Campbell 2023-01-24 12:41:35 +0000
  • 5519fd9839 test: update natdeanlewissoftwire 2023-01-20 11:36:55 +0000
  • 4dd73d7685 fix rebase conflicts Arthur Campbell 2023-01-26 16:02:35 +0000
  • 86c30810d7 fix rebase conflicts Arthur Campbell 2023-01-24 12:38:49 +0000
  • b00e0675d0 feat: update validation natdeanlewissoftwire 2023-01-19 10:00:48 +0000
  • 3a436a5e4e fix rebase conflicts Arthur Campbell 2023-01-26 15:59:23 +0000
  • a30503fd90 fix rebase conflicts Arthur Campbell 2023-01-26 15:58:57 +0000
  • 5ae7951527 amend copy on soft validation screen for rent value Arthur Campbell 2023-01-30 12:44:49 +0000
  • 12e496555a do not create logs if a setup section not complete Phil Lee 2023-01-30 12:40:18 +0000
  • 40d9f4dd44 remove duplicate field Kat 2023-01-12 12:06:45 +0000
  • b5b82b704f fix tests Kat 2022-12-16 14:38:19 +0000
  • 33f058cbce Disable the rest of the housing characteristics questions until privacynotice is answered Kat 2022-12-16 12:56:04 +0000
  • 3676545312 Always display privacy notice question Kat 2022-12-16 11:45:36 +0000
  • 98a10cc3ae Display the correct error for privacy notice and display the partial guidance at the top by default Kat 2022-12-16 11:39:39 +0000
  • 2183505030 db: update natdeanlewissoftwire 2023-01-30 12:11:14 +0000
  • b9d3d2b28b Merge branch 'main' into CLDC-1790-sales-validation-content-updates natdeanlewissoftwire 2023-01-30 12:10:57 +0000
  • 877ae74236 create logs iff the log itself is valid Phil Lee 2023-01-30 12:10:47 +0000
  • 2c01612937 feat: update copy natdeanlewissoftwire 2023-01-30 11:59:05 +0000
  • ea58c8ba95
    CLDC-845 Update validation type from hard validation to soft validation (#1224) kosiakkatrina 2023-01-30 11:54:26 +0000
  • 8452c9fab1 feat: use old min/max bedrooms validations natdeanlewissoftwire 2023-01-30 11:47:53 +0000
  • 6f1566bbc1
    Update household section name (#1246) kosiakkatrina 2023-01-30 11:41:33 +0000
  • 21d993a0e4 test: update natdeanlewissoftwire 2023-01-30 11:39:34 +0000
  • 34bff89803 typo Kat 2023-01-30 10:00:59 +0000
  • 9c468f96ba make old_persons_shared_ownership_value_check optional because it's in the setup section Kat 2023-01-27 08:40:07 +0000
  • 6ed6c919c3 update a test Kat 2023-01-26 12:30:52 +0000
  • 308798d799 Add soft validation after ownership type Kat 2023-01-26 12:16:42 +0000
  • f7d52ada89 Add pages to the household characteristics Kat 2023-01-24 12:27:55 +0000
  • da6e7f192e Add old persons shared ownership value check page and question Kat 2023-01-24 12:13:19 +0000