Commit Graph

  • f6b2cc0d8a remove tests that seem to be testing active record and/or ruby Date class Arthur Campbell 2024-05-29 16:00:40 +0100
  • ce333f0591 remove outdated distinction between unitletas mappings from before 23/24 Arthur Campbell 2024-05-29 15:05:01 +0100
  • 7a0e75f19c further refactoring of various tests to reduce database interactions and improve speed Arthur Campbell 2024-05-29 15:03:21 +0100
  • ad2d128cc3 escape . in regex for API call stubs to satisfy codeQL remove destroy_all call at the start of a test that was dealing with leftover modesl in the test db Arthur Campbell 2024-05-23 17:28:57 +0100
  • e0124a1edc remove before(:context) and associated patterns. use assign_attributes in various places for cleaner code Arthur Campbell 2024-05-23 16:57:36 +0100
  • 60c64d60f5 extract a good chunk of tests out of lettings_log_spec and into a dedicated derived fields spec file. in many cases refactor tests Arthur Campbell 2024-05-22 13:49:14 +0100
  • 15dd56dc82 stub api call for factory value, update csv tests and fixtures accordingly Arthur Campbell 2024-05-22 13:49:07 +0100
  • 2ef0b0573c create rent periods in factories as default, with an option to skip. skip automatic creation in tests specifically related to rent periods Arthur Campbell 2024-05-22 13:21:46 +0100
  • 878b66f283 revert mistaken copy changes in designs Arthur Campbell 2024-05-02 18:25:43 +0100
  • e51bc3df08 rake task to create rent period associations for orgs that have none Arthur Campbell 2024-05-02 18:13:54 +0100
  • 6d9a6020f4 update validation to reflect the fact that an org having no associated rent periods no longer means they accept all rent periods update tests adding both cases and removing unnecessary additional db additions Arthur Campbell 2024-05-02 17:11:18 +0100
  • 65cf2337bc disable checkboxes for rent periods if they are in use so that users are not able to make existing logs invalid hint text added to the question to explain this I have also added all rent periods to a hidden field to remove the need to fetch them again form the db in the update method Arthur Campbell 2024-05-02 16:53:20 +0100
  • d743faa79d changes following review Arthur Campbell 2024-04-30 13:59:32 +0100
  • ff44c98343 amend failing tests and resolve linting complaints Arthur Campbell 2024-04-26 09:40:28 +0100
  • e6cb76d85b rework the #rent_period_labels method to return All under the correct conditions, rework tests related to that. + fix assorted tests that were either flakey or breaking due to addition of rent periods logic to create and update Arthur Campbell 2024-04-24 14:26:35 +0100
  • b86e126d15 adjust various UI elements: ordering of rows, copy changes, label size and associated tests Arthur Campbell 2024-04-24 14:23:59 +0100
  • cc4ff102fd alter redirect after support user creates an organisation Arthur Campbell 2024-04-24 14:14:21 +0100
  • 2616eb8ece enable updating org rent periods update logic in #update related tests Arthur Campbell 2024-04-23 16:09:31 +0100
  • 4933473ec4 enable editing rent period in the UI display change button on org details page display rent periods question on edit page Arthur Campbell 2024-04-23 16:08:28 +0100
  • f7251583fa small changes to models Arthur Campbell 2024-04-19 15:23:04 +0100
  • f9a4653e53 update new and create in organisations controller and view to enable creation of relevant organisation rent periods write tests for this Arthur Campbell 2024-04-19 15:18:03 +0100
  • cce984908c write helper method to support having the correct rent period checkboxes checked Arthur Campbell 2024-04-19 13:35:18 +0100
  • f8d5f8c4e7 Fix joint purchase field numbers for 2023 Rachael Booth 2024-05-23 15:13:50 +0100
  • 5435dbb83d Empty Kat 2024-05-23 10:33:03 +0100
  • 3eb56c4fc0
    Only display users/orgs if they are valid filter options (#2436) v0.4.45 kosiakkatrina 2024-05-23 09:10:32 +0100
  • 84d45e5719 Only display users/orgs if they are valid filter options Kat 2024-05-23 08:38:12 +0100
  • 34ac8aeec3
    add in missing div close (#2435) v0.4.44 Arthur Campbell 2024-05-22 17:44:51 +0100
  • fab5ba3c0b add in missing div close Arthur Campbell 2024-05-22 17:22:35 +0100
  • 3a5b210da5
    Display correct assigned to user in CSV filters (#2433) kosiakkatrina 2024-05-22 17:21:34 +0100
  • 124791d183 add in missing div close CLDC-3414-update-homepage Arthur Campbell 2024-05-22 17:18:28 +0100
  • 8c1ac0fcb6 Display correct assigned to user in CSV filters Kat 2024-05-22 16:59:25 +0100
  • 47378cf7df
    CLDC 3414 update homepage (#2408) v0.4.43 Arthur Campbell 2024-05-22 11:53:19 +0100
  • 4903630079 resolve rebase confusion in csv fixture files Arthur Campbell 2024-05-22 10:18:20 +0100
  • 570a4dd31c logs assigned to a provider should be vivisble to them in the homepage count rather than logs created by them Arthur Campbell 2024-05-21 13:35:55 +0100
  • f60d12c767 various minor changes following tech review Arthur Campbell 2024-05-16 08:58:16 +0100
  • 2844c6b054 make corrections following rebase conflicts Arthur Campbell 2024-05-15 14:55:59 +0100
  • 5e4ce6790c undo unnecessary change to factory Arthur Campbell 2024-05-15 11:04:43 +0100
  • b6d04492f4 write request specs for the homepage Arthur Campbell 2024-05-15 10:36:16 +0100
  • 1d85822bc8 amend presenter and associated calls from view, tests, to ensure support user always sees sales data Arthur Campbell 2024-05-15 10:36:04 +0100
  • 7aa95d3fa5 remove view helpers that are no longer being used and remove outdated tests for home page Arthur Campbell 2024-05-14 11:10:50 +0100
  • e92d77f037 adjust tests and factories and address api call stub Arthur Campbell 2024-05-14 09:56:56 +0100
  • 6f92caef71 redesign the home page using the new presenter and partials, deliver the presenter object to the view from the controller Arthur Campbell 2024-05-13 14:12:50 +0100
  • e21b799b56 view partial changes to accommodate design changes, decouple box with counter and blue link boxes since various boxes show or not or in a different order depending on whether the org logs sales and whether we are in the crossover period I have also made grid and row partials to improve readability on the index page. Arthur Campbell 2024-05-13 14:12:14 +0100
  • 10ef59ccbd create presenter class to hold all the db calls and data for showing the home page plus tests, some changes to factoreis and helpers necessary this should avoid an overly bloated controller method or calling the DB from a view helper Arthur Campbell 2024-05-13 14:06:54 +0100
  • b8028c1413
    Merge branch 'main' into BuBuyerOrPerson2 Rachael Booth 2024-05-22 09:50:13 +0100
  • 4c84896523 CLDC-3460: Don't validate P2 not child in BU when not a joint purchase Rachael Booth 2024-05-22 09:49:24 +0100
  • 5c34132049
    Fix CSV downloads for specific organisations (#2430) v0.4.42 kosiakkatrina 2024-05-21 18:08:54 +0100
  • 31f19f098b Fix CSV downloads for specific organisations Kat 2024-05-21 15:48:19 +0100
  • 577d99be22 Disable extra borrowing soft validation for 2024 onwards Rachael Booth 2024-05-21 09:31:50 +0100
  • adb3c7be5e
    set busybox version (#2429) v0.4.41 kosiakkatrina 2024-05-20 16:36:56 +0100
  • 026a59d3e2 set busybox version Kat 2024-05-20 16:14:44 +0100
  • fcca10e5e5 Update docker image Kat 2024-05-20 13:47:22 +0100
  • 0e4950c2cc
    CLDC-3438 Update log csv download flow (#2403) kosiakkatrina 2024-05-20 11:21:53 +0100
  • 1b8d4c05c2 Update tests to use decimal discount Rachael Booth 2024-05-20 10:23:05 +0100
  • 2365e10bad
    Merge branch 'main' into DecimalDiscountPercentages Rachael Booth 2024-05-17 16:00:23 +0100
  • d1a0838e70 CLDC-3447: Allow decimal discount percentage and increased validation tolerance Rachael Booth 2024-05-17 15:58:51 +0100
  • ee2d1a5bbb
    Refactor CSV service (#2425) kosiakkatrina 2024-05-17 13:55:17 +0100
  • 23f85d8763 Extract and more sales methods Kat 2024-05-17 11:07:22 +0100
  • 2f304579eb Extract and move lettings methods Kat 2024-05-17 11:07:14 +0100
  • a8ddc9d52e Remove duplicate rent value check from CSV (#2423) kosiakkatrina 2024-05-17 12:23:09 +0100
  • 5d2235badf CLDC-3442 Download logs csv per year (#2404) kosiakkatrina 2024-05-16 14:01:59 +0100
  • eeb4414061 Update cancel and back buttons Kat 2024-05-16 10:57:06 +0100
  • 146951d9a2 Update missing and wrong copy Kat 2024-05-15 13:59:01 +0100
  • 50ce6c8d71 Update formatted organisations methods Kat 2024-05-13 11:16:39 +0100
  • b6554eb5d6 Redirect if year is not given for sales csv Kat 2024-05-13 11:07:15 +0100
  • 84ea04f428 Refactor check_your_answers_filters_list Kat 2024-05-13 11:06:46 +0100
  • 1f59234723 lint Kat 2024-05-09 14:04:43 +0100
  • 13aa000db3 Update routing from CYA Kat 2024-05-09 13:57:10 +0100
  • 361bd2faa7 Update filtering per organisation Kat 2024-05-09 13:28:30 +0100
  • 3e0681c98c Authenticate pages Kat 2024-05-09 10:34:42 +0100
  • 76e4599f87 Rename methods Kat 2024-05-09 10:15:08 +0100
  • e0b9d249e9 Deduplicate filter views Kat 2024-05-09 09:12:40 +0100
  • 249d87e996 Refactor Kat 2024-05-08 16:08:53 +0100
  • df7aa25572 Set label size on filter questions Kat 2024-05-08 15:59:58 +0100
  • f7da491d77 Update tests Kat 2024-05-08 14:13:24 +0100
  • b7a2776209 Add sales logs filters Kat 2024-05-08 09:41:29 +0100
  • bec3c92b4c Update method name Kat 2024-05-07 16:38:08 +0100
  • 88a601f315 Add removed tests Kat 2024-05-07 16:04:28 +0100
  • 38a91f3d8f Refactor Kat 2024-05-07 15:59:34 +0100
  • ae0fda1e04 Add cancel, conditionally display send email Kat 2024-05-07 14:28:19 +0100
  • c12f28dfe5 Display lettings filters CYA Kat 2024-05-07 10:23:46 +0100
  • f34ccca823 Add remaining filter questions Kat 2024-05-07 10:23:30 +0100
  • ef0bd5f81a Redirect to year filter if it is not selected Kat 2024-05-02 12:30:20 +0100
  • 973f2722af Filter out empty options from selected filters Kat 2024-05-02 12:28:20 +0100
  • 622bc122f3
    Build(deps-dev): bump rexml from 3.2.5 to 3.2.8 in /docs (#2424) kosiakkatrina 2024-05-17 12:22:46 +0100
  • 02211828a2 Bundle update Kat 2024-05-17 09:18:56 +0100
  • d4ecec58aa Build(deps-dev): bump rexml from 3.2.5 to 3.2.8 in /docs Kat 2024-05-17 09:18:44 +0100
  • e880f4fb88 Remove duplicate rent value check from CSV Kat 2024-05-17 08:26:25 +0100
  • d1ce13c8de
    Build(deps-dev): bump rexml from 3.2.5 to 3.2.8 in /docs dependabot[bot] 2024-05-16 20:01:43 +0000
  • cdbeb9dd91
    CLDC-3442 Download logs csv per year (#2404) kosiakkatrina 2024-05-16 14:01:59 +0100
  • 92a44f8cd6
    CLDC-2586 Rename scheme sensitive (#2405) kosiakkatrina 2024-05-16 13:35:23 +0100
  • 94975fc647
    CLDC-3348 Update sales CSV for support (#2407) kosiakkatrina 2024-05-16 13:34:58 +0100
  • 40ac24780d
    CLDC-3347 Show soft validations in support CSVs only (#2406) kosiakkatrina 2024-05-16 13:34:10 +0100
  • 34a50661a7
    CLDC-3352 Update lettings CSV address order (#2409) kosiakkatrina 2024-05-16 13:33:35 +0100
  • 65e1814b42
    CLDC-3352 Update sales CSV address order (#2410) kosiakkatrina 2024-05-16 13:33:13 +0100
  • a560d6e818
    CLDC-3367 Rename sales support CSV fields (#2413) kosiakkatrina 2024-05-16 13:32:20 +0100
  • 7b4c549d23
    CLDC-3415/3421/3422 Add lettings CSV updates (#2415) kosiakkatrina 2024-05-16 13:31:59 +0100
  • af661797d7 Update cancel and back buttons Kat 2024-05-16 10:57:06 +0100
  • 0adebbc992
    Update sales CSV user fields order (#2416) kosiakkatrina 2024-05-16 10:13:23 +0100
  • 78d09a8fe0 Update sales CSV user fields order Kat 2024-05-14 11:34:14 +0100