require "rails_helper" RSpec.describe BulkUpload::Lettings::Year2022::RowParser do subject(:parser) { described_class.new(attributes) } let(:now) { Time.zone.parse("01/03/2023") } let(:attributes) { { bulk_upload: } } let(:bulk_upload) { create(:bulk_upload, :lettings, user:) } let(:user) { create(:user, organisation: owning_org) } let(:owning_org) { create(:organisation, :with_old_visible_id) } let(:managing_org) { create(:organisation, :with_old_visible_id) } let(:scheme) { create(:scheme, :with_old_visible_id, owning_organisation: owning_org) } let(:location) { create(:location, :with_old_visible_id, scheme:) } let(:mock_interruption_ids) {} let(:setup_section_params) do { bulk_upload:, field_1: "2", field_111: owning_org.old_visible_id, field_113: managing_org.old_visible_id, field_96: now.day.to_s, field_97: now.month.to_s, field_98: now.strftime("%g"), field_134: "2", field_132: "1", } end let(:valid_attributes) do { bulk_upload:, field_1: "1", field_4: scheme.old_visible_id, field_7: "123", field_96: now.day.to_s, field_97: now.month.to_s, field_98: now.strftime("%g"), field_108: "EC1N", field_109: "2TD", field_111: owning_org.old_visible_id, field_113: managing_org.old_visible_id, field_130: "1", field_134: "2", field_102: "2", field_103: "1", field_104: "1", field_101: "1", field_133: "2", field_8: "1", field_9: "2", field_132: "1", field_12: "42", field_13: "41", field_14: "20", field_15: "18", field_16: "16", field_17: "14", field_18: "12", field_19: "20", field_20: "F", field_21: "M", field_22: "F", field_23: "M", field_24: "F", field_25: "M", field_26: "F", field_27: "M", field_43: "17", field_44: "18", field_28: "P", field_29: "C", field_30: "X", field_31: "R", field_32: "C", field_33: "C", field_34: "X", field_35: "1", field_36: "2", field_37: "6", field_38: "7", field_39: "8", field_40: "9", field_41: "0", field_42: "10", field_45: "1", field_114: "4", field_46: "1", field_47: "1", field_118: "2", field_55: "1", field_56: "0", field_57: "0", field_58: "1", field_59: "0", field_66: "5", field_67: "2", field_52: "31", field_61: "3", field_68: "12", field_65: "1", field_63: "EC1N", field_64: "2TD", field_69: "1", field_70: "1", field_71: "", field_72: "1", field_73: "", field_74: "", field_75: "1", field_76: "2", field_77: "2", field_78: "2", field_51: "1", field_50: "2000", field_116: "2", field_48: "1", field_49: "1", field_79: "4", field_80: "1234.56", field_87: "1", field_88: "234.56", field_106: "15", field_99: "0", field_89: now.day.to_s, field_90: now.month.to_s, field_91: now.strftime("%g"), } end before do mock_interruption_ids create(:organisation_relationship, parent_organisation: owning_org, child_organisation: managing_org) end around do |example| FormHandler.instance.use_real_forms! example.run FormHandler.instance.use_fake_forms! end describe "#blank_row?" do context "when a new object" do it "returns true" do expect(parser).to be_blank_row end end context "when the only populated fields are whitespace" do before do parser.field_18 = " " end it "returns true" do expect(parser).to be_blank_row end end context "when any field is populated with something other than whitespace" do before do parser.field_1 = "1" end it "returns false" do expect(parser).not_to be_blank_row end end end describe "validations" do before do stub_request(:get, /api.postcodes.io/) .to_return(status: 200, body: "{\"status\":200,\"result\":{\"admin_district\":\"Manchester\", \"codes\":{\"admin_district\": \"E08000003\"}}}", headers: {}) parser.valid? end describe "#valid?" do context "when the row is blank" do let(:attributes) { { bulk_upload: } } it "returns true" do expect(parser).to be_valid end end context "when calling the method multiple times" do let(:attributes) { { bulk_upload:, field_134: 2 } } it "does not add keep adding errors to the pile" do expect { parser.valid? }.not_to change(parser.errors, :count) end end context "when valid row" do before do allow(FeatureToggle).to receive(:bulk_upload_duplicate_log_check_enabled?).and_return(true) end let(:attributes) { valid_attributes } it "returns true" do expect(parser).to be_valid end it "instantiates a log with everything completed", aggregate_failures: true do questions = parser.send(:questions).reject do |q| parser.send(:log).optional_fields.include?(q.id) || q.completed?(parser.send(:log)) end expect(questions.map(&:id).size).to eq(0) expect(questions.map(&:id)).to eql([]) end context "when the log already exists in the db" do before do parser.log.save! parser.instance_variable_set(:@valid, nil) end it "is not a valid row" do expect(parser).not_to be_valid end it "adds an error to all (and only) the fields used to determine duplicates" do parser.valid? error_message = "This is a duplicate log" expected_errors = { field_5: [error_message], # location field_12: [error_message], # age1 field_20: [error_message], # sex1 field_35: [error_message], # ecstat1 field_84: [error_message], # tcharge field_96: [error_message], # startdate field_97: [error_message], # startdate field_98: [error_message], # startdate field_100: [error_message], # propcode field_108: [error_message], # postcode_full field_109: [error_message], # postcode_full field_111: [error_message], # owning_organisation } expect(parser.errors.as_json).to eq(expected_errors) end end context "when a hidden log already exists in db" do before do parser.log.status = "pending" parser.log.skip_update_status = true parser.log.save! end it "is a valid row" do expect(parser).to be_valid end it "does not add duplicate errors" do parser.valid? [ :field_5, # location :field_12, # age1 :field_20, # sex1 :field_35, # ecstat1 :field_84, # tcharge :field_96, # startdate :field_97, # startdate :field_98, # startdate :field_100, # propcode :field_108, # postcode_full :field_109, # postcode_full :field_111, # owning_organisation ].each do |field| expect(parser.errors[field]).to be_blank end end end end end context "when setup section not complete" do let(:attributes) { { bulk_upload:, field_7: "123" } } it "has errors on setup fields" do errors = parser.errors.select { |e| e.options[:category] == :setup }.map(&:attribute).sort expect(errors).to eql(%i[field_1 field_111 field_113 field_132 field_96 field_97 field_98]) end end context "when lettype is intermediate rent and intermediate rent type is not selected" do let(:attributes) { valid_attributes.merge(field_1: "11", field_130: nil) } it "has errors on setup field" do errors = parser.errors.select { |e| e.options[:category] == :setup }.map(&:attribute) expect(errors).to eql(%i[field_130]) end end context "when lettype is affordable rent and affordable rent type is not selected" do let(:attributes) { valid_attributes.merge(field_1: "5", field_130: nil) } it "has errors on setup field" do errors = parser.errors.select { |e| e.options[:category] == :setup }.map(&:attribute) expect(errors).to eql(%i[field_129]) end end describe "#field_1" do context "when null" do let(:attributes) { { bulk_upload:, field_1: nil, field_4: "1" } } it "returns an error" do expect(parser.errors[:field_1]).to be_present end end context "when incorrect data type" do let(:attributes) { { bulk_upload:, field_1: "foo" } } it "returns an error" do expect(parser.errors[:field_1]).to be_present end end context "when unpermitted value" do let(:attributes) { { bulk_upload:, field_1: "101" } } it "returns an error" do expect(parser.errors[:field_1]).to be_present end end context "when valid" do let(:attributes) { { bulk_upload:, field_1: "1" } } it "does not return any errors" do expect(parser.errors[:field_1]).to be_blank end end context "when bulk upload is for general needs" do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, needstype: "1") } context "when general needs option selected" do let(:attributes) { { bulk_upload:, field_1: "1" } } it "is permitted" do expect(parser.errors[:field_1]).to be_blank end end context "when supported housing option selected" do let(:attributes) { { bulk_upload:, field_1: "2" } } it "is not permitted" do expect(parser.errors[:field_1]).to include("Lettings type must be a general needs type because you selected general needs when uploading the file") end end end context "when bulk upload is for supported housing" do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, needstype: "2") } context "when general needs option selected" do let(:attributes) { { bulk_upload:, field_1: "1" } } it "is not permitted" do expect(parser.errors[:field_1]).to include("Lettings type must be a supported housing type because you selected supported housing when uploading the file") end end context "when supported housing option selected" do let(:attributes) { { bulk_upload:, field_1: "2" } } it "is permitted" do expect(parser.errors[:field_1]).to be_blank end end end end describe "#field_4" do # mangement group code context "when nullable not permitted" do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, needstype: 2) } let(:attributes) { { bulk_upload:, field_1: "2", field_4: nil } } it "cannot be nulled" do expect(parser.errors.where(:field_4, category: :setup).map(&:message)).to eql(["You must answer management group code"]) end end context "when nullable permitted" do let(:attributes) { { bulk_upload:, field_1: "1", field_4: nil } } it "can be nulled" do expect(parser.errors[:field_4]).to be_blank end end context "when matching scheme cannot be found" do let(:attributes) { { bulk_upload:, field_1: "1", field_4: "123" } } it "returns an error" do expect(parser.errors.where(:field_4, category: :setup)).to be_present end end context "when scheme belongs to someone else" do let(:other_scheme) { create(:scheme, :with_old_visible_id) } let(:attributes) { { bulk_upload:, field_1: "1", field_4: other_scheme.old_visible_id, field_111: owning_org.old_visible_id } } it "returns an error" do expect(parser.errors.where(:field_4, category: :setup).map(&:message)).to include("This management group code does not belong to your organisation, or any of your stock owners / managing agents") end end context "when scheme belongs to owning org" do let(:scheme) { create(:scheme, :with_old_visible_id, owning_organisation: owning_org) } let(:attributes) { { bulk_upload:, field_1: "1", field_4: scheme.old_visible_id, field_111: owning_org.old_visible_id } } it "does not return an error" do expect(parser.errors[:field_4]).to be_blank end end context "when scheme belongs to managing org" do let(:scheme) { create(:scheme, :with_old_visible_id, owning_organisation: managing_org) } let(:attributes) { { bulk_upload:, field_1: "1", field_4: scheme.old_visible_id, field_113: managing_org.old_visible_id } } it "does not return an error" do expect(parser.errors[:field_4]).to be_blank end end end describe "#field_5" do # scheme code context "when not nullable" do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, needstype: 2) } let(:attributes) { { bulk_upload:, field_1: "2", field_5: nil } } it "cannot be nulled" do expect(parser.errors.where(:field_5, category: :setup).map(&:message)).to eql(["You must answer scheme code"]) end end context "when location does not exist" do let(:scheme) { create(:scheme, :with_old_visible_id, owning_organisation: owning_org) } let(:attributes) do { bulk_upload:, field_1: "1", field_4: scheme.old_visible_id, field_5: "dontexist", field_111: owning_org.old_visible_id, } end it "returns an error" do expect(parser.errors[:field_5]).to be_present end end context "when location exists" do let(:scheme) { create(:scheme, :with_old_visible_id, owning_organisation: owning_org) } let(:attributes) do { bulk_upload:, field_1: "1", field_4: scheme.old_visible_id, field_5: location.old_visible_id, field_111: owning_org.old_visible_id, } end it "does not return an error" do expect(parser.errors[:field_5]).to be_blank end end context "when location exists but not related" do let(:location) { create(:scheme, :with_old_visible_id) } let(:attributes) do { bulk_upload:, field_1: "1", field_4: scheme.old_visible_id, field_5: location.old_visible_id, field_111: owning_org.old_visible_id, } end it "returns as setup error" do expect(parser.errors.where(:field_5, category: :setup).map(&:message)).to eql(["Location could be found with provided scheme code"]) end end end describe "#field_7" do context "when null" do let(:attributes) { { bulk_upload:, field_7: nil } } xit "returns an error" do expect(parser.errors[:field_7]).to be_present end end end describe "#field_10" do context "when field_9 is 3 aka other" do let(:attributes) { { bulk_upload:, field_9: "3" } } xit "returns an error" do expect(parser.errors[:field_10]).to be_present end end end describe "#field_12" do context "when set to a non-sensical value" do let(:attributes) { valid_attributes.merge(field_12: "A", field_35: "1") } it "returns only one error" do expect(parser.errors[:field_12].size).to be(1) end end end describe "#field_14" do # age3 context "when blank but gender given" do let(:attributes) { valid_attributes.merge(field_14: "", field_22: "F") } it "returns an error" do expect(parser.errors[:field_14]).to be_present end end end describe "#field_52" do # leaving reason context "when field_134 is 1 meaning it is a renewal" do context "when field_52 is 40" do let(:attributes) { { bulk_upload:, field_52: "40", field_134: "1" } } it "is permitted" do expect(parser.errors[:field_52]).to be_blank end end context "when field_52 is 42" do let(:attributes) { { bulk_upload:, field_52: "42", field_134: "1" } } it "is permitted" do expect(parser.errors[:field_52]).to be_blank end end context "when field_52 is not 40 or 42" do let(:attributes) { { bulk_upload:, field_52: "1", field_134: "1" } } it "is not permitted" do expect(parser.errors[:field_52]).to be_present end end context "when not a valid option" do let(:attributes) { setup_section_params.merge({ bulk_upload:, field_52: "99" }) } it "has error for invalid option" do expect(parser.errors[:field_52]).to include("Enter a valid value for What is the tenant's main reason for the household leaving their last settled home?") end end end end describe "#field_55, #field_56, #field_57" do context "when one item selected" do let(:attributes) { { bulk_upload:, field_55: "1" } } it "is permitted" do expect(parser.errors[:field_55]).to be_blank expect(parser.errors[:field_56]).to be_blank expect(parser.errors[:field_57]).to be_blank end end context "when more than one item selected" do let(:attributes) { { bulk_upload:, field_55: "1", field_56: "1" } } it "is not permitted" do expect(parser.errors[:field_55]).to be_present expect(parser.errors[:field_56]).to be_present end end end describe "#field_59" do context "when 1 and another disability field selected" do let(:attributes) { { bulk_upload:, field_59: "1", field_58: "1" } } it "is not permitted" do expect(parser.errors[:field_59]).to be_present end end end describe "#field_60" do context "when 1 and another disability field selected" do let(:attributes) { { bulk_upload:, field_60: "1", field_58: "1" } } it "is not permitted" do expect(parser.errors[:field_60]).to be_present end end end describe "#field_59, #field_60" do context "when both 1" do let(:attributes) { { bulk_upload:, field_59: "1", field_60: "1" } } it "is not permitted" do expect(parser.errors[:field_59]).to be_present expect(parser.errors[:field_60]).to be_present end end end describe "#field_68 - 74" do context "when not homeless but reasonable preference for homelessness" do let(:attributes) { { bulk_upload:, field_68: "1", field_69: "1", field_70: "1" } } it "is not permitted" do expect(parser.errors[:field_70]).to be_present end end context "when there is a reasonable preference but none is given" do let(:attributes) { { bulk_upload:, field_69: "1", field_70: nil, field_71: nil, field_72: nil, field_73: nil, field_74: nil } } it "is not permitted" do expect(parser.errors[:field_70]).to be_present expect(parser.errors[:field_71]).to be_present expect(parser.errors[:field_72]).to be_present expect(parser.errors[:field_73]).to be_present expect(parser.errors[:field_74]).to be_present end end end describe "#field_78" do # referral context "when 3 ie PRP nominated by LA and owning org is LA" do let(:attributes) { { bulk_upload:, field_78: "3", field_111: owning_org.old_visible_id } } it "is not permitted" do expect(parser.errors[:field_78]).to be_present end end context "when 4 ie referred by LA and is general needs and owning org is LA" do let(:attributes) { { bulk_upload:, field_78: "4", field_111: owning_org.old_visible_id.to_s } } it "is not permitted" do expect(parser.errors[:field_78]).to be_present end end context "when 4 ie referred by LA and is general needs and owning org is PRP" do let(:owning_org) { create(:organisation, :prp, :with_old_visible_id) } let(:attributes) { { bulk_upload:, field_78: "4", field_111: owning_org.old_visible_id.to_s } } it "is permitted" do expect(parser.errors[:field_78]).to be_blank end end context "when 4 ie referred by LA and is not general needs" do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, needstype: 2) } let(:attributes) { { bulk_upload:, field_78: "4" } } it "is permitted" do expect(parser.errors[:field_78]).to be_blank end end end describe "#field_85" do let(:bulk_upload) { create(:bulk_upload, :lettings, user:, needstype: "2") } context "when care home charge is given" do let(:attributes) { valid_attributes.merge(field_85: "100") } it "sets is carehome to yes and saves the charge" do expect(parser.log.is_carehome).to eq(1) expect(parser.log.chcharge).to eq(100) end end context "when care home charge is not given" do let(:attributes) { valid_attributes.merge(field_85: nil) } it "sets is carehome to no and does not save the charge" do expect(parser.log.is_carehome).to eq(0) expect(parser.log.chcharge).to be_nil end end end describe "fields 96, 97, 98 => startdate" do context "when all of these fields are blank" do let(:attributes) { { bulk_upload:, field_1: "1", field_96: nil, field_97: nil, field_98: nil } } it "returns them as setup errors" do expect(parser.errors.where(:field_96, category: :setup)).to be_present expect(parser.errors.where(:field_97, category: :setup)).to be_present expect(parser.errors.where(:field_98, category: :setup)).to be_present end end context "when one of these fields is blank", aggregate_failures: true do let(:attributes) { { bulk_upload:, field_1: "1", field_96: "1", field_97: "1", field_98: nil } } it "returns an error only on blank field" do expect(parser.errors.where(:field_96, category: :setup)).to be_blank expect(parser.errors.where(:field_97, category: :setup)).to be_blank expect(parser.errors.where(:field_98).map(&:message)).to eql(["You must answer tenancy start date (year)"]) expect(parser.errors.where(:field_98, category: :setup).map(&:message)).to eql(["You must answer tenancy start date (year)"]) end end context "when field 98 is 4 digits instead of 2" do let(:attributes) { { bulk_upload:, field_98: "2022" } } it "returns an error" do expect(parser.errors.where(:field_98, category: :setup).map(&:message)).to include("Tenancy start year must be 2 digits") end end context "when invalid date given" do let(:attributes) { { bulk_upload:, field_1: "1", field_96: "a", field_97: "12", field_98: "2022" } } it "does not raise an error" do expect { parser.valid? }.not_to raise_error end end context "when inside of collection year" do let(:attributes) { { bulk_upload:, field_96: "1", field_97: "10", field_98: "22" } } let(:bulk_upload) { create(:bulk_upload, :lettings, user:, year: 2022) } it "does not return errors" do expect(parser.errors[:field_96]).not_to be_present expect(parser.errors[:field_97]).not_to be_present expect(parser.errors[:field_98]).not_to be_present end end context "when outside of collection year" do around do |example| Timecop.freeze(Date.new(2022, 4, 2)) do example.run end Timecop.return end let(:attributes) { { bulk_upload:, field_96: "1", field_97: "1", field_98: "22" } } let(:bulk_upload) { create(:bulk_upload, :lettings, user:, year: 2022) } it "returns errors" do expect(parser.errors.where(:field_96, category: :setup)).to be_present expect(parser.errors.where(:field_97, category: :setup)).to be_present expect(parser.errors.where(:field_98, category: :setup)).to be_present end end end describe "#field_103" do context "when null" do let(:attributes) { setup_section_params.merge({ field_103: nil }) } it "returns an error" do expect(parser.errors[:field_103]).to be_present end it "populates with correct error message" do expect(parser.errors[:field_103]).to eql(["You must answer type of building"]) end end end describe "#field_111" do # owning org context "when no data given" do let(:attributes) { { bulk_upload:, field_1: "1", field_111: "" } } it "is not permitted as setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } expect(setup_errors.find { |e| e.attribute == :field_111 }.message).to eql("You must answer owning organisation") end it "blocks log creation" do expect(parser).to be_block_log_creation end end context "when cannot find owning org" do let(:attributes) { { bulk_upload:, field_111: "donotexist" } } it "is not permitted as a setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } expect(setup_errors.find { |e| e.attribute == :field_111 }.message).to eql("The owning organisation code is incorrect") end it "blocks log creation" do expect(parser).to be_block_log_creation end end context "when org is not stock owning" do let(:owning_org) { create(:organisation, :with_old_visible_id, :does_not_own_stock) } let(:attributes) { { bulk_upload:, field_111: owning_org.old_visible_id } } it "is not permitted as a setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } expect(setup_errors.find { |e| e.attribute == :field_111 }.message).to eql("The owning organisation code provided is for an organisation that does not own stock") end it "blocks log creation" do expect(parser).to be_block_log_creation end end context "when not affiliated with owning org" do let(:unaffiliated_org) { create(:organisation, :with_old_visible_id) } let(:attributes) { { bulk_upload:, field_111: unaffiliated_org.old_visible_id } } it "is not permitted as setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } expect(setup_errors.find { |e| e.attribute == :field_111 }.message).to eql("You do not have permission to add logs for this owning organisation") end it "blocks log creation" do expect(parser).to be_block_log_creation end end end describe "#field_112" do # username for created_by context "when blank" do let(:attributes) { { bulk_upload:, field_112: "", field_4: 1 } } it "is permitted" do expect(parser.errors[:field_112]).to be_blank end end context "when user could not be found" do let(:attributes) { { bulk_upload:, field_112: "idonotexist@example.com" } } it "is not permitted" do expect(parser.errors[:field_112]).to be_present end end context "when an unaffiliated user" do let(:other_user) { create(:user) } let(:attributes) { { bulk_upload:, field_111: owning_org.old_visible_id, field_112: other_user.email, field_113: managing_org.old_visible_id } } it "is not permitted" do expect(parser.errors[:field_112]).to be_present end it "blocks log creation" do expect(parser).to be_block_log_creation end end context "when an user part of owning org" do let(:other_user) { create(:user, organisation: owning_org) } let(:attributes) { { bulk_upload:, field_111: owning_org.old_visible_id, field_112: other_user.email, field_113: managing_org.old_visible_id } } it "is permitted" do expect(parser.errors[:field_112]).to be_blank end end context "when an user part of managing org" do let(:other_user) { create(:user, organisation: managing_org) } let(:attributes) { { bulk_upload:, field_111: owning_org.old_visible_id, field_112: other_user.email, field_113: managing_org.old_visible_id } } it "is permitted" do expect(parser.errors[:field_112]).to be_blank end end end describe "#field_113" do # managing org context "when blank" do let(:attributes) { setup_section_params.merge(field_113: nil) } it "is not permitted as setup error" do expect(parser.errors.where(:field_113, category: :setup).map(&:message)).to eql(["You must answer managing organisation"]) end it "blocks log creation" do expect(parser).to be_block_log_creation end end context "when cannot find managing org" do let(:attributes) { { bulk_upload:, field_113: "donotexist" } } it "is not permitted as setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } expect(setup_errors.find { |e| e.attribute == :field_113 }.message).to eql("The managing organisation code is incorrect") end it "blocks log creation" do expect(parser).to be_block_log_creation end end context "when not affiliated with managing org" do let(:unaffiliated_org) { create(:organisation, :with_old_visible_id) } let(:attributes) { { bulk_upload:, field_111: owning_org.old_visible_id, field_113: unaffiliated_org.old_visible_id } } it "is not permitted as setup error" do setup_errors = parser.errors.select { |e| e.options[:category] == :setup } expect(setup_errors.find { |e| e.attribute == :field_113 }.message).to eql("This managing organisation does not have a relationship with the owning organisation") end it "blocks log creation" do expect(parser).to be_block_log_creation end end end describe "#field_118, field_119 - 128" do context "when no illness but illnesses answered" do let(:attributes) { { bulk_upload:, field_118: "2", field_119: "1", field_120: "1", field_121: "1" } } it "errors added to correct fields" do expect(parser.errors[:field_119]).to be_present expect(parser.errors[:field_120]).to be_present expect(parser.errors[:field_121]).to be_present expect(parser.errors[:field_122]).not_to be_present expect(parser.errors[:field_123]).not_to be_present expect(parser.errors[:field_124]).not_to be_present expect(parser.errors[:field_125]).not_to be_present expect(parser.errors[:field_126]).not_to be_present expect(parser.errors[:field_127]).not_to be_present expect(parser.errors[:field_128]).not_to be_present end end context "when illness but no illnesses answered" do let(:attributes) { { bulk_upload:, field_118: "1", field_119: nil, field_120: nil, field_121: nil, field_122: nil, field_123: nil, field_124: nil, field_125: nil, field_126: nil, field_127: nil, field_128: nil } } it "errors added to correct fields" do expect(parser.errors[:field_119]).to be_present expect(parser.errors[:field_120]).to be_present expect(parser.errors[:field_121]).to be_present expect(parser.errors[:field_122]).to be_present expect(parser.errors[:field_123]).to be_present expect(parser.errors[:field_124]).to be_present expect(parser.errors[:field_125]).to be_present expect(parser.errors[:field_126]).to be_present expect(parser.errors[:field_127]).to be_present expect(parser.errors[:field_128]).to be_present end end end describe "#field_134" do # renewal context "when none possible option selected" do let(:attributes) { setup_section_params.merge({ field_134: "101" }) } it "adds a setup error" do expect(parser.errors.where(:field_134, category: :setup).map(&:message)).to include("Enter a valid value for Is this letting a renewal?") end end end describe "#field_55 - #field_60" do context "when all blank" do let(:attributes) { setup_section_params.merge({ field_55: nil, field_56: nil, field_57: nil, field_58: nil, field_59: nil, field_60: nil }) } it "adds errors to correct fields" do expect(parser.errors[:field_55]).to be_present expect(parser.errors[:field_56]).to be_present expect(parser.errors[:field_57]).to be_present expect(parser.errors[:field_58]).to be_present expect(parser.errors[:field_59]).to be_present end end end describe "soft validations" do context "when soft validation is triggered" do let(:attributes) { setup_section_params.merge({ field_12: 22, field_35: 5 }) } it "adds an error to the relevant fields" do expect(parser.errors.where(:field_12, category: :soft_validation)).to be_present expect(parser.errors.where(:field_35, category: :soft_validation)).to be_present end it "populates with correct error message" do expect(parser.errors.where(:field_12, category: :soft_validation).first.message).to eql("You told us this person is aged 22 years and retired.") expect(parser.errors.where(:field_35, category: :soft_validation).first.message).to eql("You told us this person is aged 22 years and retired.") end end context "when a soft validation is triggered that relates both to fields that are and are not routed to" do let(:attributes) { setup_section_params.merge({ field_47: "1", field_20: "M", field_21: "M" }) } it "adds errors to fields that are routed to" do expect(parser.errors.where(:field_20, category: :soft_validation)).to be_present expect(parser.errors.where(:field_21, category: :soft_validation)).to be_present end it "does not add errors to fields that are not routed to" do expect(parser.errors.where(:field_22, category: :soft_validation)).not_to be_present expect(parser.errors.where(:field_23, category: :soft_validation)).not_to be_present end end context "when soft validation is triggered and the mappings for errors are not defined" do let(:attributes) { setup_section_params.merge({ field_12: 22, field_35: 5 }) } let(:mock_interruption_ids) { allow_any_instance_of(Form::Page).to receive(:interruption_screen_question_ids).and_return(%w[fake_question_id]) } # rubocop:disable RSpec/AnyInstance it "does not crash" do expect(parser.errors).to be_present end end end end describe "#log" do describe "#created_by" do context "when blank" do let(:attributes) { setup_section_params } it "takes the user that is uploading" do expect(parser.log.created_by).to eql(bulk_upload.user) end end context "when email specified" do let(:other_user) { create(:user, organisation: owning_org) } let(:attributes) { setup_section_params.merge(field_112: other_user.email) } it "sets to user with specified email" do expect(parser.log.created_by).to eql(other_user) end end end [ %w[age1_known age1 field_12], %w[age2_known age2 field_13], %w[age3_known age3 field_14], %w[age4_known age4 field_15], %w[age5_known age5 field_16], %w[age6_known age6 field_17], %w[age7_known age7 field_18], %w[age8_known age8 field_19], ].each do |known, age, field| describe "##{known} and ##{age}" do context "when #{field} is blank" do let(:attributes) { { bulk_upload:, field.to_s => nil, field_4: 1 } } it "sets ##{known} 1" do expect(parser.log.public_send(known)).to be(1) end it "sets ##{age} to nil" do expect(parser.log.public_send(age)).to be_nil end end context "when #{field} is R" do let(:attributes) { { bulk_upload:, field.to_s => "R" } } it "sets ##{known} 1" do expect(parser.log.public_send(known)).to be(1) end it "sets ##{age} to nil" do expect(parser.log.public_send(age)).to be_nil end end context "when #{field} is a number" do let(:attributes) { { bulk_upload:, field.to_s => "50" } } it "sets ##{known} to 0" do expect(parser.log.public_send(known)).to be(0) end it "sets ##{age} to given age" do expect(parser.log.public_send(age)).to be(50) end end context "when #{field} is a non-sensical value" do let(:attributes) { { bulk_upload:, field.to_s => "A" } } it "sets ##{known} to 0" do expect(parser.log.public_send(known)).to be(0) end it "sets ##{age} to nil" do expect(parser.log.public_send(age)).to be_nil end end end end describe "#location" do context "when lookup is via new core id" do let(:attributes) { { bulk_upload:, field_4: scheme.old_visible_id, field_5: location.id, field_111: owning_org } } it "assigns the correct location" do expect(parser.log.location).to eql(location) end end end describe "#scheme" do context "when lookup is via id prefixed with S" do let(:attributes) { { bulk_upload:, field_4: "S#{scheme.id}", field_111: owning_org } } it "assigns the correct scheme" do expect(parser.log.scheme).to eql(scheme) end end end describe "#owning_organisation" do context "when lookup is via id prefixed with ORG" do let(:attributes) { { bulk_upload:, field_111: "ORG#{owning_org.id}" } } it "assigns the correct org" do expect(parser.log.owning_organisation).to eql(owning_org) end end end describe "#managing_organisation" do context "when lookup is via id prefixed with ORG" do let(:attributes) { { bulk_upload:, field_113: "ORG#{managing_org.id}" } } it "assigns the correct org" do expect(parser.log.managing_organisation).to eql(managing_org) end end end describe "#cbl" do context "when field_75 is yes ie 1" do let(:attributes) { { bulk_upload:, field_75: 1 } } it "sets value to 1" do expect(parser.log.cbl).to be(1) end end context "when field_75 is no ie 2" do let(:attributes) { { bulk_upload:, field_75: 2 } } it "sets value to 0" do expect(parser.log.cbl).to be(0) end end end describe "#chr" do context "when field_76 is yes ie 1" do let(:attributes) { { bulk_upload:, field_76: 1 } } it "sets value to 1" do expect(parser.log.chr).to be(1) end end context "when field_76 is no ie 2" do let(:attributes) { { bulk_upload:, field_76: 2 } } it "sets value to 0" do expect(parser.log.chr).to be(0) end end end describe "#cap" do context "when field_77 is yes ie 1" do let(:attributes) { { bulk_upload:, field_77: 1 } } it "sets value to 1" do expect(parser.log.cap).to be(1) end end context "when field_77 is no ie 2" do let(:attributes) { { bulk_upload:, field_77: 2 } } it "sets value to 0" do expect(parser.log.cap).to be(0) end end end describe "#letting_allocation_unknown" do context "when field_75, 76, 77 are no ie 2" do let(:attributes) { { bulk_upload:, field_75: 2, field_76: 2, field_77: 2 } } it "sets value to 1" do expect(parser.log.letting_allocation_unknown).to be(1) end end context "when any one of field_75, 76, 77 is yes ie 1" do let(:attributes) { { bulk_upload:, field_75: 1 } } it "sets value to 0" do expect(parser.log.letting_allocation_unknown).to be(0) end end end describe "#renewal" do context "when field_134 is no ie 2" do let(:attributes) { { bulk_upload:, field_134: 2 } } it "sets value to 0" do expect(parser.log.renewal).to eq(0) end end context "when field_134 is null but rsnvac/field_106 is 14" do let(:attributes) { { bulk_upload:, field_134: "", field_106: "14" } } it "sets renewal to 1" do expect(parser.log.renewal).to eq(1) end end end describe "#sexN fields" do let(:attributes) do { bulk_upload:, field_20: "F", field_21: "M", field_22: "X", field_23: "R", field_24: "F", field_25: "M", field_26: "X", field_27: "R", } end it "sets value from correct mapping" do expect(parser.log.sex1).to eql("F") expect(parser.log.sex2).to eql("M") expect(parser.log.sex3).to eql("X") expect(parser.log.sex4).to eql("R") expect(parser.log.sex5).to eql("F") expect(parser.log.sex6).to eql("M") expect(parser.log.sex7).to eql("X") expect(parser.log.sex8).to eql("R") end end describe "#ecstatN fields" do let(:attributes) do { bulk_upload:, field_35: "1", field_36: "2", field_37: "6", field_38: "7", field_39: "8", field_40: "9", field_41: "0", field_42: "10", } end it "sets value from correct mapping", aggregate_failures: true do expect(parser.log.ecstat1).to eq(1) expect(parser.log.ecstat2).to eq(2) expect(parser.log.ecstat3).to eq(6) expect(parser.log.ecstat4).to eq(7) expect(parser.log.ecstat5).to eq(8) expect(parser.log.ecstat6).to eq(9) expect(parser.log.ecstat7).to eq(0) expect(parser.log.ecstat8).to eq(10) end end describe "#relatN fields" do let(:attributes) do { bulk_upload:, field_28: "P", field_29: "C", field_30: "X", field_31: "R", field_32: "P", field_33: "C", field_34: "X", } end it "sets value from correct mapping", aggregate_failures: true do expect(parser.log.relat2).to eq("P") expect(parser.log.relat3).to eq("C") expect(parser.log.relat4).to eq("X") expect(parser.log.relat5).to eq("R") expect(parser.log.relat6).to eq("P") expect(parser.log.relat7).to eq("C") expect(parser.log.relat8).to eq("X") end end describe "#net_income_known" do context "when 1" do let(:attributes) { { bulk_upload:, field_51: "1" } } it "sets value from correct mapping" do expect(parser.log.net_income_known).to eq(0) end end context "when 2" do let(:attributes) { { bulk_upload:, field_51: "2" } } it "sets value from correct mapping" do expect(parser.log.net_income_known).to eq(1) end end context "when 3" do let(:attributes) { { bulk_upload:, field_51: "3" } } it "sets value from correct mapping" do expect(parser.log.net_income_known).to eq(1) end end context "when 4" do let(:attributes) { { bulk_upload:, field_51: "4" } } it "sets value from correct mapping" do expect(parser.log.net_income_known).to eq(2) end end end describe "#unitletas" do let(:attributes) { { bulk_upload:, field_105: "1" } } it "sets value from correct mapping" do expect(parser.log.unitletas).to eq(1) end end describe "#rsnvac" do let(:attributes) { { bulk_upload:, field_106: "5" } } it "sets value from correct mapping" do expect(parser.log.rsnvac).to eq(5) end end describe "#sheltered" do let(:attributes) { { bulk_upload:, field_117: "1" } } it "sets value from correct mapping" do expect(parser.log.sheltered).to eq(1) end end describe "illness fields" do mapping = [ { attribute: :illness_type_1, field: :field_119 }, { attribute: :illness_type_2, field: :field_120 }, { attribute: :illness_type_3, field: :field_121 }, { attribute: :illness_type_4, field: :field_122 }, { attribute: :illness_type_5, field: :field_123 }, { attribute: :illness_type_6, field: :field_124 }, { attribute: :illness_type_7, field: :field_125 }, { attribute: :illness_type_8, field: :field_126 }, { attribute: :illness_type_9, field: :field_127 }, { attribute: :illness_type_10, field: :field_128 }, ] mapping.each do |hash| describe "##{hash[:attribute]}" do context "when yes" do let(:attributes) { { bulk_upload:, hash[:field] => "1" } } it "sets value from correct mapping" do expect(parser.log.public_send(hash[:attribute])).to eq(1) end end context "when no" do let(:attributes) { { bulk_upload:, hash[:field] => "", field_4: 1 } } it "sets value from correct mapping" do expect(parser.log.public_send(hash[:attribute])).to be_nil end end end end end describe "#irproduct_other" do let(:attributes) { { bulk_upload:, field_131: "some other product" } } it "sets value to given free text string" do expect(parser.log.irproduct_other).to eql("some other product") end end describe "#tenancyother" do let(:attributes) { { bulk_upload:, field_10: "some other tenancy" } } it "sets value to given free text string" do expect(parser.log.tenancyother).to eql("some other tenancy") end end describe "#tenancylength" do let(:attributes) { { bulk_upload:, field_11: "2" } } it "sets value to given free text string" do expect(parser.log.tenancylength).to eq(2) end end describe "#earnings" do let(:attributes) { { bulk_upload:, field_50: "104.50" } } it "rounds to the nearest whole pound" do expect(parser.log.earnings).to eq(105) end end describe "#reasonother" do let(:attributes) { { bulk_upload:, field_53: "some other reason" } } it "sets value to given free text string" do expect(parser.log.reasonother).to eql("some other reason") end end describe "#ppcodenk" do let(:attributes) { { bulk_upload:, field_65: "2" } } it "sets correct value from mapping" do expect(parser.log.ppcodenk).to eq(0) end end describe "#household_charge" do let(:attributes) { { bulk_upload:, field_86: "1" } } it "sets correct value from mapping" do expect(parser.log.household_charge).to eq(1) end end describe "#chcharge" do let(:attributes) { { bulk_upload:, field_85: "123.45" } } it "sets value given" do expect(parser.log.chcharge).to eq(123.45) end end describe "#tcharge" do let(:attributes) { { bulk_upload:, field_84: "123.45" } } it "sets value given" do expect(parser.log.tcharge).to eq(123.45) end end describe "#supcharg" do let(:attributes) { { bulk_upload:, field_83: "123.45" } } it "sets value given" do expect(parser.log.supcharg).to eq(123.45) end end describe "#pscharge" do let(:attributes) { { bulk_upload:, field_82: "123.45" } } it "sets value given" do expect(parser.log.pscharge).to eq(123.45) end end describe "#scharge" do let(:attributes) { { bulk_upload:, field_81: "123.45" } } it "sets value given" do expect(parser.log.scharge).to eq(123.45) end end describe "#offered" do let(:attributes) { { bulk_upload:, field_99: "3" } } it "sets value given" do expect(parser.log.offered).to eq(3) end end describe "#propcode" do let(:attributes) { { bulk_upload:, field_100: "abc123" } } it "sets value given" do expect(parser.log.propcode).to eq("abc123") end end describe "#mrcdate" do context "when valid" do let(:attributes) { { bulk_upload:, field_92: "13", field_93: "12", field_94: "22" } } it "sets value given" do expect(parser.log.mrcdate).to eq(Date.new(2022, 12, 13)) end end context "when invalid" do let(:attributes) { { bulk_upload:, field_92: "13", field_93: "13", field_94: "22" } } it "does not raise an error" do expect { parser.log.mrcdate }.not_to raise_error end end end describe "#majorrepairs" do context "when mrcdate given" do let(:attributes) { { bulk_upload:, field_92: "13", field_93: "12", field_94: "22" } } it "sets #majorrepairs to 1" do expect(parser.log.majorrepairs).to eq(1) end end context "when mrcdate not given" do let(:attributes) { { bulk_upload:, field_92: "", field_93: "", field_94: "", field_4: 1 } } it "sets #majorrepairs to 0" do expect(parser.log.majorrepairs).to eq(0) end end end describe "#voiddate" do context "when valid" do let(:attributes) { { bulk_upload:, field_89: "13", field_90: "12", field_91: "22" } } it "sets value given" do expect(parser.log.voiddate).to eq(Date.new(2022, 12, 13)) end end context "when invalid" do let(:attributes) { { bulk_upload:, field_89: "13", field_90: "13", field_91: "22" } } it "does not raise an error" do expect { parser.log.voiddate }.not_to raise_error end end end describe "#startdate" do let(:attributes) { { bulk_upload:, field_96: now.day.to_s, field_97: now.month.to_s, field_98: now.strftime("%g") } } it "sets value given" do expect(parser.log.startdate).to eq(now) end end describe "#postcode_full" do let(:attributes) { { bulk_upload:, field_108: " EC1N ", field_109: " 2TD " } } it "strips whitespace" do expect(parser.log.postcode_full).to eql("EC1N 2TD") end end describe "#la" do let(:attributes) { { bulk_upload:, field_107: "E07000223" } } it "sets to given value" do expect(parser.log.la).to eql("E07000223") end end describe "#prevloc" do let(:attributes) { { bulk_upload:, field_62: "E07000223" } } it "sets to given value" do expect(parser.log.prevloc).to eql("E07000223") end end describe "#previous_la_known" do context "when known" do let(:attributes) { { bulk_upload:, field_62: "E07000223" } } it "sets to 1" do expect(parser.log.previous_la_known).to eq(1) end end context "when not known" do let(:attributes) { { bulk_upload:, field_62: "", field_4: 1 } } it "sets to 0" do expect(parser.log.previous_la_known).to eq(0) end end end describe "#first_time_property_let_as_social_housing" do context "when field_106 is 15, 16, or 17" do let(:attributes) { { bulk_upload:, field_106: %w[15 16 17].sample } } it "sets to 1" do expect(parser.log.first_time_property_let_as_social_housing).to eq(1) end end context "when field_106 is not 15, 16, or 17" do let(:attributes) { { bulk_upload:, field_106: "1" } } it "sets to 0" do expect(parser.log.first_time_property_let_as_social_housing).to eq(0) end end end describe "#housingneeds" do context "when no disabled needs" do let(:attributes) { { bulk_upload:, field_59: "1" } } it "sets to 2" do expect(parser.log.housingneeds).to eq(2) end end context "when dont know about disabled needs" do let(:attributes) { { bulk_upload:, field_60: "1" } } it "sets to 3" do expect(parser.log.housingneeds).to eq(3) end end context "when housingneeds are given" do let(:attributes) { { bulk_upload:, field_59: "0", field_57: "1", field_58: "1" } } it "sets correct housingneeds" do expect(parser.log.housingneeds).to eq(1) expect(parser.log.housingneeds_type).to eq(2) expect(parser.log.housingneeds_other).to eq(1) end end context "when housingneeds are given and field_59 is nil" do let(:attributes) { { bulk_upload:, field_57: "1", field_58: "1", field_59: nil } } it "sets correct housingneeds" do expect(parser.log.housingneeds).to eq(1) expect(parser.log.housingneeds_type).to eq(2) expect(parser.log.housingneeds_other).to eq(1) end end context "when housingneeds a and b are selected" do let(:attributes) { { bulk_upload:, field_55: "1", field_56: "1" } } it "sets error on housingneeds a and b" do parser.valid? expect(parser.errors[:field_55]).to include("Only one disabled access need: fully wheelchair-accessible housing, wheelchair access to essential rooms or level access housing, can be selected") expect(parser.errors[:field_56]).to include("Only one disabled access need: fully wheelchair-accessible housing, wheelchair access to essential rooms or level access housing, can be selected") expect(parser.errors[:field_57]).to be_blank end end context "when housingneeds a and c are selected" do let(:attributes) { { bulk_upload:, field_55: "1", field_57: "1" } } it "sets error on housingneeds a and c" do parser.valid? expect(parser.errors[:field_55]).to include("Only one disabled access need: fully wheelchair-accessible housing, wheelchair access to essential rooms or level access housing, can be selected") expect(parser.errors[:field_57]).to include("Only one disabled access need: fully wheelchair-accessible housing, wheelchair access to essential rooms or level access housing, can be selected") expect(parser.errors[:field_56]).to be_blank end end context "when housingneeds b and c are selected" do let(:attributes) { { bulk_upload:, field_56: "1", field_57: "1" } } it "sets error on housingneeds b and c" do parser.valid? expect(parser.errors[:field_56]).to include("Only one disabled access need: fully wheelchair-accessible housing, wheelchair access to essential rooms or level access housing, can be selected") expect(parser.errors[:field_57]).to include("Only one disabled access need: fully wheelchair-accessible housing, wheelchair access to essential rooms or level access housing, can be selected") expect(parser.errors[:field_55]).to be_blank end end context "when housingneeds a and g are selected" do let(:attributes) { { bulk_upload:, field_55: "1", field_59: "1" } } it "sets error on housingneeds a and g" do parser.valid? expect(parser.errors[:field_59]).to include("No disabled access needs can’t be selected if you have selected fully wheelchair-accessible housing, wheelchair access to essential rooms, level access housing or other disabled access needs") expect(parser.errors[:field_55]).to include("No disabled access needs can’t be selected if you have selected fully wheelchair-accessible housing, wheelchair access to essential rooms, level access housing or other disabled access needs") expect(parser.errors[:field_56]).to be_blank expect(parser.errors[:field_57]).to be_blank end end context "when only housingneeds g is selected" do let(:attributes) { { bulk_upload:, field_55: "0", field_59: "1" } } it "does not add any housingneeds errors" do parser.valid? expect(parser.errors[:field_59]).to be_blank expect(parser.errors[:field_55]).to be_blank expect(parser.errors[:field_56]).to be_blank expect(parser.errors[:field_57]).to be_blank end end context "when housingneeds a and h are selected" do let(:attributes) { { bulk_upload:, field_55: "1", field_60: "1" } } it "sets error on housingneeds a and h" do parser.valid? expect(parser.errors[:field_60]).to include("Don’t know disabled access needs can’t be selected if you have selected fully wheelchair-accessible housing, wheelchair access to essential rooms, level access housing or other disabled access needs") expect(parser.errors[:field_55]).to include("Don’t know disabled access needs can’t be selected if you have selected fully wheelchair-accessible housing, wheelchair access to essential rooms, level access housing or other disabled access needs") expect(parser.errors[:field_56]).to be_blank expect(parser.errors[:field_57]).to be_blank end end context "when only housingneeds h is selected" do let(:attributes) { { bulk_upload:, field_55: "0", field_60: "1" } } it "does not add any housingneeds errors" do parser.valid? expect(parser.errors[:field_60]).to be_blank expect(parser.errors[:field_55]).to be_blank expect(parser.errors[:field_56]).to be_blank expect(parser.errors[:field_57]).to be_blank end end end describe "#housingneeds_type" do context "when field_55 is 1" do let(:attributes) { { bulk_upload:, field_55: "1" } } it "set to 0" do expect(parser.log.housingneeds_type).to eq(0) end end context "when field_56 is 1" do let(:attributes) { { bulk_upload:, field_56: "1" } } it "set to 1" do expect(parser.log.housingneeds_type).to eq(1) end end context "when field_57 is 1" do let(:attributes) { { bulk_upload:, field_57: "1" } } it "set to 2" do expect(parser.log.housingneeds_type).to eq(2) end end end describe "#housingneeds_other" do context "when field_58 is 1" do let(:attributes) { { bulk_upload:, field_58: "1" } } it "sets to 1" do expect(parser.log.housingneeds_other).to eq(1) end end end end describe "#start_date" do context "when year of 9 is passed to represent 2009" do let(:attributes) { { bulk_upload:, field_96: "1", field_97: "1", field_98: "9" } } it "uses the year 2009" do expect(parser.send(:start_date)).to eql(Date.new(2009, 1, 1)) end end end describe "#spreadsheet_duplicate_hash" do it "returns a hash" do expect(parser.spreadsheet_duplicate_hash).to be_a(Hash) end end describe "#add_duplicate_found_in_spreadsheet_errors" do it "adds errors" do expect { parser.add_duplicate_found_in_spreadsheet_errors }.to change(parser.errors, :size) end end end