You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
408 lines
15 KiB
408 lines
15 KiB
require "rails_helper" |
|
|
|
RSpec.describe Validations::Sales::SaleInformationValidations do |
|
subject(:sale_information_validator) { validator_class.new } |
|
|
|
let(:validator_class) { Class.new { include Validations::Sales::SaleInformationValidations } } |
|
|
|
describe "#validate_practical_completion_date_before_saledate" do |
|
context "when hodate blank" do |
|
let(:record) { build(:sales_log, hodate: nil) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_practical_completion_date_before_saledate(record) |
|
|
|
expect(record.errors).not_to be_present |
|
end |
|
end |
|
|
|
context "when saledate blank" do |
|
let(:record) { build(:sales_log, saledate: nil) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_practical_completion_date_before_saledate(record) |
|
|
|
expect(record.errors).not_to be_present |
|
end |
|
end |
|
|
|
context "when saledate and hodate blank" do |
|
let(:record) { build(:sales_log, hodate: nil, saledate: nil) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_practical_completion_date_before_saledate(record) |
|
|
|
expect(record.errors).not_to be_present |
|
end |
|
end |
|
|
|
context "when hodate before saledate" do |
|
let(:record) { build(:sales_log, hodate: 2.months.ago, saledate: 1.month.ago) } |
|
|
|
it "does not add the error" do |
|
sale_information_validator.validate_practical_completion_date_before_saledate(record) |
|
|
|
expect(record.errors).not_to be_present |
|
end |
|
end |
|
|
|
context "when hodate after saledate" do |
|
let(:record) { build(:sales_log, hodate: 1.month.ago, saledate: 2.months.ago) } |
|
|
|
it "adds error" do |
|
sale_information_validator.validate_practical_completion_date_before_saledate(record) |
|
|
|
expect(record.errors[:hodate]).to be_present |
|
end |
|
end |
|
|
|
context "when hodate == saledate" do |
|
let(:record) { build(:sales_log, hodate: Time.zone.parse("2023-07-01"), saledate: Time.zone.parse("2023-07-01")) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_practical_completion_date_before_saledate(record) |
|
|
|
expect(record.errors[:hodate]).not_to be_present |
|
end |
|
end |
|
end |
|
|
|
describe "#validate_exchange_date" do |
|
context "when exdate blank" do |
|
let(:record) { build(:sales_log, exdate: nil) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_exchange_date(record) |
|
|
|
expect(record.errors[:exdate]).not_to be_present |
|
end |
|
end |
|
|
|
context "when saledate blank" do |
|
let(:record) { build(:sales_log, saledate: nil) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_exchange_date(record) |
|
|
|
expect(record.errors[:exdate]).not_to be_present |
|
end |
|
end |
|
|
|
context "when saledate and exdate blank" do |
|
let(:record) { build(:sales_log, exdate: nil, saledate: nil) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_exchange_date(record) |
|
|
|
expect(record.errors[:exdate]).not_to be_present |
|
end |
|
end |
|
|
|
context "when exdate before saledate" do |
|
let(:record) { build(:sales_log, exdate: 2.months.ago, saledate: 1.month.ago) } |
|
|
|
it "does not add the error" do |
|
sale_information_validator.validate_exchange_date(record) |
|
|
|
expect(record.errors[:exdate]).not_to be_present |
|
end |
|
end |
|
|
|
context "when exdate more than 1 year before saledate" do |
|
let(:record) { build(:sales_log, exdate: 2.years.ago, saledate: 1.month.ago) } |
|
|
|
it "adds error" do |
|
sale_information_validator.validate_exchange_date(record) |
|
|
|
expect(record.errors[:exdate]).to eq( |
|
["Contract exchange date must be less than 1 year before sale completion date"], |
|
) |
|
expect(record.errors[:saledate]).to eq( |
|
["Sale completion date must be less than 1 year after contract exchange date"], |
|
) |
|
end |
|
end |
|
|
|
context "when exdate after saledate" do |
|
let(:record) { build(:sales_log, exdate: 1.month.ago, saledate: 2.months.ago) } |
|
|
|
it "adds error" do |
|
sale_information_validator.validate_exchange_date(record) |
|
|
|
expect(record.errors[:exdate]).to eq( |
|
["Contract exchange date must be before sale completion date"], |
|
) |
|
expect(record.errors[:saledate]).to eq( |
|
["Sale completion date must be after contract exchange date"], |
|
) |
|
end |
|
end |
|
|
|
context "when exdate == saledate" do |
|
let(:record) { build(:sales_log, exdate: Time.zone.parse("2023-07-01"), saledate: Time.zone.parse("2023-07-01")) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_exchange_date(record) |
|
|
|
expect(record.errors[:exdate]).not_to be_present |
|
end |
|
end |
|
end |
|
|
|
describe "#validate_previous_property_unit_type" do |
|
context "when number of bedrooms is <= 1" do |
|
let(:record) { FactoryBot.build(:sales_log, frombeds: 1, fromprop: 2) } |
|
|
|
it "does not add an error if it's a bedsit" do |
|
sale_information_validator.validate_previous_property_unit_type(record) |
|
|
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
|
|
context "when number of bedrooms is > 1" do |
|
let(:record) { FactoryBot.build(:sales_log, frombeds: 2, fromprop: 2) } |
|
|
|
it "does add an error if it's a bedsit" do |
|
sale_information_validator.validate_previous_property_unit_type(record) |
|
expect(record.errors["fromprop"]).to include(I18n.t("validations.sale_information.previous_property_type.property_type_bedsit")) |
|
expect(record.errors["frombeds"]).to include(I18n.t("validations.sale_information.previous_property_type.property_type_bedsit")) |
|
end |
|
end |
|
end |
|
|
|
describe "#validate_discounted_ownership_value" do |
|
context "when sale is on or after 24/25 collection window" do |
|
context "when grant is routed to" do |
|
let(:record) { FactoryBot.build(:sales_log, mortgage: 10_000, deposit: 5_000, value: 30_000, ownershipsch: 2, type: 8, saledate: Time.zone.local(2024, 4, 3)) } |
|
|
|
context "and not provided" do |
|
before do |
|
record.grant = nil |
|
end |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
|
|
context "and is provided" do |
|
it "adds an error if mortgage, deposit and grant total does not equal market value" do |
|
record.grant = 3_000 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
expected_message = ["Mortgage, deposit, and grant total must equal £30,000.00"] |
|
|
|
expect(record.errors[:mortgage]).to eq(expected_message) |
|
expect(record.errors[:deposit]).to eq(expected_message) |
|
expect(record.errors[:grant]).to eq(expected_message) |
|
expect(record.errors[:value]).to eq(expected_message) |
|
expect(record.errors[:discount]).to eq(expected_message) |
|
end |
|
|
|
it "does not add an error if mortgage, deposit and grant total equals market value" do |
|
record.grant = 15_000 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
end |
|
|
|
context "when discount is routed to" do |
|
let(:record) { FactoryBot.build(:sales_log, mortgage: 10_000, deposit: 5_000, value: 30_000, ownershipsch: 2, type: 9, saledate: Time.zone.local(2024, 4, 3)) } |
|
|
|
context "and not provided" do |
|
before do |
|
record.discount = nil |
|
end |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
|
|
context "and is provided" do |
|
it "adds an error if mortgage and deposit total does not equal market value - discount" do |
|
record.discount = 10 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expected_message = ["Mortgage, deposit, and grant total must equal £27,000.00"] |
|
|
|
expect(record.errors[:mortgage]).to eq(expected_message) |
|
expect(record.errors[:deposit]).to eq(expected_message) |
|
expect(record.errors[:grant]).to eq(expected_message) |
|
expect(record.errors[:value]).to eq(expected_message) |
|
expect(record.errors[:discount]).to eq(expected_message) |
|
end |
|
|
|
it "does not add an error if mortgage and deposit total equals market value - discount" do |
|
record.discount = 50 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
end |
|
|
|
context "when neither discount nor grant is routed to" do |
|
let(:record) { FactoryBot.build(:sales_log, mortgage: 10_000, value: 30_000, ownershipsch: 2, type: 29, saledate: Time.zone.local(2024, 4, 3)) } |
|
|
|
it "adds an error if mortgage and deposit total does not equal market value" do |
|
record.deposit = 2_000 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expected_message = ["Mortgage, deposit, and grant total must equal £30,000.00"] |
|
|
|
expect(record.errors[:mortgage]).to eq(expected_message) |
|
expect(record.errors[:deposit]).to eq(expected_message) |
|
expect(record.errors[:grant]).to eq(expected_message) |
|
expect(record.errors[:value]).to eq(expected_message) |
|
expect(record.errors[:discount]).to eq(expected_message) |
|
end |
|
|
|
it "does not add an error if mortgage and deposit total equals market value" do |
|
record.deposit = 20_000 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
|
|
context "when mortgage is routed to" do |
|
let(:record) { FactoryBot.build(:sales_log, mortgageused: 1, deposit: 5_000, grant: 3_000, value: 20_000, discount: 10, ownershipsch: 2, saledate: Time.zone.local(2024, 4, 3)) } |
|
|
|
context "and not provided" do |
|
before do |
|
record.mortgage = nil |
|
end |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
|
|
context "and is provided" do |
|
it "adds an error if mortgage, grant and deposit total does not equal market value - discount" do |
|
record.mortgage = 10 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expected_message = ["Mortgage, deposit, and grant total must equal £18,000.00"] |
|
|
|
expect(record.errors[:mortgage]).to eq(expected_message) |
|
expect(record.errors[:deposit]).to eq(expected_message) |
|
expect(record.errors[:grant]).to eq(expected_message) |
|
expect(record.errors[:value]).to eq(expected_message) |
|
expect(record.errors[:discount]).to eq(expected_message) |
|
end |
|
|
|
it "does not add an error if mortgage, grant and deposit total equals market value - discount" do |
|
record.mortgage = 10_000 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
end |
|
|
|
context "when mortgage is not routed to" do |
|
let(:record) { FactoryBot.build(:sales_log, mortgageused: 2, deposit: 5_000, grant: 3_000, value: 20_000, discount: 10, ownershipsch: 2, saledate: Time.zone.local(2024, 4, 3)) } |
|
|
|
it "adds an error if grant and deposit total does not equal market value - discount" do |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expected_message = ["Mortgage, deposit, and grant total must equal £18,000.00"] |
|
expect(record.errors[:mortgage]).to eq(expected_message) |
|
expect(record.errors[:deposit]).to eq(expected_message) |
|
expect(record.errors[:grant]).to eq(expected_message) |
|
expect(record.errors[:value]).to eq(expected_message) |
|
expect(record.errors[:discount]).to eq(expected_message) |
|
end |
|
|
|
it "does not add an error if mortgage, grant and deposit total equals market value - discount" do |
|
record.grant = 13_000 |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
|
|
context "when ownership is not discounted" do |
|
let(:record) { FactoryBot.build(:sales_log, mortgage: 10_000, deposit: 5_000, grant: 3_000, value: 20_000, discount: 10, ownershipsch: 1, saledate: Time.zone.local(2024, 4, 3)) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
end |
|
|
|
context "when sale is before 24/25 collection" do |
|
let(:record) { FactoryBot.build(:sales_log, mortgageused: 2, deposit: 5_000, grant: 3_000, value: 20_000, discount: 10, ownershipsch: 2, saledate: Time.zone.local(2023, 4, 4)) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_discounted_ownership_value(record) |
|
|
|
expect(record.errors).to be_empty |
|
end |
|
end |
|
end |
|
|
|
describe "#validate_basic_monthly_rent" do |
|
context "when within permitted bounds" do |
|
let(:record) { build(:sales_log, mrent: 9998, ownershipsch: 1, type: 2) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_basic_monthly_rent(record) |
|
|
|
expect(record.errors[:mrent]).not_to be_present |
|
expect(record.errors[:type]).not_to be_present |
|
end |
|
end |
|
|
|
context "when the rent is blank" do |
|
let(:record) { build(:sales_log, mrent: nil, ownershipsch: 1, type: 2) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_basic_monthly_rent(record) |
|
|
|
expect(record.errors[:mrent]).not_to be_present |
|
expect(record.errors[:type]).not_to be_present |
|
end |
|
end |
|
|
|
context "when the type is old persons shared ownership" do |
|
let(:record) { build(:sales_log, mrent: 100_000, ownershipsch: 1, type: 24) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_basic_monthly_rent(record) |
|
|
|
expect(record.errors[:mrent]).not_to be_present |
|
expect(record.errors[:type]).not_to be_present |
|
end |
|
end |
|
|
|
context "when the type is blank" do |
|
let(:record) { build(:sales_log, mrent: 100_000, ownershipsch: 1, type: nil) } |
|
|
|
it "does not add an error" do |
|
sale_information_validator.validate_basic_monthly_rent(record) |
|
|
|
expect(record.errors[:mrent]).not_to be_present |
|
expect(record.errors[:type]).not_to be_present |
|
end |
|
end |
|
|
|
context "when higher than upper bound" do |
|
let(:record) { build(:sales_log, mrent: 100_000, ownershipsch: 1, type: 2) } |
|
|
|
it "adds an error" do |
|
sale_information_validator.validate_basic_monthly_rent(record) |
|
|
|
expect(record.errors[:mrent]).to include(I18n.t("validations.sale_information.monthly_rent.higher_than_expected")) |
|
expect(record.errors[:type]).to include(I18n.t("validations.sale_information.monthly_rent.higher_than_expected")) |
|
end |
|
end |
|
end |
|
end
|
|
|