submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

Tree: 16b5b2149e

Arthur Campbell a2b684b123 CLDC-1826 lettings log codes only download (#1268 ) * update seeds to add self in review env, change spec to reflect this, update config yml to allow csv exports in review * update interface of relevant methods EmailCsvJob, LettingsLog.to_csv and LettingsLogCsvService consume codes_only flag * update tests including adding a new csv file to test against * update LettingsLogCsvService to output codes only csv * correct minor error and linting * enable codes only download in UI - add link on lettings log index page - pass codes_only flag through params in relevant links and methods - convert flag to boolean in controller methods * ensure link displayed successfully for all renderings of logs_list and params passed through relevant methods in organisations controller * fix existing tests * correct linting thing * correct linting error * update tests for lettings log controller * correct linting errors * update organisations controller tests * make minor changes after code review * remove changes made for testing on review app * make codes only download visible to support users only * change variable names throughout after info on rauby/rails naming conventions, update tests for change in who can view codes only download link * rework csv service for readability, remove delegating methods from lettings log to keep all code to do with mapping between our domain and desired export format in one place * update test name * correct a small typo and remove a duplicated method after clever git merge conflict suggestion * point review app at staging csv bucket for csv download * change variables named codes_only_export to codes_only to avoid inconsistency * write tests to ensure that differetn user roles have the correct permissions around csv download * ensure that non support users may not download codes only exports * correct a small error in a previous commit * correct minor linting error	3 years ago
..
lettings_log_csv_service.rb	CLDC-1826 lettings log codes only download (#1268 )	3 years ago

CLDC-1826 lettings log codes only download (#1268 )

* update seeds to add self in review env, change spec to reflect this, update config yml to allow csv exports in review

* update interface of relevant methods
EmailCsvJob, LettingsLog.to_csv and LettingsLogCsvService consume codes_only flag

* update tests including adding a new csv file to test against

* update LettingsLogCsvService to output codes only csv

* correct minor error and linting

* enable codes only download in UI
- add link on lettings log index page
- pass codes_only flag through params in relevant links and methods
- convert flag to boolean in controller methods

* ensure link displayed successfully for all renderings of logs_list and params passed through relevant methods in organisations controller

* fix existing tests

* correct linting thing

* correct linting error

* update tests for lettings log controller

* correct linting errors

* update organisations controller tests

* make minor changes after code review

* remove changes made for testing on review app

* make codes only download visible to support users only

* change variable names throughout after info on rauby/rails naming conventions, update tests for change in who can view codes only download link

* rework csv service for readability, remove delegating methods from lettings log to keep all code to do with mapping between our domain and desired export format in one place

* update test name

* correct a small typo and remove a duplicated method after clever git merge conflict suggestion

* point review app at staging csv bucket for csv download

* change variables named codes_only_export to codes_only to avoid inconsistency

* write tests to ensure that differetn user roles have the correct permissions around csv download

* ensure that non support users may not download codes only exports

* correct a small error in a  previous commit

* correct minor linting error

3 years ago

lettings_log_csv_service.rb

CLDC-1826 lettings log codes only download (#1268 )

3 years ago