submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

Phil Lee 3f27008034 CLDC-2235 Bulk upload now support invalid options (#1564 An error occurred ) # Context - https://digital.dclg.gov.uk/jira/browse/CLDC-2235 - Support invalid options for bulk upload. one use case when user for a new collection year supplies a value only valid in the previous collection year # Changes - this validation works before `log.valid?` clears any fields - as a result there is the potential to get 2 errors on a field for when it becomes blanked and invalid option occur together - bulk upload validations are now split so that they run before or after `log.valid?`. this is due to the fact that `log.valid?` heavily mutates the `log` object. so we want to validate both before and after the data mutates depending on what needs to be checked - errors must be duplicated and merged as calling `valid?` clears any existing errors on the object - all validations are assigned a specific context otherwise they are added to the default context and will also be called when a context is given	2 years ago
..
csv_parser.rb	bulk upload checks column count of CSV (#1423 An error occurred )	2 years ago
row_parser.rb	CLDC-2235 Bulk upload now support invalid options (#1564 An error occurred )	2 years ago

CLDC-2235 Bulk upload now support invalid options (#1564)

# Context

- https://digital.dclg.gov.uk/jira/browse/CLDC-2235
- Support invalid options for bulk upload. one use case when user for a new collection year supplies a value only valid in the previous collection year

# Changes

- this validation works before `log.valid?` clears any fields
- as a result there is the potential to get 2 errors on a field for when it becomes blanked and invalid option occur together
- bulk upload validations are now split so that they run before or after `log.valid?`. this is due to the fact that `log.valid?` heavily mutates the `log` object. so we want to validate both before and after the data mutates depending on what needs to be checked
- errors must be duplicated and merged as calling `valid?` clears any existing errors on the object
- all validations are assigned a specific context otherwise they are added to the default context and will also be called when a context is given

csv_parser.rb

bulk upload checks column count of CSV (#1423)

row_parser.rb

CLDC-2235 Bulk upload now support invalid options (#1564)