submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

SamSeed-Softwire a62846c212 CLDC-1666 Update locations table (#987 ) * feat: remove redundant cols from locations table * feat: add status col to locations table * test: start adding status tag tests * test: pick the simplest format for the tag helper tests * feat: make the locations table (plus related content above & below) 2/3 width * feat: add incomplete to location status method * test: all status tag helpers * test: update test text to match what's being tested * test: update locations list test in locations_controller_spec.rb * test: update locations list test in schemes feature tests * test: that status=incomplete when mandatory info is missing * feat: simplify logic for incomplete status Co-authored-by: James Rose <james@jbpr.net> * feat: hide new locations table layout behind feature flag * feat: use route helpers to get scheme_location path * feat: simplify "scheme_id: @scheme.id" to "@scheme" * feat: reference location, not @location, in scheme_location_path * feat: reorder postcode and code in locations table * feat: change ' ' to "" in location_spec * feat: update wording and ordering for 'view location details' page * test: re-add tests for locations page when new layout not enabled * test: check for mobility_type and location_admin_district in locations_controller as support user * test: update locations helper test to match new field naming and ordering * feat: always scale locations list by 2/3, not just when new layout used * feat: scale the scheme details page by 2/3 to match the locations list page * feat: only make scheme details and locations pages 2/3 scale if feature toggle on * test: mock new locations layout feature toggle in tests * feat: use the existing location_toggle_enabled instead of new_locations_table_layout_enabled * refactor: don't use html inside ruby in locations index page * refactor: use Rails routes in all places in locations index page * style: lint * feat: move logic from views/schemes/show into schemes_helper * refactor: make consistent the removal of fields from SchemeHelper base_attributes * test: improvements to tests * test: make 'returns correct display attributes' tests sensible * test: check scheme toggle off => no scheme status shown * style: correct indentation in spec/helpers/schemes_helper_spec.rb * test: that when owning = managing, "Organisation providing support" hidden * style: lint code * test: don't set scheme id explicitly in schemes_helper_spec * style: reorder tag helper spec to match tag helper * refactor: ensure display_scheme_attributes always takes user type * test: make location incomplete status depend on location.confirmed * test: add missing location validations for nil postcode & mobility type Co-authored-by: James Rose <james@jbpr.net>		3 years ago
..
application_helper_spec.rb	…
check_answers_helper_spec.rb	…
conditional_questions_helper_spec.rb	…
details_table_helper_spec.rb	…
filters_helper_spec.rb	…
form_page_error_helper_spec.rb	…
interruption_screen_helper_spec.rb	…
locations_helper_spec.rb	CLDC-1666 Update locations table (#987 )	3 years ago
navigation_items_helper_spec.rb	…
question_attribute_helper_spec.rb	Cldc 1668 deactivate location (#981 )	3 years ago
question_view_helper_spec.rb	…
schemes_helper_spec.rb	CLDC-1666 Update locations table (#987 )	3 years ago
tab_nav_helper_spec.rb	…
tag_helper_spec.rb	CLDC-1666 Update locations table (#987 )	3 years ago
tasklist_helper_spec.rb	…
title_helper_spec.rb	…
user_helper_spec.rb	…