submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

David May-Miller 4a31906d45 CLDC-853 Added validations for sales income2 (#1101 ) * CLDC-853 Added hard validations for sales income2 * CLDC-853 Added soft validation for sales income2 * CLDC-853 Fix tests broken by new code * CLDC-853 Add new tests for new page and refactor slightly * CLDC-853 Fix linting errors * CLDC-853 Rename migration and update schema version * CLDC-853 Fix broken sales income2 test * CLDC-853 Rename migration * CLDC-853 Move income 2 to cya card 2 and commonise combined income validation * CLDC-853 Actually use the validate_combined_income method * combine duplicate methods after rebase, ensure hard validations are triggered on all relevant fields * move validation on child income to financial validations to stop it being triggered on lettings logs, minor amendments to tests broken by changes * revamp financial validations tests against income to reflect updates * amend child income validation to reflect specifications and write tests to cover this validation * correct linting errors and play a little code golf * change copy for some validations, add sales log method and amend interruption screen helper to support this * extract duplicate code to private method * update buyer 1 and 2 income value check to be consistent * remove ecstat from income checks, the only ecstat we care about is child which is dealt with elsewhere * rename constant struct with same anme as existing variable * amend tests to reflect the chagnes in validations and copy * enable currency formatting of numbers for inserting into informative_text or title_text * update evil test in form handler spec * rebase and fix conflicts and tests * change a variable name and correct minor rebase errors * update interruption screen helper tests * correct linting errors, minor test failure and typo * add tests for new sales log method for formatting currency * fix merge conflicts --------- Co-authored-by: Arthur Campbell <arfa.camble@gmail.com>		2 years ago
..
application_helper_spec.rb	Rename case log to lettings log (#840 )	2 years ago
check_answers_helper_spec.rb	Rename case log to lettings log (#840 )	2 years ago
collection_time_helper_spec.rb	Change CDS export archive names from quarter to financial year (#1309 )	2 years ago
conditional_questions_helper_spec.rb	Revert to `f4e6d6d6bb` (#887 )	2 years ago
details_table_helper_spec.rb	Update tests for DetailsTableHelper	3 years ago
filters_helper_spec.rb	CLDC-1909 Add 2023-2024 collection year filter (#1314 )	2 years ago
form_page_error_helper_spec.rb	Rename case log to lettings log (#840 )	2 years ago
interruption_screen_helper_spec.rb	CLDC-853 Added validations for sales income2 (#1101 )	2 years ago
locations_helper_spec.rb	Cldc 1669 add location redesign (#1034 )	2 years ago
navigation_items_helper_spec.rb	change housing provider -> stock owner (#1104 )	2 years ago
question_attribute_helper_spec.rb	Cldc 1668 deactivate location (#981 )	2 years ago
question_view_helper_spec.rb	CLDC-1185: now wrap label in div	3 years ago
schemes_helper_spec.rb	CLDC-1741 Remove scheme support provider question (#1173 )	2 years ago
tab_nav_helper_spec.rb	CLDC-864 Add contract exchange date validations (#1231 )	2 years ago
tag_helper_spec.rb	CLDC-1666 Update locations table (#987 )	2 years ago
tasklist_helper_spec.rb	Update collection year end dates for 2022 onwards (#1312 )	2 years ago
title_helper_spec.rb	Dry searched logic (#643 )	3 years ago
user_helper_spec.rb	Content tweaks for user and organisation management (#676 )	3 years ago