You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
1695 lines
68 KiB
1695 lines
68 KiB
require "rails_helper" |
|
|
|
RSpec.describe LocationsController, type: :request do |
|
let(:page) { Capybara::Node::Simple.new(response.body) } |
|
let(:user) { FactoryBot.create(:user, :support) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let(:fake_2021_2022_form) { Form.new("spec/fixtures/forms/2021_2022.json") } |
|
|
|
before do |
|
allow(FormHandler.instance).to receive(:current_lettings_form).and_return(fake_2021_2022_form) |
|
end |
|
|
|
describe "#new" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
get "/schemes/1/locations/new" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/1/locations/new" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations/new" |
|
end |
|
|
|
it "returns a template for a new location" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Add a location to this scheme") |
|
end |
|
|
|
context "when trying to new location to a scheme that belongs to another organisation" do |
|
let(:another_scheme) { FactoryBot.create(:scheme) } |
|
|
|
it "displays the new page with an error message" do |
|
get "/schemes/#{another_scheme.id}/locations/new" |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
end |
|
|
|
context "when signed in as a support user" do |
|
before do |
|
allow(user).to receive(:need_two_factor_authentication?).and_return(false) |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations/new" |
|
end |
|
|
|
it "returns a template for a new location" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Add a location to this scheme") |
|
end |
|
end |
|
end |
|
|
|
describe "#create" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
post "/schemes/1/locations" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
post "/schemes/1/locations" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let(:startdate) { Time.utc(2022, 2, 2) } |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", startdate:, mobility_type: "A" } } } |
|
|
|
before do |
|
sign_in user |
|
post "/schemes/#{scheme.id}/locations", params: |
|
end |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your answers before creating this scheme") |
|
end |
|
|
|
it "creates a new location for scheme with valid params" do |
|
expect(Location.last.scheme.owning_organisation_id).to eq(user.organisation_id) |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.postcode).to eq("ZZ1 1ZZ") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
expect(Location.last.startdate).to eq(startdate) |
|
expect(Location.last.mobility_type).to eq("Fitted with equipment and adaptations") |
|
end |
|
|
|
context "when postcode is submitted with lower case" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "zz1 1zz", mobility_type: "N" } } } |
|
|
|
it "creates a new location for scheme with postcode " do |
|
expect(Location.last.postcode).to eq("ZZ1 1ZZ") |
|
end |
|
end |
|
|
|
context "when startdate is submitted with leading zeroes" do |
|
let(:params) do |
|
{ location: { |
|
name: "Test", |
|
units: "5", |
|
type_of_unit: "Bungalow", |
|
add_another_location: "No", |
|
postcode: "zz1 1zz", |
|
mobility_type: "N", |
|
"startdate(3i)" => "01", |
|
"startdate(2i)" => "01", |
|
"startdate(1i)" => "2022", |
|
} } |
|
end |
|
|
|
it "creates a new location for scheme with postcode " do |
|
expect(Location.last.startdate).to eq(Time.utc(2022, 1, 1)) |
|
end |
|
end |
|
|
|
context "when trying to add location to a scheme that belongs to another organisation" do |
|
let(:another_scheme) { FactoryBot.create(:scheme) } |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", mobility_type: "N" } } } |
|
|
|
it "displays the new page with an error message" do |
|
post "/schemes/#{another_scheme.id}/locations", params: params |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
|
|
context "when do you want to add another location is selected as yes" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "Yes", postcode: "ZZ1 1ZZ", mobility_type: "N" } } } |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Add a location to this scheme") |
|
end |
|
|
|
it "creates a new location for scheme with valid params" do |
|
expect(Location.last.scheme.owning_organisation_id).to eq(user.organisation_id) |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
expect(Location.last.mobility_type).to eq("None") |
|
end |
|
end |
|
|
|
context "when do you want to add another location is selected as no" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", mobility_type: "N" } } } |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your changes before creating this scheme") |
|
end |
|
|
|
it "creates a new location for scheme with valid params" do |
|
expect(Location.last.scheme.owning_organisation_id).to eq(user.organisation_id) |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when do you want to add another location is not selected" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", postcode: "ZZ1 1ZZ", mobility_type: "W" } } } |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your changes before creating this scheme") |
|
end |
|
|
|
it "creates a new location for scheme with valid params" do |
|
expect(Location.last.scheme.owning_organisation_id).to eq(user.organisation_id) |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
expect(Location.last.mobility_type).to eq("Wheelchair-user standard") |
|
end |
|
end |
|
|
|
context "when required param are missing" do |
|
let(:params) { { location: { postcode: "", name: "Test", units: "", type_of_unit: "", add_another_location: "No" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.postcode")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.units.blank")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.type_of_unit.blank")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.mobility_type.blank")) |
|
end |
|
end |
|
|
|
context "when invalid time is supplied" do |
|
let(:params) do |
|
{ location: { |
|
name: "Test", |
|
units: "5", |
|
type_of_unit: "Bungalow", |
|
mobility_type: "N", |
|
add_another_location: "No", |
|
postcode: "ZZ1 1ZZ", |
|
"startdate(3i)" => "1", |
|
"startdate(2i)" => "1", |
|
"startdate(1i)" => "w", |
|
} } |
|
end |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.date.invalid_date")) |
|
end |
|
end |
|
|
|
context "when no startdate is supplied" do |
|
let(:params) do |
|
{ location: { |
|
name: "Test", |
|
units: "5", |
|
type_of_unit: "Bungalow", |
|
mobility_type: "N", |
|
add_another_location: "No", |
|
postcode: "ZZ1 1ZZ", |
|
"startdate(3i)" => "", |
|
"startdate(2i)" => "", |
|
"startdate(1i)" => "", |
|
} } |
|
end |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your answers before creating this scheme") |
|
end |
|
end |
|
|
|
context "when postcodes.io doesn't return a la_code" do |
|
let(:params) do |
|
{ location: { |
|
name: "Test", |
|
units: "5", |
|
type_of_unit: "Bungalow", |
|
mobility_type: "N", |
|
add_another_location: "No", |
|
postcode: "AA1 4AA", |
|
"startdate(3i)" => "", |
|
"startdate(2i)" => "", |
|
"startdate(1i)" => "", |
|
} } |
|
end |
|
|
|
it "redirects to la_fallback" do |
|
post "/schemes/#{scheme.id}/locations", params: params |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("What is the local authority of AA1 4AA?") |
|
end |
|
end |
|
end |
|
|
|
context "when signed in as a support user" do |
|
let(:user) { FactoryBot.create(:user, :support) } |
|
let!(:scheme) { FactoryBot.create(:scheme) } |
|
let(:params) { { location: { name: " Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", mobility_type: "N" } } } |
|
|
|
before do |
|
allow(user).to receive(:need_two_factor_authentication?).and_return(false) |
|
sign_in user |
|
post "/schemes/#{scheme.id}/locations", params: |
|
end |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your answers before creating this scheme") |
|
end |
|
|
|
it "creates a new location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.postcode).to eq("ZZ1 1ZZ") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
|
|
context "when postcode is submitted with lower case" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "zz1 1zz", mobility_type: "N" } } } |
|
|
|
it "creates a new location for scheme with postcode " do |
|
expect(Location.last.postcode).to eq("ZZ1 1ZZ") |
|
end |
|
end |
|
|
|
context "when required postcode param is missing" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No" } } } |
|
|
|
it "displays the new page with an error message" do |
|
post "/schemes/#{scheme.id}/locations", params: params |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.postcode")) |
|
end |
|
end |
|
|
|
context "when do you want to add another location is selected as yes" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "Yes", postcode: "ZZ1 1ZZ", mobility_type: "N" } } } |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Add a location to this scheme") |
|
end |
|
|
|
it "creates a new location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when do you want to add another location is selected as no" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", mobility_type: "N" } } } |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your changes before creating this scheme") |
|
end |
|
|
|
it "creates a new location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when do you want to add another location is not selected" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", postcode: "ZZ1 1ZZ", mobility_type: "N" } } } |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your changes before creating this scheme") |
|
end |
|
|
|
it "creates a new location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when required param are missing" do |
|
let(:params) { { location: { postcode: "", name: "Test", units: "", type_of_unit: "", add_another_location: "No" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.postcode")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.units.blank")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.type_of_unit.blank")) |
|
end |
|
end |
|
|
|
context "when invalid time is supplied" do |
|
let(:params) do |
|
{ location: { |
|
name: "Test", |
|
units: "5", |
|
type_of_unit: "Bungalow", |
|
mobility_type: "N", |
|
add_another_location: "No", |
|
postcode: "ZZ1 1ZZ", |
|
"startdate(3i)" => "1", |
|
"startdate(2i)" => "1", |
|
"startdate(1i)" => "w", |
|
} } |
|
end |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.date.invalid_date")) |
|
end |
|
end |
|
|
|
context "when no startdate is supplied" do |
|
let(:params) do |
|
{ location: { |
|
name: "Test", |
|
units: "5", |
|
type_of_unit: "Bungalow", |
|
mobility_type: "N", |
|
add_another_location: "No", |
|
postcode: "ZZ1 1ZZ", |
|
"startdate(3i)" => "", |
|
"startdate(2i)" => "", |
|
"startdate(1i)" => "", |
|
} } |
|
end |
|
|
|
it "creates a new location for scheme with valid params and redirects to correct page" do |
|
expect { post "/schemes/#{scheme.id}/locations", params: }.to change(Location, :count).by(1) |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your answers before creating this scheme") |
|
end |
|
end |
|
|
|
context "when postcodes.io doesn't return a la_code" do |
|
let(:params) do |
|
{ location: { |
|
name: "Test", |
|
units: "5", |
|
type_of_unit: "Bungalow", |
|
mobility_type: "N", |
|
add_another_location: "No", |
|
postcode: "AA1 4AA", |
|
"startdate(3i)" => "", |
|
"startdate(2i)" => "", |
|
"startdate(1i)" => "", |
|
} } |
|
end |
|
|
|
it "redirects to la_fallback" do |
|
post "/schemes/#{scheme.id}/locations", params: params |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("What is the local authority of AA1 4AA?") |
|
end |
|
end |
|
end |
|
end |
|
|
|
describe "#edit" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
get "/schemes/1/locations/1/edit" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/1/locations/1/edit" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations/#{location.id}/edit" |
|
end |
|
|
|
it "returns a template for a new location" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Add a location to this scheme") |
|
end |
|
|
|
context "when trying to edit a location that belongs to another organisation" do |
|
let(:another_scheme) { FactoryBot.create(:scheme) } |
|
let(:another_location) { FactoryBot.create(:location, scheme: another_scheme) } |
|
|
|
it "displays the new page with an error message" do |
|
get "/schemes/#{another_scheme.id}/locations/#{another_location.id}/edit" |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
|
|
context "when the requested location does not exist" do |
|
let(:location) { OpenStruct.new(id: (Location.maximum(:id) || 0) + 1) } |
|
|
|
it "returns not found" do |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
end |
|
|
|
context "when signed in as a support user" do |
|
let(:user) { FactoryBot.create(:user, :support) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:) } |
|
|
|
before do |
|
allow(user).to receive(:need_two_factor_authentication?).and_return(false) |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations/#{location.id}/edit" |
|
end |
|
|
|
it "returns a template for a new location" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Add a location to this scheme") |
|
end |
|
end |
|
end |
|
|
|
describe "#update" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
patch "/schemes/1/locations/1" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
patch "/schemes/1/locations/1" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:) } |
|
let(:startdate) { Time.utc(2021, 1, 2) } |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", startdate:, page: "edit" } } } |
|
|
|
before do |
|
sign_in user |
|
patch "/schemes/#{scheme.id}/locations/#{location.id}", params: |
|
end |
|
|
|
it "updates existing location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your answers before creating this scheme") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.scheme.owning_organisation_id).to eq(user.organisation_id) |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.postcode).to eq("ZZ1 1ZZ") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
expect(Location.last.startdate).to eq(startdate) |
|
end |
|
|
|
context "when updating from edit-name page" do |
|
let(:params) { { location: { name: "Test", page: "edit-name" } } } |
|
|
|
it "updates existing location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Test") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
end |
|
end |
|
|
|
context "when postcode is submitted with lower case" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "zz1 1zz", page: "edit" } } } |
|
|
|
it "updates existing location for scheme with postcode " do |
|
expect(Location.last.postcode).to eq("ZZ1 1ZZ") |
|
end |
|
end |
|
|
|
context "when trying to update location for a scheme that belongs to another organisation" do |
|
let(:another_scheme) { FactoryBot.create(:scheme) } |
|
let(:another_location) { FactoryBot.create(:location) } |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", page: "edit" } } } |
|
|
|
it "displays the new page with an error message" do |
|
patch "/schemes/#{another_scheme.id}/locations/#{another_location.id}", params: params |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
|
|
context "when required postcode param is invalid" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "invalid", page: "edit" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.postcode")) |
|
end |
|
end |
|
|
|
context "when do you want to add another location is selected as yes" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "Yes", postcode: "ZZ1 1ZZ", page: "edit" } } } |
|
|
|
it "updates existing location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Add a location to this scheme") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.scheme.owning_organisation_id).to eq(user.organisation_id) |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when do you want to add another location is selected as no" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", page: "edit" } } } |
|
|
|
it "updates existing location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your changes before creating this scheme") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.scheme.owning_organisation_id).to eq(user.organisation_id) |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when do you want to add another location is not selected" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", postcode: "ZZ1 1ZZ", page: "edit" } } } |
|
|
|
it "updates existing location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your changes before creating this scheme") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.scheme.owning_organisation_id).to eq(user.organisation_id) |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when required param are missing" do |
|
let(:params) { { location: { postcode: "", name: "Test", units: "", type_of_unit: "", add_another_location: "No" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.postcode")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.units.blank")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.type_of_unit.blank")) |
|
end |
|
end |
|
|
|
context "when the requested location does not exist" do |
|
let(:location) { OpenStruct.new(id: (Location.maximum(:id) || 0) + 1) } |
|
let(:params) { {} } |
|
|
|
it "returns not found" do |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
end |
|
|
|
context "when signed in as a support user" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:) } |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", page: "edit" } } } |
|
|
|
before do |
|
allow(user).to receive(:need_two_factor_authentication?).and_return(false) |
|
sign_in user |
|
patch "/schemes/#{scheme.id}/locations/#{location.id}", params: |
|
end |
|
|
|
it "updates a location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your answers before creating this scheme") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.postcode).to eq("ZZ1 1ZZ") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
|
|
context "when updating from edit-name page" do |
|
let(:params) { { location: { name: "Test", page: "edit-name" } } } |
|
|
|
it "updates existing location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Test") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
end |
|
end |
|
|
|
context "when postcode is submitted with lower case" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "zz1 1zz", page: "edit" } } } |
|
|
|
it "updates a location for scheme with postcode " do |
|
expect(Location.last.postcode).to eq("ZZ1 1ZZ") |
|
end |
|
end |
|
|
|
context "when required postcode param is missing" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "invalid", page: "edit" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.postcode")) |
|
end |
|
end |
|
|
|
context "when do you want to add another location is selected as yes" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "Yes", postcode: "ZZ1 1ZZ", page: "edit" } } } |
|
|
|
it "updates location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Add a location to this scheme") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when do you want to add another location is selected as no" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", add_another_location: "No", postcode: "ZZ1 1ZZ", page: "edit" } } } |
|
|
|
it "updates a location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your changes before creating this scheme") |
|
end |
|
|
|
it "updates existing location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when do you want to add another location is not selected" do |
|
let(:params) { { location: { name: "Test", units: "5", type_of_unit: "Bungalow", postcode: "ZZ1 1ZZ", page: "edit" } } } |
|
|
|
it "updates a location for scheme with valid params and redirects to correct page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Check your changes before creating this scheme") |
|
end |
|
|
|
it "updates a location for scheme with valid params" do |
|
expect(Location.last.name).to eq("Test") |
|
expect(Location.last.units).to eq(5) |
|
expect(Location.last.type_of_unit).to eq("Bungalow") |
|
end |
|
end |
|
|
|
context "when required param are missing" do |
|
let(:params) { { location: { postcode: "", name: "Test", units: "", type_of_unit: "", add_another_location: "No" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.postcode")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.units.blank")) |
|
expect(page).to have_content(I18n.t("activerecord.errors.models.location.attributes.type_of_unit.blank")) |
|
end |
|
end |
|
end |
|
end |
|
|
|
describe "#index" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
get "/schemes/#{scheme.id}/locations" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider user" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator user" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:locations) { FactoryBot.create_list(:location, 3, scheme:, startdate: Time.zone.local(2022, 4, 1)) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations" |
|
end |
|
|
|
context "when coordinator attempts to see scheme belonging to a different organisation" do |
|
let!(:another_scheme) { FactoryBot.create(:scheme) } |
|
|
|
before do |
|
FactoryBot.create(:location, scheme:, startdate: Time.zone.local(2022, 4, 1)) |
|
end |
|
|
|
it "returns 404 not found" do |
|
get "/schemes/#{another_scheme.id}/locations" |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
|
|
it "shows locations with correct data wben the new locations layout feature toggle is enabled" do |
|
locations.each do |location| |
|
expect(page).to have_content(location.id) |
|
expect(page).to have_content(location.postcode) |
|
expect(page).to have_content(location.name) |
|
expect(page).to have_content(location.status) |
|
end |
|
end |
|
|
|
it "shows locations with correct data wben the new locations layout feature toggle is disabled" do |
|
allow(FeatureToggle).to receive(:location_toggle_enabled?).and_return(false) |
|
get "/schemes/#{scheme.id}/locations" |
|
locations.each do |location| |
|
expect(page).to have_content(location.id) |
|
expect(page).to have_content(location.postcode) |
|
expect(page).to have_content(location.type_of_unit) |
|
expect(page).to have_content(location.mobility_type) |
|
expect(page).to have_content(location.location_admin_district) |
|
expect(page).to have_content(location.startdate&.to_formatted_s(:govuk_date)) |
|
end |
|
end |
|
|
|
it "has page heading" do |
|
expect(page).to have_content(scheme.service_name) |
|
end |
|
|
|
it "has correct title" do |
|
expected_title = CGI.escapeHTML("#{scheme.service_name} - Submit social housing lettings and sales data (CORE) - GOV.UK") |
|
expect(page).to have_title(expected_title) |
|
end |
|
|
|
context "when paginating over 20 results" do |
|
let!(:locations) { FactoryBot.create_list(:location, 25, scheme:) } |
|
|
|
context "when on the first page" do |
|
before do |
|
get "/schemes/#{scheme.id}/locations" |
|
end |
|
|
|
it "shows which schemes are being shown on the current page" do |
|
expect(CGI.unescape_html(response.body)).to match("Showing <b>1</b> to <b>20</b> of <b>#{locations.count}</b> locations") |
|
end |
|
|
|
it "has correct page 1 of 2 title" do |
|
expected_title = CGI.escapeHTML("#{scheme.service_name} (page 1 of 2) - Submit social housing lettings and sales data (CORE) - GOV.UK") |
|
expect(page).to have_title(expected_title) |
|
end |
|
|
|
it "has pagination links" do |
|
expect(page).not_to have_content("Previous") |
|
expect(page).not_to have_link("Previous") |
|
expect(page).to have_content("Next") |
|
expect(page).to have_link("Next") |
|
end |
|
end |
|
|
|
context "when on the second page" do |
|
before do |
|
get "/schemes/#{scheme.id}/locations?page=2" |
|
end |
|
|
|
it "shows which schemes are being shown on the current page" do |
|
expect(CGI.unescape_html(response.body)).to match("Showing <b>21</b> to <b>25</b> of <b>#{locations.count}</b> locations") |
|
end |
|
|
|
it "has correct page 2 of 2 title" do |
|
expected_title = CGI.escapeHTML("#{scheme.service_name} (page 2 of 2) - Submit social housing lettings and sales data (CORE) - GOV.UK") |
|
expect(page).to have_title(expected_title) |
|
end |
|
|
|
it "has pagination links" do |
|
expect(page).to have_content("Previous") |
|
expect(page).to have_link("Previous") |
|
expect(page).not_to have_content("Next") |
|
expect(page).not_to have_link("Next") |
|
end |
|
end |
|
end |
|
|
|
context "when searching" do |
|
let(:searched_location) { locations.first } |
|
let(:search_param) { searched_location.name } |
|
|
|
before do |
|
get "/schemes/#{scheme.id}/locations?search=#{search_param}" |
|
end |
|
|
|
it "returns matching results" do |
|
expect(page).to have_content(searched_location.name) |
|
locations[1..].each do |location| |
|
expect(page).not_to have_content(location.name) |
|
end |
|
end |
|
|
|
it "updates the table caption" do |
|
expect(page).to have_content("1 location found matching ‘#{search_param}’") |
|
end |
|
|
|
it "has search in the title" do |
|
expected_title = CGI.escapeHTML("#{scheme.service_name} (1 location matching ‘#{search_param}’) - Submit social housing lettings and sales data (CORE) - GOV.UK") |
|
expect(page).to have_title(expected_title) |
|
end |
|
end |
|
end |
|
|
|
context "when signed in as a support user" do |
|
let(:user) { FactoryBot.create(:user, :support) } |
|
let!(:scheme) { FactoryBot.create(:scheme) } |
|
let!(:locations) { FactoryBot.create_list(:location, 3, scheme:, startdate: Time.zone.local(2022, 4, 1)) } |
|
|
|
before do |
|
allow(user).to receive(:need_two_factor_authentication?).and_return(false) |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations" |
|
end |
|
|
|
it "shows locations with correct data wben the new locations layout feature toggle is enabled" do |
|
locations.each do |location| |
|
expect(page).to have_content(location.id) |
|
expect(page).to have_content(location.postcode) |
|
expect(page).to have_content(location.name) |
|
expect(page).to have_content(location.status) |
|
end |
|
end |
|
|
|
it "shows locations with correct data wben the new locations layout feature toggle is disabled" do |
|
allow(FeatureToggle).to receive(:location_toggle_enabled?).and_return(false) |
|
get "/schemes/#{scheme.id}/locations" |
|
locations.each do |location| |
|
expect(page).to have_content(location.id) |
|
expect(page).to have_content(location.postcode) |
|
expect(page).to have_content(location.type_of_unit) |
|
expect(page).to have_content(location.mobility_type) |
|
expect(page).to have_content(location.location_admin_district) |
|
expect(page).to have_content(location.startdate&.to_formatted_s(:govuk_date)) |
|
end |
|
end |
|
|
|
it "has page heading" do |
|
expect(page).to have_content(scheme.service_name) |
|
end |
|
|
|
it "has correct title" do |
|
expected_title = CGI.escapeHTML("#{scheme.service_name} - Submit social housing lettings and sales data (CORE) - GOV.UK") |
|
expect(page).to have_title(expected_title) |
|
end |
|
|
|
context "when paginating over 20 results" do |
|
let!(:locations) { FactoryBot.create_list(:location, 25, scheme:) } |
|
|
|
context "when on the first page" do |
|
before do |
|
get "/schemes/#{scheme.id}/locations" |
|
end |
|
|
|
it "shows which schemes are being shown on the current page" do |
|
expect(CGI.unescape_html(response.body)).to match("Showing <b>1</b> to <b>20</b> of <b>#{locations.count}</b> locations") |
|
end |
|
|
|
it "has correct page 1 of 2 title" do |
|
expected_title = CGI.escapeHTML("#{scheme.service_name} (page 1 of 2) - Submit social housing lettings and sales data (CORE) - GOV.UK") |
|
expect(page).to have_title(expected_title) |
|
end |
|
|
|
it "has pagination links" do |
|
expect(page).not_to have_content("Previous") |
|
expect(page).not_to have_link("Previous") |
|
expect(page).to have_content("Next") |
|
expect(page).to have_link("Next") |
|
end |
|
end |
|
|
|
context "when on the second page" do |
|
before do |
|
get "/schemes/#{scheme.id}/locations?page=2" |
|
end |
|
|
|
it "shows which schemes are being shown on the current page" do |
|
expect(CGI.unescape_html(response.body)).to match("Showing <b>21</b> to <b>25</b> of <b>#{locations.count}</b> locations") |
|
end |
|
|
|
it "has correct page 1 of 2 title" do |
|
expected_title = CGI.escapeHTML("#{scheme.service_name} (page 2 of 2) - Submit social housing lettings and sales data (CORE) - GOV.UK") |
|
expect(page).to have_title(expected_title) |
|
end |
|
|
|
it "has pagination links" do |
|
expect(page).to have_content("Previous") |
|
expect(page).to have_link("Previous") |
|
expect(page).not_to have_content("Next") |
|
expect(page).not_to have_link("Next") |
|
end |
|
end |
|
end |
|
|
|
context "when searching" do |
|
let(:searched_location) { locations.first } |
|
let(:search_param) { searched_location.name } |
|
|
|
before do |
|
get "/schemes/#{scheme.id}/locations?search=#{search_param}" |
|
end |
|
|
|
it "returns matching results" do |
|
expect(page).to have_content(searched_location.name) |
|
locations[1..].each do |location| |
|
expect(page).not_to have_content(location.name) |
|
end |
|
end |
|
|
|
it "updates the table caption" do |
|
expect(page).to have_content("1 location found matching ‘#{search_param}’") |
|
end |
|
|
|
it "has search in the title" do |
|
expected_title = CGI.escapeHTML("#{scheme.service_name} (1 location matching ‘#{search_param}’) - Submit social housing lettings and sales data (CORE) - GOV.UK") |
|
expect(page).to have_title(expected_title) |
|
end |
|
end |
|
end |
|
end |
|
|
|
describe "#edit-name" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
get "/schemes/1/locations/1/edit-name" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/1/locations/1/edit-name" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations/#{location.id}/edit-name" |
|
end |
|
|
|
it "returns a template for a edit-name" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Location name for #{location.postcode}") |
|
end |
|
|
|
context "when trying to edit location name of location that belongs to another organisation" do |
|
let(:another_scheme) { FactoryBot.create(:scheme) } |
|
let(:another_location) { FactoryBot.create(:location, scheme: another_scheme) } |
|
|
|
it "displays the new page with an error message" do |
|
get "/schemes/#{another_scheme.id}/locations/#{another_location.id}/edit-name" |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
end |
|
|
|
context "when signed in as a support user" do |
|
let(:user) { FactoryBot.create(:user, :support) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:) } |
|
|
|
before do |
|
allow(user).to receive(:need_two_factor_authentication?).and_return(false) |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations/#{location.id}/edit-name" |
|
end |
|
|
|
it "returns a template for a new location" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("Location name for #{location.postcode}") |
|
end |
|
|
|
context "when the requested location does not exist" do |
|
let(:location) { OpenStruct.new(id: (Location.maximum(:id) || 0) + 1) } |
|
|
|
it "returns not found" do |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
end |
|
end |
|
|
|
describe "#edit-local-authority" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
get "/schemes/1/locations/1/edit-local-authority" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/1/locations/1/edit-local-authority" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations/#{location.id}/edit-local-authority" |
|
end |
|
|
|
it "returns a template for an edit-local-authority" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("What is the local authority of #{location.postcode}?") |
|
end |
|
|
|
context "when trying to edit location name of location that belongs to another organisation" do |
|
let(:another_scheme) { FactoryBot.create(:scheme) } |
|
let(:another_location) { FactoryBot.create(:location, scheme: another_scheme) } |
|
|
|
it "displays the new page with an error message" do |
|
get "/schemes/#{another_scheme.id}/locations/#{another_location.id}/edit-local-authority" |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
end |
|
|
|
context "when signed in as a support user" do |
|
let(:user) { FactoryBot.create(:user, :support) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:) } |
|
|
|
before do |
|
allow(user).to receive(:need_two_factor_authentication?).and_return(false) |
|
sign_in user |
|
get "/schemes/#{scheme.id}/locations/#{location.id}/edit-local-authority" |
|
end |
|
|
|
it "returns a template for a new location" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("What is the local authority of #{location.postcode}?") |
|
end |
|
|
|
context "when the requested location does not exist" do |
|
let(:location) { OpenStruct.new(id: (Location.maximum(:id) || 0) + 1) } |
|
|
|
it "returns not found" do |
|
expect(response).to have_http_status(:not_found) |
|
end |
|
end |
|
end |
|
end |
|
|
|
describe "#deactivate" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
patch "/schemes/1/locations/1/deactivate" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
patch "/schemes/1/locations/1/deactivate" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:, startdate: nil, created_at: Time.zone.local(2022, 4, 1)) } |
|
let(:deactivation_date) { Time.utc(2022, 10, 10) } |
|
let!(:lettings_log) { FactoryBot.create(:lettings_log, :sh, location:, scheme:, startdate:, owning_organisation: user.organisation) } |
|
let(:startdate) { Time.utc(2022, 10, 11) } |
|
let(:add_deactivations) { nil } |
|
let(:setup_locations) { nil } |
|
|
|
before do |
|
Timecop.freeze(Time.utc(2022, 10, 10)) |
|
sign_in user |
|
add_deactivations |
|
setup_locations |
|
location.save! |
|
patch "/schemes/#{scheme.id}/locations/#{location.id}/new-deactivation", params: |
|
end |
|
|
|
after do |
|
Timecop.unfreeze |
|
end |
|
|
|
context "with default date" do |
|
let(:params) { { location_deactivation_period: { deactivation_date_type: "default", deactivation_date: } } } |
|
|
|
context "and affected logs" do |
|
it "redirects to the confirmation page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("This change will affect 1 logs") |
|
end |
|
end |
|
|
|
context "and no affected logs" do |
|
let(:setup_locations) { location.lettings_logs.update(location: nil) } |
|
|
|
it "redirects to the location page and updates the deactivation period" do |
|
follow_redirect! |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_css(".govuk-notification-banner.govuk-notification-banner--success") |
|
location.reload |
|
expect(location.location_deactivation_periods.count).to eq(1) |
|
expect(location.location_deactivation_periods.first.deactivation_date).to eq(Time.zone.local(2022, 4, 1)) |
|
end |
|
end |
|
end |
|
|
|
context "with other date" do |
|
let(:params) { { location_deactivation_period: { deactivation_date_type: "other", "deactivation_date(3i)": "10", "deactivation_date(2i)": "10", "deactivation_date(1i)": "2022" } } } |
|
|
|
context "and afected logs" do |
|
it "redirects to the confirmation page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_content("This change will affect #{location.lettings_logs.count} logs") |
|
end |
|
end |
|
|
|
context "and no affected logs" do |
|
let(:setup_locations) { location.lettings_logs.update(location: nil) } |
|
|
|
it "redirects to the location page and updates the deactivation period" do |
|
follow_redirect! |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_css(".govuk-notification-banner.govuk-notification-banner--success") |
|
location.reload |
|
expect(location.location_deactivation_periods.count).to eq(1) |
|
expect(location.location_deactivation_periods.first.deactivation_date).to eq(Time.zone.local(2022, 10, 10)) |
|
end |
|
end |
|
end |
|
|
|
context "when confirming deactivation" do |
|
let(:params) { { deactivation_date:, confirm: true, deactivation_date_type: "other" } } |
|
|
|
before do |
|
Timecop.freeze(Time.utc(2022, 10, 10)) |
|
sign_in user |
|
patch "/schemes/#{scheme.id}/locations/#{location.id}/deactivate", params: |
|
end |
|
|
|
after do |
|
Timecop.unfreeze |
|
end |
|
|
|
it "updates existing location with valid deactivation date and renders location page" do |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_css(".govuk-notification-banner.govuk-notification-banner--success") |
|
location.reload |
|
expect(location.location_deactivation_periods.count).to eq(1) |
|
expect(location.location_deactivation_periods.first.deactivation_date).to eq(deactivation_date) |
|
end |
|
|
|
context "and a log startdate is after location deactivation date" do |
|
it "clears the location and scheme answers" do |
|
expect(lettings_log.location).to eq(location) |
|
expect(lettings_log.scheme).to eq(scheme) |
|
lettings_log.reload |
|
expect(lettings_log.location).to eq(nil) |
|
expect(lettings_log.scheme).to eq(nil) |
|
end |
|
|
|
it "marks log as needing attention" do |
|
expect(lettings_log.unresolved).to eq(nil) |
|
lettings_log.reload |
|
expect(lettings_log.unresolved).to eq(true) |
|
end |
|
end |
|
|
|
context "and a log startdate is before location deactivation date" do |
|
let(:startdate) { Time.utc(2022, 10, 9) } |
|
|
|
it "does not update the log" do |
|
expect(lettings_log.location).to eq(location) |
|
expect(lettings_log.scheme).to eq(scheme) |
|
lettings_log.reload |
|
expect(lettings_log.location).to eq(location) |
|
expect(lettings_log.scheme).to eq(scheme) |
|
end |
|
|
|
it "does not mark log as needing attention" do |
|
expect(lettings_log.unresolved).to eq(nil) |
|
lettings_log.reload |
|
expect(lettings_log.unresolved).to eq(nil) |
|
end |
|
end |
|
end |
|
|
|
context "when the date is not selected" do |
|
let(:params) { { location_deactivation_period: { "deactivation_date": "" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.not_selected")) |
|
end |
|
end |
|
|
|
context "when invalid date is entered" do |
|
let(:params) { { location_deactivation_period: { deactivation_date_type: "other", "deactivation_date(3i)": "10", "deactivation_date(2i)": "44", "deactivation_date(1i)": "2022" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.invalid")) |
|
end |
|
end |
|
|
|
context "when the date is entered is before the beginning of current collection window" do |
|
let(:params) { { location_deactivation_period: { deactivation_date_type: "other", "deactivation_date(3i)": "10", "deactivation_date(2i)": "4", "deactivation_date(1i)": "2020" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.out_of_range", date: "1 April 2022")) |
|
end |
|
end |
|
|
|
context "when the day is not entered" do |
|
let(:params) { { location_deactivation_period: { deactivation_date_type: "other", "deactivation_date(3i)": "", "deactivation_date(2i)": "2", "deactivation_date(1i)": "2022" } } } |
|
|
|
it "displays page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.invalid")) |
|
end |
|
end |
|
|
|
context "when the month is not entered" do |
|
let(:params) { { location_deactivation_period: { deactivation_date_type: "other", "deactivation_date(3i)": "2", "deactivation_date(2i)": "", "deactivation_date(1i)": "2022" } } } |
|
|
|
it "displays page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.invalid")) |
|
end |
|
end |
|
|
|
context "when the year is not entered" do |
|
let(:params) { { location_deactivation_period: { deactivation_date_type: "other", "deactivation_date(3i)": "2", "deactivation_date(2i)": "2", "deactivation_date(1i)": "" } } } |
|
|
|
it "displays page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.invalid")) |
|
end |
|
end |
|
|
|
context "when deactivation date is during a deactivated period" do |
|
let(:deactivation_date) { Time.zone.local(2022, 10, 10) } |
|
let(:params) { { location_deactivation_period: { deactivation_date_type: "other", "deactivation_date(3i)": "8", "deactivation_date(2i)": "9", "deactivation_date(1i)": "2022" } } } |
|
let(:add_deactivations) { FactoryBot.create(:location_deactivation_period, deactivation_date: Time.zone.local(2022, 5, 5), reactivation_date: Time.zone.local(2022, 10, 12), location:) } |
|
|
|
it "displays page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.deactivation.during_deactivated_period")) |
|
end |
|
end |
|
end |
|
end |
|
|
|
describe "#show" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
get "/schemes/1/locations/1" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
get "/schemes/1/locations/1" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:, startdate: nil) } |
|
let(:add_deactivations) { location.location_deactivation_periods << location_deactivation_period } |
|
|
|
before do |
|
Timecop.freeze(Time.utc(2022, 10, 10)) |
|
sign_in user |
|
add_deactivations |
|
location.save! |
|
get "/schemes/#{scheme.id}/locations/#{location.id}" |
|
end |
|
|
|
after do |
|
Timecop.unfreeze |
|
end |
|
|
|
context "with active location" do |
|
let(:add_deactivations) {} |
|
|
|
it "renders deactivate this location" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_link("Deactivate this location", href: "/schemes/#{scheme.id}/locations/#{location.id}/new-deactivation") |
|
end |
|
end |
|
|
|
context "with deactivated location" do |
|
let(:location_deactivation_period) { FactoryBot.create(:location_deactivation_period, deactivation_date: Time.zone.local(2022, 10, 9), location:) } |
|
|
|
it "renders reactivate this location" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_link("Reactivate this location", href: "/schemes/#{scheme.id}/locations/#{location.id}/new-reactivation") |
|
end |
|
end |
|
|
|
context "with location that's deactivating soon" do |
|
let(:location_deactivation_period) { FactoryBot.create(:location_deactivation_period, deactivation_date: Time.zone.local(2022, 10, 12), location:) } |
|
|
|
it "does not render toggle location link" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).not_to have_link("Reactivate this location") |
|
expect(page).not_to have_link("Deactivate this location") |
|
end |
|
end |
|
|
|
context "with location that's reactivating soon" do |
|
let(:location_deactivation_period) { FactoryBot.create(:location_deactivation_period, deactivation_date: Time.zone.local(2022, 4, 12), reactivation_date: Time.zone.local(2022, 10, 12), location:) } |
|
|
|
it "does not render toggle location link" do |
|
expect(response).to have_http_status(:ok) |
|
expect(page).not_to have_link("Reactivate this location") |
|
expect(page).not_to have_link("Deactivate this location") |
|
end |
|
end |
|
end |
|
end |
|
|
|
describe "#reactivate" do |
|
context "when not signed in" do |
|
it "redirects to the sign in page" do |
|
patch "/schemes/1/locations/1/reactivate" |
|
expect(response).to redirect_to("/account/sign-in") |
|
end |
|
end |
|
|
|
context "when signed in as a data provider" do |
|
let(:user) { FactoryBot.create(:user) } |
|
|
|
before do |
|
sign_in user |
|
patch "/schemes/1/locations/1/reactivate" |
|
end |
|
|
|
it "returns 401 unauthorized" do |
|
request |
|
expect(response).to have_http_status(:unauthorized) |
|
end |
|
end |
|
|
|
context "when signed in as a data coordinator" do |
|
let(:user) { FactoryBot.create(:user, :data_coordinator) } |
|
let!(:scheme) { FactoryBot.create(:scheme, owning_organisation: user.organisation) } |
|
let!(:location) { FactoryBot.create(:location, scheme:, startdate: nil) } |
|
let(:deactivation_date) { Time.zone.local(2022, 4, 1) } |
|
let(:startdate) { Time.utc(2022, 10, 11) } |
|
|
|
before do |
|
Timecop.freeze(Time.utc(2022, 10, 10)) |
|
sign_in user |
|
FactoryBot.create(:location_deactivation_period, deactivation_date:, location:) |
|
location.save! |
|
patch "/schemes/#{scheme.id}/locations/#{location.id}/reactivate", params: |
|
end |
|
|
|
after do |
|
Timecop.unfreeze |
|
end |
|
|
|
context "with default date" do |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "default" } } } |
|
|
|
it "redirects to the location page and displays a success banner" do |
|
expect(response).to redirect_to("/schemes/#{scheme.id}/locations/#{location.id}") |
|
follow_redirect! |
|
expect(response).to have_http_status(:ok) |
|
expect(page).to have_css(".govuk-notification-banner.govuk-notification-banner--success") |
|
expect(page).to have_content("#{location.name} has been reactivated") |
|
end |
|
|
|
it "updates existing location deactivations with valid reactivation date" do |
|
follow_redirect! |
|
location.reload |
|
expect(location.location_deactivation_periods.count).to eq(1) |
|
expect(location.location_deactivation_periods.first.reactivation_date).to eq(Time.zone.local(2022, 4, 1)) |
|
end |
|
end |
|
|
|
context "with other date" do |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "other", "reactivation_date(3i)": "10", "reactivation_date(2i)": "10", "reactivation_date(1i)": "2022" } } } |
|
|
|
it "redirects to the location page and displays a success banner" do |
|
expect(response).to redirect_to("/schemes/#{scheme.id}/locations/#{location.id}") |
|
follow_redirect! |
|
expect(page).to have_css(".govuk-notification-banner.govuk-notification-banner--success") |
|
expect(page).to have_content("#{location.name} has been reactivated") |
|
end |
|
|
|
it "updates existing location deactivations with valid reactivation date" do |
|
follow_redirect! |
|
location.reload |
|
expect(location.location_deactivation_periods.count).to eq(1) |
|
expect(location.location_deactivation_periods.first.reactivation_date).to eq(Time.zone.local(2022, 10, 10)) |
|
end |
|
end |
|
|
|
context "with other future date" do |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "other", "reactivation_date(3i)": "14", "reactivation_date(2i)": "12", "reactivation_date(1i)": "2022" } } } |
|
|
|
it "redirects to the location page and displays a success banner" do |
|
expect(response).to redirect_to("/schemes/#{scheme.id}/locations/#{location.id}") |
|
follow_redirect! |
|
expect(page).to have_css(".govuk-notification-banner.govuk-notification-banner--success") |
|
expect(page).to have_content("#{location.name} will reactivate on 14 December 2022") |
|
end |
|
end |
|
|
|
context "when the date is not selected" do |
|
let(:params) { { location_deactivation_period: { "reactivation_date": "" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.not_selected")) |
|
end |
|
end |
|
|
|
context "when invalid date is entered" do |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "other", "reactivation_date(3i)": "10", "reactivation_date(2i)": "44", "reactivation_date(1i)": "2022" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.invalid")) |
|
end |
|
end |
|
|
|
context "when the date is entered is before the beginning of current collection window" do |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "other", "reactivation_date(3i)": "10", "reactivation_date(2i)": "4", "reactivation_date(1i)": "2020" } } } |
|
|
|
it "displays the new page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.out_of_range", date: "1 April 2022")) |
|
end |
|
end |
|
|
|
context "when the day is not entered" do |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "other", "reactivation_date(3i)": "", "reactivation_date(2i)": "2", "reactivation_date(1i)": "2022" } } } |
|
|
|
it "displays page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.invalid")) |
|
end |
|
end |
|
|
|
context "when the month is not entered" do |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "other", "reactivation_date(3i)": "2", "reactivation_date(2i)": "", "reactivation_date(1i)": "2022" } } } |
|
|
|
it "displays page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.invalid")) |
|
end |
|
end |
|
|
|
context "when the year is not entered" do |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "other", "reactivation_date(3i)": "2", "reactivation_date(2i)": "2", "reactivation_date(1i)": "" } } } |
|
|
|
it "displays page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.toggle_date.invalid")) |
|
end |
|
end |
|
|
|
context "when the reactivation date is before deactivation date" do |
|
let(:deactivation_date) { Time.zone.local(2022, 10, 10) } |
|
let(:params) { { location_deactivation_period: { reactivation_date_type: "other", "reactivation_date(3i)": "8", "reactivation_date(2i)": "9", "reactivation_date(1i)": "2022" } } } |
|
|
|
it "displays page with an error message" do |
|
expect(response).to have_http_status(:unprocessable_entity) |
|
expect(page).to have_content(I18n.t("validations.location.reactivation.before_deactivation", date: "10 October 2022")) |
|
end |
|
end |
|
end |
|
end |
|
end
|
|
|