baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Submit social housing lettings and sales data (CORE)
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
104 Commits
218 Branches
260 Tags
83 MiB
 
 
 
 
Tree: 78df07b29b
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '78df07b29b'
${ noResults }
submit-social-housing-letti.../doc/adr/adr-005.md

1.4 KiB
Raw Blame History

ADR - 005: Saving values to the database

We have opted to save values to the database directly instead of saving keys/numbers that need to be converted with enums in models using active record.

Saving values to the database

There are a few reasons we have opted to save the values directly, they are as follows

  • The data will be easier to consume and analyse for anyone associated with the project who needs to do so but does not necessarily have the technical skills to access it through Rails i.e. A person could get the data directly from the database and it would require no additional work to be usable for reporting purposes.

  • Currently there is no need to abstract the data as the data should be safe from being accessed by anyone external to the project.

  • It doesn't require additional dev work to map keys/numbers to values, we can just pull the values out directly and use them in the code, for example on the check answers page.

Drawbacks

  • changing the wording/casing of the answers could result in discrepancies in the database

  • There is a small risk that if the database is accessed by someone unauthorised they would have access to personally identifiable information.

This decision is not too difficult to change and can be revisited in the future if there is sufficient reason to switch to storing keys/numbers and using enums and active record to convert those to the appropriate values.