submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

Arthur Campbell 40cf0c10c2 CLDC-1633 build feature csv download of sales logs (#1568 ) * create a method on the FormHandler that returns the sales form questions for all years in the order that they appear in the form * update csv email job to accomodate sales log export as well as lettings add to tests to reflec the changes made * write tests to cover the desired functionality of the SalesLogCsvService * create the SalesLogCsvService create a necessary method on the log to enable submission method to be included on the csv derive values for the two halves of previous postcode for export * add relevant links in the UI and pipe everything together in controllers amend organisations controller to have flexibility to download logs of either type add necessary methods to sales log controller, raising shared method to logs controller update routing for amendments and additions extract helper method to build urls for downloading logs within an organisation * correct various linter complaints and tech review suggestions * minor amendment to add old_id and reorder early columns * undo my 'clever' refactor that broke things * refactoring of csv service after some tech review and some UI testing in review app * update tests to include a test of a full export and all values in teh csv * correct minor routing error to ensure correct url is shown and tab selected after requesting csv email * update organisations controller requests spec file to cover new functionality and make a minor amendment to authentication scope in the controller after error found in testing * write request tests for the new functionality in the sales log controller, define authorisation in the controller * minor correction after rubocop's kind suggestion' * various corrections from first pass at PO, tech review, linter, etc * refactor :ordered_sales_questions_for_all_years * first pass at implementing flexible code-based form fixtures for testing * second pass * refactor all tests of :ordered_sales_questions_for_all_years to use new factories * some refactoring in the testing of the csv service * use that fact that params is always available in controllers and don't pass it around, inline some methods calls * correct minor bug to ensure that "Return to logs" link returns to the correct index page * remove reminder comments * write further tests on the manipulation of questions into the csv headers, update factories of form constituents to allow the creation of forms with richer questions * fix linter complaints * minor alterations after rebase to account for changes made on other branches * refactor after code review * tweak fixtures after rebase containing alterations to the factory defaults		2 years ago
..
form	CLDC-2248 Improve soft validations (#1584 )	2 years ago
forms	Fix collection year shift issues (#1506 )	2 years ago
validations	CLDC-2248 Improve soft validations (#1584 )	2 years ago
form_handler_spec.rb	CLDC-1633 build feature csv download of sales logs (#1568 )	2 years ago
form_spec.rb	CLDC-2072 changing startdate to another collection year clear invalid answers (#1469 )	2 years ago
lettings_log_spec.rb	CLDC-2288 ensure derived answers cleared when renewal changed from yes to no (#1596 )	2 years ago
location_deactivation_period_spec.rb	CLDC-1687 allow deactivation or reactivation of last year schemes and locations in crossover period (#1396 )	2 years ago
location_spec.rb	CLDC-2140 Scheme and location updates (#1455 )	2 years ago
log_spec.rb	Revert to `f4e6d6d6bb` (#887 )	2 years ago
organisation_relationship_spec.rb	change housing provider -> stock owner (#1104 )	2 years ago
organisation_spec.rb	CLDC-2135 Bulk upload resume with how fix (#1503 )	2 years ago
rent_period_spec.rb	Revert to `f4e6d6d6bb` (#887 )	2 years ago
sales_log_spec.rb	CLDC-2163 add validations on whether buyers are living in the property (#1512 )	2 years ago
scheme_deactivation_period_spec.rb	CLDC-1687 allow deactivation or reactivation of last year schemes and locations in crossover period (#1396 )	2 years ago
scheme_spec.rb	Fix collection year shift issues (#1506 )	2 years ago
user_spec.rb	CLDC-2135 Bulk upload resume with how fix (#1503 )	2 years ago