submit-social-housing-lettings-and-sales-data

Submit social housing lettings and sales data (CORE)

core

SamSeed-Softwire 92a00e4305 CLDC-1723 Overhaul letting log owning & managing org questions & tests (#1140 ) * test: check managing org not gone from answer opts when relationship deleted * feat: add current managing org to answer opts * feat: check if managing org exists before trying to show it * wip * test: improve managing orgs opts test when not support * test: improve managing orgs opts tests when support * test: make relationship deletion test consistent with other tests * test: add "(with hint)" to managing org opts test descriptions * test: refactor managing orgs opts tests for support user case * fix: don't call user in get_answer_label in CYA component * style: reorder instance vars and remove old comments in managing_organisation.rb * refactor: ensure label_from_value always accepts log & nil as args * lint * test: pass in log and user in housing provider opts test for support user * test: update housing provider opts tests for non-support user * feat: update housing provider answer opts to include current HP in db * style: add space after user definition * test: make context definition more human-readable * test: refactor housing providers opts tests (not support user) * test: check housing prov. still selectable after deleting relationship * fix: define log and current_user instance vars in label_from_value (housing prov.) * lint * test: update lettings log feature tests to differentiate between different numbers of stock owners when acting as a data coordinator * test: check owning & managing orgs set correctly when a log is created * test: add line breaks and start context descriptions with and (not if) * test: artificially reference org_rel2 to avoid lint offense * feat: don't set log owning org as user's org if that org doesn't hold stock * test: improve test context descriptions in lettings_log_spec * test: finish overhauling owning and managing org tests in lettings_log_spec * test: change let! to let where possible in spec/features/lettings_log_spec.rb * test: change let! to let where possible in spec/models/form/lettings/questions/managing_organisation_spec.rb * test: change let! to let where possible in spec/models/form/lettings/questions/stock_owner_spec.rb * test: remove if statement from "coordinator user's org doesn't hold stock" managing org test * test: remove if statement from "coordinator user's org does hold stock" no managing orgs managing org test * test: remove if statement from "coordinator user's org does hold stock" >=1 managing orgs managing org test plus refactor previous test * test: explicitly reference org rels in "coordinator user's org doesn't hold stock" managing org test * test: don't create vars inside other vars (for tests edited/created in this branch) * chore: save schema changes after migration Co-authored-by: Phil Lee <asmega@users.noreply.github.com>	2 years ago
..
created_by_id.rb	CLDC-1723 Overhaul letting log owning & managing org questions & tests (#1140 )	2 years ago
owning_organisation_id.rb	CLDC-1723 Overhaul letting log owning & managing org questions & tests (#1140 )	2 years ago

CLDC-1723 Overhaul letting log owning & managing org questions & tests (#1140 )

* test: check managing org not gone from answer opts when relationship deleted

* feat: add current managing org to answer opts

* feat: check if managing org exists before trying to show it

* wip

* test: improve managing orgs opts test when not support

* test: improve managing orgs opts tests when support

* test: make relationship deletion test consistent with other tests

* test: add "(with hint)" to managing org opts test descriptions

* test: refactor managing orgs opts tests for support user case

* fix: don't call user in get_answer_label in CYA component

* style: reorder instance vars and remove old comments in managing_organisation.rb

* refactor: ensure label_from_value always accepts log & nil as args

* lint

* test: pass in log and user in housing provider opts test for support user

* test: update housing provider opts tests for non-support user

* feat: update housing provider answer opts to include current HP in db

* style: add space after user definition

* test: make context definition more human-readable

* test: refactor housing providers opts tests (not support user)

* test: check housing prov. still selectable after deleting relationship

* fix: define log and current_user instance vars in label_from_value (housing prov.)

* lint

* test: update lettings log feature tests

to differentiate between different numbers of stock owners when acting as a data coordinator

* test: check owning & managing orgs set correctly when a log is created

* test: add line breaks and start context descriptions with and (not if)

* test: artificially reference org_rel2 to avoid lint offense

* feat: don't set log owning org as user's org if that org doesn't hold stock

* test: improve test context descriptions in lettings_log_spec

* test: finish overhauling owning and managing org tests in lettings_log_spec

* test: change let! to let where possible in spec/features/lettings_log_spec.rb

* test: change let! to let where possible in spec/models/form/lettings/questions/managing_organisation_spec.rb

* test: change let! to let where possible in spec/models/form/lettings/questions/stock_owner_spec.rb

* test: remove if statement from "coordinator user's org doesn't hold stock" managing org test

* test: remove if statement from "coordinator user's org does hold stock" no managing orgs managing org test

* test: remove if statement from "coordinator user's org does hold stock" >=1 managing orgs managing org test

plus refactor previous test

* test: explicitly reference org rels in "coordinator user's org doesn't hold stock" managing org test

* test: don't create vars inside other vars (for tests edited/created in this branch)

* chore: save schema changes after migration

Co-authored-by: Phil Lee <asmega@users.noreply.github.com>

2 years ago

created_by_id.rb

CLDC-1723 Overhaul letting log owning & managing org questions & tests (#1140 )

2 years ago

owning_organisation_id.rb

CLDC-1723 Overhaul letting log owning & managing org questions & tests (#1140 )

2 years ago